Re: Review Request 128429: Fix strings in tooltips

2017-02-03 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128429/ --- (Updated Feb. 3, 2017, 8:12 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 590 - Still Unstable!

2017-02-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/590/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Feb 2017 17:08:22 + Build duration: 6 min 8 sec CHANGE SET Revision

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-03 Thread Ben Cooksley
On Fri, Feb 3, 2017 at 11:37 PM, René J.V. Bertin wrote: > On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote: > >>You missed the point. This "bit rot" is not about disk damage but >>about software incompatibility. ZFS doesn't help with that... > > You mean diffs that

Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-03 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/ --- Review request for kde-workspace and Plasma. Repository:

[Differential] [Request, 5 lines] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

2017-02-03 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hpereiradacosta. broulik set the repository for this revision to R31 Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This results in the highlight in

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 41 - Still Unstable!

2017-02-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Feb 2017 07:04:04 + Build duration: 16 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 591 - Still Unstable!

2017-02-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/591/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Feb 2017 05:29:34 + Build duration: 10 min CHANGE SET Revision

[Differential] [Commented On] D4401: Pressing Enter should open submenus in Kicker

2017-02-03 Thread Eike Hein
hein added a comment. I'll review on Monday, I have a weird gut feeling about this (without looking at the diff) so I want to double-check, sorry :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4401 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 719 - Still Unstable!

2017-02-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/719/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Feb 2017 05:30:36 + Build duration: 18 min CHANGE SET Revision

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-03 Thread Eike Hein
hein added a comment. Gnome-only spec? Why aren't they contributing to fd.o? REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D4416 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma,

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 47 - Still Unstable!

2017-02-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Feb 2017 07:09:34 + Build duration: 7 min 37 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 42 - Still Unstable!

2017-02-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/42/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Feb 2017 07:09:54 + Build duration: 8 min 10 sec CHANGE SET Revision

[Differential] [Accepted] D4410: Fix header content size when sorting is disabled

2017-02-03 Thread Christoph Feck
cfeck accepted this revision. cfeck added a reviewer: cfeck. This revision is now accepted and ready to land. REPOSITORY R113 Oxygen Theme BRANCH fix-unsortable-item-view-header-size REVISION DETAIL https://phabricator.kde.org/D4410 EMAIL PREFERENCES

[Differential] [Closed] D4410: Fix header content size when sorting is disabled

2017-02-03 Thread Elvis Stansvik
This revision was automatically updated to reflect the committed changes. Closed by commit R113:f6cd73e6d7b4: Fix header content size when sorting is disabled (authored by astan). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4410?vs=10857=10896

[Differential] [Accepted] D4415: make services disqualification much stricter

2017-02-03 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4415 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, broulik Cc:

[Differential] [Commented On] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

2017-02-03 Thread Hugo Pereira Da Costa
hpereiradacosta added inline comments. INLINE COMMENTS > breezestyle.cpp:3071 > +// no focus indicator on ComboBox list items > +if (widget && widget->metaObject()->className() == > QByteArrayLiteral("QComboBoxListView")) { > +return true; I would rather use

[Differential] [Commented On] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

2017-02-03 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. In https://phabricator.kde.org/D4426#82837, @broulik wrote: > I can't reproduce the issue with Oxygen – does it even have the focus underline thingie? > > It might be missing the fix for QQC I did [1] which caused the line to show up because I

[Differential] [Commented On] D4400: Plasma 5.10 "Cascade" Wallpaper

2017-02-03 Thread Marco Martin
mart added a comment. awesome REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D4400 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kvermette, #plasma, #plasma:_design, fredrik Cc: mart, broulik, andreaska, plasma-devel,

[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

2017-02-03 Thread Rog131
https://bugs.kde.org/show_bug.cgi?id=375909 Rog131 changed: What|Removed |Added CC||samrog...@hotmail.com ---

[Differential] [Commented On] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

2017-02-03 Thread Kai Uwe Broulik
broulik added a comment. I can't reproduce the issue with Oxygen – does it even have the focus underline thingie? It might be missing the fix for QQC I did [1] which caused the line to show up because I fixed/changed some offset. [1]

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-03 Thread René J . V . Bertin
On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote: >You missed the point. This "bit rot" is not about disk damage but >about software incompatibility. ZFS doesn't help with that... You mean diffs that no longer apply cleanly? In that case you missed our point. Being able to consult

[Differential] [Updated, 5 lines] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

2017-02-03 Thread Kai Uwe Broulik
broulik updated this revision to Diff 10892. broulik added a comment. Use inherits() instead of metaObject()->className() REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4426?vs=10891=10892 REVISION DETAIL https://phabricator.kde.org/D4426 AFFECTED FILES

[Differential] [Updated] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

2017-02-03 Thread Kai Uwe Broulik
broulik marked an inline comment as done. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D4426 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, hpereiradacosta Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D4401: Pressing Enter should open submenus in Kicker

2017-02-03 Thread Marco Martin
mart added a comment. +1 I was windering if even space would make sense for this, tough is better is used for the input field REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4401 EMAIL PREFERENCES

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-03 Thread Luigi Toscano
René J.V. Bertin ha scritto: > On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote: > >> You missed the point. This "bit rot" is not about disk damage but >> about software incompatibility. ZFS doesn't help with that... > > You mean diffs that no longer apply cleanly? In that case you

[Differential] [Accepted] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

2017-02-03 Thread Hugo Pereira Da Costa
hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Thanks ! Care to do the same with oxygen ? (no need for a review, just push) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D4426 EMAIL

[Differential] [Closed] D4426: [Breeze Kstyle] Don't draw focus indicator on ComboBox entries

2017-02-03 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R31:4d272dcbb53e: [KStyle] Don't draw focus indicator on ComboBox entries (authored by broulik). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4426?vs=10892=10893