no Plasma meeting today

As some of us are still travelling, let's not have a Plasma hangout today. Happy hacking, anyway! -- sebas http://vizZzion.org ⦿http://www.kde.org

D5825: Include signal.h for kill(), and prototype kqueue/kevent stuff...

tcberner added a comment. In https://phabricator.kde.org/D5825#109093, @davidedmundson wrote: > > but now that it is all here already, let's just call this a prototype, for someone who knows C/kevent/kqueue to fix. > > So what doesn't work? I have not yet had time to test it

D5851: Fix the PID updated in PlasmaWindowedModel

davidedmundson abandoned this revision. davidedmundson added a comment. That would also be completely fine from my POV. I should have read the original review request, I was just fixing the tests based on what was currently here. REPOSITORY R127 KWayland REVISION DETAIL

[kio-extras] [Bug 379817] Behaviour change: JPEG image preview scaled to widget size

https://bugs.kde.org/show_bug.cgi?id=379817 --- Comment #2 from Alex Bikadorov --- Thanks for the fast response. I don't have permission to view the review request. -- You are receiving this mail because: You are the assignee for the bug.

[kio-extras] [Bug 379817] Behaviour change: JPEG image preview scaled to widget size

https://bugs.kde.org/show_bug.cgi?id=379817 Alexander Volkov changed: What|Removed |Added CC||a.vol...@rusbitech.ru

D5742: Replace Q_DECL_OVERRIDE with override.

This revision was automatically updated to reflect the committed changes. Closed by commit R135:4aef17e64f56: Replace Q_DECL_OVERRIDE with override. (authored by markg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5742?vs=14232=14546#toc REPOSITORY R135 Integration for Qt

Re: [plasma-devel] Plasma 5.10 beta tars available

Last minute update to powerdevil to fix compile with clang powerdevil;master;1d6e500a75c49787c09acca33132d4891295e1d1;powerdevil-5.9.95.tar.xz;3503f8e7dc061e48bf8ba4b63b892e5cf45fdeccdd2a04e75c76d09b0ceb8776 Jonathan On Thu, May 11, 2017 at 04:07:04PM +, Jonathan Riddell wrote: > Tars

Plasma 5.9 Beta

Plasma 5.9.95 is now released https://www.kde.org/announcements/plasma-5.9.95.php

D5743: Fix deprecation warnings. setSelection -> setSelectedUrl ui -> uiDelegate

This revision was automatically updated to reflect the committed changes. Closed by commit R135:f25c5e10d023: Fix deprecation warnings. setSelection -> setSelectedUrl ui -> uiDelegate (authored by markg). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

Re: Plasma 5.9 Beta

That's 5.10 beta. David

D5870: Match subsequences in application runner

rthomas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Match applications in krunner using subsequences instead of substrings. This allows matching applications using parts of its name, instead of

D5871: Remove obviously wrongly-named symbolic links

marten created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY It's not clear where these entries came from, but they are clearly a mistake - either scripting or copy-and-paste. The

D5872: pidChanged also signals dataChanged in WindowModel

sebas created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Eike removed this, but I'm not sure why. All other roles trigger datachanged, so I don't see why pid

D5872: pidChanged also signals dataChanged in WindowModel

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. See d581 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5872 To: sebas, #plasma, hein, davidedmundson Cc: davidedmundson,

D5871: Remove obviously wrongly-named symbolic links

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R267 Oxygen Icons REVISION DETAIL https://phabricator.kde.org/D5871 To: marten, #plasma, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D5871: Remove obviously wrongly-named symbolic links

This revision was automatically updated to reflect the committed changes. Closed by commit R267:1b641f89d752: Remove obviously wrongly-named symbolic links (authored by marten). REPOSITORY R267 Oxygen Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5871?vs=14560=14564 REVISION

D5872: pidChanged also signals dataChanged in WindowModel

bshah added a comment. In https://phabricator.kde.org/D5872#109874, @sebas wrote: > What's d581? I think he meant https://phabricator.kde.org/D5851 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5872 To: sebas, #plasma, hein, davidedmundson Cc: bshah,

D5872: pidChanged also signals dataChanged in WindowModel

sebas added a comment. What's d581? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5872 To: sebas, #plasma, hein, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp,

D5872: pidChanged also signals dataChanged in WindowModel

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > it can still be set after being initially 0. In fact, it has to be. Not at the time the client sees it. see initialStateCallback which is important.

D5748: workaround for correct wayland positioning

mart updated this revision to Diff 14556. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - don't execute event two times REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5748?vs=14250=14556

D5748: workaround for correct wayland positioning

mart marked 2 inline comments as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in view.cpp:248 > When we get here we've already run Dialog::event() > > won't that have already done the positioning? > > There's a virtual geometry method in dialog to allow krunner and

D5872: pidChanged also signals dataChanged in WindowModel

sebas requested review of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5872 To: sebas, #plasma, hein, davidedmundson Cc: bshah, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5872: pidChanged also signals dataChanged in WindowModel

sebas added a comment. Possibly, in this case, I disagree. The pid is initially unknown set to in the client, and can change afterwards. In reality, the pid of the window doesn't change, but it can still be set after being initially 0. In fact, it has to be. In the end, I don't care

D5870: Match subsequences in application runner

apol added a comment. +1 INLINE COMMENTS > servicerunner.cpp:101 > + > +for(int i=1; i +{ use a foreach > servicerunner.cpp:203 > +//Splitting the query term to match using subsequences > +QStringList queryList = term.split(" "); > +

D5756: Set pid on the ClientConnection backing the PlasmaWindow surface.

hein added a comment. What was the regression? (I'm aware of a failing unit test, but since the unit test itself was new, it was obviously not a regression.) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5756 To: hein, #plasma, sebas, graesslin Cc: kwin,

D5868: make pagerow test pass

mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY during the pop animation the actual depth differs from the stored one as the pages that are being popped are still in the data structure so