D5914: Add template for Plasma QML Applet with QML extension

2017-05-19 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH addtemplateforplasmoidwithqmlplugin REVISION DETAIL https://phabricator.kde.org/D5914 To: kossebau, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot,

D5910: make shadows work on wayland

2017-05-19 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in breezeshadowhelper.cpp:177 > we use Expose everywhere else, why not here? It gets called a lot less it's a qwidget, doesn't get expose events > davidedmundson wrote in breezeshadowhelper.cpp:464 > this is currently leaking?

Re: Broken dependencies: plasma-vault

2017-05-19 Thread Ben Cooksley
On Tue, May 16, 2017 at 9:17 PM, Ben Cooksley wrote: > Hi all, > > When someone gets a chance can they please correct the dependency > metadata in kde-build-metadata for Plasma Vault? > > See >

D5868: make pagerow test pass

2017-05-19 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R169:f59205a8f467: make pagerow test pass (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5868?vs=14554=14685 REVISION DETAIL

D5916: Fix warnings

2017-05-19 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Makes sure we are not calling null objects. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D5916

D5912: minimize dialog resizes/moves

2017-05-19 Thread Marco Martin
mart updated this revision to Diff 14688. mart added a comment. - remove updategeometryblocked REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5912?vs=14674=14688 BRANCH phab/dialogresize REVISION DETAIL

tracking the popupmenus problem in qtwayland

2017-05-19 Thread Marco Martin
Hi all, as a reminder, for the problem we explored about in the meeting about broken context menus in qtwayland, i've created an upstream bug as is easy to reproduce with a test case https://bugreports.qt.io/browse/QTBUG-60932 -- Marco Martin

D5918: set transientparent for menus

2017-05-19 Thread Marco Martin
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY set transient parent for popup menus created by appletinterface/ containmentinterface, it makes them appear at the proper

D5012: Delay notifications until desktop session has loaded

2017-05-19 Thread Luca Beltrame
lbeltrame added a comment. Months later, it turns out that notify-osd ships a org.freedesktop.Notifications.service already, so it conflicts with the one made by this patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo,

D5918: set transientparent for menus

2017-05-19 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Please test under x. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/popupparents REVISION DETAIL https://phabricator.kde.org/D5918 To: mart, #plasma,

Re: Plasma 5.10 voice over text

2017-05-19 Thread Sebastian Kügler
On woensdag 17 mei 2017 14:35:58 CEST Łukasz Sawicki wrote: > 2017-05-17 13:31 GMT+01:00 Łukasz Sawicki : > > > > 2017-05-17 13:03 GMT+01:00 Łukasz Sawicki : > > > >>Could you run this by kde-promo as well? We should try to keep to keep the > >>promo people

D5912: minimize dialog resizes/moves

2017-05-19 Thread Marco Martin
mart added a comment. removed that extra complexity block/unblock that didn't seem to buy anything. comparing before/after, all the normal tooltips, exept taskmanager consistyently passed from two resizes to one. perhaps will be possible to fix the taskmanager case by tweaking up how

Re: Broken dependencies: plasma-vault

2017-05-19 Thread Ivan Čukić
Seems I updated the wrong file (the one for qt4 which is strangely called just dependency-data), thanks Marco for applying the changes to proper files. Cheers, Ivan

D5914: Add template for Plasma QML Applet with QML extension

2017-05-19 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R242:4d5793c28a3f: Add template for Plasma QML Applet with QML extension (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5914?vs=14681=14687#toc REPOSITORY R242 Plasma

D5912: minimize dialog resizes/moves

2017-05-19 Thread Marco Martin
mart added a comment. now tooltips are animated again REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D5912: minimize dialog resizes/moves

2017-05-19 Thread Marco Martin
mart updated this revision to Diff 14690. mart added a comment. - make the tooltips actual tooltips REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5912?vs=14688=14690 BRANCH phab/dialogresize REVISION DETAIL