D5926: Remove filename from source/dest fields in job notification

2017-05-25 Thread Kai Uwe Broulik
broulik added a comment. I think it's fine in this place (not kuiserverengine), I suppose slice(0,0) will return the entire string so this won't break cases where we do not have a path? Can we perhaps extend this so when the filename of the destination is the same as the filename in

D5870: Match subsequences in application runner

2017-05-25 Thread Ronnie Thomas
rthomas added a comment. No, I don't have commit access yet. Can I apply for a developer account now? I haven't done so until now. REVISION DETAIL https://phabricator.kde.org/D5870 To: rthomas, #plasma, davidedmundson Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff,

D5968: Fix co-installability with other DBus activated notification services

2017-05-25 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In Plasma we install a DBus activated service to handle the case of notifications being sent before Plasma is loaded. This file

D5381: Add brightness control using ddcutil lib

2017-05-25 Thread Dorian Vogel
dvogel added a comment. The final conclusion was that I should figure out some cmake to allow building without ddccontrol. I kind of did it locally (tho it's a bit dirty). The second big point is that powerdevil only supports one brightness controller at a time. The solution kbroulik

D5968: Fix co-installability with other DBus activated notification services

2017-05-25 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D5968 To: davidedmundson, #plasma, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D5012: Delay notifications until desktop session has loaded

2017-05-25 Thread David Edmundson
davidedmundson added a comment. Fix in https://phabricator.kde.org/D5968 > Undefined means anything can happen That is what the word means, but DBus isn't a black box. We do roughly know what it will do. If it was truly problematic, they would force the name to match, something

D5968: Fix co-installability with other DBus activated notification services

2017-05-25 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ab60c3be74a0: Fix co-installability with other DBus activated notification services (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5968?vs=14829=14830#toc

D5916: Fix warnings

2017-05-25 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R169:fe208428c939: Fix warnings (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5916?vs=14686=14837 REVISION DETAIL

D5932: KCM for controlling Night Color

2017-05-25 Thread Chris Holland
Zren added a comment. Is there a "daytime" setting or is it hardcoded to be 100% blue? Redshift Control for example: F3764291: 2017-05-25___08-09-46.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5932 To:

D5912: minimize dialog resizes/moves

2017-05-25 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:32e67a591edb: minimize dialog resizes/moves (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5912?vs=14809=14834#toc REPOSITORY R242 Plasma Framework (Library) CHANGES

D5748: workaround for correct wayland positioning

2017-05-25 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:d3bdb8d657ba: workaround for correct wayland positioning (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5748?vs=14556=14835 REVISION

D5961: PoC: Generic adoption of KUserFeedback for Discover

2017-05-25 Thread Marco Martin
mart added a comment. +1 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5961 To: apol, #plasma, vkrause Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5912: minimize dialog resizes/moves

2017-05-25 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D5912#111657, @davidedmundson wrote: > but: we're still doing a resize whislt we have the old window management min/max hints set from the previous item, so it'll still have an extra resize, just at a kwin level not here.

D5916: Fix warnings

2017-05-25 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D5916 To: apol, #kirigami, mart Cc: plasma-devel, apol, mart

plasma 5.10 tars

2017-05-25 Thread Jonathan Riddell
Plasma 5.10 tars are now available on racnoss for packagers Release is due on Tuesday Jonathan

Re: plasma 5.10 tars

2017-05-25 Thread Eike Hein
On 05/26/2017 07:29 AM, Jonathan Riddell wrote: > Plasma 5.10 tars are now available on racnoss for packagers > > Release is due on Tuesday If possible it would be nice to still refresh plasma-desktop from the 5.10 branch. We forgot a fix that was only commited to master, and is now on the

D5910: make shadows work on wayland

2017-05-25 Thread Marco Martin
mart updated this revision to Diff 14839. mart added a comment. - use a different map to keep track of surfaces REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5910?vs=14665=14839 BRANCH phab/waylandshadow REVISION DETAIL

D5910: make shadows work on wayland

2017-05-25 Thread Marco Martin
mart edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5910 To: mart, #plasma, hpereiradacosta Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D5381: Add brightness control using ddcutil lib

2017-05-25 Thread Dorian Vogel
dvogel updated this revision to Diff 14843. dvogel added a comment. Absence of ddcutil on the system is now handled: the ddcbrightness object is still instantiated in powerdevilupowerbackend, however, this is a dummy object, returning isSupported()=FALSE, making powerdevilupowerbackend

D5956: Make sure we always set a default mime filter in save mode

2017-05-25 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH defaultFilterSaveMode (branched from Plasma/5.10) REVISION DETAIL https://phabricator.kde.org/D5956 To: elvisangelaccio, #plasma, dfaure Cc: