D7607: ARGB buffers are premultipliedD7460 in kwayland assumes all WL_SHM_FORMAT_ARGB8888 buffers arepremultipied RGB values.Kwin tests need updating to do the same.Rendering code did not need changin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D7607 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
Re: Plasma Mobile on the Librem 5
Am 2017-08-29 15:28, schrieb Matthias Klumpp: What we would be interested in is knowing about the future plans for Plasma Mobile, especially in the area of design and performance improvements. I didn't have the opportunity yet to test Plasma Mobile on one of our development boards, but I hope I can get to that soonish. Speaking for the KWin (Wayland compositor) part. Ideal would be drm support in the phone directly, but that is probably just wishful thinking. KWin does have a working Android hwcomposer backend through libhybris. That works well and good for the limited use cases we had so far. The code base of this plugin is extremely small (< 1000 lines of code), which shows that most of the code is shared and it's relatively easy to extend and adjust this code base for new needs. Having done the initial port of KWin to the Nexus 5 I can proudly say that KWin performs very well on such kind of hardware. We benefit a lot from performance improvements done in the general KWin stack. And we can bring improvements from other platforms also to the phone stack. For example Roman did a lot of work to get layered compositing working in the DRM platform and that would be an ideal candidate to bring also in the hwcomposer plugin. Thus we have all the heavy lifting done to do things like rendering videos directly in a hardware plane. One of the things currently being worked on for the phone is to get rid of XWayland. This could give you a nice performance boost as you have a Wayland only system (of course it's also nice to have X support, but one cannot get it with GL support, so the gain is not worth it IMHO). Cheers Martin
D7567: Support edit and appstream actions also for application search results
hein added inline comments. INLINE COMMENTS > mak wrote in actionlist.cpp:380 > I know, that's why I didn't flag this as change request (just a general > observation). Aye, just gut reaction to avoid bike shedding etc :) Thanks for the note, it's important REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7567 To: hein, #plasma, broulik, davidedmundson Cc: mak, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Re: Review Request 126322: [ToolTip] Dismiss tooltip when item becomes invisible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126322/ --- (Updated Aug. 29, 2017, 8:58 nachm.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-framework Description --- When an item containing a tooltip becomes invisible the tooltip would stay there indefinitely. Diffs - src/declarativeimports/core/tooltip.h d38c49b src/declarativeimports/core/tooltip.cpp a5e223b Diff: https://git.reviewboard.kde.org/r/126322/diff/ Testing --- Hovered icon widget on my desktop, tooltip appeared, removed the widget through its context menu. Before: tooltip would stay there until I either hovered another item or I commited the applet deletion. Now: tooltip hides as soon as the applet disappeared Thanks, Kai Uwe Broulik
D7599: [KRunner] Remove copy of dialog.h
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead use PlasmaQuick/Dialog TEST PLAN Compiles and KRunner still positions correctly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7599 AFFECTED FILES krunner/dialog.h krunner/view.h To: broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
[Breeze] [Bug 384129] Rename colors from British to American English
https://bugs.kde.org/show_bug.cgi?id=384129 Christoph Feckchanged: What|Removed |Added Product|systemsettings |Breeze Assignee|mwoehlke.fl...@gmail.com|plasma-devel@kde.org Component|kcm_colors |general -- You are receiving this mail because: You are the assignee for the bug.
D7596: Register objectPath before service
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When the service is regsitered we want to have all the internal routing pre-configured. Otherwise pending calls (such as pending DBus activated calls) can be processed before the path is registered and then fail with an error that the path does not exist. Also remove the fairly redundant check on registerObject. That can return false if some object in this process has registered itself on that path; but in that case, the very last thing we'd want to do is call unregisterService. TEST PLAN Generated a load of notifications Started plasma Ouptut showed valid return on GetCapabilities, not an error on missing path REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7596 AFFECTED FILES dataengines/notifications/notificationsengine.cpp To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Fwd: Change in qt/qtbase[dev]: Make QPlatformServices as a separated plugin
This might be of interest to some of you. -- Forwarded Message -- Subject: Change in qt/qtbase[dev]: Make QPlatformServices as a separated plugin Date: mardi 29 août 2017, 10:59:02 CEST From: Jan Grulich (Code Review)To: David Faure CC: Qt Sanity Bot Hello David Faure, I'd like you to do a code review. Please visit https://codereview.qt-project.org/202746 to review the following change. Change subject: Make QPlatformServices as a separated plugin .. Make QPlatformServices as a separated plugin If one wants to reimplement QPlatformServices he has to reimplement whole QPlatformIntegration plugin, which is not an easy task to do. For this purpose we might want to make QPlatformServices as a standalone plugin which can be specified additionally, like QPlatformTheme. This patch allows to use custom QPlatformServices by providing parameter "-platformservices" or additionally when you set QT_QPA_PLATFORM_SERVICES variable. Change-Id: Iaee0565aa75b4de2412d64ecb2d0b8d8d992aed3 --- M src/gui/kernel/kernel.pri M src/gui/kernel/qguiapplication.cpp M src/gui/kernel/qguiapplication_p.h A src/gui/kernel/qplatformservicesfactory.cpp A src/gui/kernel/qplatformservicesfactory_p.h A src/gui/kernel/qplatformservicesplugin.cpp A src/gui/kernel/qplatformservicesplugin.h M src/gui/util/qdesktopservices.cpp 8 files changed, 368 insertions(+), 3 deletions(-) git pull ssh://codereview.qt-project.org:29418/qt/qtbase refs/changes/ 46/202746/2 -- To view, visit https://codereview.qt-project.org/202746 To unsubscribe, visit https://codereview.qt-project.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaee0565aa75b4de2412d64ecb2d0b8d8d992aed3 Gerrit-PatchSet: 2 Gerrit-Project: qt/qtbase Gerrit-Branch: dev Gerrit-Owner: Jan Grulich Gerrit-Reviewer: David Faure Gerrit-Reviewer: Friedemann Kleint Gerrit-Reviewer: Gunnar Sletta Gerrit-Reviewer: Jani Heikkinen Gerrit-Reviewer: Paul Olav Tvete Gerrit-Reviewer: Qt Sanity Bot Gerrit-Reviewer: Samuel Rødal - -- David Faure | david.fa...@kdab.com | Managing Director KDAB France KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts
D7582: [FrameSvgItem] Create margins/fixedMargins object on demand
This revision was automatically updated to reflect the committed changes. Closed by commit R242:a8ce2e85ecf5: [FrameSvgItem] Create margins/fixedMargins object on demand (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7582?vs=18877=18915 REVISION DETAIL https://phabricator.kde.org/D7582 AFFECTED FILES src/declarativeimports/core/framesvgitem.cpp src/declarativeimports/core/framesvgitem.h To: broulik, #plasma, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7583: [Kicker] Add "Edit application" and "Manage application" entry to service runner results
broulik abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7583 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7567: Support edit and appstream actions also for application search results
broulik added a comment. Minor nitpicks, then it's good to go. INLINE COMMENTS > actionlist.cpp:322 > + > +bool canEdit(const QString ) > +{ canEditApplication > actionlist.cpp:327 > + > +void edit(const QString , const QString ) > +{ editApplication > runnermatchesmodel.cpp:128 > +if (service->isApplication()) { > +actionList << Kicker::createSeparatorActionItem(); > +actionList << Kicker::editApplicationAction(service); You always add a separator at the end, so this isn't strictly neccessary (QMenu is smart enough to collapse double separators, though) > backend.cpp:134 > + > +if (launcherUrl.isValid() && launcherUrl.scheme() == > QStringLiteral("applications")) { > +const KService::Ptr service = > KService::serviceByMenuId(launcherUrl.path()); Unrelated, from https://phabricator.kde.org/D7561? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7567 To: hein, #plasma, broulik, davidedmundson Cc: mak, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7598: [Folder Model] Introduce status enum
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows to use bindings for properties like plasmoid.busy TEST PLAN Will update https://phabricator.kde.org/D7586 based on this once it's in. Verified that on startup it circles while it's reading the dir. It does not do that when changing the config but I think it didn't do that before (`if (!grid.model) ...`) Verified that error string is properly shown and doesn't keep spinning in case of error REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7598 AFFECTED FILES containments/desktop/package/contents/ui/FolderView.qml containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7587: kfileaudiopreview: don't autoplay media files by default
broulik added a comment. +1 from me also REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7587 To: elvisangelaccio, #plasma Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7590: Don't search for and link to libcln when using libqalculate>=2.0
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b915e5b4bab1: Don't search for and link to libcln when using libqalculate>=2.0 (authored by arojas). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7590?vs=18894=18907 REVISION DETAIL https://phabricator.kde.org/D7590 AFFECTED FILES cmake/FindQalculate.cmake To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7587: kfileaudiopreview: don't autoplay media files by default
bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D7587 To: elvisangelaccio, #plasma, bshah Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7561: Avoid absolute paths to .desktop files in launcher URLs.
This revision was automatically updated to reflect the committed changes. hein marked 2 inline comments as done. Closed by commit R120:a47d1f19e1e0: Avoid absolute paths to .desktop files in launcher URLs. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7561?vs=18822=18942#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7561?vs=18822=18942 REVISION DETAIL https://phabricator.kde.org/D7561 AFFECTED FILES libtaskmanager/launchertasksmodel.cpp libtaskmanager/startuptasksmodel.cpp libtaskmanager/tasktools.cpp libtaskmanager/xwindowtasksmodel.cpp To: hein, broulik, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7567: Support edit and appstream actions also for application search results
hein updated this revision to Diff 18943. hein marked 4 inline comments as done. hein added a comment. - Address Kai's review comments - Don't double-add edit action in AppEntry - Also perform system immutability checks in RunnerMatchesModel REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7567?vs=18889=18943 BRANCH arcpatch-D7567_2 REVISION DETAIL https://phabricator.kde.org/D7567 AFFECTED FILES applets/kicker/plugin/actionlist.cpp applets/kicker/plugin/actionlist.h applets/kicker/plugin/appentry.cpp applets/kicker/plugin/runnermatchesmodel.cpp To: hein, #plasma, broulik, davidedmundson Cc: mak, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7611: Port Appmenu model to QDBusServiceWatcher
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QDBusConnection::serviceOwnerChanged is deprecated, with the intended replacement being QDBusServiceWatcher. QDBusServiceWatcher only creates a match rule for the relevant services, resulting in less noise and wakeups. (practically this has no impact as the the system tray also connects to watch every service change, and that runs in the same process) TEST PLAN Ran appmenu Had dolphin open showing the menu Closed dolphin menu immediately closed REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7611 AFFECTED FILES applets/appmenu/plugin/appmenumodel.cpp applets/appmenu/plugin/appmenumodel.h To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7601: [EventPluginsManager] Expose pluginPath in model
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY That's what digital clock stores in its config, allows us to do matching. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7601 AFFECTED FILES src/declarativeimports/calendar/eventpluginsmanager.cpp To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory
broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7602 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7601: [EventPluginsManager] Expose pluginPath in model
broulik added a dependent revision: D7603: [Digital Clock] Show event plugin configurations only if enabled. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7601 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
[Breeze] [Bug 384129] Rename colors from British to American English
https://bugs.kde.org/show_bug.cgi?id=384129 Jonathan Riddellchanged: What|Removed |Added CC||j...@jriddell.org --- Comment #2 from Jonathan Riddell --- I like your English teacher already. But snobbery will get us nowhere, KDE uses en_US in strings as do other projects like Libreoffice who want to use this stuff. -- You are receiving this mail because: You are the assignee for the bug.
D7555: Add basic example for adjusting column width draggable handle
This revision was automatically updated to reflect the committed changes. Closed by commit R169:fbe9e84b4bd8: Add basic example for adjusting column width draggable handle (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7555?vs=18878=18923 REVISION DETAIL https://phabricator.kde.org/D7555 AFFECTED FILES examples/simpleexamples/dragPageWidth.qml To: hein, mart Cc: plasma-devel, apol, mart, hein
Re: Plasma Mobile on the Librem 5
On 08/29/2017 10:28 PM, Matthias Klumpp wrote: > As some of you might already know, we at Purism are planning to > develop a mobile phone that uses only free software and Matrix[2] for > communication. We are currently running a crowdfunding campaign[1] in > order to be able to make the phone a reality.> > [...] > > Our scope for this project is limited, in order to be able to complete > it successfully and not end up in a never ending development loop: The > phone should be able to communicate via Matrix, have a web browser, > make calls, take pictures. We are not aiming for a massive amount of > apps, but instead want the basic functionalities of the phone working > well when we ship it - more apps and features can be delivered later > via Flatpaks and system updates. Very interesting! I'll let others reply about some of the more Plasma Mobile-specific parts as they're better equipped to do so and will focus on the Matrix part, as it piqued my interest with my "Konversation developer" hat on. Konversation is KDE's IRC client. As a by-product of an (ongoing) conversation within the KDE community on whether we want to stick by IRC or move on to another chat solution as 'the one' for the community, and how to transition smoothly, we're currently (a) rewriting the UI to be more convergent and allow for a mobile version and (b) looking to retarget it as an IRC/Matrix client. This is a very early effort currently focused on UI experimentation and rampup (read: there are no Matrix bits yet, although the Konvi team has been following Matrix for a while and is to a degree familiar with the technology). After a few initial sessions of hacking this months, here are some (working and chatting) mockups of the UI direction: https://www.youtube.com/watch?v=1cr7hirDzws=1 https://www.youtube.com/watch?v=b88oqdlNyuU=1 http://imgur.com/a/bT7XE As you can see the UI is headed toward a responsive/convergent bent (here with desktop-specific concessions) using KDE's Kirigami UI technology. As one of the main problems the community has with IRC is the poor state of mobile access, a mobile version of Konversation for both Plasma Mobile and Android - both platforms Kirigami easily deploys to - is definitely planned, leveraging both Kirigami's convergent nature (and meaning it, not buzzword bingo) and the ability to do form factor-specific customization via KPackage. This work is currently being done in collab with KDE's Visual Design group and with (code, advice) support from the Kirigami team as well. Again, it's the early days of this effort - but I can confirm Matrix is something we're interested in and gearing up to hack on, motivated in large part by mobile. We share that one. Cheers, Eike
[Breeze] [Bug 384129] Rename colors from British to American English
https://bugs.kde.org/show_bug.cgi?id=384129 --- Comment #3 from Heiko Tietze--- Not my idea, but LibreOffice translates color names and KDE could do that too with Breeze_EN-GB.col. -- You are receiving this mail because: You are the assignee for the bug.
D7598: [Folder Model] Introduce status enum
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7598 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Plasma Mobile on the Librem 5
[ Please keep the CC list intact for replies ] Hi! As some of you might already know, we at Purism are planning to develop a mobile phone that uses only free software and Matrix[2] for communication. We are currently running a crowdfunding campaign[1] in order to be able to make the phone a reality. One of the open questions for the phone is still which UX we will use, and Plasma Mobile would obviously be a perfect fit for this kind of project, since KDE and Purism share the same values, the UI is already done in large parts, and nothing would have to be developed from scratch (especially the Kirigami controls are great!). ## Some details about the phone software The base operating system of the phone will be PureOS[3], our Debian derivative that is currently pending endorsement from the FSF. The plan is to use OSTree[4] for the base system, in order to achieve atomic updates and easy rollbacks, as well as Flatpaks[5] for deployment of applications. It is likely that we will have our own Flatpak repository with apps specifically for the phone at some point in the future. The system will make full use of systemd and will use Bubblewrap[6] for sandboxing of selected more critical components. Due to the nature of the hardware, we will not need libhybris or any Android kernel abstraction, which means that we can run stock Linux on the phone, which greatly simplifies development and will allow us to develop at a faster pace, due to not being bound to a specific kernel version. The downside is that the i.mx6 ARM CPU isn't incredibly fast. We hope that we will be able to update to the faster i.mx8 when it is available and can be used with free drivers, but at this point in time we need to focus on the i.mx6 as primary hardware target. ## What we need from a phone UI Our scope for this project is limited, in order to be able to complete it successfully and not end up in a never ending development loop: The phone should be able to communicate via Matrix, have a web browser, make calls, take pictures. We are not aiming for a massive amount of apps, but instead want the basic functionalities of the phone working well when we ship it - more apps and features can be delivered later via Flatpaks and system updates. The UI therefore doesn't need to be excessive and support each and every feature that Android already has, having a more minimal UI works fine. ## Purism and KDE While Purism is using GNOME for its laptops by default for various reasons, partnering with KDE for the phone does make a lot of sense for us, and we are excited about it. There are a few ways we can think of how to help the Plasma Mobile team, and this email is intended to make first contact and allow you to ask us any questions. What we would be interested in is knowing about the future plans for Plasma Mobile, especially in the area of design and performance improvements. I didn't have the opportunity yet to test Plasma Mobile on one of our development boards, but I hope I can get to that soonish. It is still not certain yet whether we will ultimately go with Plasma Mobile as OS on the Librem 5 (there are also ideas to use GNOME), but I think Plasma would be a good choice. So, let's hope for the success of the campaign! If you have any questions about Purism, the phone, Plasma on PureOS / Debian, life, the universe, everything, please ask! Kind regards, Matthias Klumpp (Software engineer at Purism) [1]: https://puri.sm/shop/librem-5/ [2]: https://matrix.org/ [3]: https://pureos.net/ [4]: https://ostree.readthedocs.io/en/latest/ [5]: http://flatpak.org/ [6]: https://github.com/projectatomic/bubblewrap
[Breeze] [Bug 384129] Rename colors from British to American English
https://bugs.kde.org/show_bug.cgi?id=384129 Jens Reuterbergchanged: What|Removed |Added CC||jens...@kolabnow.com --- Comment #1 from Jens Reuterberg --- "In this class we learn English, not American" as my old English teacher used to say. The choice of names for colours are most probably my fault simply because that is how I spell them. "Grey", "Colour", "Aluminium". But its potato/potato as far as I am concerned -- You are receiving this mail because: You are the assignee for the bug.
D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The appendCategory(ConfigCategory*) allows to add a category created by e.g. an Instantiator that can use bindings rather than fixed arguments. The removeCategory methods allow to remove a category when e.g. the model in an Instantiator resets. CCBUG: 372090 TEST PLAN Pre-requisite for dynamically showing and hiding calendar plugin config in digital clock. Verified that onObjectAdded and onObjectRemoved of an Instantiator work fine with ConfigModel. Adding an overload shouldn't cause issues as the others require at least four string arguments and you cannot pass null as QString from QML anyway. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7602 AFFECTED FILES src/plasmaquick/configmodel.cpp src/plasmaquick/configmodel.h To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory
broulik added a dependent revision: D7603: [Digital Clock] Show event plugin configurations only if enabled. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7602 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7603: [Digital Clock] Show event plugin configurations only if enabled
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This replaces the loop with fixed values by an Instantiator creating bindings on the model. CCBUG: 372090 TEST PLAN Depends on https://phabricator.kde.org/D7601 and https://phabricator.kde.org/D7602 Verified that enabling and disabling the plugins shows and hides the categories. The enabled categories are also shown correctly when opening the dialog. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7603 AFFECTED FILES applets/digital-clock/package/contents/config/config.qml To: broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7587: kfileaudiopreview: don't autoplay media files by default
This revision was automatically updated to reflect the committed changes. Closed by commit R320:c1a7f07d4629: kfileaudiopreview: don't autoplay media files by default (authored by elvisangelaccio). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7587?vs=18890=18929 REVISION DETAIL https://phabricator.kde.org/D7587 AFFECTED FILES kfileaudiopreview/kfileaudiopreview.cpp To: elvisangelaccio, #plasma, bshah Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
Re: Plasma Mobile on the Librem 5
Hi Matthias, et al! On Tue, 29 Aug 2017 15:28:36 +0200 Matthias Klumppwrote: > [ Please keep the CC list intact for replies ] > > Hi! > > As some of you might already know, we at Purism are planning to > develop a mobile phone that uses only free software and Matrix[2] for > communication. We are currently running a crowdfunding campaign[1] in > order to be able to make the phone a reality. > > One of the open questions for the phone is still which UX we will use, > and Plasma Mobile would obviously be a perfect fit for this kind of > project, since KDE and Purism share the same values, the UI is already > done in large parts, and nothing would have to be developed from > scratch (especially the Kirigami controls are great!). Yes, Kirigami has been rather a success story, and we see more and more applications adopting it. That means that they will work much better also on mobile devices, such as phones. (It doesn't necessarily mean that they'll run and work entirely perfectly on a phone, but moves them from "this is clearly a desktop-focused UI into "small, fixable niggles".) > ## Some details about the phone software > > The base operating system of the phone will be PureOS[3], our Debian > derivative that is currently pending endorsement from the FSF. > The plan is to use OSTree[4] for the base system, in order to achieve > atomic updates and easy rollbacks, as well as Flatpaks[5] for > deployment of applications. It is likely that we will have our own > Flatpak repository with apps specifically for the phone at some point > in the future. Great, this is a direction we've been pursuing as well, e.g. by adding support for Flatpak to discover, our package manager client (and KDE Store / OCS client). Discover uses Kirigami as well, by the way, so it works well on a smartphone already. > The system will make full use of systemd and will use Bubblewrap[6] > for sandboxing of selected more critical components. Interesting, makes a lot of sense. I can't really comment from a Plasma point of view on this, it's something we need to try and if necessary, make work. > Due to the nature of the hardware, we will not need libhybris or any > Android kernel abstraction, which means that we can run stock Linux on > the phone, which greatly simplifies development and will allow us to > develop at a faster pace, due to not being bound to a specific kernel > version. That. Is. Awesome. (One of our wet dreams, actually!) > The downside is that the i.mx6 ARM CPU isn't incredibly fast. We hope > that we will be able to update to the faster i.mx8 when it is > available and can be used with free drivers, but at this point in time > we need to focus on the i.mx6 as primary hardware target. It would be good to be able to try Plasma Mobile on a development board and identify performance bottlenecks, then we can evaluate what it needs to fix these to make it all run fast enough. I don't think we can sensibly say "well, this hardware is fast enough / too slow" before we actually try it. In the end, it's software, so we should be able to make it run acceptably fast. > ## What we need from a phone UI > > Our scope for this project is limited, in order to be able to complete > it successfully and not end up in a never ending development loop: The > phone should be able to communicate via Matrix, have a web browser, > make calls, take pictures. We are not aiming for a massive amount of > apps, but instead want the basic functionalities of the phone working > well when we ship it - more apps and features can be delivered later > via Flatpaks and system updates. > > The UI therefore doesn't need to be excessive and support each and > every feature that Android already has, having a more minimal UI works > fine. I think that's a very valid approach. Catching up with Android (or iOS) in a short time-frame won't work, and it's better and more realistic to concentrate on a limited feature set and extend from there. That said, we have a reasonably working shell / workspace UI to launch and switch between apps, and a bunch of essential system controls, so we should offer a state which isn't too far from a basic usable system (except perhaps for Matrix support, but I'd suggest to read Eike's email, he's our chat goto guy and knows these ins and outs much better than I do). I think it would make sense to sit down and look at the delta between what you have in mind as a basic feature set and what we currently have, and then evaluate what we need to work on and prioritize based on that. > ## Purism and KDE > > While Purism is using GNOME for its laptops by default for various > reasons, partnering with KDE for the phone does make a lot of sense > for us, and we are excited about it. There are a few ways we can think > of how to help the Plasma Mobile team, and this email is intended to > make first contact and allow you to ask us any questions. > > What we would be interested in is knowing about the
Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126061/ --- (Updated Aug. 29, 2017, 8:57 nachm.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-framework Description --- QMenu is smart enough not to position itself outside the screen, however this can mean that the button the Menu originated from, could be covered. This can be observed with Widget Explorer's "get more widgets" buttons. Diffs - src/declarativeimports/plasmacomponents/qmenu.cpp d84f481 Diff: https://git.reviewboard.kde.org/r/126061/diff/ Testing --- Ran the menu.qml test and moved the window around, positioning seemed sane. Also Widget Explorer more menu now pops up to the top. I subtract the Y from the position to not break the most common usecase of popup(0, height) to have the menu pop up below the button. Now it pops up above it, still glued to it as it should be. Thanks, Kai Uwe Broulik