D8221: keyboard navigation in systemsettings

2017-10-09 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY correct keyboard navigation in systemsettings, since there is a mix of qwidgets and QQuickWidgets, when a QQW takes focus, then the focus

Re: recap on failing plasma-frameworks tests on CI

2017-10-09 Thread David Edmundson
The "breaking" change in p-f is the one that bumps the version. It then enables 7af93dd23873d0b9cdbac192949e7e5114940aa6 in extra-cmake-modules Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing. For compatbility this only gets set when frameworks switch to version 5.38 I

D8221: keyboard navigation in systemsettings

2017-10-09 Thread Marco Martin
mart added a reviewer: Plasma. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8221 To: mart, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: recap on failing plasma-frameworks tests on CI

2017-10-09 Thread Martin Flöser
Am 2017-10-09 16:53, schrieb Marco Martin: On Mon, Oct 9, 2017 at 2:45 PM, David Edmundson wrote: The "breaking" change in p-f is the one that bumps the version. It then enables 7af93dd23873d0b9cdbac192949e7e5114940aa6 in extra-cmake-modules Set

D8221: keyboard navigation in systemsettings

2017-10-09 Thread Marco Martin
mart updated this revision to Diff 20518. mart added a comment. - activate items on space, enter and return REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8221?vs=20516=20518 BRANCH randa/accessibility REVISION DETAIL

Re: recap on failing plasma-frameworks tests on CI

2017-10-09 Thread Marco Martin
On Mon, Oct 9, 2017 at 2:45 PM, David Edmundson wrote: > The "breaking" change in p-f is the one that bumps the version. > > It then enables 7af93dd23873d0b9cdbac192949e7e5114940aa6 in > extra-cmake-modules > > Set CMAKE_*_OUTPUT_DIRECTORY to run tests without

Re: recap on failing plasma-frameworks tests on CI

2017-10-09 Thread Marco Martin
On Mon, Oct 9, 2017 at 5:09 PM, Martin Flöser wrote: > So get rid of the build dir. Best also get rid of all installed files when > running the tests, so that it doesn't pick up them. > > Personally I think it's a mess and I think it's really bad that just > requiring a new

D8152: [platforms/drm] Use a shared pointer for gbm_surface

2017-10-09 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:47343fb8f759: [platforms/drm] Use a shared pointer for gbm_surface (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8152?vs=20375=20532

First bridge status: crossed

2017-10-09 Thread Paul Brown
Dear Todd, Jeff, Matthias, Ken, and everybody else at Purism, Congratulations for the successful crowdfunding. Still a lot to do, but, as long as we keep up the same enthusiasm and pool our resources as we have done up until now, everything will work out fine. I look forward to working on the

D8232: Add option to center shadow

2017-10-09 Thread rodrigo pelorosso
rpelorosso created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch adds an option to center the Breeze's decoration shadow. REPOSITORY R31 Breeze REVISION DETAIL

D8232: Add option to center shadow

2017-10-09 Thread rodrigo pelorosso
rpelorosso added a reviewer: Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8232 To: rpelorosso, #breeze Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[kio-extras] [Bug 369850] Can't browse samba workgroups

2017-10-09 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=369850 Nate Graham changed: What|Removed |Added CC||tomsk_interf...@vtomske.ru

D8219: Move the git find_package call to where it's used

2017-10-09 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Prevents getting a misleading "Could not find Git" cmake warning with no explanation whatsoever of what it's

Re: Plasma Team Communication & Development Practices [MUST READ]

2017-10-09 Thread Marco Martin
On Sun, Oct 8, 2017 at 12:01 PM, David Edmundson wrote: > Martin, > > don't go out of your way to get offended, most of the criticisms (of which > certainly 1 part is valid) are directed at a few certain people in Plasma. > Myself being one; Ben's kindly going out of

recap on failing plasma-frameworks tests on CI

2017-10-09 Thread Marco Martin
Hi all, I was looking into the tests that are currently failing in plasma-framework in https://build.kde.org/view/Frameworks/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/ which are 7 tests, all of them started failing from

D7315: Don't duplicate UI option for automatic speed detection

2017-10-09 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. You are correct, validation expects a value greater than 0 (Automatic). I guess the "Automatic" value was there because various configurations were allowed before, while now it expects

D8219: Move the git find_package call to where it's used

2017-10-09 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8219 To: arojas, mart, davidedmundson Cc: plasma-devel, apol, davidedmundson, mart, hein