D8752: [platforms/drm] At safety checks for the properties

graesslin added a subscriber: sebas. graesslin added a comment. In https://phabricator.kde.org/D8752#166896, @fvogt wrote: > I don't remember seeing any of those issues before AMS got added. > Only issue 1 disappears with KWIN_DRM_NO_AMS=1. The problem is not ams, but that

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in device.cpp:464 > Shouldn't we be multiplying the default matrix for the device by the matrix > you're generating here then setting that? > > If a user has set a static calibration we want to keep that. Hmm, you might

D8771: Use heuristic weighted length algorithm to calculate the query term length.

cfeck added inline comments. INLINE COMMENTS > servicerunner.cpp:52 > +} > +length += 1; > +} Since there is no 'else', the length is increased by 3 for Han characters. Is this intended? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D6688: Adjusted Scrollbars

LordTermor reopened this revision. LordTermor added a comment. This revision is now accepted and ready to land. It looks like that binary files still aren't changed . So here's a diff file. F5488819: scrollbars.diff

D8770: Resolve the input method issue by always force focus in search field.

xuetianweng updated this revision to Diff 22212. xuetianweng added a comment. revert the reordering of code in unrelated part REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8770?vs=22211=22212 BRANCH master REVISION DETAIL

D8775: Fix layout scalability issue

This revision was automatically updated to reflect the committed changes. Closed by commit R846:e16d8d0441dc: Fix layout scalability issue (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8775?vs=7=8 REVISION

D8775: Fix layout scalability issue

Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ref https://phabricator.kde.org/T7439 add fix for overlaps in tab sidebar and fix skill tips tab layout affected

D8744: Use Qt.callLater instead of creating a Timer

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8744 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8771: Use heuristic weighted length algorithm to calculate the query term length.

xuetianweng created this revision. xuetianweng added reviewers: hein, broulik. Restricted Application added a project: Plasma. REVISION SUMMARY Composing CJK character requires a lot more key comparing to latin characters. The raw length check does not make much sense for query string in

D8771: Use heuristic weighted length algorithm to calculate the query term length.

xuetianweng updated this revision to Diff 22214. xuetianweng added a comment. Revert the accident checking length change. Also make weightedLength linkage local. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8771?vs=22213=22214 BRANCH master

D8441: Wallpaper: hide color or blur filling options for full filling mode

jensreuterberg accepted this revision. jensreuterberg added a comment. This revision is now accepted and ready to land. Sure thing - I worry that there may be some technical difficulties even though I, with my limited technical skillset, can't foresee any. (Waiting nervously for a dev to

D8770: Resolve the input method issue by always force focus in search field.

xuetianweng created this revision. xuetianweng added reviewers: hein, mart. Restricted Application added a project: Plasma. REVISION SUMMARY ActivityManager.qml doesn't have input method issue because the initial focus is inside the text field. So here we try to apply the same logic. Always

D8441: Wallpaper: hide color or blur filling options for full filling mode

ngraham accepted this revision. ngraham added a comment. I'm inclined to accept this since it handles the common case better than what we have right now, and the uncommon case of transparent images is going to be a nightmare no matter what. REPOSITORY R120 Plasma Workspace BRANCH

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

asturmlechner added a comment. ping - anyone here to give a ship it? ;) REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8267 To: ostroffjh, #plasma Cc: asturmlechner, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8771: Use heuristic weighted length algorithm to calculate the query term length.

xuetianweng marked an inline comment as done. xuetianweng added inline comments. INLINE COMMENTS > cfeck wrote in servicerunner.cpp:52 > Since there is no 'else', the length is increased by 3 for Han characters. Is > this intended? Yeah you're right.. I intended to use else here. REPOSITORY

D8771: Use heuristic weighted length algorithm to calculate the query term length.

xuetianweng updated this revision to Diff 22234. xuetianweng added a comment. forget to use else.. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8771?vs=22214=22234 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8771 AFFECTED

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

davidedmundson added a comment. Mostly ship it, but I noticed something in the docs when I was checking the matrices. INLINE COMMENTS > device.cpp:464 > +} > +libinput_device_config_calibration_set_matrix(m_device, matrix.data()); > +} Shouldn't we be multiplying the default matrix

D8758: Support modifier+mouse button on window decoration

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. ship it, but I have a question INLINE COMMENTS > input.cpp:960 > + > +std::pair performClientWheelAction(QWheelEvent *event, > AbstractClient *c, MouseAction

D8759: Implement SH_Widget_Animation_Duration style hint

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > breezestyle.cpp:656 > +#if QT_VERSION >= 0x050A00 > +// TODO Qt6: drop deprecated SH_Widget_Animate > +case

D8752: [platforms/drm] At safety checks for the properties

graesslin added a dependent revision: D8776: [autotests] Add tests for DRM platform plugin. REPOSITORY R108 KWin BRANCH drm-property-safety REVISION DETAIL https://phabricator.kde.org/D8752 To: graesslin, #kwin, #plasma, fvogt, subdiff Cc: plasma-devel, kwin, ZrenBot, progwolff,

D8776: [autotests] Add tests for DRM platform plugin

graesslin added a dependency: D8752: [platforms/drm] At safety checks for the properties. REVISION DETAIL https://phabricator.kde.org/D8776 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8776: [autotests] Add tests for DRM platform plugin

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The addition of the test infrastructure is motivated by the regressions caused by adding mode

D8759: Implement SH_Widget_Animation_Duration style hint

hpereiradacosta accepted this revision. hpereiradacosta added a comment. Thanks for the patch ! REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D8759 To: elvisangelaccio, hpereiradacosta, apol Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8759: Implement SH_Widget_Animation_Duration style hint

elvisangelaccio marked an inline comment as done. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8759 To: elvisangelaccio, hpereiradacosta, apol Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D8759: Implement SH_Widget_Animation_Duration style hint

This revision was automatically updated to reflect the committed changes. Closed by commit R31:41c24a337c56: Implement SH_Widget_Animation_Duration style hint (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8759?vs=22193=22238#toc REPOSITORY R31 Breeze

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

graesslin updated this revision to Diff 22237. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Handle deviceAdded REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8748?vs=22175=22237 BRANCH

D8752: [platforms/drm] At safety checks for the properties

fvogt added a comment. Works, plasma starts fine OOTB now! However: 1. KScreen configures a way too high resolution (1920x1080 instead of 1024x768 like on X 2. On virtio, the screen freezes completely and not even switching back to consoles works before killing kwin_wayland 3. On

D8779: Avoid hypothetical crash if output->init fails

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY con->setOutput and crtc->setOutput is called in Output::~Output so this is doing