D8827: experimental support for auto mnemonics

broulik added inline comments. INLINE COMMENTS > Button.qml:43 > +//in case of explicit & the button manages it by itself > +enabled: controlRoot.text.indexOf("&") == -1 > +sequence: controlRoot.Kirigami.MnemonicData.sequence How does it behave if text contains an `&&`

D8827: experimental support for auto mnemonics

mart added inline comments. INLINE COMMENTS > broulik wrote in Button.qml:43 > How does it behave if text contains an `&&` ie. user explicitly wants an > ampersand but not a mnemonic? hm, yeah, will be terrible :/ REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D8827: experimental support for auto mnemonics

mart updated this revision to Diff 22409. mart added a comment. - && means we want & and not a mnemonic REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8827?vs=22402=22409 BRANCH mart/mnemonics REVISION DETAIL

D7543: [autotests] Support new way to run the tests without need to install

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH autotests-ecm-in-dir REVISION DETAIL https://phabricator.kde.org/D7543 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,

D8396: Add support for zwp_idle_inhibit_manager_v1

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I think we need some big discussion about how powerdevil inhbitions, logind inhibitions and this are all going to fit together in a clear coherent way. But given there

D8827: experimental support for auto mnemonics

mart added inline comments. INLINE COMMENTS > mart wrote in Button.qml:43 > hm, yeah, will be terrible :/ eww, even worse, in Qt 5.10 the mnemonics are removed in setText so is impossible to know what the original text was /o\ REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION

D8641: FormLayout

mart updated this revision to Diff 22410. mart added a comment. - && means we want & and not a mnemonic REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8641?vs=22401=22410 BRANCH mart/formlayout REVISION DETAIL https://phabricator.kde.org/D8641

D8776: [autotests] Add tests for DRM platform plugin

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in mock_drm.h:1 > I assume this is just phab being stupid? yes or git being stupid. I did not copy any files around but created a new empty file. Ok, I admit I copied the copyright header, but certainly one with my

D8661: Allow a cross-process check for same applications

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH belong-to-same-application-5.11 REVISION DETAIL https://phabricator.kde.org/D8661 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot,

D8827: experimental support for auto mnemonics

broulik added inline comments. INLINE COMMENTS > ToolButton.qml:36 > > hoverEnabled: true //Qt.styleHints.useHoverEffects TODO: how to make > this work in 5.7? > Btw probably Qt.styleHints.hasOwnProperty("useHoverEffects") ? Qt.styleHints.useHoverEffects : true REPOSITORY R858

D8827: experimental support for auto mnemonics

mart added inline comments. INLINE COMMENTS > mart wrote in Button.qml:43 > eww, even worse, in Qt 5.10 the mnemonics are removed in setText so is > impossible to know what the original text was /o\ which, they noticed it was terrible and reverted in Qt 5.11, but 5.10 is still meh, so the

D8776: [autotests] Add tests for DRM platform plugin

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > mock_drm.h:1 > / > KWin - the KDE window manager I assume this is just phab

D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found

ngraham added a comment. Yeah, putting workarounds everywhere isn't so appealing. My preference would be for a Qt fix, otherwise we'll be playing whack-a-mole here forever. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5109 To: broulik, #plasma, hein Cc:

D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found

broulik abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5109 To: broulik, #plasma, hein Cc: sefaeyeoglu, rkflx, smartins, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

https://bugs.kde.org/show_bug.cgi?id=304696 da-kdebugs...@abelonline.de changed: What|Removed |Added CC||da-kdebugs...@abelonline.de ---

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

https://bugs.kde.org/show_bug.cgi?id=304696 --- Comment #12 from da-kdebugs...@abelonline.de --- This is still open. Setting "Dim screen" to "3 min" makes the display dim after 90s (instead of 180s). Unchecking "Dim screen" disables dimming, so it is likely due to this setting. System settings

D8597: Cleanup: use temp variables instead of querying properties repeatedly

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b985b7432ef9: Cleanup: use temp variables instead of querying properties repeatedly (authored by mwolff). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8493: Make Folder View screen aware

mwolff added inline comments. INLINE COMMENTS > foldermodeltest.cpp:48 > + > +void FolderModelTest::initTestCase() > +{ remove the init and cleanup if both are empty? > screenmappertest.cpp:36 > + > +void ScreenMapperTest::cleanupTestCase() > +{ remove if empty > screenmappertest.cpp:45 > +

D8421: Port the dict applet to KF5 and QtQuick 2

dfaure added a comment. In https://phabricator.kde.org/D8421#158352, @davidedmundson wrote: > Have you added it to the panel? What should happen when I do? Surely a webview won't fit there... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D8421

D8744: Use Qt.callLater instead of creating a Timer

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e8c4c3953d4e: Use Qt.callLater instead of creating a Timer (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8744?vs=22145=22381

D8834: Make it possible to have videos on the background of breeze

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. If someone wants to make a theme with videos they can do so. I am not ok with polluting the default theme with every possible option someone could want.

D8833: Make it possible to pass different kind of backgrounds as such

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. No for the same reason. INLINE COMMENTS > themeconfig.cpp:90 > +QMimeDatabase db; > +const auto mime =

D8833: Make it possible to pass different kind of backgrounds as such

apol created this revision. apol added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY At the moment we already allowed it, we just always marked them as "image", now it will depend on

D8834: Make it possible to have videos on the background of breeze

apol created this revision. apol added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY So far people were doing it wrong, modifying files locally and there's no good reason for it.

D8793: Fix using avatars from the gallery and from local files

This revision was automatically updated to reflect the committed changes. Closed by commit R128:472f9a7446da: Fix using avatars from the gallery and from local files (authored by ngraham). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D8493: Make Folder View screen aware

amantia added inline comments. INLINE COMMENTS > mwolff wrote in screenmapper.cpp:41 > this is a pretty arbitrary timer, can you add a comment on why 100ms is > better than going through the eventloop once via QMetaObject::invokeMethod > with the delayed flag set? Done. InvokeMethod would not

D8820: Don't notify about value changes if we are still in the constructor

apol added a comment. > If you're emitting something in the constructor, how could a UI be connected to it? There's a timer. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8820 To: apol, #frameworks Cc: davidedmundson, broulik, plasma-devel, apol, mart, hein

D8026: [Activity KCM] Disallow adding/removing activity when restricted

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0e4484b6feb1: [Activity KCM] Disallow adding/removing activity when restricted (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22387. amantia marked 2 inline comments as done. amantia added a comment. Fix for some of Milian's comments (rest later, need to move to different computer) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8820: Don't notify about value changes if we are still in the constructor

davidedmundson added a comment. > it will make the UI react to it at some point If you're emitting something in the constructor, how could a UI be connected to it? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8820 To: apol, #frameworks Cc: davidedmundson,

D8793: Fix using avatars from the gallery and from local files

davidedmundson accepted this revision. davidedmundson added a comment. No objections. It fixes a bug... But, if you have the time, I'm sure we could come up wtih something much more elegant with some refactoring. (like storing the pixmap in infToSave, and then just writing it into

D8826: Support Qt scaling in wallpaper loading

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3c5df91dd1a9: Support Qt scaling in wallpaper loading (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8826?vs=22396=22398#toc REPOSITORY R120 Plasma Workspace

D3754: expose toggleWidgetExplorer through dbus

davidedmundson closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 To: mvourlakos, #plasma, davidedmundson, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8793: Fix using avatars from the gallery and from local files

ngraham added a comment. Thanks for the approval. I'll land this, then the refactoring onto my to-do list. I agree that the current code is a bit stinky and could benefit from a more direct approach. REPOSITORY R128 User Manager BRANCH arcpatch-D8793_2 REVISION DETAIL

D3209: [Notification Applet] Position dialog before showing it

davidedmundson added a comment. What's the status of this? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3209 To: broulik, #plasma, mck182, mart Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8159: Add API for setting server decoration palettes

davidedmundson planned changes to this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8159 To: davidedmundson, #plasma, graesslin Cc: graesslin, broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed,

D8794: Split init'ing the wayland output from init

This revision was automatically updated to reflect the committed changes. Closed by commit R108:e96f2bff11da: Split initing the wayland output from init (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8794?vs=22280=22400 REVISION

D8779: Avoid hypothetical crash if output->init fails

This revision was automatically updated to reflect the committed changes. Closed by commit R108:6325749f2117: Avoid hypothetical crash if output-init fails (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8779?vs=22247=22399 REVISION

D8798: Add xf86-input-libinput support for X11 mouse backend.

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > x11mousebackend.cpp:186 > +m_supportedAccelerationProfiles.clear(); > +bool adaptiveAvaiable = false; > +bool flatAvailable = false;

D8820: Don't notify about value changes if we are still in the constructor

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D8820 To: apol, #frameworks, davidedmundson Cc: davidedmundson, broulik, plasma-devel, apol, mart, hein

D8820: Don't notify about value changes if we are still in the constructor

This revision was automatically updated to reflect the committed changes. Closed by commit R169:09efedec8c71: Dont notify about value changes if we are still in the constructor (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D8826: Support Qt scaling in wallpaper loading

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY On wayland we're using Qt scaling. This normally handles most scaling stuff itself, except

D2660: Prefer an algorithm over an explicit for loop

This revision was automatically updated to reflect the committed changes. Closed by commit R122:d492dc57eeb3: Prefer an algorithm over an explicit for loop (authored by jkt, committed by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2660?vs=7144=22397#toc REPOSITORY

D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect

davidedmundson added a comment. > New test case added which crashes without this fix. I wanted to see the backtrace of what we're working round, so applied just the test and not the changes to the effect. It didn't crash. Any ideas? REPOSITORY R108 KWin BRANCH

D1986: WIP: Save PanelView settings in terms of grid units

davidedmundson abandoned this revision. davidedmundson added a comment. Can't remember what the state of this is, and the original code probably changed. Closing. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1986 To: davidedmundson, #plasma Cc: mart,

D8826: Support Qt scaling in wallpaper loading

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:38 > property bool ready: false > +property var sourceSize: Qt.size(root.width * Screen.devicePixelRatio, > root.height * Screen.devicePixelRatio)

D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect

graesslin added a comment. In https://phabricator.kde.org/D8821#168053, @davidedmundson wrote: > > New test case added which crashes without this fix. > > I wanted to see the backtrace of what we're working round, so applied just the test and not the changes to the effect. > It

D1971: Disable high DPI scaling on kscreenlocker

davidedmundson abandoned this revision. davidedmundson added a comment. > Worst still it highlights a bug when using text with Qt.NativeRendering AFAIK this is fixed. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D1971 To: davidedmundson, #plasma,

D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect

davidedmundson added a comment. Got it, thanks. REPOSITORY R108 KWin BRANCH windowgeometry-delay-effectframe REVISION DETAIL https://phabricator.kde.org/D8821 To: graesslin, #kwin, #plasma, broulik Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D8641: FormLayout

mart updated this revision to Diff 22401. mart added a comment. - mnemoinictext property, which always has the & - support mnemonics in the global drawer - different weigths for differnt control types - filter on the window not the app REPOSITORY R169 Kirigami CHANGES SINCE LAST

D8821: [effects] Delay creation of EffectFrames in WindowGeometryEffect

graesslin added a comment. As I just made my kwin crash just to get the backtrace I'm adding nevertheless: (gdb) bt #0 0x7f8d550626b0 in KWayland::Client::Compositor::operator wl_compositor*() () at /workspace/build/src/client/compositor.cpp:131 #1 0x7f8d428b377d in

D8641: FormLayout

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in mnemonicattached.cpp:49 > Note that the alt to show is a Breeze special feature for widgets. i think it's fine assuming the style supports that... (and assume that the one which is really supported is breeze) i wouldn't know

D8827: experimental support for auto mnemonics

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY use auto mnemonics for common widgets as buttons, checkboxes and tabs A feature similar to KXMLGui apps TEST

D8828: Honour the preferred mode flag in the kwayland backend

fvogt created this revision. fvogt added reviewers: Plasma, sebas. Restricted Application added a project: Plasma. REVISION SUMMARY BUG: 386900 TEST PLAN Ran plasma on wayland in virtio, instead of switching to 4096x2160@60 it stays at the right resolution of 1024x768@60 on startup and

D8828: Honour the preferred mode flag in the kwayland backend

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D8828 To: fvogt, #plasma, sebas, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8828: Honour the preferred mode flag in the kwayland backend

This revision was automatically updated to reflect the committed changes. Closed by commit R110:a4aa09ef9a83: Honour the preferred mode flag in the kwayland backend (authored by fvogt). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE