D8850: Support drag and drop between shared folder view containments

mwolff accepted this revision. mwolff added a comment. This revision is now accepted and ready to land. lgtm in general, but a unit test for the positioner would be good to have INLINE COMMENTS > foldermodel.cpp:1053 > +if (isDropBetweenSharedViews(mimeData->urls(),

D8924: Move the KDE Polkit-Agent into ksmserver

apol added a comment. > This creates a "slight" problem for Wayland as ksmserver is forced to XCB. What do you think about doing it like with kscreenlocker? On X11 ksmserver, on Wayland KWin? Otherwise +1000 to this suggestion. Isn't the solution to stop forcing ksmserver to XCB?

D8864: RFC: [MouseEventListener] Allow accepting mouse event

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D8864 To: broulik, #plasma, hein Cc: apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8598: FolderView: position files at drop event target position

mwolff updated this revision to Diff 22715. mwolff added a comment. remove unused param REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8598?vs=22458=22715 BRANCH wip/lim-2 REVISION DETAIL https://phabricator.kde.org/D8598 AFFECTED FILES

D8598: FolderView: position files at drop event target position

hein accepted this revision. hein added a comment. Small comment change request in the comments, but code-wise good to go. INLINE COMMENTS > foldermodel.cpp:1068 > + * > + * TODO: move this somehow to the Positioner > + */ As mentioned on IRC I'd currently prefer to keep the

D8598: FolderView: position files at drop event target position

mwolff added inline comments. INLINE COMMENTS > foldermodel.cpp:155 > + * > + * TODO: push this somehow into the Positioner > + */ here as well then REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8598 To: mwolff, hein, amantia Cc: plasma-devel,

D7246: Tooltips in Breeze theme

McPain added a comment. In https://phabricator.kde.org/D7246#158488, @ngraham wrote: > @McPain, any update? Not now. I don't get what to do: rewrite entire patch or write it for oxygen? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain,

D8939: Offset the scrollbar by the header size

apol added a comment. Here's a video of what it looks like after the patch, in Discover F5502419: vokoscreen-2017-11-22_12-26-58.mkv . REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8939 To: apol, #kirigami, mart Cc:

D8939: Offset the scrollbar by the header size

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 387098 REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL

D8939: Offset the scrollbar by the header size

apol added reviewers: ngraham, abetts. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8939 To: apol, #kirigami, mart, ngraham, abetts Cc: plasma-devel, apol, davidedmundson, mart, hein

D8939: Offset the scrollbar by the header size

colomar added a comment. Looking great! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8939 To: apol, #kirigami, mart, ngraham, abetts Cc: colomar, plasma-devel, apol, davidedmundson, mart, hein

D8493: Make Folder View screen aware

hein added a comment. Modulo above edge-casey comments it looks good to me. INLINE COMMENTS > foldermodel.cpp:1324 > +const QString name = item.url().toString(); > +const int screen = m_screenMapper->screenForItem(name); > +// don't do anything if the folderview is

D8850: Support drag and drop between shared folder view containments

hein added inline comments. INLINE COMMENTS > foldermodel.cpp:1122 > +if (targetUrl.toString().startsWith(url.toString())) { > +m_screenMapper->addMapping(targetUrl.toString(), m_screen, > ScreenMapper::DelayedSignal); > +} else if >

D8915: Update the proxy to source and source to proxy mapping correctly

hein accepted this revision. BRANCH master REVISION DETAIL https://phabricator.kde.org/D8915 To: amantia, #plasma, hein, mwolff Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8598: FolderView: position files at drop event target position

amantia requested changes to this revision. amantia added a comment. This revision now requires changes to proceed. Milian, please also update the commit description (the last paragraph needs to go away). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8598

D8493: Make Folder View screen aware

amantia updated this revision to Diff 22795. amantia marked 2 inline comments as done. amantia added a comment. Handle Eike's comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=22444=22795 BRANCH master REVISION DETAIL

D8493: Make Folder View screen aware

amantia added inline comments. INLINE COMMENTS > hein wrote in foldermodel.cpp:1688 > I know it's a very theoretical case, but you're not disconnecting from an old > non-null ScreenMapper here. > > You're also not calling invalidateFilter even though filterAcceptsRow uses > the mapper. It's

D8850: Support drag and drop between shared folder view containments

amantia updated this revision to Diff 22797. amantia added a comment. Guard m_screenMapper usage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8850?vs=22682=22797 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8850 AFFECTED FILES

D8939: Offset the scrollbar by the header size

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fantastic, that's perfect! REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D8939 To: apol, #kirigami, mart, ngraham, abetts Cc: colomar,

D7246: Tooltips in Breeze theme

ngraham added a comment. Probably redo the patch so that it can apply to any theme. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. After a lot of design work in https://phabricator.kde.org/tag/vdg/, we all agreed on the following: F5502756: photo_2017-11-22_08-59-07.jpg REPOSITORY R119 Plasma Desktop REVISION DETAIL

D7246: Tooltips in Breeze theme

ngraham edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

ngraham added a comment. In https://phabricator.kde.org/D8798#170879, @jriddell wrote: > on kcm touchpad I still get "No touchpad found" (on my KDE Slimbook), this isn't a surprise as your patch doesn't touch the touchpad kcm. Should it? That would be probably be handled by a

D8916: QML port of fonts kcm

mart added a comment. In https://phabricator.kde.org/D8916#170365, @ngraham wrote: > Could we possibly take the opportunity to turn font anti-aliasing on by default instead of leaving it with "Vendor Default" (a string that doesn't have any meaning to most users)? i would really

D8798: Add xf86-input-libinput support for X11 mouse backend.

jriddell requested changes to this revision. jriddell added a comment. This revision now requires changes to proceed. kcms/input/kcmmouse.ui Don't change as that makes the default tab seem wrong REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8798 To:

D8798: Add xf86-input-libinput support for X11 mouse backend.

jriddell added a comment. on kcm touchpad I still get "No touchpad found" (on my KDE Slimbook), this isn't a surprise as your patch doesn't touch the touchpad kcm. Should it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham,

D8798: Add xf86-input-libinput support for X11 mouse backend.

jriddell added a comment. This disables the input kcm if libinput x11 plugin is not found. I expect this is fine, it is for ubuntu distros at least, but it might be worth asking distros if it causes them a problem. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Thanks, will implement tomorrow! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmustac, ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8798: Add xf86-input-libinput support for X11 mouse backend.

jriddell added a comment. Using the patch the acceleration profile box doesn't show. I have a KDE Slimbook with and xinput reports this: ⎡ Virtual core pointer id=2[master pointer (3)] ⎜ ↳ Virtual core XTEST pointerid=4[slave

D8924: Move the KDE Polkit-Agent into ksmserver

graesslin added a comment. In https://phabricator.kde.org/D8924#170463, @apol wrote: > > This creates a "slight" problem for Wayland as ksmserver is forced to XCB. What do you think about doing it like with kscreenlocker? On X11 ksmserver, on Wayland KWin? Otherwise +1000 to this

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng added a comment. Whether it shows up reallys depends on your system. Especially when there's multiple mouse driver available and you may using evdev. For example, here's one output on my system, when you see something like this, you'll know it's using libinput's xf86 driver.

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng updated this revision to Diff 22774. xuetianweng added a comment. revert the accidentally changed currentIndex in ui file when save in designer. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8798?vs=22543=22774 BRANCH mouse REVISION

D8956: Implement geometry update blocking in ShellClient

graesslin created this revision. graesslin added reviewers: Plasma, KWin. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Commit https://phabricator.kde.org/R108:188491d3922180f1e1bba8fa2cd3fd2aa4a527c0 introduced a

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng marked 3 inline comments as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham, #plasma, jriddell Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng added a comment. In https://phabricator.kde.org/D8798#170892, @jriddell wrote: > This disables the input kcm if libinput x11 plugin is not found. I expect this is fine, it is for ubuntu distros at least, but it might be worth asking distros if it causes them a problem.

D8916: QML port of fonts kcm

mart added a comment. In https://phabricator.kde.org/D8916#170830, @mart wrote: > In https://phabricator.kde.org/D8916#170365, @ngraham wrote: > > > Could we possibly take the opportunity to turn font anti-aliasing on by default instead of leaving it with "Vendor Default" (a string