D9325: Use QUrl in the ScreenMapper API

ervin added a comment. @mwolff and @broulik Could one of you answer @amantia concerns regarding the motivations of that patch? If you agree with him maybe we don't want that patch at all... REVISION DETAIL https://phabricator.kde.org/D9325 To: amantia, #plasma, mwolff, dakon, broulik Cc:

D9313: Don't move back items to second screen if they were manually moved

mwolff added inline comments. INLINE COMMENTS > screenmapper.cpp:177 > +{ > +for (auto it = m_itemsOnDisabledScreensMap.begin(); > + it != m_itemsOnDisabledScreensMap.end(); ++it) { doesn't this work too: for (auto : m_itemsOnDisabledScreensMap) { names.removeAll(name);

D9324: [Air theme] Add task bar progress graphic

broulik added a comment. > What should be the move here? What do you mean? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9324 To: broulik, #plasma, #vdg, ngraham Cc: abetts, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D9325: Use QUrl in the ScreenMapper API

mwolff added a comment. I'd personally prefer to use an API with less conversions if possible. The fact that the test code becomes (marginally) more complex doesn't really count in my opinion. INLINE COMMENTS > foldermodel.cpp:291 > > -const auto oldUrl = m_url; > +const auto

D9406: Fix ASAN warning on TestXdgForeign

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D9406 To: davidedmundson, #plasma, graesslin Cc:

D9349: Fix qmake build of Kirigami

IlyaBizyaev closed this revision. IlyaBizyaev added a comment. Closed by https://phabricator.kde.org/R169:b0bf6b85ccd60aecb57c2cd5c54a912fc62d4113. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9349 To: IlyaBizyaev, #kirigami, davidedmundson Cc: davidedmundson,

D9411: Add a commandline tool to switch lnf package

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:76 > +target_link_libraries(lookandfeeltool > +# Qt5::Gui > +# Qt5::Widgets please tidy this > lnftool.cpp:89 > + > +

D9407: Scope exported/imported objects to the test

This revision was automatically updated to reflect the committed changes. Closed by commit R127:9121e6897254: Scope exported/imported objects to the test (authored by davidedmundson). Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland

D9406: Fix ASAN warning on TestXdgForeign

This revision was automatically updated to reflect the committed changes. Closed by commit R127:b13560ceac59: Fix ASAN warning on TestXdgForeign (authored by davidedmundson). Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland CHANGES

D9411: Add a commandline tool to switch lnf package

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY using the kcm c++ itself to do the switch, have a tool that can be used to switch lnf package from the command

D9407: Scope exported/imported objects to the test

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9407 To: davidedmundson, #plasma,

D9411: Add a commandline tool to switch lnf package

This revision was automatically updated to reflect the committed changes. Closed by commit R119:46fcd51d73a8: Add a commandline tool to switch lnf package (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9411?vs=24113=24114#toc REPOSITORY R119 Plasma Desktop CHANGES

D9411: Add a commandline tool to switch lnf package

mart updated this revision to Diff 24113. mart added a comment. remove dead code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9411?vs=24110=24113 BRANCH mart/lookandfeeltool REVISION DETAIL https://phabricator.kde.org/D9411 AFFECTED FILES

D9414: Implement OSD to select action when unknown monitors is connected

dvratil created this revision. dvratil added reviewers: sebas, davidedmundson, VDG. dvratil added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Building on top of the `sebas/osd` branch, this change introduces a special OSD that appears when a

D9414: Implement OSD to select action when unknown monitors is connected

graesslin added a comment. How is the interaction supposed to happen? KWin considers OSDs as a non-interactive on screen display (as the name says). Key events are not passed to OSDs and for mouse I'm not sure. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414

D9414: Implement OSD to select action when unknown monitors is connected

graesslin added a comment. And also please test on Wayland: we have a requirement of new features on Wayland first. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc: graesslin, ngraham, plasma-devel, mlaurent,

D9391: [effects] Add 'Fullscreen' effect

zzag marked 2 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9391 To: zzag, #kwin, #plasma Cc: graesslin, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24139. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Updating https://phabricator.kde.org/D9391: [effects] Add 'Fullscreen' effect REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. It seems to be working, but there is a problem with GTK apps. They have wrong positions in their geometries: Output like `"{...} -> {...}"` comes from `geometryChanged`: js

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. F5557841: fullscreen_konsole.mp4 F5557844: fullscreen_gimp.mp4 REPOSITORY R108 KWin REVISION DETAIL

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Seems like calculation of gravity in `Client::calculateGravitation()` is wrong for gtk apps. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9391 To: zzag, #kwin, #plasma Cc:

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24141. zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. [effects] Add 'Fullscreen' effect This effect animates transition to/from fullscreen mode. For the most part it is a copy-paste of the Maximize effect with

D9406: Fix ASAN warning on TestXdgForeign

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Internally XdgForeign has some delete laters If we clean

D9407: Scope exported/imported objects to the test

davidedmundson created this revision. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY m_imported was parented to the TestForeign class, which lasts for all the tests. This caused an

D9407: Scope exported/imported objects to the test

davidedmundson added a reviewer: Plasma. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D9407 To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,