I've made new stable branches for Plasma 5.12 for these repos
https://cgit.kde.org/releaseme.git/tree/plasma/git-repositories-for-release
Please make bugfixes to these branches
Tars and Tag is due Thu 1 Feb for final release on Tue 6th
i18n dudes could you set the new stable branch for
mart created this revision.
mart added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.
REVISION SUMMARY
This is the first step in actually creating a valid Qt static plugin.
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-integration%20kf5-qt5%20FreeBSDQt5.9/10/
Project:
Plasma plasma-integration kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 13:11:27 +
Build duration:
2 hr 32 min and counting
5.12 is about ready to go but the announce says Wayland support is LTS
which not everyone is happy with. Who knows what the story is here?
"For the first time we offer our Wayland integration on long term
support so you can be sure we will continue to fix bugs over the
coming releases. "
" It
Hi, Valorie!
I have just edited the list of Krita ideas, now we have 8 ideas, 4 of
which are low-hanging fruits with localized optimizations of the code. I
hope that will help people who do not want to learn all half-million
lines of Krita code.
Speaking truly, I think I understand why
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9891
To: broulik, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
Am 2018-01-15 17:04, schrieb Jonathan Riddell:
5.12 is about ready to go but the announce says Wayland support is LTS
which not everyone is happy with. Who knows what the story is here?
The story is: for 5.8 we explicitly excluded Wayland (especially KWin)
from the LTS promise. We don't do
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Otherwise by the time applications receive the DBus signal, the
mart added a reviewer: lepagevalleeemmanuel.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D9892
To: mart, #kirigami, lepagevalleeemmanuel
Cc: plasma-devel, apol, davidedmundson, mart, hein
Please update the errata page for issues in Plasma 5.12
https://community.kde.org/Plasma/5.12_Errata
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:87f0a119e112: Add support for apply initial shortcut
window rule (authored by graesslin).
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
CHANGES SINCE LAST
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:d7cc5eb3bd5b: Add support for apply initial keep
above/below window rules (authored by graesslin).
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
CHANGES
graesslin abandoned this revision.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Superseeded by
https://phabricator.kde.org/R108:8510f31340ac78d76df69a3bccb001f610613913
REPOSITORY
R108 KWin
REVISION DETAIL
Jonathan Riddell ha scritto:
> I've made new stable branches for Plasma 5.12 for these repos
> https://cgit.kde.org/releaseme.git/tree/plasma/git-repositories-for-release
>
> Please make bugfixes to these branches
> Tars and Tag is due Thu 1 Feb for final release on Tue 6th
>
> i18n dudes could
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:e200d7403110: [effects/blur] Disable texture cache on
Wayland (authored by graesslin).
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
CHANGES SINCE LAST
broulik created this revision.
broulik added reviewers: Plasma, VDG, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This gets rid of all those internal
dvratil updated this revision to Diff 25427.
dvratil added a comment.
Fix commit message
REPOSITORY
R110 KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9905?vs=25425=25427
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9905
AFFECTED FILES
dvratil updated this revision to Diff 25428.
dvratil added a comment.
Fix commit message
REPOSITORY
R110 KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9906?vs=25426=25428
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9906
AFFECTED FILES
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R110 KScreen Library
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9905
To: dvratil, sebas, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
ngraham created this revision.
ngraham added reviewers: hpereiradacosta, Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
CCBUG: 388810
I don't have strong feeling
ngraham edited the test plan for this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9900
To: ngraham, hpereiradacosta, #breeze
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
dvratil created this revision.
dvratil added reviewers: sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
dvratil requested review of this revision.
REVISION SUMMARY
Fixes scaling not being restored when known config
dvratil created this revision.
dvratil added reviewers: sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
dvratil requested review of this revision.
REVISION SUMMARY
On Wayland outputs are not merely disconnected,
dvratil created this revision.
dvratil added reviewers: sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
dvratil requested review of this revision.
REVISION SUMMARY
Sharing a single config leads to undesired
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Thanks ever so much.
There's been a bug report open on this for ages.
definitely 388567 and probably 384733
REPOSITORY
R104 KScreen
BRANCH
master
REVISION
I've submitted an idea for System Settings: Improve handling for
touchpads and mice with Libinput
https://community.kde.org/GSoC/2018/Ideas#Improve_handling_for_touchpads_and_mice_with_Libinput
This is pretty important going forward since most distros are shipping
with Libinput now, but our
lopatin updated this revision to Diff 25414.
lopatin added a comment.
Ok, I updated patch and added showTopLevelItems flag.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8816?vs=22337=25414
REVISION DETAIL
https://phabricator.kde.org/D8816
dvratil created this revision.
dvratil added reviewers: sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
dvratil requested review of this revision.
REVISION SUMMARY
The 'name' argument is in most cases empty by which
dvratil created this revision.
dvratil added reviewers: sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
dvratil requested review of this revision.
REVISION SUMMARY
This prevents the code from unnecesarilly emitting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20plasma-integration%20kf5-qt5%20FreeBSDQt5.9/11/
Project:
Plasma plasma-integration kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 15:44:30 +
Build duration:
2 hr 31 min and counting
broulik added a comment.
I think `OnScreenDisplay` implies being non-interactive on Wayland
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D9414
To: dvratil, sebas, davidedmundson, #vdg
Cc: broulik, kamathraghavendra, graesslin, ngraham, plasma-devel, mlaurent,
anemeth added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
This change will be superseded by: https://phabricator.kde.org/D9848
I just removed the caching blur altogether.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9879
To:
dvratil added a comment.
In https://phabricator.kde.org/D9414#181150, @graesslin wrote:
> How is the interaction supposed to happen? KWin considers OSDs as a
non-interactive on screen display (as the name says). Key events are not passed
to OSDs and for mouse I'm not sure.
This
dvratil updated this revision to Diff 25432.
dvratil added a comment.
Fixes and improvements
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9414?vs=24119=25432
BRANCH
dvratil/osd
REVISION DETAIL
https://phabricator.kde.org/D9414
AFFECTED FILES
anemeth updated this revision to Diff 25436.
anemeth added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Removed the option the cache blur.
The reason was that since it was disabled in wayland
(https://phabricator.kde.org/D9879) because it does not work
dvratil added a comment.
Indeed for out-of-process backends the config arrives serialized via DBus and
a new copy which is then passed to a client is created during serialization.
The change you mention is likely unrelated - it only mentions X11 which is
always out-of-process, so not
Including wayland fixes to 5.12, for the lifespan of the LTS and having the
same technical policy is absolutely fine.
The problem is calling something LTS has strong implications both in terms
of expectations and marketing.
I don't want us to try jumping from "wayland is experimental" to boldly
apol added a comment.
> I did consider it and went ahead in ring-kde and put every QML in QRC even
in non static builds. I think it makes sense, but makes debugging a bit harder
and I didn't want to change too much things to fix the static plugin. Shipping
assets in QRC doesn't seem to be
lepagevalleeemmanuel added a comment.
In https://phabricator.kde.org/D9892#191590, @apol wrote:
> I wonder if it would make sense to always ship the qml files as qrc in the
plugin. Have you considered it?
(this code is originally from me, then improved by notmart and is part of
anemeth added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS
> fredrik wrote in blur.h:41
> This number could use an explanation.
I don't know why it's 5
This was in the old blur too:
davidedmundson added a comment.
Looks sensible to me.
To make sure I'm on the same page, out of process configs implicitly are
copies of the one in the backend. So for consistent behaviour, in-process ones
need to be explicitly cloned.
Can you look if
dvratil created this revision.
dvratil added reviewers: sebas, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
dvratil requested review of this revision.
REVISION SUMMARY
We can share the same "guessing" code with the
apol added a comment.
I wonder if it would make sense to always ship the qml files as qrc in the
plugin. Have you considered it?
INLINE COMMENTS
> CMakeLists.txt:47
> +set_target_properties(kirigamiplugin PROPERTIES LIBRARY_OUTPUT_DIRECTORY
> ${CMAKE_BINARY_DIR}/bin/org/kde/kirigami.2)
dvratil edited the summary of this revision.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D9414
To: dvratil, sebas, davidedmundson, #vdg
Cc: kamathraghavendra, graesslin, ngraham, plasma-devel, mlaurent, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg,
hein accepted this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9797
To: broulik, #plasma, hein, mart
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c31e5963d5a2: [Task Manager] Clear smart launcher data
when launcher URL changes (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a3dae3abb7b0: [Panel View] Check if its the same
applet were configuring before just hiding… (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:755adc801aa1: [DBusMenuImporter] Just send
opened in updateMenu() (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:94b91f723a23: [ConfigModel] Set QML context on
ConfigModule (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R111 KSysguard Library
BRANCH
history
REVISION DETAIL
https://phabricator.kde.org/D9689
To: fvogt, #plasma, broulik
Cc: kossebau, broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/61/
Project:
Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 09:03:53 +
Build duration:
1 hr 2 min and counting
JUnit
mart added a comment.
ping?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8726
To: broulik, #plasma, mart
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
mart added a comment.
ping?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8725
To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, davidedmundson, mart, hein
mart accepted this revision.
mart added a comment.
ping?
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7681
To: adridg, dfaure, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein
broulik added a comment.
Looking good!
INLINE COMMENTS
> ApplicationsView.qml:112
> +// HACK: Align the content to right for RTL locales
> +leftMargin: LayoutMirroring.enabled ? Math.max(0, width -
> contentWidth) : undefined
> +
`leftMargin` does not have a `RESET`
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma%20kdeplasma-addons%20kf5-qt5%20FreeBSDQt5.9/14/
Project:
Plasma kdeplasma-addons kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 09:04:02 +
Build duration:
1 hr 18 min and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:813749e75f52: [Task Manager] Let mouse back/forward keys
switch tracks (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
hein accepted this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9813
To: broulik, #plasma, hein, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mart accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9812
To: broulik, #plasma, hein, mwolff, davidedmundson, mart
Cc: mwolff, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:639e8684e3b3: [Icon Item] Treat sources starting with a
slash as local file (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ae219e8941cb: [Kicker] Also round to icon size custom
square images (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
broulik closed this revision.
broulik added a comment.
https://cgit.kde.org/kdeclarative.git/commit/?id=84a370ce2c3ac48be9e8745a93cd347bba463323
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9784
To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks,
broulik accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
BRANCH
blur-no-cache-wayland
REVISION DETAIL
https://phabricator.kde.org/D9879
To: graesslin, #kwin, #plasma, broulik
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/105/
Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 09:03:41 +
Build duration:
51 min and counting
JUnit Tests
Name:
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:f28072080b89: Add a per-process CPU usage graph shown in
the process list (authored by fvogt).
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
broulik abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4361
To: broulik, #plasma
Cc: bshah, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:87ec46be03b4: [Image Wallpaper] Just use Timer to
determin when were ready (authored by broulik).
REPOSITORY
R120
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:37e134b62527: [PageRow] Navigate between levels with
mouse back/forward buttons (authored by broulik).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:52e87d2c96db: [ScrollView] Scroll one page with
Shift+wheel (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8726?vs=22087=25382#toc
REPOSITORY
R169 Kirigami
CHANGES
mart added inline comments.
INLINE COMMENTS
> hpereiradacosta wrote in breezestyle.cpp:5016
> Ok. Just checked: this whole code should still work if replaced by:
>
> const bool widgetMouseOver( _animations->scrollBarEngine().isHovered(
> widget, QStyle::SC_ScrollBarGroove ) );
>
> (used
Hi,
on GCompris side, we hope/plan to mentor 2 students like last year. I
updated the page to add one more task.
Regarding the events: this year, we were planning to skip SoK to focus more
on GCi and GSoC, having the 3 events is too consuming and do not allow us
to progress on our main tasks.
broulik accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
BRANCH
shell-client-keep-above-below-rules
REVISION DETAIL
https://phabricator.kde.org/D9870
To: graesslin, #kwin,
broulik accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
BRANCH
shell-client-shortcut-rule
REVISION DETAIL
https://phabricator.kde.org/D9876
To: graesslin, #kwin, #plasma,
jgrulich requested changes to this revision.
jgrulich added a comment.
This revision now requires changes to proceed.
Could you also add support for RSA SecurID so support for tokens is complete?
I'm also not sure whether with this the support is complete, because you need
to also add this
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/55/
Project:
Plasma kwin kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 07:57:12 +
Build duration:
2 min 38 sec and counting
CONSOLE OUTPUT
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9b8029fdfb38: [Task Manager] Show badge count also in
tooltip (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9825?vs=25174=25371#toc
REPOSITORY
R119 Plasma Desktop
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2edca0b16860: [Task Manager] Let badge become pill-shaped
and limit to 0 through 9,999 items (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9827?vs=25238=25369#toc
davidedmundson accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9812
To: broulik, #plasma, hein, mwolff, davidedmundson
Cc: mwolff, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9786
To: safaalfulaij, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
davidedmundson added a comment.
Please merge after 5.12 branches.
REPOSITORY
R31 Breeze
BRANCH
arcpatch-D9792
REVISION DETAIL
https://phabricator.kde.org/D9792
To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Cc: davidedmundson, ngraham, colomar, abetts, plasma-devel,
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma%20kinfocenter%20kf5-qt5%20FreeBSDQt5.9/11/
Project:
Plasma kinfocenter kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 09:05:34 +
Build duration:
1 hr 59 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/56/
Project:
Plasma kwin kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 09:04:46 +
Build duration:
1 hr 58 min and counting
JUnit Tests
Name: (root)
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:6e74b46c9857: Use smaller non-italic font for system
settings module authentication message (authored by broulik).
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
safaalfulaij updated this revision to Diff 25384.
safaalfulaij added a comment.
- 0 instead of undefined
- change statments order
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9786?vs=25138=25384
BRANCH
master
REVISION DETAIL
mart added inline comments.
INLINE COMMENTS
> mart wrote in breezestyle.cpp:5016
> it works ok for the qwidget case, unfortunately in the case of qml,
> _animations will always be empty, so i still have to check
> option->styleObject anyways
this is the shortest form i could come up which
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b127e545b552: [Kickoff] Fix RTL issues (authored by
safaalfulaij).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9786?vs=25384=25386
REVISION DETAIL
mart updated this revision to Diff 25385.
mart added a comment.
- shorter form
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9792?vs=25240=25385
BRANCH
arcpatch-D9792
REVISION DETAIL
https://phabricator.kde.org/D9792
AFFECTED FILES
hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
Ship it ! Thanks !
REPOSITORY
R31 Breeze
BRANCH
arcpatch-D9792
REVISION DETAIL
https://phabricator.kde.org/D9792
To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Cc: ngraham, colomar, abetts,
88 matches
Mail list logo
