D10571: [AppletAppearance] Remove d QtObject

2018-02-16 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It's not like this is public API or anything. TEST PLAN Saves

D10560: [Clipboard plasmoid] Support Aztec barcode

2018-02-16 Thread Volker Krause
vkrause added a comment. looks good to me REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10560 To: broulik, #plasma, graesslin, vkrause Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10560: [Clipboard plasmoid] Support Aztec barcode

2018-02-16 Thread Kai Uwe Broulik
broulik added a comment. > There surely needs to be some CMake change somewhere with the version? I thought the same but in CMakeLists.txt ist says find_package(KF5Prison ${KF5_MIN_VERSION}) and min is 5.42 already REPOSITORY R120 Plasma Workspace REVISION DETAIL

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2018-02-16 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=346972 Bug 346972 depends on bug 339863, which changed state. Bug 339863 Summary: Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon https://bugs.kde.org/show_bug.cgi?id=339863

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

2018-02-16 Thread Harald Sitter
sitter added a comment. Yeah, it costs us nothing to use a 5 suffix though and it is more consistent with the other bins. If someone says bin/kdesu as a name is more useful to them I am not opposed to dropping the suffix though. (also I just checked and we even had kdesu in libexec of

D10560: [Clipboard plasmoid] Support Aztec barcode

2018-02-16 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:a42ccf51c3c5: [Clipboard plasmoid] Support Aztec barcode (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10560?vs=27301=27332#toc REPOSITORY R120 Plasma Workspace

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Michail Vourlakos
mvourlakos added a comment. Latte config window is a Plasma::ConfigView, so it inherates a QQuickView REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh,

D10480: align checkable widgets in menu items

2018-02-16 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. In D10480#207511 , @zzag wrote: > > Here: if you look at the last checkbox (folders first). The distance to the left edge is larger to that of the bottom edge, while before they were identical. > > Oh, I

Re: Does Breeze provide QtQuick2 theming?

2018-02-16 Thread Marco Martin
On venerdì 16 febbraio 2018 03:10:53 CET Ongun Kanat wrote: > Hello, > > I was testing a QtQuick2 application > (https://github.com/agateau/sfxr-qt). One thing I noticed, using dark > color schemes (i.e Breeze Dark) result in unreadable white-ish text on > white window backgrounds in QtQuick2

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Michail Vourlakos
mvourlakos added a comment. Can you build Latte from master version? All comboboxes in its settings window are PlasmaComponents3 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart,

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Safa Alfulaij
safaalfulaij added a comment. In D9275#207623 , @mvourlakos wrote: > Can you build Latte from master version? All comboboxes in its settings window are PlasmaComponents3 :) Ok, I can assume that Latte doens't have a

Mind to update package pages

2018-02-16 Thread Jonathan Riddell
Distros are reminded to update the pages listing when they make Plasma software available though packages, docker images and live/installable images https://community.kde.org/Plasma/Live_Images https://community.kde.org/Plasma/Docker_Images https://community.kde.org/Plasma/Packages Jonathan

D10388: allow to have more than one default activity

2018-02-16 Thread Ivan Čukić
ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R161 KActivity Manager Service BRANCH phab/defaultMultipleActivities REVISION DETAIL https://phabricator.kde.org/D10388 To: mart, #plasma, ivan, bshah Cc: davidedmundson, plasma-devel, ZrenBot,

D10560: [Clipboard plasmoid] Support Aztec barcode

2018-02-16 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10560 To: broulik, #plasma, graesslin, vkrause, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff,

D10480: align checkable widgets in menu items

2018-02-16 Thread Vlad Zagorodniy
zzag reclaimed this revision. zzag added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezestyle.cpp:4740 > If I understand right, this is the double spacing bug fix. > Correct ? Very nice. > In principle, it would be better to have it in a separate Review, and a > separate

D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-16 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10392 To: icota, #kirigami, mart Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein

D10388: allow to have more than one default activity

2018-02-16 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R161:6e60c6a3e46b: allow to have more than one default activity (authored by mart). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Safa Alfulaij
safaalfulaij added a comment. I've done some more testing and read some Qt docs. `Popup` item get reparented to the window once displayed, so LayoutMirroring is applied to it only at that point (applying it to the contentItem). So my comments above about `Popup` not inheerting `Item` are

D10579: Search runtime dependencies on QML modules

2018-02-16 Thread Heiko Becker
heikobecker updated this revision to Diff 27351. heikobecker added a comment. Also updated README REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10579?vs=27338=27351 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10579 AFFECTED FILES

D10500: Make the review pop-up a bit more user-friendly

2018-02-16 Thread Nathaniel Graham
ngraham added a comment. That's a good idea, but I'm having a bit of trouble with the implementation. If this is otherwise okay, can we land it in its current state, and commit to doing that in a subsequent patch? REPOSITORY R134 Discover Software Store REVISION DETAIL

D10579: Search runtime dependencies on QML modules

2018-02-16 Thread Michail Vourlakos
mvourlakos added a comment. nice REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https://phabricator.kde.org/D10579 To: heikobecker, mvourlakos, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

2018-02-16 Thread Hugo Pereira Da Costa
This revision was automatically updated to reflect the committed changes. Closed by commit R31:336cf7b63a6a: Added option to set transparency and blur behind menu frames such as right… (authored by hpereiradacosta). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10170?vs=27010=27358#toc

D10480: align checkable widgets in menu items

2018-02-16 Thread Vlad Zagorodniy
This revision was automatically updated to reflect the committed changes. Closed by commit R31:f697b07340f3: align checkable widgets in menu items (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10480?vs=27344=27359 REVISION DETAIL

D10552: Keep item highlighted when context menu opens

2018-02-16 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4d229146fa4c: Keep item highlighted when context menu opens (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10552?vs=27283=27337

D10500: Make the review pop-up a bit more user-friendly

2018-02-16 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH review-popup-button-text REVISION DETAIL https://phabricator.kde.org/D10500 To: ngraham, #discover_software_store, apol, abetts Cc: anemeth, plasma-devel, ZrenBot,

T7071: Fragment shader in UserDelegate.qml is not GLSL/ES compatible, missing precision specifier

2018-02-16 Thread Jonathan Riddell
jriddell closed this task as "Resolved". TASK DETAIL https://phabricator.kde.org/T7071 To: plasma-devel, jriddell Cc: bruns, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10500: Make the review pop-up a bit more user-friendly

2018-02-16 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:d69abdbe4dce: Make the review pop-up a bit more user-friendly (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

2018-02-16 Thread Jonathan Riddell
jriddell created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jriddell requested review of this revision. TEST PLAN Start plasma as new user REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

2018-02-16 Thread Jonathan Riddell
jriddell retitled this revision from "Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash link https://phabricator.kde.org/T7948; to "Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash

KDE CI: Plasma breeze kf5-qt5 SUSEQt5.9 - Build # 88 - Still Failing!

2018-02-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20breeze%20kf5-qt5%20SUSEQt5.9/88/ Project: Plasma breeze kf5-qt5 SUSEQt5.9 Date of build: Fri, 16 Feb 2018 16:45:21 + Build duration: 9 min 45 sec and counting CONSOLE OUTPUT

D10170: Added optional transparency/blur to menu frames

2018-02-16 Thread Vlad Zagorodniy
zzag reopened this revision. This revision is now accepted and ready to land. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel,

D10579: Search runtime dependencies on QML modules

2018-02-16 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R878:cf64323795b9: Search runtime dependencies on QML modules (authored by heikobecker). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10579?vs=27351=27352

Re: Release calendar

2018-02-16 Thread Luigi Toscano
On Friday, 16 February 2018 16:27:10 CET Jonathan Riddell wrote: > I've added the release dates for Plasma 5.12, .13 and .14 as well as > Frameworks releases to the end of the year onto the calendar on Phab. > > https://phabricator.kde.org/calendar/ Thanks! > > Which makes more sense than

D10586: [Task Manager] Limit badge label to a sane size

2018-02-16 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When moving a horizontal panel around so it becomes

D10480: align checkable widgets in menu items

2018-02-16 Thread Hugo Pereira Da Costa
hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Ship it ! Thanks ! REPOSITORY R31 Breeze BRANCH center-checkbox REVISION DETAIL https://phabricator.kde.org/D10480 To: zzag, #breeze, #vdg, hpereiradacosta Cc:

KDE CI: Plasma breeze kf5-qt5 FreeBSDQt5.9 - Build # 24 - Failure!

2018-02-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20breeze%20kf5-qt5%20FreeBSDQt5.9/24/ Project: Plasma breeze kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 16 Feb 2018 16:28:56 + Build duration: 2 min 8 sec and counting CONSOLE OUTPUT

KDE CI: Plasma breeze kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Failing!

2018-02-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20breeze%20kf5-qt5%20FreeBSDQt5.9/25/ Project: Plasma breeze kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 16 Feb 2018 16:45:21 + Build duration: 2 min 15 sec and counting CONSOLE OUTPUT

D10170: Added optional transparency/blur to menu frames

2018-02-16 Thread Vlad Zagorodniy
zzag added a comment. This breaks build. Missed breezeblurhelper.cpp and breezeblurhelper.h? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag,

D10584: fix double spacing bug

2018-02-16 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. Thanks for the patch. I "think" one must also do a similar fix in "Style::menuItemSizeFromContents". It seems to me that there also the line 2728 leftColumnWidth += Metrics::MenuItem_ItemSpacing; should also be conditionned with "if iconWidth > 0"

KDE CI: Plasma breeze kf5-qt5 SUSEQt5.9 - Build # 87 - Failure!

2018-02-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20breeze%20kf5-qt5%20SUSEQt5.9/87/ Project: Plasma breeze kf5-qt5 SUSEQt5.9 Date of build: Fri, 16 Feb 2018 16:28:56 + Build duration: 1 min 30 sec and counting CONSOLE OUTPUT

D10505: [konsolesession runner] Rename to konsoleprofiles, no sessions here

2018-02-16 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R114:cd25c7078ab2: [konsolesession runner] Rename to konsoleprofiles, no sessions here (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

Re: Does Breeze provide QtQuick2 theming?

2018-02-16 Thread Ongun Kanat
Hi, thanks for the answer Application is a QtQuickControls 2 application (https://github.com/agateau/sfxr-qt/blob/master/ui/main.qml#L4). There's a pull request implements system palette so I think it will be solved (https://github.com/agateau/sfxr-qt/pull/5). Looking at theme definitions in

D10580: Add .arcconfig

2018-02-16 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https://phabricator.kde.org/D10580 To: heikobecker, mvourlakos, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10480: align checkable widgets in menu items

2018-02-16 Thread Vlad Zagorodniy
zzag updated this revision to Diff 27344. zzag added a comment. delete double space bug fix REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10480?vs=27116=27344 BRANCH center-checkbox REVISION DETAIL https://phabricator.kde.org/D10480 AFFECTED FILES

Release calendar

2018-02-16 Thread Jonathan Riddell
I've added the release dates for Plasma 5.12, .13 and .14 as well as Frameworks releases to the end of the year onto the calendar on Phab. https://phabricator.kde.org/calendar/ Which makes more sense than the Google calendar I had on my personal account. You should be able to export the .ics

Releases Status

2018-02-16 Thread Jonathan Riddell
As discussed at Kickoff meeting I've documented our ongoing releases and their dependencies and status. Please check for clarity and correctness. https://community.kde.org/Schedules/Plasma_5 5.8 LTS. Qt 5.6, KDE Frameworks 5.26. Releases made as required in cases of important bugfixes or

D10579: Search runtime dependencies on QML modules

2018-02-16 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https://phabricator.kde.org/D10579 To: heikobecker, mvourlakos, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10584: fix double spacing bug

2018-02-16 Thread Vlad Zagorodniy
zzag created this revision. zzag added reviewers: Breeze, VDG, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY When a menu doesn't have any icons, space between

D10579: Search runtime dependencies on QML modules

2018-02-16 Thread Michail Vourlakos
mvourlakos added a comment. Can you please update also the README file? REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https://phabricator.kde.org/D10579 To: heikobecker, mvourlakos, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10580: Add .arcconfig

2018-02-16 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: mvourlakos. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. heikobecker requested review of this revision. REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL

D10580: Add .arcconfig

2018-02-16 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R878:15dc67016117: Add .arcconfig (authored by heikobecker). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10580?vs=27339=27350 REVISION DETAIL

D10579: Search runtime dependencies on QML modules

2018-02-16 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: mvourlakos. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY Raises the required version of

D10584: fix double spacing bug

2018-02-16 Thread Vlad Zagorodniy
zzag edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10584 To: zzag, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10480: align checkable widgets in menu items

2018-02-16 Thread Vlad Zagorodniy
zzag edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10480 To: zzag, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10480: align checkable widgets in menu items

2018-02-16 Thread Vlad Zagorodniy
zzag edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10480 To: zzag, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10594: Disable window rule configuration for Wayland

2018-02-16 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D10593: Fix qmake warning for Kirigami

2018-02-16 Thread Ilya Bizyaev
IlyaBizyaev added a reviewer: mart. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10593 To: IlyaBizyaev, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D10593: Fix qmake warning for Kirigami

2018-02-16 Thread Ilya Bizyaev
IlyaBizyaev retitled this revision from "Fix qmake warning for " to "Fix qmake warning for Kirigami". IlyaBizyaev edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10593 To: IlyaBizyaev Cc: plasma-devel, apol, davidedmundson, mart,

D10593: Fix qmake warning for Kirigami

2018-02-16 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10593 To: IlyaBizyaev, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D10593: Fix qmake warning for

2018-02-16 Thread Ilya Bizyaev
IlyaBizyaev created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. IlyaBizyaev requested review of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10593 AFFECTED FILES

D10584: fix double spacing bug

2018-02-16 Thread Vlad Zagorodniy
zzag added a comment. @hpereiradacosta: yes, you're right REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10584 To: zzag, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10584: fix double spacing bug

2018-02-16 Thread Vlad Zagorodniy
zzag updated this revision to Diff 27367. zzag added a comment. add icon width to the contents size only if there is an icon REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10584?vs=27345=27367 BRANCH double-space-bug REVISION DETAIL

D10589: Make it possible to tweak the sorting of a resources list

2018-02-16 Thread Nathaniel Graham
ngraham added a comment. Huzzah! Users are going to be really happy about this. Sorting by name and size seem to work as expected. I found some issues, though: - We should use a dropdown menu control for this UI. Perhaps we should revive our Kirigami patch to keep the title visible when

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

2018-02-16 Thread David Edmundson
davidedmundson updated this revision to Diff 27364. davidedmundson added a comment. Track window changes REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10019?vs=25753=27364 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10019

D10588: Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948

2018-02-16 Thread Vlad Zagorodniy
zzag added a comment. Why? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10588 To: jriddell, #plasma Cc: zzag, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10589: Make it possible to tweak the sorting of a resources list

2018-02-16 Thread Nathaniel Graham
ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10589 To: apol, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10592: fix RTL appearance for ComboBox

2018-02-16 Thread Michail Vourlakos
mvourlakos created this revision. mvourlakos added reviewers: Plasma, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY - when the combobox isnt

D10589: Make it possible to tweak the sorting of a resources list

2018-02-16 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Now that we have context actions shown, we can consider doing it, will need work for the header.

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

2018-02-16 Thread Anthony Fieroni
anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. It looks good to me. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10019 To: davidedmundson, #plasma, anthonyfieroni Cc:

D10170: Added optional transparency/blur to menu frames

2018-02-16 Thread Vlad Zagorodniy
This revision was automatically updated to reflect the committed changes. Closed by commit R31:e5c0824adf8a: Added optional transparency/blur to menu frames (authored by anemeth, committed by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10170?vs=27358=27368#toc REPOSITORY R31

D10591: forcefully activate popup windows when they open

2018-02-16 Thread David Edmundson
davidedmundson added a comment. What would this code do if the device notifier is expanded but on the desktop? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10591 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, michaelh,

D10170: Added optional transparency/blur to menu frames

2018-02-16 Thread Vlad Zagorodniy
zzag added a comment. I've reverted that commit. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff,

KDE CI: Plasma breeze kf5-qt5 SUSEQt5.9 - Build # 89 - Fixed!

2018-02-16 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20breeze%20kf5-qt5%20SUSEQt5.9/89/ Project: Plasma breeze kf5-qt5 SUSEQt5.9 Date of build: Fri, 16 Feb 2018 17:14:46 + Build duration: 2 min 38 sec and counting JUnit Tests Name: (root)

KDE CI: Plasma breeze kf5-qt5 FreeBSDQt5.9 - Build # 26 - Fixed!

2018-02-16 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20breeze%20kf5-qt5%20FreeBSDQt5.9/26/ Project: Plasma breeze kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 16 Feb 2018 17:14:46 + Build duration: 3 min 35 sec and counting

D10591: forcefully activate popup windows when they open

2018-02-16 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY if an applet is requiresattention, always give the

D9275: fix RTL appearance for ComboBox

2018-02-16 Thread Michail Vourlakos
mvourlakos added a comment. @safaalfulaij I created the following for this: https://phabricator.kde.org/D10592 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart, plasma-devel, #frameworks,

D3588: Remove inexistent file references from kirigami.qrc

2018-02-16 Thread Ilya Bizyaev
IlyaBizyaev abandoned this revision. IlyaBizyaev added a comment. Outdated, was superceded by D3591 . REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D3588 To: IlyaBizyaev, #kirigami, mart Cc: bearsh, plasma-devel, apol,

D10593: Fix qmake warning for Kirigami

2018-02-16 Thread Ilya Bizyaev
IlyaBizyaev closed this revision. IlyaBizyaev added a comment. Merged by 389f4c29acc3 . REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10593 To: IlyaBizyaev, mart Cc: plasma-devel, apol,

D10592: fix RTL appearance for ComboBox

2018-02-16 Thread Safa Alfulaij
safaalfulaij added inline comments. INLINE COMMENTS > ComboBox.qml:113 > highlightMoveDuration: 0 > -LayoutMirroring.enabled: true > +// HACK: When the ComboBox is not inside the base Item, it does > not inherit > +// the LayoutMirroring options.

D10596: Remove uninstalled themerc files for no longer existing Qt themes

2018-02-16 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH deleteunusedthemercfiles REVISION DETAIL https://phabricator.kde.org/D10596 To: kossebau, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, lesliezhai,

D10596: Remove uninstalled themerc files for no longer existing Qt themes

2018-02-16 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH deleteunusedthemercfiles REVISION

D10592: fix RTL appearance for ComboBox

2018-02-16 Thread Michail Vourlakos
mvourlakos marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10592: fix RTL appearance for ComboBox

2018-02-16 Thread Michail Vourlakos
mvourlakos updated this revision to Diff 27382. mvourlakos added a comment. - improve semantics REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10592?vs=27373=27382 BRANCH rtl REVISION DETAIL https://phabricator.kde.org/D10592

D10596: Remove uninstalled themerc files for no longer existing Qt themes

2018-02-16 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R120:4149b474d301: Remove uninstalled themerc files for no longer existing Qt themes (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D10597: Fix media frame config layout

2018-02-16 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Removed pointless parent wrapper Added

D10482: Add an isNull() check before setting wheter QIcon is a mask

2018-02-16 Thread Igor Cota
icota closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10482 To: icota, #kirigami, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D10392: Don't trigger SwipeListItem's actions unless they are exposed

2018-02-16 Thread Igor Cota
icota closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10392 To: icota, #kirigami, mart Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein

D10481: Add FormLayout.qml to kirigami.qrc

2018-02-16 Thread Igor Cota
icota added a commit: R169:bed2722949b6: Add FormLayout.qml to kirigami.qrc. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10481 To: icota, #kirigami, mart Cc: plasma-devel, apol, davidedmundson, mart, hein