D10668: Fix PowerDevil shortcuts migration

davidedmundson added inline comments. INLINE COMMENTS > aacid wrote in powerdevilapp.cpp:177 > Won't this return QList() since you've set it on the line just > before? You'd think so, but no. setShortcut(QAction, sequence, KGlobalAccel::NoAutoloading) would do exactly that

D10337: First approach to a plasmoid that can display the state of caps lock

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:1ab3d012b2d5: First approach to a plasmoid that can display the state of caps lock (authored by apol). CHANGED PRIOR

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

https://bugs.kde.org/show_bug.cgi?id=369676 Michael D changed: What|Removed |Added CC||nortex...@gmail.com ---

D10668: Fix PowerDevil shortcuts migration

aacid added inline comments. INLINE COMMENTS > powerdevilapp.cpp:177 > +KGlobalAccel::self()->setShortcut(, > QList()); > +auto shortcuts = KGlobalAccel::self()->shortcut(); > +KGlobalAccel::self()->removeAllShortcuts(); Won't this return QList() since

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #10 from Rog131 --- (In reply to Michael D from comment #9) > Why not have configurable font color, or have the background detected and > automatically select text color based on that (which I imagine is way harder >

D10670: Reduce plasmashell frozen time

jtamate added a comment. In D10670#209823 , @mwolff wrote: > ok, looking at the reasoning in the other commit: > > - you need to extend the commit message here Will be done. > - you need to provide a comment in the code the

D10563: Place toolbox in the top right corner of the screen

rikmills added a comment. In D10563#209359 , @davidedmundson wrote: > > what "the toolbox' own xml file is ignored > > What xml file? If it's not used, delete it. containments/desktop/package/contents/config/main.xml It

D10642: [kcmkwin/rules] Disable detect button on Wayland

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH detect-button-disabled-5.12 REVISION DETAIL https://phabricator.kde.org/D10642 To: graesslin, #kwin,

D10563: Place toolbox in the top right corner of the screen

davidedmundson added a comment. > what "the toolbox' own xml file is ignored What xml file? If it's not used, delete it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10563 To: broulik, #plasma, #vdg, ngraham Cc: davidedmundson, cfeck, rikmills,

D10325: [KFileWidget] Hide places frame and header

broulik added a comment. If no Frameworks dev objects within next few days this will be pushed REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10325 To: broulik, #plasma, #vdg, #frameworks, ngraham, mart Cc: apol, markg, ngraham, plasma-devel, michaelh, ZrenBot,

D10629: Avoid a double emitResult()

broulik added a comment. dataengines/places/setupdevicejob.cpp dataengines/mpris2/playeractionjob.cpp dataengines/applicationjobs/jobaction.cpp REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10629 To: jtamate, #frameworks, #plasma, broulik Cc: broulik,

D10629: Avoid a double emitResult()

jtamate updated this revision to Diff 27523. jtamate added a comment. I haven't found more instances of setResult followed by emitResult. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10629?vs=27456=27523 REVISION DETAIL

D10620: Improve sidebar header visibility

mart added inline comments. INLINE COMMENTS > mart wrote in CategoriesPage.qml:134 > hoverEnabled: false should be enough (iirc there are also properties to make > it not do mousepressed effects) should be supportsMouseEvents: false REPOSITORY R124 System Settings REVISION DETAIL

D10627: Reduce plasmashell frozen time to almost nothing

davidedmundson added a comment. I'd do reviews on the other two, because there's a mistake in your commit message: > The other eventType are "windows_generic_MSG" and "mac_generic_NSEvent". QAbstractEventDispatcher::filterNativeEvent is public. Client code could be using that for

D10620: Improve sidebar header visibility

mart added a comment. I'm ok with making the text darker in the headers. I'm not exactly sure why as viewbackgroundcolor should be correct(tough deprecated), but in the breeze light screenshots the headers have a background slightly ligher than the other elements, which makes it look a bit

D10620: Improve sidebar header visibility

ngraham edited the test plan for this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart,

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

This revision was automatically updated to reflect the committed changes. Closed by commit R114:c8c734fabe47: Port minimize all applet from its own plugin to org.kde.TaskManager (authored by davidedmundson). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D10605: Fix location of Firefox dbCacheFile

mlaurent added a comment. Ok I will commit for you. Regards REPOSITORY R120 Plasma Workspace BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10652: [Run Command] Add history drop down button

ngraham added a comment. Indeed; I never discovered it! This is great. INLINE COMMENTS > RunCommand.qml:125 > +right: parent.right > +rightMargin: 6 // from PlasmaStyle TextFieldStyle > +verticalCenter: parent.verticalCenter Do we

D10613: Make it possible for actions to show submenus

mart added inline comments. INLINE COMMENTS > ActionsMenu.qml:35 > +text: model.text > +icon.name: model.iconName > +visible: model.visible does it work? icon.* in controls is supposed to work only in qt 5.10 (and qqc2 2.3) which we can't use in kirigami yet

D10659: [AppletConfiguration] Let applet override Return closing the dialog

broulik created this revision. broulik added reviewers: Plasma, kossebau. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In weather applet, pressing Return should invoke the

D10660: [Weather applet] Let Return invoke search

broulik edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10660 To: broulik, #plasma, kossebau Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10660: [Weather applet] Let Return invoke search

broulik edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10660 To: broulik, #plasma, kossebau Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10652: [Run Command] Add history drop down button

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:8227e4e2b7f0: [Run Command] Add history drop down button (authored by broulik). REPOSITORY R120 Plasma Workspace

D10591: forcefully activate popup windows when they open

mart added a comment. another way, may be adding a default kwin rule or script which lets every plasma window go trough REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10591 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks,

D10642: [kcmkwin/rules] Disable detect button on Wayland

mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. i also wonder if wouldn't be better to hide it as that button could never ever be enabled at all in wayland (at least.. i guess?) REPOSITORY R108 KWin BRANCH detect-button-disabled-5.12 REVISION

D10659: [AppletConfiguration] Let applet override Return closing the dialog

broulik added a dependent revision: D10660: [Weather applet] Let Return invoke search. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10659 To: broulik, #plasma, kossebau Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10660: [Weather applet] Let Return invoke search

broulik created this revision. broulik added reviewers: Plasma, kossebau. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Depends on D10659

D10620: Improve sidebar header visibility

ngraham closed this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D10652: [Run Command] Add history drop down button

broulik added a comment. Those magic values are copied straight from Plasma `TextFieldStyle` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10652 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10652: [Run Command] Add history drop down button

ngraham accepted this revision as: VDG. ngraham added a comment. VDG-wise, big thumbs up. This is a clear usability improvement. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10652 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, ZrenBot, lesliezhai,

D10652: [Run Command] Add history drop down button

ngraham added a comment. I imagine refactoring that not to use magic numbers is a bigger effort. Still, we should keep that in mind, I think. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10652 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel,

D10653: Set IconItem default to smooth=true

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D10653 To: davidedmundson, #plasma, apol Cc: plasma-devel, #frameworks,

D10620: Improve sidebar header visibility

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R124 System Settings BRANCH more-visible-headers (branched from master) REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot,

D10613: Make it possible for actions to show submenus

apol updated this revision to Diff 27547. apol added a comment. Drop Qt 5.10 dependency REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10613?vs=27454=27547 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10613 AFFECTED FILES

D10620: Improve sidebar header visibility

ngraham updated this revision to Diff 27550. ngraham added a comment. re-base on Plasma 5.12 branch REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10620?vs=27540=27550 BRANCH more-visible-headers (branched from Plasma/5.12) REVISION DETAIL

D10563: Place toolbox in the top right corner of the screen

broulik added a comment. In D10563#209361 , @rikmills wrote: > In D10563#209359 , @davidedmundson wrote: > > > What xml file? If it's not used, delete it. > > >

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Do you have commit access? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10434 To: piotrkakol, davidedmundson Cc: davidedmundson,

D10653: Set IconItem default to smooth=true

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This changes between

Minutes Monday Plasma Hangout

Plasma Team meeting, 2018-02-19 Present: kbroulik, romangg, d_ed, bshah, notmart, Riddell, Sho_ kbroulik: * Did some cleanup and performance fixes to Klipper plasmoid: ** Opens almost instant on first startup now, used to cause quite a hickup ** Added support for "Aztec" barcodes (credit goes to

D10605: Fix location of Firefox dbCacheFile

z3ntu added a comment. No (this is one of my first patches ) REPOSITORY R120 Plasma Workspace BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10620: Improve sidebar header visibility

ngraham updated this revision to Diff 27540. ngraham marked 2 inline comments as done. ngraham added a comment. Also improve subcategory headers REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10620?vs=27539=27540 BRANCH more-visible-headers

D10591: forcefully activate popup windows when they open

mart added a comment. In D10591#207905 , @davidedmundson wrote: > What would this code do if the device notifier is expanded but on the desktop? giving desktop window focus, which means we should also either check window flags or the

D10597: Fix media frame config layout

davidedmundson abandoned this revision. davidedmundson added a comment. someone else made some mods. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10597 To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10618: Fix ComboBox & mode description for image fill mode

This revision was automatically updated to reflect the committed changes. Closed by commit R114:5bf2d077895b: Fix ComboBox mode description for image fill mode (authored by sharvey, committed by davidedmundson). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D10605: Fix location of Firefox dbCacheFile

This revision was automatically updated to reflect the committed changes. Closed by commit R120:745cffc9ffd3: Fix location of Firefox dbCacheFile (authored by z3ntu, committed by mlaurent). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D10620: Improve sidebar header visibility

ngraham updated this revision to Diff 27539. ngraham added a comment. Use supportsMouseEvents: false instead REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10620?vs=27438=27539 BRANCH more-visible-headers (branched from master) REVISION DETAIL

D10620: Improve sidebar header visibility

ngraham edited the test plan for this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart,

D10629: Avoid a double emitResult()

jtamate added a comment. In D10629#209358 , @broulik wrote: > I did a objdump -d to be sure: > dataengines/places/setupdevicejob.cpp setError is from KJob and it only sets a member value (d->error = errorCode;) >

D9227: [Breeze widget style] Override QLineEditIconButton paint event to force Active icon on press

broulik abandoned this revision. broulik added a comment. I just received a +2 for my Qt patch and will merge it. This is obsolete then. Thanks, Hugo! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9227 To: broulik, #plasma, #vdg, hpereiradacosta Cc: ngraham,

D10629: Avoid a double emitResult()

broulik added a comment. Okay, nevermind. Go for it then! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10629 To: jtamate, #frameworks, #plasma, broulik Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10652: [Run Command] Add history drop down button

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Indicates that there's a "drop down" history similar to a

Plasma 5.13 dependencies

Plasma 5.13, due out in June, will depend on Qt 5.10, KDE Frameworks 5.46. The newer Qt will help us port KControl modules to QtQuick Controls 2 a target of this release. https://phabricator.kde.org/project/view/254/ Jonathan

D10605: Fix location of Firefox dbCacheFile

mlaurent added a comment. Do you have commit access ? REPOSITORY R120 Plasma Workspace BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: QtWayland decoration improvement

Am 2018-02-19 16:37, schrieb Martin Bříza: Hello everyone, I thought this would be a good place to discuss this small problem: I'm trying to make Qt work better under Wayland and especially in GNOME. The current infrastructure in QtWayland doesn't allow for very complicated window

D10512: try to preload certain applets in a smart way

broulik added inline comments. INLINE COMMENTS > appletquickitem.cpp:55 > { > +if (qEnvironmentVariableIsSet("KDE_PLASMA_PRELOAD_POLICY")) { > +const QByteArray policy = qgetenv("KDE_PLASMA_PRELOAD_POLICY"); Cache the result in a static to read it only once? >

D10407: Disable positioning in popup folderviews

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10407 To: amantia, hein Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

piotrkakol added a comment. Thank you for reviewing. No, I don't have commit access. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10434 To: piotrkakol, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10512: try to preload certain applets in a smart way

ngraham added a comment. If by default this slows down plasmashell's loading in favor of making widgets load faster, I'm against it. People will notice the drawbacks of the former more than the benefits of the latter. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D10592: fix RTL appearance for ComboBox

mvourlakos added a comment. @safaalfulaij is there a green light for this? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai,

D10512: try to preload certain applets in a smart way

mart updated this revision to Diff 27557. mart added a comment. - cache env var reading REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27554=27557 BRANCH arcpatch-D10512 REVISION DETAIL https://phabricator.kde.org/D10512

D10512: try to preload certain applets in a smart way

broulik added a comment. lgtm REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10512 To: mart, #plasma Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10408: Add option to enable shared folderview content per desktop

amantia closed this revision. REVISION DETAIL https://phabricator.kde.org/D10408 To: amantia, #plasma, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10512: try to preload certain applets in a smart way

davidedmundson added inline comments. INLINE COMMENTS > appletquickitem.cpp:51 > +DefaultLauncherPreloadWeight = 100, > +DelayedPreloadWeight = 25, > +PreloadWeightIncrement = 5, So by default we preload /everything/ then over time your session gets faster as you don't use stuff?

D10512: try to preload certain applets in a smart way

mart updated this revision to Diff 27559. mart added a comment. - just PLASMA_PRELOAD_POLICY REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27558=27559 BRANCH arcpatch-D10512 REVISION DETAIL

D10592: fix RTL appearance for ComboBox

mvourlakos added a reviewer: safaalfulaij. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart, safaalfulaij Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10592: fix RTL appearance for ComboBox

mvourlakos added a comment. > Sure. Go ahead and commit. is it possible to give first the green light by accepting the review? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart, safaalfulaij Cc: safaalfulaij,

D10512: try to preload certain applets in a smart way

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:6cbea20bf9f7: try to preload certain applets in a smart way (authored by mart). REPOSITORY R242 Plasma Framework

D10592: fix RTL appearance for ComboBox

safaalfulaij added a comment. In D10592#209670 , @mvourlakos wrote: > @safaalfulaij is there a green light for this? Sure. Go ahead and commit. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D10512: try to preload certain applets in a smart way

anthonyfieroni added inline comments. INLINE COMMENTS > appletquickitem.cpp:57-68 > +if (s_preloadPolicy == Uninitialized) { > +if (qEnvironmentVariableIsSet("PLASMA_PRELOAD_POLICY")) { > +const QString policy = >

D10592: fix RTL appearance for ComboBox

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1ff405cca5b3: fix RTL appearance for ComboBox (authored by mvourlakos). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10592?vs=27382=27568

D10512: try to preload certain applets in a smart way

mart added a comment. In D10512#209679 , @ngraham wrote: > If by default this slows down plasmashell's loading in favor of making widgets load faster, I'm against it. People will notice the drawbacks of the former more than the benefits of the

D10512: try to preload certain applets in a smart way

mart updated this revision to Diff 27558. mart added a comment. - always delay preloading REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27557=27558 BRANCH arcpatch-D10512 REVISION DETAIL https://phabricator.kde.org/D10512

D10592: fix RTL appearance for ComboBox

safaalfulaij accepted this revision. safaalfulaij added a comment. This revision is now accepted and ready to land. Now since I'm a reviewer, sure :) REPOSITORY R242 Plasma Framework (Library) BRANCH rtl REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma,

D10670: Reduce plasmashell frozen time

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. what? this is totally unsafe - the reinterpret_cast below shouldn't be done on anything that has event names other than the previously used one... REPOSITORY R242 Plasma

D10670: Reduce plasmashell frozen time

mwolff added a comment. ok, looking at the reasoning in the other commit: - you need to extend the commit message here - you need to provide a comment in the code the clarifies what's going on here in general, I don't see how such a comparison can be so costly - the real problem

D10668: Fix PowerDevil shortcuts migration

cfeck added a comment. Regarding the comments, I prefer a space after '//' for better readability. INLINE COMMENTS > powerdevilapp.cpp:169 > +}); > +for(const QString : actionIds) > +{ Missing space after 'for'. > powerdevilapp.cpp:170 > +for(const QString :

QtWayland decoration improvement

Hello everyone, I thought this would be a good place to discuss this small problem: I'm trying to make Qt work better under Wayland and especially in GNOME. The current infrastructure in QtWayland doesn't allow for very complicated window decorations. First, QWaylandAbstractDecoration is a

D10512: try to preload certain applets in a smart way

mart updated this revision to Diff 27554. mart added a comment. control with an env variable can be either always off, always on or adaptive REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27263=27554 BRANCH

D10642: [kcmkwin/rules] Disable detect button on Wayland

graesslin updated this revision to Diff 27555. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Hide buttons intead of disabling them REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10642?vs=27484=27555 BRANCH

D10668: Fix PowerDevil shortcuts migration

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY 5.11 -> 5.12 migrated shortcuts from kded5

D10669: Reduce plasmashell frozen time

jtamate created this revision. jtamate added reviewers: Plasma, Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY Second part of

D10670: Reduce plasmashell frozen time

jtamate created this revision. jtamate added reviewers: Frameworks, Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY Third part of

D10627: Reduce plasmashell frozen time to almost nothing

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e1fe26f1fc78: Reduce plasmashell frozen time to almost nothing (authored by jtamate). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10627?vs=27453=27577

D10659: [AppletConfiguration] Let applet override Return closing the dialog

kossebau added a comment. Eek. Undocumented secret properties make my toe nails roll up. Can this property become something more official, with real documentation (and test case), so that other applet config pages can make use of it as well? No real insight into design of applet

Re: Plasma 5.13 dependencies

On 20/02/2018 12:23 AM, "Jonathan Riddell" wrote: Hi Jonathan, Plasma 5.13, due out in June, will depend on Qt 5.10, KDE Frameworks 5.46. The newer Qt will help us port KControl modules to QtQuick Controls 2 a target of this release.

D10629: Avoid a double emitResult()

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4b68374192ac: Avoid a double emitResult() (authored by jtamate). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10629?vs=27523=27571 REVISION DETAIL

D10660: [Weather applet] Let Return invoke search

kossebau added a comment. Not tested, but seems good to me by pure reading. INLINE COMMENTS > ConfigWeatherStation.qml:33 > + > +property bool acceptOnReturnPressed: !searchStringEdit.activeFocus || > searchStringEdit.length === 0 > Slightly undecided: given above we use the `length`