D11308: Use the default Plasma wallpaper on the lock screen

[Martin Flöser]

graesslin added a comment.


  In D11308#226836 , @ngraham wrote:
  
  > @graesslin, those are good comments for @mart's ideas for the other 
approach. Do you have any remaining concerns with this one that I can work on?
  
  
  As long as the lnf theme is not changed to provide sensible background 
contrast I'm against this change. We don't have control over the default 
background, this is done by distros. We cannot change in ways that it would 
break for them.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin, abetts
Cc: davidedmundson, zzag, Pitel, progwolff, abetts, hein, mart, graesslin, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11197: Allow OverlaySheet clients to omit the built-in close button

[Nathaniel Graham]

ngraham added a comment.


  Ping

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11197

To: ngraham, mart, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

Re: no OSK in Plasma Mobile

[Bhushan Shah]

Hello Heather,

On Thu, Mar 15, 2018 at 06:57:27PM -0600, Heather Ellsworth wrote:
> I've been running Plasma Mobile on my iMX6 dev board (precursor to the
> dev kit for the Librem 5) and I've notices there's no onscreen keyboard.
> Is it there and I'm just not initializing it? Or what is the story with
> the OSK in Plasma Mobile?

For OSK, you just need to install qtvirtualkeyboard-plugin package, it
should give you working on-screen-keyboard for the Qt applications. It
is however possible that QtVirtualKeyboard is disabled by default if you
have keyboard attached. In that case you can enable it by clicking on
virtualkeyboard icon in top drawer.

You can also "export QT_VIRTUALKEYBOARD_STYLE=Plasma" for better theming
integration with Plasma Mobile.

Thanks

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

D11375: Don't block evaluating DBus scripts if widgets are locked.

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Original decision didn't really have a rationale:
  https://git.reviewboard.kde.org/r/125648/
  
  It's causing bugs in people doing somewhat sensible things.
  BUG: 380347
  
  If widgets are locked, the script will still fail when it tries to do
  something it can't.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11375

AFFECTED FILES
  shell/shellcorona.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: no OSK in Plasma Mobile

[Ongun Kanat]

Hi,

I'm not the maintainer or even an accountable person but these may help:

Blog about: 
https://blog.martin-graesslin.com/blog/2016/05/virtual-keyboard-support-in-kwinwayland-5-7/
> As you can see in the video the virtual keyboard is only enabled by default 
> if no hardware keyboard is available.

Setting environment variable QT_IM_MODULE=qtvirtualkeyboard should
also launch Qt's virtual keyboard.

Best
-Ongun

On 16 March 2018 at 03:57, Heather Ellsworth  wrote:
> Hi Guys,
>
> I've been running Plasma Mobile on my iMX6 dev board (precursor to the
> dev kit for the Librem 5) and I've notices there's no onscreen keyboard.
> Is it there and I'm just not initializing it? Or what is the story with
> the OSK in Plasma Mobile?
>
> Thanks,
> Heather
>

D11372: Put the refresh action on the left

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah, just what the doctor ordered! A much cleaner approach than making one 
contextual and the other one main. Works great.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11372

To: apol, ngraham
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11372: Put the refresh action on the left

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Rather than on the contextual actions that incidentally go on the right of the
  main action.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11372

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: apol, ngraham
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

no OSK in Plasma Mobile

[Heather Ellsworth]

Hi Guys,

I've been running Plasma Mobile on my iMX6 dev board (precursor to the
dev kit for the Librem 5) and I've notices there's no onscreen keyboard.
Is it there and I'm just not initializing it? Or what is the story with
the OSK in Plasma Mobile?

Thanks,
Heather



signature.asc
Description: OpenPGP digital signature

D11308: Use the default Plasma wallpaper on the lock screen

[Nathaniel Graham]

ngraham added a comment.


  @graesslin, those are good comments for @mart's ideas for the other approach. 
Do you have any remaining concerns with this one that I can work on?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin, abetts
Cc: davidedmundson, zzag, Pitel, progwolff, abetts, hein, mart, graesslin, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Martin Flöser]

graesslin added a comment.


  In D11308#226803 , @ngraham wrote:
  
  > Thanks @mart. I think using an animated slideshow by default will be really 
popular, especially if we do some work to add more nice images by default and 
polish up the slideshow plugin's UI a bit. I'm glad to hear that the memory 
issue is or should be resolved soon.
  >
  > @graesslin, have we satisfactorily resolved your objections yet? It not, 
what more needs to be done here?
  
  
  Please be aware of two things:
  
  - Most distros only install one wallpaper by default. If we go this route we 
must reach out to distros before and check whether they are able to install 
more default wallpapers
  - If you talk about this please never, never,ever call it a screen saver. We 
don't have to save screens, we don't have crts anymore. We removed the screen 
saver support because of that and because of the energy saving. Call it 
animations or transitions, but not screen saver.
  
  Personally I dislike animations on the lock screen by default due to the 
environment impact. We burn CPU and GPU cycles to show animations nobody will 
see (if the screen is locked the reason is mostly that the user went away). In 
times of global warming we should consider the impact of enabling animations 
for maybe millions of systems.
  
  My suggestion is to:
  
  - Decrease the default power saving time
  - Ensure those animations stop when screen is power saved
  - Increase the time between wallpaper transitions in e.g. Fibonacci time.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin, abetts
Cc: davidedmundson, zzag, Pitel, progwolff, abetts, hein, mart, graesslin, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Nathaniel Graham]

ngraham added a comment.


  Thanks @mart. I think using an animated slideshow by default will be really 
popular, especially if we do some work to add more nice images by default and 
polish up the slideshow plugin's UI a bit. I'm glad to hear that the memory 
issue is or should be resolved soon.
  
  @graesslin, have we satisfactorily resolved your objections yet? It not, what 
more needs to be done here?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin, abetts
Cc: davidedmundson, zzag, Pitel, progwolff, abetts, hein, mart, graesslin, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11352: [RFC] Auto ordered systray

[Marco Martin]

mart added a comment.


  I like where this is going! (will still have to test it running tough)
  
  one general thing i wonder, is if would be better to implementthe whole 
reorderItem() logic on the c++ side as is potentially heavy and complicated.. 
(and the actual reordering needs to be done in c++ already anyways)

INLINE COMMENTS

> AbstractItem.qml:81
> +function updateVisibility() {
> +Qt.callLater(updateItemVisibility, abstractItem)
> +}

what's the reson for using callLater?

> main.qml:65
> +]
> +function getCategoryOrder(item) {
> +if (item.itemId == "org.kde.plasma.notifications") {

as convention we usually don't have getFoo as names (and this is not getting a 
property anyways)
i would like a more descriptive name like indexForCategory and have the 
category as parameter instead of the item

> main.qml:79
> +function reorderItem(item, container) {
> +if (container.children.length == 0) {
> +item.parent = container

i like the logic, but add some comments on what is doing

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11352

To: Pitel
Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Marco Martin]

mart added a subscriber: davidedmundson.
mart added a comment.


  In D11308#226767 , @ngraham wrote:
  
  > @mart  You're essentially describing transforming the lock screen into a 
screensaver, with the default effect being an animated slideshow. I would favor 
this. Users like screensavers simply for the visual flair, and I've heard a lot 
of user feedback that they'd like something approximating a screensaver. 
However, that's a substantially different patch from this one, and we might run 
into memory pressure issues if we're not able to resolve 
https://bugs.kde.org/show_bug.cgi?id=368838 beforehand.
  
  
  ok for pushing this, but with the idea to change to a slideshow in the future 
(to me with the default wallpaper looks less quality refined than now, but is 
just a personal opinion)
  
  (btw that leak i think should be solved, @davidedmundson also has a rewrite 
of the wallpaper code which should make it take less memory, as right now the 
first few times it changes memory gooes up not for an actual leak but more for 
the management not being correct)

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin, abetts
Cc: davidedmundson, zzag, Pitel, progwolff, abetts, hein, mart, graesslin, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11358: Give file and folder names a bit more room in Folder View

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8208d9b3b3b9: Give file and folder names a bit more room 
in Folder View (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11358?vs=29614=29629

REVISION DETAIL
  https://phabricator.kde.org/D11358

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: ngraham, hein, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 366 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/366/
 Project:
Plasma discover kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 15 Mar 2018 19:40:35 +
 Build duration:
3 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.appargFailed: TestSuite.appstreamUrlFailed: TestSuite.categoryargFailed: TestSuite.installFailed: TestSuite.packageArgumentFailed: TestSuite.toplevelsFailed: TestSuite.updateandinstall
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report76%
(13/17)80%
(86/108)80%
(86/108)65%
(3042/4670)49%
(1678/3435)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdiscover100%
(10/10)100%
(10/10)67%
(417/621)47%
(180/386)discover.autotests100%
(1/1)100%
(1/1)100%
(93/93)53%
(48/90)exporter0%
(0/3)0%
(0/3)0%
(0/67)0%
(0/50)libdiscover70%
(7/10)70%
(7/10)65%
(159/245)63%
(121/192)libdiscover.Category100%
(5/5)100%
(5/5)70%
(156/223)53%
(120/226)libdiscover.ReviewsBackend100%
(8/8)100%
(8/8)65%
(145/223)67%
(48/72)libdiscover.Transaction63%
(5/8)63%
(5/8)44%
(127/286)36%
(50/139)libdiscover.UpdateModel100%
(4/4)100%
(4/4)96%
(174/182)81%
(73/90)libdiscover.appstream0%
(0/4)0%
(0/4)0%
(0/214)0%
(0/134)libdiscover.backends.DummyBackend91%
(10/11)91%
(10/11)76%
(217/286)76%
(107/141)libdiscover.backends.DummyBackend.tests100%
(3/3)100%
(3/3)96%
(246/255)52%
(205/396)libdiscover.backends.KNSBackend100%
(6/6)100%
(6/6)66%
(286/435)54%
(139/256)libdiscover.backends.KNSBackend.tests100%
(2/2)100%
(2/2)98%
(91/93)54%
(88/164)libdiscover.notifiers0%
(0/2)0%
(0/2)0%
(0/4)0%
(0/2)libdiscover.resources100%
(22/22)100%
(22/22)66%
(701/1066)49%
(374/769)libdiscover.tests100%
(3/3)100%
(3/3)85%
(230/272)51%
(125/244)notifier0%
(0/6)0%

D11358: Give file and folder names a bit more room in Folder View

[Nathaniel Graham]

ngraham added a comment.


  Well, either way, we can continue the discussion elsewhere, and I'll land 
this minimal patch. Thanks, Eike.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  more-generous-folder-view-title-display (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11358

To: ngraham, hein, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 365 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/365/
 Project:
Plasma discover kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 15 Mar 2018 19:04:18 +
 Build duration:
36 min and counting
   CONSOLE OUTPUT
  [...truncated 180.31 KB...][ 34%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractBackendUpdater.cpp.o[ 35%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractSourcesBackend.cpp.o[ 36%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/StoredResultsStream.cpp.o[ 37%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/CachedNetworkAccessManager.cpp.o[ 38%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ActionsModel.cpp.o[ 38%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverBackendsFactory.cpp.o[ 39%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ScreenshotsModel.cpp.o[ 40%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ApplicationAddonsModel.cpp.o[ 41%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/appstream/OdrsReviewsBackend.cpp.o[ 42%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/appstream/AppStreamIntegration.cpp.o[ 43%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverCommon_autogen/mocs_compilation.cpp.oScanning dependencies of target DummyNotifier[ 44%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.o[ 45%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[ 46%] Linking CXX shared module DummyNotifier.so[ 46%] Built target DummyNotifierScanning dependencies of target DiscoverNotifierDeclarativePlugin[ 47%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/BackendNotifierFactory.cpp.o[ 48%] Linking CXX shared library libDiscoverCommon.so[ 48%] Built target DiscoverCommonScanning dependencies of target kns-backend_autogen[ 50%] Automatic MOC for target kns-backend[ 51%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifier.cpp.o[ 51%] Built target kns-backend_autogenScanning dependencies of target knsbackendtest_autogen[ 52%] Automatic MOC for target knsbackendtest[ 52%] Built target knsbackendtest_autogenScanning dependencies of target dummy-backend_autogen[ 53%] Automatic MOC for target dummy-backend[ 53%] Built target dummy-backend_autogenScanning dependencies of target updatedummytest_autogen[ 54%] Automatic MOC for target updatedummytest[ 54%] Built target updatedummytest_autogenScanning dependencies of target dummytest_autogen[ 55%] Automatic MOC for target dummytest[ 55%] Built target dummytest_autogenScanning dependencies of target CategoriesTest_autogen[ 56%] Automatic MOC for target CategoriesTest[ 56%] Built target CategoriesTest_autogenScanning dependencies of target plasma-discover_autogen[ 57%] Automatic MOC for target plasma-discover[ 58%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[ 58%] Built target plasma-discover_autogenScanning dependencies of target plasma-discover-exporter_autogen[ 59%] Automatic MOC for target plasma-discover-exporter[ 59%] Built target plasma-discover-exporter_autogenScanning dependencies of target kns-backend[ 60%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.o[ 61%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[ 62%] Linking CXX shared library libDiscoverNotifierDeclarativePlugin.so[ 62%] Built target DiscoverNotifierDeclarativePluginScanning dependencies of target knsbackendtest[ 63%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o[ 64%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/knsbackendtest_autogen/mocs_compilation.cpp.o[ 65%] Linking CXX executable knsbackendtest[ 65%] Built target knsbackendtestScanning dependencies of target dummy-backend[ 66%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.o[ 67%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.o/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp: In member function ‘void DummyBackend::populate(const QString&)’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:65:65: error: invalid new-_expression_ of abstract class type ‘DummyResource’ DummyResource* res = new DummyResource(name, false, this); ^In 

D11308: Use the default Plasma wallpaper on the lock screen

[Nathaniel Graham]

ngraham added a comment.


  @mart  You're essentially describing transforming the lock screen into a 
screensaver, with the default effect being an animated slideshow. I would favor 
this. Users like screensavers simply for the visual flair, and I've heard a lot 
of user feedback that they'd like something approximating a screensaver. 
However, that's a substantially different patch from this one, and we might run 
into memory pressure issues if we're not able to resolve 
https://bugs.kde.org/show_bug.cgi?id=368838 beforehand.
  
  My worry is that we let the perfect be the enemy of the good and don't get 
something in time for 5.13, and ship yet another Plasma version with the 
eyeball-searing blue background. I support your initiative, but could we land 
this or a tweaked variant before then, so at we at least have a better fallback 
in case we aren't able to ship your idea in time?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin, abetts
Cc: zzag, Pitel, progwolff, abetts, hein, mart, graesslin, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

[Marco Martin]

mart added a comment.


  That's a way i would like it:
  https://www.youtube.com/watch?v=BOsclMNpK3M
  (quick and dirty so the interaction and effects are very buggy)
  have the lockscreen by default to be a slideshow of the default installed 
wallpapers and show only the clock (in this mode the text has a shadow as it 
might be invisible)
  then at the minimum interaction (mouse, keyboard, anything) the rest of the 
ui appears and it becomes functional (after a timeout would go back to 
slideshow mode)
  when in ui mode, either fades to a plain color (to look like the current blue 
default which i like a lot) or some effect like heavy blur (but still with 
coloring, again for readability reasons)

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D11308

To: ngraham, #plasma, #vdg, graesslin, abetts
Cc: zzag, Pitel, progwolff, abetts, hein, mart, graesslin, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 195 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/195/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 15 Mar 2018 19:19:53 +
 Build duration:
4 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.appargFailed: TestSuite.appstreamUrlFailed: TestSuite.categoryargFailed: TestSuite.installFailed: TestSuite.packageArgumentFailed: TestSuite.toplevelsFailed: TestSuite.updateandinstall

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 194 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/194/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 15 Mar 2018 19:13:28 +
 Build duration:
1 min 56 sec and counting
   CONSOLE OUTPUT
  [...truncated 155.92 KB...][ 43%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractSourcesBackend.cpp.o[ 44%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/StoredResultsStream.cpp.o[ 45%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/CachedNetworkAccessManager.cpp.o[ 46%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ActionsModel.cpp.o[ 47%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverBackendsFactory.cpp.o[ 48%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ScreenshotsModel.cpp.o[ 50%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ApplicationAddonsModel.cpp.o[ 51%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverCommon_autogen/mocs_compilation.cpp.o[ 52%] Linking CXX shared library libDiscoverCommon.so[ 52%] Built target DiscoverCommonScanning dependencies of target kns-backend_autogenScanning dependencies of target knsbackendtest_autogenScanning dependencies of target dummy-backend_autogenScanning dependencies of target updatedummytest_autogen[ 53%] Automatic MOC for target kns-backendScanning dependencies of target dummytest_autogenScanning dependencies of target CategoriesTest_autogen[ 53%] Automatic MOC for target dummy-backend[ 54%] Automatic MOC for target knsbackendtest[ 55%] Automatic MOC for target CategoriesTest[ 56%] Automatic MOC for target updatedummytest[ 57%] Automatic MOC for target dummytest[ 57%] Built target knsbackendtest_autogenScanning dependencies of target plasma-discover_autogen[ 58%] Automatic MOC for target plasma-discover[ 58%] Built target dummytest_autogen[ 58%] Built target CategoriesTest_autogenScanning dependencies of target plasma-discover-exporter_autogen[ 59%] Automatic MOC for target plasma-discover-exporterScanning dependencies of target knsbackendtest[ 60%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o[ 60%] Built target plasma-discover-exporter_autogen[ 60%] Built target updatedummytest_autogenScanning dependencies of target CategoriesTest[ 60%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest.cpp.oScanning dependencies of target dummytest[ 61%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/__/__/__/tests/modeltest.cpp.o[ 61%] Built target dummy-backend_autogen[ 62%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/knsbackendtest_autogen/mocs_compilation.cpp.o[ 62%] Built target kns-backend_autogen[ 63%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest_autogen/mocs_compilation.cpp.oScanning dependencies of target plasma-discover-exporter[ 64%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/main.cpp.o[ 65%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/MuonExporter.cpp.o[ 65%] Built target plasma-discover_autogen[ 66%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/plasma-discover-exporter_autogen/mocs_compilation.cpp.o[ 67%] Linking CXX executable CategoriesTest[ 68%] Linking CXX executable knsbackendtestScanning dependencies of target kns-backend[ 69%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.o[ 70%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSResource.cpp.o[ 70%] Built target CategoriesTest[ 71%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/DummyTest.cpp.o[ 71%] Built target knsbackendtestScanning dependencies of target dummy-backend[ 72%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.o[ 73%] Linking CXX executable plasma-discover-exporter[ 73%] Built target plasma-discover-exporter[ 74%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/dummytest_autogen/mocs_compilation.cpp.oScanning dependencies of target updatedummytest[ 75%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/__/__/__/tests/modeltest.cpp.o[ 76%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/UpdateDummyTest.cpp.o[ 77%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.o[ 78%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/updatedummytest_autogen/mocs_compilation.cpp.o[ 79%] Building CXX object 

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 193 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/193/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 15 Mar 2018 19:04:18 +
 Build duration:
3 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 130.37 KB...]Found property definition "X-Plasma-StandAloneApp" with type "bool"Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"Found property definition "NoDisplay" with type "bool"Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to stringUnknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-json[  4%] Built target DiscoverNotifiers_autogenScanning dependencies of target DiscoverNotifiers[  4%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[  5%] Built target PaginateModelTest_autogen[  6%] Linking CXX shared library libDiscoverNotifiers.so[  6%] Built target DiscoverNotifiersScanning dependencies of target DummyNotifier_autogenScanning dependencies of target DiscoverNotifierDeclarativePlugin_autogen[  7%] Automatic MOC for target DummyNotifier[  8%] Automatic MOC for target DiscoverNotifierDeclarativePlugin[  8%] Built target DummyNotifier_autogenScanning dependencies of target DummyNotifier[ 10%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.o[ 10%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[ 10%] Built target DiscoverNotifierDeclarativePlugin_autogenScanning dependencies of target PaginateModelTest[ 11%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[ 12%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[ 13%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.o[ 14%] Linking CXX shared module DummyNotifier.so[ 14%] Built target DummyNotifier[ 15%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[ 15%] Built target DiscoverCommon_autogenScanning dependencies of target DiscoverNotifierDeclarativePlugin[ 16%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/BackendNotifierFactory.cpp.oScanning dependencies of target DiscoverCommon[ 17%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[ 18%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[ 19%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifier.cpp.o[ 20%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[ 21%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[ 22%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[ 23%] Linking CXX executable PaginateModelTest[ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[ 25%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.o[ 26%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[ 28%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[ 29%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/Transaction.cpp.o[ 30%] Linking CXX shared library libDiscoverNotifierDeclarativePlugin.so[ 31%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionListener.cpp.o[ 32%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionModel.cpp.o[ 32%] Built target PaginateModelTest[ 33%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateItem.cpp.o[ 34%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateModel.cpp.o[ 34%] Built target DiscoverNotifierDeclarativePlugin[ 35%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesModel.cpp.o[ 36%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesProxyModel.cpp.o[ 37%] Building CXX object 

D11364: Remove redundant app name from header

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11364

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11358: Give file and folder names a bit more room in Folder View

[Nathaniel Graham]

ngraham added a comment.


  In D11358#226649 , @hein wrote:
  
  > Folder View always reserves enough vertical space to fit the configured 
number of lines to keep an evenly-spaced grid. The default number of lines 
should therefore strike a happy medium between conserving vertical space to fit 
more rows and catering to the odd longer file name. 3 would optimize for most 
file names being so long that even with ellision they're not readable at two 
lines, which I don't feel is warranted.
  
  
  I don't feel like 3 lines is excessively long or uncommon. Here's a 
screenshot of a random folder viewed in Dolphin on my personal machine, for 
example:
  F5755148: Common file names.png 
  
  Many of the files have names that seem perfectly normal and reasonable to me 
in terms of length, yet require 3 or even 4 lines. In Dolphin, this is fine, 
there's no problem. If I put them on the desktop, they become borderline 
unreadable until I increase the number of lines. This isn't a problem for you 
and me; we're expert users who find and tweak settings. But most normal users 
won't, and will assume that their Desktop is just broken.
  
  As is, we need to balance against two use cases:
  
  - People with an enormous amount of desktop icons (for whom it is more 
important to have a tight grid and show more icons)
  - People with desktop icons that have long-ish titles (for whom it is more 
important to show their icons' titles
  
  Since these people's needs are mutually exclusive, we'll always upset one 
group unless we let them self-serve with a config option, or somehow cleverly 
improve the UI to obviate the problem. The latter case would seem ideal, but 
I'm drawing a blank right now.
  
  > As for making it configurable - maybe. Not sure. I'm not there yet, because 
on my end, the user complaints have stopped
  
  FWIW we have at least three bug reports complaining that titles don't get 
enough room:
  
  - https://bugs.kde.org/show_bug.cgi?id=379432
  - https://bugs.kde.org/show_bug.cgi?id=380272
  - https://bugs.kde.org/show_bug.cgi?id=390531

REPOSITORY
  R119 Plasma Desktop

BRANCH
  more-generous-folder-view-title-display (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11358

To: ngraham, hein, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11362: Fix double top padding on scrollable pages with headers

[Nathaniel Graham]

ngraham added a comment.


  OK, I see that you just added the same fix to the cards branch, so I'll 
abandon this.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11362

To: ngraham, mart, apol, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11316: Components for Cards

[Marco Martin]

mart updated this revision to Diff 29626.
mart added a comment.


  - better top padding

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11316?vs=29585=29626

BRANCH
  mart/Card

REVISION DETAIL
  https://phabricator.kde.org/D11316

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/CardsGridViewGallery.qml
  examples/gallerydata/contents/ui/gallery/CardsLayoutGallery.qml
  examples/gallerydata/contents/ui/gallery/CardsListViewGallery.qml
  kirigami.qrc
  src/controls/AbstractCard.qml
  src/controls/Card.qml
  src/controls/CardsGridView.qml
  src/controls/CardsLayout.qml
  src/controls/CardsListView.qml
  src/controls/GlobalDrawer.qml
  src/controls/Heading.qml
  src/controls/Page.qml
  src/controls/ScrollablePage.qml
  src/controls/Units.qml
  src/controls/plugins.qmltypes
  src/controls/private/BannerGroup.qml
  src/controls/private/BannerImage.qml
  src/controls/private/RefreshableScrollView.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/AbstractCard.qml
  src/controls/templates/private/ScrollView.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: mart, #kirigami, davidedmundson
Cc: apol, ngraham, davidedmundson, progwolff, plasma-devel, mart, hein

D11362: Fix double top padding on scrollable pages with headers

[Marco Martin]

mart added a comment.


  that should be done also in the cards branch (tough this version is more 
correct)
  if it's ok with you i would put this in the branch iinstead, otherwise there 
may be a conflict when merging

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11362

To: ngraham, mart, apol, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11364: Remove redundant app name from header

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Now that we're using the header for buttons, the app name name starts to make 
it look a bit crowsed. Also, it's redundant, since the name is listed again 
right below it. So, let's remove it.

TEST PLAN
  F5755196: Discover after.png 
  
  Man, Discover is looking really good these days.

REPOSITORY
  R134 Discover Software Store

BRANCH
  app-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11364

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11362: Fix double top padding on scrollable pages with headers

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: mart, apol, Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Kirigami was erroneously allocating extra top padding to ScrollablePages with 
headers, despite the fact that the headers allocale enough space for themselves 
automatically.
  
  This patch fixes the issue and resolves a visual glitch in Discover arising 
from the use of standard ToolBarApplicationHeaders.

TEST PLAN
  Viewed all pages in Kirigami Gallery and made sure there were no visual 
regressions.
  
  Discover, before:
  
  Discover, after:

REPOSITORY
  R169 Kirigami

BRANCH
  fix-scrollablepage-redundant-top-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11362

AFFECTED FILES
  src/controls/ScrollablePage.qml

To: ngraham, mart, apol, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11358: Give file and folder names a bit more room in Folder View

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Folder View always reserves enough vertical space to fit the configured 
number of lines to keep an evenly-spaced grid. The default number of lines 
should therefore strike a happy medium between conserving vertical space to fit 
more rows and catering to the odd longer file name. 3 would optimize for most 
file names being so long that even with ellision they're not readable at two 
lines, which I don't feel is warranted.
  
  As for making it configurable - maybe. Not sure. I'm not there yet, because 
on my end, the user complaints have stopped with 4.10 when we prominently 
followed feedback and made the delegates and grid tighter. Before that we got 
tickets about it more regularly, which has mostly ceased, and the release 
itself was met with lots of positive feedback. I therefore feel that we've been 
doing quite well at iterating towards what makes most people happy. I'm sure 
it's always possible to find individual opinions that buck the trend, but I 
have to integrate the feedback channels somehow.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  more-generous-folder-view-title-display (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11358

To: ngraham, hein, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 192 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/192/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 15 Mar 2018 16:58:38 +
 Build duration:
1 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 130.02 KB...]Found property definition "X-Plasma-StandAloneApp" with type "bool"Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"Found property definition "NoDisplay" with type "bool"Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to stringUnknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-json[  4%] Built target DiscoverNotifiers_autogenScanning dependencies of target DiscoverNotifiers[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[  5%] Built target PaginateModelTest_autogenScanning dependencies of target PaginateModelTest[  6%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[  7%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[  8%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.o[  9%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[ 10%] Linking CXX shared library libDiscoverNotifiers.so[ 10%] Built target DiscoverNotifiersScanning dependencies of target DummyNotifier_autogen[ 11%] Automatic MOC for target DummyNotifier[ 11%] Built target DummyNotifier_autogenScanning dependencies of target DiscoverNotifierDeclarativePlugin_autogen[ 12%] Automatic MOC for target DiscoverNotifierDeclarativePlugin[ 12%] Built target DiscoverNotifierDeclarativePlugin_autogenScanning dependencies of target DummyNotifier[ 13%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.oScanning dependencies of target DiscoverNotifierDeclarativePlugin[ 14%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/BackendNotifierFactory.cpp.o[ 15%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[ 16%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifier.cpp.o[ 17%] Linking CXX shared module DummyNotifier.so[ 18%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[ 18%] Built target DummyNotifier[ 19%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[ 20%] Linking CXX executable PaginateModelTest[ 20%] Built target PaginateModelTest[ 21%] Linking CXX shared library libDiscoverNotifierDeclarativePlugin.so[ 21%] Built target DiscoverNotifierDeclarativePlugin[ 21%] Built target DiscoverCommon_autogenScanning dependencies of target DiscoverCommon[ 22%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[ 23%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[ 25%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[ 26%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.o[ 28%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[ 29%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[ 30%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/Transaction.cpp.o[ 31%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionListener.cpp.o[ 32%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionModel.cpp.o[ 33%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateItem.cpp.o[ 34%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateModel.cpp.o[ 35%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesModel.cpp.o[ 36%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesProxyModel.cpp.o[ 37%] Building CXX object 

D11358: Give file and folder names a bit more room in Folder View

[Nathaniel Graham]

ngraham added a comment.


  This patch does that too, so I've removed the other changes.
  
  However, if we have users clamoring for diametrically-opposed things, maybe 
it's time to consider making the grid spacing configurable? macOS had the exact 
same problem for more than a decade and Apple eventually relented and added a 
slider. They're famously allergic to unnecessary configurability, so if even 
they bowed to user feedback and did this, it might be appropriate for us to 
investigate doing likewise.
  
  What's the objection to increasing the default max number of lines, out of 
curiosity?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11358

To: ngraham, hein, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11358: Give file and folder names a bit more room in Folder View

[Nathaniel Graham]

ngraham updated this revision to Diff 29614.
ngraham added a comment.


  Revert unacceptable changes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11358?vs=29609=29614

BRANCH
  more-generous-folder-view-title-display (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11358

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: ngraham, hein, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 364 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/364/
 Project:
Plasma discover kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 15 Mar 2018 16:57:33 +
 Build duration:
1 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 203.58 KB...][ 69%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSResource.cpp.oIn file included from /usr/include/qt5/QtCore/QtCore:4:0, from /usr/include/qt5/QtGui/QtGuiDepends:3, from /usr/include/qt5/QtGui/QtGui:3, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp: In member function ‘void ModelTest::data()’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:429:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );~~^~~~[ 70%] Linking CXX executable CategoriesTest[ 71%] Linking CXX executable knsbackendtest[ 71%] Built target CategoriesTestScanning dependencies of target dummy-backend[ 72%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.oScanning dependencies of target updatedummytest[ 73%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/__/__/__/tests/modeltest.cpp.o[ 74%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSReviews.cpp.o[ 74%] Built target knsbackendtest[ 74%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/kns-backend_autogen/mocs_compilation.cpp.o[ 75%] Linking CXX executable dummytest[ 76%] Generating qrc_assets.cpp[ 77%] Generating qrc_resources.cppIn file included from /usr/include/qt5/QtCore/QtCore:4:0, from /usr/include/qt5/QtGui/QtGuiDepends:3, from /usr/include/qt5/QtGui/QtGui:3, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp: In member function ‘void ModelTest::data()’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:429:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );~~^~~~[ 78%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.oScanning dependencies of target plasma-discover[ 79%] Building CXX object discover/CMakeFiles/plasma-discover.dir/qrc_resources.cpp.o[ 80%] Linking CXX shared module kns-backend.so[ 81%] Building CXX object discover/CMakeFiles/plasma-discover.dir/qrc_assets.cpp.o[ 82%] Building CXX object discover/CMakeFiles/plasma-discover.dir/main.cpp.o[ 82%] Built target dummytest[ 83%] Building CXX object discover/CMakeFiles/plasma-discover.dir/DiscoverObject.cpp.o[ 83%] Built target kns-backendScanning dependencies of target plasma-discover-exporter[ 84%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/main.cpp.o/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp: In member function ‘void DummyBackend::populate(const QString&)’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:65:65: error: invalid new-_expression_ of abstract class type ‘DummyResource’ DummyResource* res = new DummyResource(name, false, this); ^In file included from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:22:0:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyResource.h:27:7: note:   because the following virtual functions are pure within ‘DummyResource’: class DummyResource : public AbstractResource   ^In file included from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/resources/AbstractResourcesBackend.h:28:0, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.h:24, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:21:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/resources/AbstractResource.h:206:23: 

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 191 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/191/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 15 Mar 2018 16:54:03 +
 Build duration:
3 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 130.45 KB...]Found property definition "X-Plasma-StandAloneApp" with type "bool"Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"Found property definition "NoDisplay" with type "bool"Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to stringUnknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-json[  4%] Built target DiscoverNotifiers_autogenScanning dependencies of target DiscoverNotifiers[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[  5%] Built target PaginateModelTest_autogenScanning dependencies of target PaginateModelTest[  6%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[  7%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[  8%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.o[  9%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[ 10%] Linking CXX shared library libDiscoverNotifiers.so[ 10%] Built target DiscoverNotifiersScanning dependencies of target DummyNotifier_autogen[ 11%] Automatic MOC for target DummyNotifier[ 11%] Built target DummyNotifier_autogenScanning dependencies of target DiscoverNotifierDeclarativePlugin_autogen[ 12%] Automatic MOC for target DiscoverNotifierDeclarativePlugin[ 12%] Built target DiscoverNotifierDeclarativePlugin_autogenScanning dependencies of target DummyNotifierScanning dependencies of target DiscoverNotifierDeclarativePlugin[ 13%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[ 14%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.o[ 15%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/BackendNotifierFactory.cpp.o[ 16%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifier.cpp.o[ 17%] Linking CXX executable PaginateModelTest[ 17%] Built target PaginateModelTest[ 18%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[ 19%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[ 20%] Linking CXX shared module DummyNotifier.so[ 20%] Built target DummyNotifier[ 20%] Built target DiscoverCommon_autogenScanning dependencies of target DiscoverCommon[ 21%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[ 22%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[ 25%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[ 26%] Linking CXX shared library libDiscoverNotifierDeclarativePlugin.so[ 26%] Built target DiscoverNotifierDeclarativePlugin[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.o[ 28%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[ 29%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[ 30%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/Transaction.cpp.o[ 31%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionListener.cpp.o[ 32%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionModel.cpp.o[ 33%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateItem.cpp.o[ 34%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateModel.cpp.o[ 35%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesModel.cpp.o[ 36%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesProxyModel.cpp.o[ 37%] Building CXX object 

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 363 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/363/
 Project:
Plasma discover kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 15 Mar 2018 16:54:03 +
 Build duration:
1 min 40 sec and counting
   CONSOLE OUTPUT
  [...truncated 205.61 KB...] from /usr/include/qt5/QtGui/QtGui:3, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp: In member function ‘void ModelTest::data()’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:429:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );~~^~~~In file included from /usr/include/qt5/QtCore/QtCore:4:0, from /usr/include/qt5/QtGui/QtGuiDepends:3, from /usr/include/qt5/QtGui/QtGui:3, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp: In member function ‘void ModelTest::data()’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:429:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );~~^~~~[ 68%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest_autogen/mocs_compilation.cpp.o[ 69%] Linking CXX executable CategoriesTest[ 70%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/knsbackendtest_autogen/mocs_compilation.cpp.o[ 71%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/plasma-discover-exporter_autogen/mocs_compilation.cpp.o[ 71%] Built target CategoriesTest[ 72%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSResource.cpp.o[ 73%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/DummyTest.cpp.o[ 74%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/UpdateDummyTest.cpp.o[ 75%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSReviews.cpp.o[ 76%] Linking CXX executable knsbackendtest[ 77%] Linking CXX executable plasma-discover-exporter[ 77%] Built target knsbackendtest[ 77%] Built target plasma-discover-exporterScanning dependencies of target dummy-backend[ 78%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.o[ 78%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/kns-backend_autogen/mocs_compilation.cpp.o[ 79%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.o[ 80%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyReviewsBackend.cpp.o/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp: In member function ‘void DummyBackend::populate(const QString&)’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:65:65: error: invalid new-_expression_ of abstract class type ‘DummyResource’ DummyResource* res = new DummyResource(name, false, this); ^In file included from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:22:0:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyResource.h:27:7: note:   because the following virtual functions are pure within ‘DummyResource’: class DummyResource : public AbstractResource   ^In file included from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/resources/AbstractResourcesBackend.h:28:0, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.h:24, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:21:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/resources/AbstractResource.h:206:23: note: 	virtual QDate AbstractResource::releaseDate() const virtual QDate releaseDate() const = 0;   ^~~/home/jenkins/workspace/Plasma discover kf5-qt5 

D10753: Provide the source selection as a contextual action

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:af5058de7f9a: Provide the source selection as a 
contextual action (authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10753?vs=27842=29613

REVISION DETAIL
  https://phabricator.kde.org/D10753

AFFECTED FILES
  discover/qml/ApplicationPage.qml
  libdiscover/resources/ResourcesProxyModel.cpp
  libdiscover/resources/ResourcesProxyModel.h

To: apol, ngraham
Cc: cfeck, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11358: Give file and folder names a bit more room in Folder View

[Eike Hein]

hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  The grid spacing has been reduced multiple times on user requests. I'm not 
going to accept a patch that makes it wider, or changes the default number of 
lines. But I think a patch that makes the text label wider within the delegate 
could work.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11358

To: ngraham, hein, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11358: Give file and folder names a bit more room in Folder View

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: hein, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Give Folder View cells a small amount more horizontal space and increase the 
default number of lines to 3. This goes a long way toward giving typical file 
and folders enough room to show their full titles.
  
  This slightly increases the grid spacing overall, but I believe this is worth 
it to allow file and folder names to be displayed with more fidelity.
  
  BUG: 379432
  FIXED-IN: 5.13.0

TEST PLAN
  Before, normal-sized icons:
  
  After, normal-sized icons:
  
  Before: small icons:
  
  After, small icons:

REPOSITORY
  R119 Plasma Desktop

BRANCH
  more-generous-folder-view-title-display (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11358

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/FolderItemDelegate.qml
  containments/desktop/package/contents/ui/FolderView.qml

To: ngraham, hein, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11356: [Media Controller] Show track length if available even if seeking isn't possible

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Thanks for the quick patch, works nicely with my CanSeek=false gwenview 
position WIP patch :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11356

To: broulik, #plasma, #vdg, kossebau, Fuchs, romangg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11356: [Media Controller] Show track length if available even if seeking isn't possible

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:513d3a69af50: [Media Controller] Show track length if 
available even if seeking isnt possible (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11356?vs=29603=29604

REVISION DETAIL
  https://phabricator.kde.org/D11356

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: broulik, #plasma, #vdg, kossebau, Fuchs, romangg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11356: [Media Controller] Show track length if available even if seeking isn't possible

[Christian]

Fuchs accepted this revision.
Fuchs added a comment.
This revision is now accepted and ready to land.


  +1, looks great to me. 
  Bit of duplicate control, but given there can be one at most, that seems fine 
to me.
  
  Also progress bar makes sense, since a playing track is progress, so it 
should even look good if other plasma themes decide to use something completely 
different looking for that compared to the slider.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11356

To: broulik, #plasma, #vdg, kossebau, Fuchs
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11356: [Media Controller] Show track length if available even if seeking isn't possible

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, kossebau, Fuchs.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When seeking isn't possible but the track duration is known, show a progress 
bar instead of showing nothing.
  A progress bar is also much nicer than a disabled slider here as it's then 
meant as an indicator instead.

TEST PLAN
  Disabled slider:
  F5755038: Screenshot_20180315_162409.png 

  Progress bar (this patch)
  F5755039: Screenshot_20180315_162240.png 

  
  - Verified that it is not shown when streaming music where length isn't known

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11356

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: broulik, #plasma, #vdg, kossebau, Fuchs
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 190 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/190/
 Project:
Plasma discover kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 15 Mar 2018 13:48:23 +
 Build duration:
2 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 130.25 KB...]Found property definition "X-Plasma-StandAloneApp" with type "bool"Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"Found property definition "NoDisplay" with type "bool"Unknown property type for key "X-Plasma-Requires-FileDialog" -> falling back to stringUnknown property type for key "X-Plasma-Requires-LaunchApp" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma discover kf5-qt5 FreeBSDQt5.9/build/notifier/org.kde.discovernotifier-plasmoids-metadata.json" [  4%] Built target org.kde.discovernotifier-plasmoids-metadata-json[  4%] Built target DiscoverNotifiers_autogenScanning dependencies of target DiscoverNotifiers[  4%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[  5%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[  6%] Linking CXX shared library libDiscoverNotifiers.so[  6%] Built target DiscoverNotifiers[  6%] Built target PaginateModelTest_autogenScanning dependencies of target DummyNotifier_autogenScanning dependencies of target DiscoverNotifierDeclarativePlugin_autogen[  7%] Automatic MOC for target DummyNotifier[  8%] Automatic MOC for target DiscoverNotifierDeclarativePlugin[  8%] Built target DummyNotifier_autogenScanning dependencies of target DummyNotifier[  9%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.o[ 10%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[ 10%] Built target DiscoverNotifierDeclarativePlugin_autogenScanning dependencies of target DiscoverNotifierDeclarativePlugin[ 11%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/BackendNotifierFactory.cpp.o[ 12%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifier.cpp.oScanning dependencies of target PaginateModelTest[ 13%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[ 14%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[ 15%] Linking CXX shared module DummyNotifier.so[ 15%] Built target DummyNotifier[ 16%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[ 17%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[ 18%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/__/libdiscover/tests/modeltest.cpp.o[ 19%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[ 19%] Built target DiscoverCommon_autogen[ 20%] Linking CXX shared library libDiscoverNotifierDeclarativePlugin.soScanning dependencies of target DiscoverCommon[ 21%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[ 23%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[ 22%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[ 24%] Built target DiscoverNotifierDeclarativePlugin[ 25%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[ 26%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.o[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[ 28%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[ 29%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/Transaction.cpp.o[ 30%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionListener.cpp.o[ 31%] Linking CXX executable PaginateModelTest[ 32%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionModel.cpp.o[ 33%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateItem.cpp.o[ 33%] Built target PaginateModelTest[ 34%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateModel.cpp.o[ 35%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesModel.cpp.o[ 36%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesProxyModel.cpp.o[ 37%] Building CXX object 

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 362 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/362/
 Project:
Plasma discover kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 15 Mar 2018 13:48:23 +
 Build duration:
2 min 36 sec and counting
   CONSOLE OUTPUT
  [...truncated 206.12 KB...] from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp: In member function ‘void ModelTest::data()’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:429:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );~~^~~~[ 68%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/MuonExporter.cpp.oIn file included from /usr/include/qt5/QtCore/QtCore:4:0, from /usr/include/qt5/QtGui/QtGuiDepends:3, from /usr/include/qt5/QtGui/QtGui:3, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp: In member function ‘void ModelTest::data()’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:429:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );~~^~~~[ 69%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/plasma-discover-exporter_autogen/mocs_compilation.cpp.o[ 70%] Linking CXX executable CategoriesTest[ 71%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/UpdateDummyTest.cpp.o[ 72%] Linking CXX executable knsbackendtest[ 73%] Linking CXX executable plasma-discover-exporter[ 73%] Built target CategoriesTest[ 73%] Built target knsbackendtest[ 73%] Built target plasma-discover-exporterScanning dependencies of target kns-backend[ 74%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/updatedummytest_autogen/mocs_compilation.cpp.o[ 75%] Generating qrc_assets.cpp[ 76%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.oScanning dependencies of target dummy-backend[ 77%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.o[ 78%] Generating qrc_resources.cpp[ 79%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/DummyTest.cpp.oScanning dependencies of target plasma-discover[ 80%] Building CXX object discover/CMakeFiles/plasma-discover.dir/qrc_resources.cpp.o[ 81%] Building CXX object discover/CMakeFiles/plasma-discover.dir/qrc_assets.cpp.o[ 82%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.o[ 83%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyReviewsBackend.cpp.o[ 84%] Linking CXX executable updatedummytest[ 85%] Building CXX object discover/CMakeFiles/plasma-discover.dir/main.cpp.o/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp: In member function ‘void DummyBackend::populate(const QString&)’:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:65:65: error: invalid new-_expression_ of abstract class type ‘DummyResource’ DummyResource* res = new DummyResource(name, false, this); ^In file included from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:22:0:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyResource.h:27:7: note:   because the following virtual functions are pure within ‘DummyResource’: class DummyResource : public AbstractResource   ^In file included from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/resources/AbstractResourcesBackend.h:28:0, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.h:24, from /home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/backends/DummyBackend/DummyBackend.cpp:21:/home/jenkins/workspace/Plasma discover kf5-qt5 SUSEQt5.9/libdiscover/resources/AbstractResource.h:206:23: note: 	virtual QDate AbstractResource::releaseDate() const  

D11333: introduce the function containmentGraphicsItemPreview

[Marco Martin]

mart updated this revision to Diff 29595.
mart added a comment.


  approach with a model
  
  a possible approach is this: a model with all the activities that map to
  items, but i don't like this, because it's pretty much duplicating the
  activity model present in kactivities with a worse version.
  
  another approach i'll try shortly, is to just have a list property
  of all possible containments and then it's a problem of the qml part to
  find the right ones for the right activities

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11333?vs=29513=29595

BRANCH
  mart/containmentPreview

REVISION DETAIL
  https://phabricator.kde.org/D11333

AFFECTED FILES
  shell/desktopview.cpp
  shell/desktopview.h
  shell/shellcorona.cpp
  shell/shellcorona.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11333: introduce the function containmentGraphicsItemPreview

[Marco Martin]

mart added a comment.


  a possible approach is this: a model with all the activities that map to
  items, but i don't like this, because it's pretty much duplicating the
  activity model present in kactivities with a worse version.
  
  another approach i'll try shortly, is to just have a list property
  of all possible containments and then it's a problem of the qml part to
  find the right ones for the right activities

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11333

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11198: [libbreezecommon] add box shadow helper

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> broulik wrote in config-breezecommon.h.cmake:1
> This file is generated and should not be checked in

What do you mean? We need to pass an input file to the `configure_file`.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11292: [RFC] Ordered system tray v2

[Radek Hušek]

Pitel added a comment.


  To compare with auto ordering (as @mart would like) see D11352 
.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel, #plasma, #vdg
Cc: mart, zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D11352: [RFC] Auto ordered systray

[Radek Hušek]

Pitel created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Pitel requested review of this revision.

REVISION SUMMARY
  @mart dislikes idea of manually ordering the systray (D11233 
, D11292 
) but prefers auto
  ordering instead. To make my opinion I hacked up this and started testing on 
myself.
  Current version breaks if two items have the same category and text (I guess 
this
  should not happen but...).
  
  Note that category order is more or less randomly chosen (I do believe 
someone else
  has an opinion what the correct order is).
  
  This is mutually exclusive with D11292 .

REPOSITORY
  R120 Plasma Workspace

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel
Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D11133: Fix minimise all applet on wayland with an active window

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:3697f4511337: Fix minimise all applet on wayland with an 
active window (authored by davidedmundson).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11133?vs=28952=29589

REVISION DETAIL
  https://phabricator.kde.org/D11133

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11327: [Workspace Options KCM] sync() after writing settings

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:06c837e274ed: [Workspace Options KCM] sync() after 
writing settings (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11327?vs=29493=29588

REVISION DETAIL
  https://phabricator.kde.org/D11327

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions.cpp

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10338: Don't show tooltips for inactive windows

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10338

To: broulik, #plasma, graesslin, McPain
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11309: Use the default Plasma wallpaper on the login screen

[David Edmundson]

davidedmundson added a comment.


  > if vdg agrees ok... i'm still not sure about this
  
  Will wait for the relevant screenlocker thread

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11309

To: davidedmundson, #plasma, #vdg, broulik, abetts, ngraham
Cc: mart, davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11335: [System Tray] Fix hiding applets with HiddenStatus

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:de715e8c5d95: [System Tray] Fix hiding applets with 
HiddenStatus (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11335?vs=29518=29587

REVISION DETAIL
  https://phabricator.kde.org/D11335

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11316: Components for Cards

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in CardsLayout.qml:35
> I can see you want it in a layout because you're setting the relevant 
> attached properties, but why explicitly Column?

It's not mandatory but the one i think it makes more sense, so i want to put it 
as a recommendation.
kirigami pages always scroll only vertically, so makes sense to recommend a 
vertical development of the final page layout.

> davidedmundson wrote in AbstractApplicationHeader.qml:88
> What are these changes in the header about?

they were done to put the correct vertical margin on top, to have the same 
amount of space left/top/right in the card, otherwise there was a too big space 
in the top margin (which was a generic problem, but with cards it became very 
apparent)
F5754851: Spectacle.J16533.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11316

To: mart, #kirigami, davidedmundson
Cc: apol, ngraham, davidedmundson, progwolff, plasma-devel, mart, hein

D11316: Components for Cards

[Marco Martin]

mart updated this revision to Diff 29585.
mart marked 3 inline comments as done.
mart added a comment.


  - fix elide for bannerimage

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11316?vs=29514=29585

BRANCH
  mart/Card

REVISION DETAIL
  https://phabricator.kde.org/D11316

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/CardsGridViewGallery.qml
  examples/gallerydata/contents/ui/gallery/CardsLayoutGallery.qml
  examples/gallerydata/contents/ui/gallery/CardsListViewGallery.qml
  kirigami.qrc
  src/controls/AbstractCard.qml
  src/controls/Card.qml
  src/controls/CardsGridView.qml
  src/controls/CardsLayout.qml
  src/controls/CardsListView.qml
  src/controls/GlobalDrawer.qml
  src/controls/Heading.qml
  src/controls/Page.qml
  src/controls/ScrollablePage.qml
  src/controls/Units.qml
  src/controls/plugins.qmltypes
  src/controls/private/BannerGroup.qml
  src/controls/private/BannerImage.qml
  src/controls/private/RefreshableScrollView.qml
  src/controls/templates/AbstractApplicationHeader.qml
  src/controls/templates/AbstractCard.qml
  src/controls/templates/private/ScrollView.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: mart, #kirigami, davidedmundson
Cc: apol, ngraham, davidedmundson, progwolff, plasma-devel, mart, hein

D11350: [AppMenuModel] Don't store actions ourselves

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Always redirect to the ones in `m_menu` in case they get deleted or otherwise 
altered.
  Also emit `dataChanged` when an action changes and reset the model when it 
gets deleted.
  This fixes the menu getting confused in LibreOffice 6 with 
gmenu-dbusmenu-proxy.
  
  CCBUG: 391868

TEST PLAN
  It does not fix the unresponsive/empty "File" menu item I get when running 
`soffice --writer` directly, needs further investigation, but the appmenu and 
window menu are no longer intermingled.
  It also fixes crashes (dangling pointer) I had when a menu item got removed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11350

AFFECTED FILES
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11333: introduce the function containmentGraphicsItemPreview

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in desktopview.cpp:201
> In the main code path shellcorona is responsible for assigning containments 
> to desktopviews.
> 
> In this code path DesktopView is extracting the relevant containments for 
> itself.
> 
> That's super messy, please redesign.

shellcorona assigns what is actually the current one, which is conceptually 
another thing.
not sure how to go on the other direction..
perhaps the corona could assign as well as another property like 
"allcontainmentsForScreen" which is then.. a model which has activity id, name 
and pointer to containment?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11333

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10837: bad textarea width for rename file if filename too short

[Eike Hein]

hein closed this revision.
hein added a comment.


  Committed as d6818eac6fbe495facf558b41cd570604bb7cbcb.

REVISION DETAIL
  https://phabricator.kde.org/D10837

To: painlessroaster, #plasma, hein
Cc: Pitel, cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11333: introduce the function containmentGraphicsItemPreview

[Marco Martin]

mart added a comment.


  In D11333#225797 , @davidedmundson 
wrote:
  
  > ShellCorona only creates the containment in currentActivityChanged, so this 
swiping stuff isn't going to work until you've first switched containment an 
existing way, then started swiping.
  
  
  no, the Containment* instances are all created immediately, as well the 
contained ContainmentInterface*
  What's created on demand (that is heavy indeed) is the qml stuff, which is 
created when the ContainmentInterface* gets a view, which can be controlled by 
the qml part of the shell (ie, when to cann this function and reparent the 
resulting ContainmentInterface*)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11333

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11292: [RFC] Ordered system tray v2

[Marco Martin]

mart added a comment.


  i'm still against this, but in favor of just forcing sort by type and 
alphabetic

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11292

To: Pitel, #plasma, #vdg
Cc: mart, zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham, 
plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D11309: Use the default Plasma wallpaper on the login screen

[Marco Martin]

mart added a comment.


  if vdg agrees ok... i'm still not sure about this

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11309

To: davidedmundson, #plasma, #vdg, broulik, abetts, ngraham
Cc: mart, davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D11198: [libbreezecommon] add box shadow helper

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> config-breezecommon.h.cmake:1
> +/* config-breezecommon.h. Generated by cmake from 
> config-breezecommon.h.cmake */
> +

This file is generated and should not be checked in

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart