D11253: Improve discoverability for changing the wallpaper

richardbowen added a comment. Since wallpaper is a feature of the desktop I don't mentioning wallpaper in the context menu title is necessary. "Configure Desktop" sounds a little technical but with the wallpaper image beside it it should be more clear. the word Configure is used throught

D11561: fix typos in UI strings

schwarzer added a comment. In D11561#231670 , @ivan wrote: > You can also switch to 'can't' as far as I'm concerned "can't" should not be used in formal writings. Not sure how formal documentation is considered to be. REPOSITORY R845

D11561: fix typos in UI strings

schwarzer closed this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D11561 To: schwarzer, ivan, davidedmundson Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11253: Improve discoverability for changing the wallpaper

ngraham added a comment. In D11253#232607 , @richardbowen wrote: > Since wallpaper is a feature of the desktop I don't think mentioning wallpaper in the context menu title is necessary. The entire point of this patch is my assertion

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 30271. Kanedias added a comment. - Implement releasing of client-freed output - Review fixes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=25976=30271 BRANCH gbm-vnc REVISION DETAIL

D11584: Set a transient parent for SNI context menus

fvogt added inline comments. INLINE COMMENTS > davidedmundson wrote in StatusNotifierItem.qml:63 > This change is unrelated, and not a change I would support. Why not? It is a fix for an oversight, which is currently a no-op due to another bug. REPOSITORY R120 Plasma Workspace REVISION

D11584: Set a transient parent for SNI context menus

broulik added inline comments. INLINE COMMENTS > StatusNotifierItem.qml:63 > onClicked: { > -var pos = plasmoid.nativeInterface.popupPosition(taskIcon, 0, 0); > +var pos = plasmoid.nativeInterface.popupPosition(taskIcon, mouse.x, > mouse.y); > I think this change is

D11584: Set a transient parent for SNI context menus

fvogt updated this revision to Diff 30279. fvogt added a comment. Split mouse.xy stuff into separate patch. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11584?vs=30251=30279 BRANCH snitest REVISION DETAIL https://phabricator.kde.org/D11584

D11584: Set a transient parent for SNI context menus

fvogt added inline comments. INLINE COMMENTS > broulik wrote in StatusNotifierItem.qml:63 > I think this change is fine. Except that the `MouseArea` covers the entire > list item, so for hidden SNIs the app might get coordinates outside of its > icon. > > For context menu we ignore the

D11600: Pass proper click coordinates to SNI ContextMenu calls

fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Currently it always passes the top left corner of the SNI icon as coordinates, but now it passes the actual click coordinates.

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 30273. Kanedias marked an inline comment as done. Kanedias added a comment. - Merge branch 'master' into gbm-vnc REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=30272=30273 BRANCH gbm-vnc REVISION DETAIL

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 30272. Kanedias added a comment. Remove already merged changes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=30271=30272 BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1231 AFFECTED FILES

D11586: libdbusmenu-qt: Remove nonexistant actions directly from the menu

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8827bb38806e: libdbusmenu-qt: Remove nonexistant actions directly from the menu (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11584: Set a transient parent for SNI context menus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cf2d64fa9718: Set a transient parent for SNI context menus (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11584?vs=30279=30293

D11600: Pass proper click coordinates to SNI ContextMenu calls

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a4a0d5bfd0da: Pass proper click coordinates to SNI ContextMenu calls (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11516: use plasma_install_bundled_package

mart updated this revision to Diff 30297. mart added a comment. - bump frameworks dep for new install bundled package REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11516?vs=30012=30297 BRANCH phab/bundle REVISION DETAIL

D11606: [WebBrowser Plasmoid] Support opening external links

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This implements a context menu for opening links externally.

D10234: LibInput: Queue native libinput events instead of LibInput::Event

fvogt abandoned this revision. fvogt added a comment. In D10234#232304 , @mart wrote: > for @fvogt: as an alternative approach has been pushed, can this be closed? Yup. REPOSITORY R108 KWin REVISION DETAIL

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 86 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/86/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Mar 2018 19:02:41 + Build duration: 1 min 27 sec and counting

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.9 - Build # 250 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.9/250/ Project: Plasma plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Fri, 23 Mar 2018 19:02:41 + Build duration: 6 min 8 sec and counting JUnit Tests

D11563: Remove long-time deprecated Encoding=UTF-8 from desktop format files

This revision was automatically updated to reflect the committed changes. Closed by commit R120:45a19fa16c45: Remove long-time deprecated Encoding=UTF-8 from desktop format files (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D9875: Extend parsing ssh prompt

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. Sorry that you had to wait so long - it seems there's no active maintainer for this. I just wanted to give this a try. Unfortunately the patch doesn't apply to current master

D11625: Unify padding on all sides of app icons in delegates

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Without this patch, delegate app icons got

D11625: Unify padding on all sides of app icons in delegates

ngraham updated this revision to Diff 30354. ngraham added a comment. Improve spacing in compact view with this new style REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11625?vs=30353=30354 BRANCH master REVISION DETAIL

D11625: Unify padding on all sides of app icons in delegates

ngraham updated this revision to Diff 30356. ngraham added a comment. Very very slightly increase padding (2 -> 3) in compact mode for better aesthetics REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11625?vs=30354=30356 BRANCH master

D11625: Unify padding on all sides of app icons in delegates

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11625 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11607: Update systemsettings docbook to 5.12

lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread bump date + releaseinfo

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

ngraham updated this revision to Diff 30313. ngraham added a comment. Rebase on master, it's been a while REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11253?vs=29300=30313 BRANCH arcpatch-D11253 REVISION DETAIL

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

richardbowen added a comment. Also how about a preferences shortcut for "Desktop Wallpaper" (or some other suitable text) searchable from the start menu and krunner? This would be similar to the other desktop preferences that are searchable like "Desktop Theme", "Desktop Effects", etc..

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

mart added a comment. In D11253#232219 , @richardbowen wrote: > Also how about a preferences shortcut for "Desktop Wallpaper" (or some other suitable text) searchable from the start menu and krunner? This would be similar to the other desktop

D11613: call beginRemoveRows before removing the data

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It's perfectly valid to call ::data() from

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

mart added a comment. active window control is a 3rd party plasmoid, right? REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D11071 To: Pitel, #plasma, martinkostolny Cc: mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10838: [joystick kcm] Fix translation catalog name to follow patterns

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1e266200ecae: [joystick kcm] Fix translation catalog name to follow patterns (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10838?vs=28051=30318#toc REPOSITORY R119

D11182: org.freedesktop.PowerManagement.Inhibit should only prevent suspend

This revision was automatically updated to reflect the committed changes. Closed by commit R122:152400c1b688: org.freedesktop.PowerManagement.Inhibit should only prevent suspend (authored by broulik). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE

D11611: Move to KRunner's second results item with a single keypress

ngraham created this revision. ngraham added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, to navigate the list of results after typing a

D10838: [joystick kcm] Fix translation catalog name to follow patterns

ltoscano added a comment. Historical note: the few kcm catalogs called kcm5_ have been renamed by me to avoid conflict with the files with kde-runtime, which is co-installable with KF5. While this is not going to be a problem for the transition between KF5 and KF6, we can never be sure that

D11590: Add mutex round static member used in a thread

davidedmundson updated this revision to Diff 30298. davidedmundson added a comment. shallow-copy QStringList outside mutex REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11590?vs=30264=30298 BRANCH master REVISION DETAIL

D11352: [RFC] Auto ordered systray

mart added a comment. In D11352#230681 , @Pitel wrote: > Great, but I found one more bug (and it affected order of items). This fixes it. > > - Add tie breaking (for the unlikely case of the same category & text) > - Add debug print

D11352: [RFC] Auto ordered systray

mart added inline comments. INLINE COMMENTS > AbstractItem.qml:80 > > -onEffectiveStatusChanged: updateItemVisibility(abstractItem); > +property int creationId // used for item order tie breaking > +onEffectiveStatusChanged: updateItemVisibility(abstractItem) This is probably not

D11410: [RFC] Add option to make applet fixed width

mart added a comment. In D11410#229494 , @Pitel wrote: > In D11410#229277 , @mart wrote: > > > it's moving on the right track.. i would like the checkbox to appear like the one in the panel spacer,

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

richardbowen added a comment. In D11253#232189 , @mart wrote: > what about as text using Configure-desktop and as icon preferences-desktop-wallpaper?F5763655: Spectacle.T27450.png +1 A big

D10850: Rename wallpaper translation catalogs to follow pattern

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f945ad4bae01: Rename wallpaper translation catalogs to follow pattern (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11516: use plasma_install_bundled_package

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Cannot test at the moment, but looks straight forward, so no objection from me. Besides the unrelated changes, they want to have their own commits :) INLINE COMMENTS >

D11182: org.freedesktop.PowerManagement.Inhibit should only prevent suspend

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Given it's relying on other applications being sane, which is generally unreliable, maybe it's best to only put this in master. REPOSITORY R122 Powerdevil REVISION

D10838: [joystick kcm] Fix translation catalog name to follow patterns

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. If toscano is for it, then I'm for it. REPOSITORY R119 Plasma Desktop BRANCH improvekcmjoystickcatalogname REVISION DETAIL https://phabricator.kde.org/D10838 To:

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

mart added a comment. what about as text using Configure-desktop and as icon preferences-desktop-wallpaper?F5763655: Spectacle.T27450.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11253 To: ngraham, #plasma,

D10838: [joystick kcm] Fix translation catalog name to follow patterns

kossebau added a comment. In D10838#230049 , @ltoscano wrote: > (you can add the #Localization group too) > > I would suggest kcm5_joystick in order to be future-proof. Okay. Had

D11073: [RFC] [Active Window Control] Elide appmenu when it is too long

mart added a comment. we are starting to use more the "overflow-menu" icon for this use case REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D11073 To: Pitel, #plasma, martinkostolny Cc: mart, plasma-devel, ZrenBot, lesliezhai,

D11611: Move to KRunner's second results item with a single keypress

broulik accepted this revision. broulik added a comment. I guess this could go into 5.12 also REPOSITORY R120 Plasma Workspace BRANCH fix-krunner-double-down-key-issue (branched from master) REVISION DETAIL https://phabricator.kde.org/D11611 To: ngraham, #plasma, broulik, mart Cc:

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

davidedmundson added a comment. There's a pre-existing discussion on bugzilla about the latter comment. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11253 To: ngraham, #plasma, davidedmundson Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot,

D11611: Move to KRunner's second results item with a single keypress

ngraham updated this revision to Diff 30319. ngraham added a comment. Also don't lose focus when there are no search results REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11611?vs=30311=30319 BRANCH fix-krunner-double-down-key-issue (branched

D11611: Move to KRunner's second results item with a single keypress

ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11611 To: ngraham, #plasma, broulik, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10660: [Weather applet] Let Return invoke search

kossebau added a comment. In D10660#232255 , @mart wrote: > any news on this? Blocked a little by me having the desire to have the secret API used here made public documented, cmp. question to you in

D11516: use plasma_install_bundled_package

mart added a comment. In D11516#232097 , @kossebau wrote: > Cannot test at the moment, but looks straight forward, so no objection from me. > > Besides the unrelated changes, they want to have their own commits :) INLINE COMMENTS >

D10429: Disable the title bar separator by default

ngraham added a comment. +1 for tri-state as a compromise, but I still don't really see the point, as in Breeze light it's almost invisible even when on. Would also approve of off-by-default or even removing it entirely. REPOSITORY R31 Breeze REVISION DETAIL

D10344: Create panel on current screen

mart added a comment. btw, this was ignored for a long time as there weren't reviewers specified REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10344 To: hoffmannrobert, #plasma Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

mart added a comment. any update on this? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces, hein Cc: mart, mwolff, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

ngraham added a comment. FYI Linus doesn't have a developer account, so someone will need to commit this for him. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D10304 REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility, mart

D10291: Add a recursion blocker in Pointer/TouchInputRedirection::update

mart added a comment. janitor message: review process on this should start again (or abandoned if doesn't make sense anymore) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10291 To: graesslin, #kwin, #plasma Cc: mart, romangg, plasma-devel, kwin, iodelay, zzag,

D10234: LibInput: Queue native libinput events instead of LibInput::Event

mart added a comment. for @fvogt: as an alternative approach has been pushed, can this be closed? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10234 To: fvogt, #plasma, graesslin Cc: mart, kwin, plasma-devel, #kwin, iodelay, zzag, bwowk, ZrenBot, lesliezhai,

D10855: Emit clicked when double click expires

mart added a comment. on the link i see mostly the motivation as a personal opinion of Thomas L. The fact i kinda defend this diff is that the vdg is pushing to limit and drop the long press buttons menus on most places. this is a thing i think should take proper discussion in the vdg and

D10660: [Weather applet] Let Return invoke search

mart added a comment. any news on this? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10660 To: broulik, #plasma, kossebau Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10659: [AppletConfiguration] Let applet override Return closing the dialog

mart added a comment. to me is fine.. already the main item can implement functions that can do $stuff, which is not abvious and could be bertter. i guess the best thing is to put a big text comment here what are the supported comments/functions REPOSITORY R119 Plasma Desktop

D11064: add preview images to fonts kcm

mart added inline comments. INLINE COMMENTS > progwolff wrote in previewrenderengine.cpp:136 > It's a bug in Qt: https://bugreports.qt.io/browse/QTBUG-38127 > > Workaround: set the sourceSize to something. can you put the workaround with a giant comment that points to the qt bug? REPOSITORY

D10344: Create panel on current screen

mart added a comment. I like the idea, needs a bit of thinking to work on wayland INLINE COMMENTS > shellcorona.cpp:1816 > +// find out current screen to create new panels on > +const QPoint cursorPos(QCursor::pos()); > +int screenNum = -1; this is probably going to break in

D10263: Fix being unable to close the toolbox menu by clicking outside

mart added a comment. still can't reproduce the popup not closing when clicking on empty areas of desktop, does the problem persists for you? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To: hein, #plasma, mart Cc: broulik, plasma-devel, ZrenBot,

D11516: use plasma_install_bundled_package

This revision was automatically updated to reflect the committed changes. Closed by commit R114:c505a726b3f1: use plasma_install_bundled_package (authored by mart). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11516?vs=30297=30324 REVISION DETAIL

D10660: [Weather applet] Let Return invoke search

mart added a comment. yeah, for me that other patch is ok, is not optimal but should all be documented in line in that file maaaybe introducing a root component for those config uis.. not sure REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10660 To:

D10660: [Weather applet] Let Return invoke search

kossebau added inline comments. INLINE COMMENTS > ConfigWeatherStation.qml:33 > + > +property bool acceptOnReturnPressed: !searchStringEdit.activeFocus || > searchStringEdit.length === 0 > could be "readonly property" as well, no? REPOSITORY R114 Plasma Addons REVISION DETAIL

D10383: Fix pinning apps when their .desktop file has a space in the file name.

mart added a comment. any update on this? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10383 To: hein, #plasma, broulik, ivan Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10429: Disable the title bar separator by default

mart added a comment. shouldn't make it worse for everybody to make it better for the subset who use a dark theme. at most, should be if the palette color is darker than something, draw it, otherwise don't so +1 for 3state REPOSITORY R31 Breeze REVISION DETAIL

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 30325. progwolff added a comment. - giant comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28856=30325 BRANCH arcpatch-D11064 REVISION DETAIL https://phabricator.kde.org/D11064 AFFECTED

D11516: use plasma_install_bundled_package

kossebau added inline comments. INLINE COMMENTS > mart wrote in main.qml:24 > ah, to me it appeared to break fifteenpuzzle, can you test if also for you > using the qrc way, but keeping this unaltered, breaks it? Sadly cannot test currently, self-compiled plasma-frameworks in custom prefix

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 88 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/88/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 24 Mar 2018 00:06:23 + Build duration: 1 min 12 sec and counting

D10184: Port mediawiki runner to Plasma5/Qt5

This revision was automatically updated to reflect the committed changes. Closed by commit R114:d9d708debf6c: Port mediawiki runner to Plasma5/Qt5 (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10184?vs=26662=30363 REVISION

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 87 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/87/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 23 Mar 2018 23:45:08 + Build duration: 1 min 29 sec and counting

D11590: Add mutex round static member used in a thread

davidedmundson added a comment. Very well spotted! In this specific case it's probably fine as it's never modified after construction, but I'll change anyway. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11590 To: davidedmundson, #plasma Cc:

D11262: KDE logout screen background color fix

mart added a comment. In D11262#224843 , @Pitel wrote: > I see that relative luminance formula is more correct but I would like to point out that we do not need here to calculate precise luminance. The point of the `?:` statement is to collapse

D11220: option to force FolderView icon-only presentation

mart added a comment. i don't see much use case for it, but... Eike, i think the final word would be up to you, what do you think about it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11220 To: mvourlakos, #plasma, mart, hein Cc: sebas, broulik, hein,

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

ngraham added a comment. All right, how about this? F5763759: Better 2.png F5763758: better.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11253 To: ngraham, #plasma,

D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

ngraham updated this revision to Diff 30327. ngraham added a comment. Use a more appropriate icon and shorten the string REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11253?vs=30313=30327 BRANCH arcpatch-D11253 REVISION DETAIL

D10263: Fix being unable to close the toolbox menu by clicking outside

hein added a comment. Yup. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To: hein, #plasma, mart Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11631: Fixes pixelated icon scaling for HiDPI screens This enables HiDPI pixmaps in the main window. This commit also replaces QPixmap and KIconLoader with QIcon to load properly scaled icons in the

acrouthamel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. acrouthamel requested review of this revision. TEST PLAN Open icon selection in main window. Expand tree menu and ensure selection works. REPOSITORY

D11253: Improve discoverability for changing the wallpaper

richardbowen added a comment. In D11253#232632 , @ngraham wrote: > In D11253#232607 , @richardbowen wrote: > > > Since wallpaper is a feature of the desktop I don't think mentioning wallpaper in