This revision was automatically updated to reflect the committed changes.
Closed by commit R884:1119c47f1756: [Active Window Control] Slightly fix
vertical alignment of window name (authored by Pitel).
REPOSITORY
R884 Active Window Control Applet for Plasma
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R884:f48d5afac734: Show window title when app name is missing
(authored by Pitel).
REPOSITORY
R884 Active Window Control Applet for Plasma
CHANGES SINCE LAST UPDATE
Pitel added inline comments.
INLINE COMMENTS
> Pitel wrote in AbstractItem.qml:80
> Probably not, I have not observed any problems even without this rule, I just
> wanted to be safe. I see that I can use `applet.id` or even
> `applet.pluginName` as there should be at most one instace of given
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b9d2f63fe1c2: Update clock docbook to 5.12 (authored by
lueck).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D11695?vs=30548=30861#toc
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST
Pitel updated this revision to Diff 30859.
Pitel added a comment.
- Remove debug print
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11352?vs=30111=30859
BRANCH
stableSystray2
REVISION DETAIL
https://phabricator.kde.org/D11352
AFFECTED
Hi Jan,
It seems that as part of your recent changes to networkmanager-qt to
increase the dependency to 1.0.0 you've made some other changes which
mean the appropriate include paths are no longer being provided to
projects that depend on networkmanager-qt.
This has the unfortunate effect that
asturmlechner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
asturmlechner requested review of this revision.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D11794
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/509/
Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.9
Date of build:
Thu, 29 Mar 2018 22:14:54 +
Build duration:
8 min 12 sec and counting
CONSOLE
croick added a comment.
bump
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D11234
To: croick, #plasma_workspaces, apol, mwolff
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
hein updated this revision to Diff 30835.
hein added a comment.
- Make icon a grouped property.
- Support icon color tinting.
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11663?vs=30781=30835
BRANCH
master
REVISION DETAIL
broulik added inline comments.
INLINE COMMENTS
> xwindowsystemeventbatcher.cpp:69
> +{
> +Q_UNUSED(event);
> +for (auto it = m_cache.constBegin(); it!= m_cache.constEnd(); it++) {
Please check `event->timerId()` against `m_timerId`, plasmashell keeps hogging
100% CPU when I have
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e6231547df6d: Add InlineMessage type and Gallery app
example page (authored by hein).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11663?vs=30835=30836
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fdeb02ce37a1: Notification dataengine debug category
(authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11774?vs=30821=30838
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c3a0a7aa780e: Remove dead dataengine code (authored by
davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11775?vs=30823=30837
REVISION
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/506/
Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.9
Date of build:
Thu, 29 Mar 2018 10:55:30 +
Build duration:
7 min 1 sec and counting
CONSOLE
davidedmundson updated this revision to Diff 30839.
davidedmundson added a comment.
proper timer usage
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7481?vs=30822=30839
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7481
broulik added inline comments.
INLINE COMMENTS
> broulik wrote in xwindowsystemeventbatcher.cpp:69
> Please check `event->timerId()` against `m_timerId`, plasmashell keeps
> hogging 100% CPU when I have certain windows focused (e.g. ksysguard) as this
> method is entered a ton of times with
davidedmundson updated this revision to Diff 30842.
davidedmundson added a comment.
Code comments
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11726?vs=30649=30842
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D11726
AFFECTED
cfeck added a comment.
Otherwise looks good. Maybe needs more feedback from testers.
INLINE COMMENTS
> kiconloader.cpp:1264
> {
> +return loadIcon(_name, group, 1.0 /*scale*/, size, state, overlays,
> path_store, canReturnNull);
> +}
indent
> kicontheme.cpp:169
> +} else if (scale >
BUILD SUCCESS
Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/510/
Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.9
Date of build:
Fri, 30 Mar 2018 03:25:52 +
Build duration:
1 hr 10 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f713a77e670a: Vastly simplify image wallpaper code
(authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11726?vs=30842=30844
davidedmundson updated this revision to Diff 30843.
davidedmundson added a comment.
fixup
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7481?vs=30839=30843
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7481
AFFECTED FILES
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/507/
Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.9
Date of build:
Thu, 29 Mar 2018 12:41:46 +
Build duration:
12 min and counting
CONSOLE OUTPUT
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:4b438abc8b15: Force a content size into the background
style item (authored by apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11189?vs=29505=30853
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ec1931f7b298: Batch window changes events on XCB
(authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7481?vs=30843=30849
BUILD FAILURE
Build URL
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/508/
Project:
Plasma plasma-workspace kf5-qt5 SUSEQt5.9
Date of build:
Thu, 29 Mar 2018 14:38:56 +
Build duration:
9 min 23 sec and counting
CONSOLE
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Haven't reviewed it very well, it's quite a complex diff to follow, but it
seems fine.
REPOSITORY
R119 Plasma Desktop
BRANCH
mouseKCM
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:420549603372: Ensure _NET_CURRENT_DESKTOP is set on
startup (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10836?vs=28039=30856
REVISION
28 matches
Mail list logo
