Look N' Feel and Latte Dock

2018-04-01 Thread Michail Vourlakos
Hello everyone, Latte is a few months before its next major release (v0.8 that is). Very exciting features this is going to bring and I would like to investigate if I can use this month for one important feature (Look N' Feel support). Can anyone give me some hints how this can be achieved? Is

D11866: Fix install target for kgamma

2018-04-01 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. lueck requested review of this revision. TEST PLAN builds REPOSITORY R100 KGamma REVISION DETAIL

D11842: Remove categories from app delegates

2018-04-01 Thread Nathaniel Graham
ngraham updated this revision to Diff 31109. ngraham added a comment. Rebase on master REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11842?vs=31054=31109 BRANCH remove-categories-on-delegates (branched from master) REVISION DETAIL

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-04-01 Thread Eike Hein
hein added a comment. It's also worth noting that the way the delay and the animation are currently implemented makes it pretty ugly even in the case of an accidental overshoot. If you do A->B->A in quick succession, the move from B back to A doesn't commence until the animation moving from

D11860: [kstyle] use Q_FALLTHROUGH in breezesplitterproxy

2018-04-01 Thread Vlad Zagorodniy
zzag created this revision. zzag added a reviewer: Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Qt has its own macro to tell the compiler that the lack of the break

D11855: By default, sort app lists by rating again

2018-04-01 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:1735ac9d97f0: By default, sort app lists by rating again (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11855?vs=31080=31108

D11864: Update kinfocenter docbook to 5.12

2018-04-01 Thread Burkhard Lück
lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread bump date + realeaseinfo

D11866: Fix install target for kgamma

2018-04-01 Thread Burkhard Lück
lueck updated this revision to Diff 31105. lueck added a reviewer: Localization. lueck added a comment. change install target to kgamma5, that is the target generated by scripty using autogen.sh REPOSITORY R100 KGamma CHANGES SINCE LAST UPDATE

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-04-01 Thread Eike Hein
hein added a comment. And FWIW, the main reason there's a delay right now is probably as a poor man's implementation of lazy menus. If you're hitting the menu button in the lower-left of the screen and then move the pointer to, say, the third or forth tab, you're likely to graze adjacent

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-04-01 Thread Nathaniel Graham
ngraham added a comment. I agree with @hein that the reason is probably " a poor man's implementation of lazy menus". The thing is, it's an inappropriate application of the feature and isn't necessary here. Allow me to put on my Usability Consultant hat and me illustrate why: Lazy

D11849: [kdecoration] properly compare opacity values

2018-04-01 Thread Vlad Zagorodniy
zzag added a comment. In D11849#238233 , @broulik wrote: > Why not use `qFuzzyCompare`? Opacity can be 0. But yeah, I could also use the +1 trick. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11849 To: zzag,

D11801: remove m_desktopContainments

2018-04-01 Thread David Edmundson
davidedmundson added a comment. Now that previous containmentForScreen patch is looking a thousand times better. Good stuff. +1 INLINE COMMENTS > shellcorona.cpp:1256 > if (containment) { > containment->setActivity(activity); > insertContainment(activity,

D11722: If GL context creation fails fall back to the software renderer

2018-04-01 Thread David Edmundson
davidedmundson added a comment. Kwin's crash detection is this pernament REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11722 To: davidedmundson, #plasma Cc: mart, broulik, graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-04-01 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. That second diagram literally has that arrow crossing through the History tab... I'm not approving something that replaces one bug with a different known bug.

D11849: [kdecoration] properly compare opacity values

2018-04-01 Thread Kai Uwe Broulik
broulik added a comment. Why not use `qFuzzyCompare`? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11849 To: zzag, #breeze Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-04-01 Thread Nathaniel Graham
ngraham updated this revision to Diff 31134. ngraham added a comment. Increase threshold to 50ms until I/we can implement a triangle filter thingy REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11848?vs=31068=31134 BRANCH

D11876: Display star ratings

2018-04-01 Thread Andrew Crouthamel
acrouthamel added a comment. Awesome patch! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11876 To: ngraham, apol, #discover_software_store Cc: acrouthamel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11848: [Kickoff] Reduce hover delay before switching tabs

2018-04-01 Thread Nathaniel Graham
ngraham added a comment. In D11848#238363 , @davidedmundson wrote: > That second diagram literally has that arrow crossing through the History tab... Yes, I drew the arrow that way deliberately to illustrate that it still works okay