D11198: [libbreezecommon] add box shadow helper

2018-04-22 Thread Vlad Zagorodniy
zzag updated this revision to Diff 32789. zzag added a comment. Fix invalid read of size 1 Valgrind output: ==8054== Invalid read of size 1 ==8054==at 0x1D8818C6: Breeze::BoxShadowHelper::blurAlphaNaivePass(QImage const&, QImage&, QVector const&) (in

D12278: WIP: [Colors KCM] Port to new design

2018-04-22 Thread Kai Uwe Broulik
broulik added a comment. > I also don't like "Default" either. What does that even mean to a regular user? That basically reloads the "no config" case hardcoded in KColorScheme. I think we should drop that and then make sure the "Default" button works well (as in: select Breeze).

D12376: [ContextMenu Containment Action] Fix checking for KIOSK

2018-04-22 Thread Kai Uwe Broulik
broulik updated this revision to Diff 32793. broulik added a comment. - Check both in run command REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12376?vs=32635=32793 REVISION DETAIL https://phabricator.kde.org/D12376 AFFECTED FILES

D12433: Add Plasma Calendar plugin Astronomical Events

2018-04-22 Thread Friedrich W . H . Kossebau
kossebau added a comment. One remaining issue: I have no clue yet how the calendar plugin should get notified about changed config (currently needs a plasma restart) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12433 To: kossebau, #plasma Cc: plasma-devel,

D12433: Add Plasma Calendar plugin Astronomical Events

2018-04-22 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY For now adds the option to show - lunar phase events

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

2018-04-22 Thread Christian
Fuchs added a comment. Also needs https://phabricator.kde.org/D12463 What it does: adds a new menu entry for the non-icon-only task manager which allows to set an application "icon only", so it will always be displayed without label (like a launcher) even if in running state. Both

D6096: Add Wayland RemoteAccess capabilities to KRfb

2018-04-22 Thread Oleg Chernovskiy
Kanedias added a comment. I've digged through old diff and I must say, many of what's described here will be peeled off. For now we support read-only views, so I'll be focusing on it. REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias,

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

2018-04-22 Thread Christian
Fuchs created this revision. Fuchs added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Fuchs requested review of this revision. REVISION SUMMARY This adds backend support for pinned tasks, which will only show an icon

D12459: WIP: [Icon KCM] Port to new design

2018-04-22 Thread Andres Betts
abetts added a comment. Love it! I like how convenient the configure button is. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12459 To: broulik, #plasma, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12455: kcm_opengl: Fix EGL info retrieval.

2018-04-22 Thread Lindsay Roberts
roberts created this revision. roberts added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. roberts requested review of this revision. REVISION SUMMARY Under certain contexts (tested with Mesa 18.0.1 + AMDGPU)

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

2018-04-22 Thread Christian
Fuchs created this revision. Fuchs added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Fuchs requested review of this revision. REVISION SUMMARY Frontend part for https://phabricator.kde.org/D12462, please check that

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-04-22 Thread Stefan BrĂ¼ns
bruns added a comment. In D12311#250731 , @stikonas wrote: > In D12311#250688 , @bruns wrote: > > > Gnome-disks does, and so do other programs. > > > Gnome-disks uses UDisks to do everything

D12459: WIP: [Icon KCM] Port to new design

2018-04-22 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This completely drops the icon customization with icon

D12459: WIP: [Icon KCM] Port to new design

2018-04-22 Thread Nathaniel Graham
ngraham added a comment. Oh my god, this looks so, so good. I love the icon size slider panel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12459 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

2018-04-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. @davidedmundson? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D12252 To: sharvey, ngraham, mart, davidedmundson Cc: davidedmundson, cfeck, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12351: introduce candidateContainments

2018-04-22 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:de483d47409c: introduce candidateContainments (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12351?vs=32568=32816 REVISION DETAIL

D11064: add preview images to fonts kcm

2018-04-22 Thread David Edmundson
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:1793b51ed8b9: add preview images to fonts kcm (authored by progwolff, committed by davidedmundson). REPOSITORY R119

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-04-22 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=369676 Marco Martin changed: What|Removed |Added Status|CONFIRMED |RESOLVED

D11928: fade to blur when the login box appears

2018-04-22 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:448455c3c937: fade to blur when the login box appears (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11928?vs=32483=32809#toc REPOSITORY R120 Plasma Workspace CHANGES

D11309: Use the default Plasma wallpaper on the login screen

2018-04-22 Thread David Edmundson
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:05b096135ca9: Use the default Plasma wallpaper on the login screen (authored by davidedmundson). REPOSITORY R120

D12449: Add hidden system setting group

2018-04-22 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We have a KCM (my plasma renderer settings)

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

2018-04-22 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > sharvey wrote in SettingsBase.cpp:82 > So should I just run the "preferred size" (1024x760) through the `boundedTo` > function for odd-sized screens? In other words, ditch the scale factor > completely? As in: > > const QSize screenSize = >

D12278: WIP: [Colors KCM] Port to new design

2018-04-22 Thread Nathaniel Graham
ngraham added a comment. In D12278#251602 , @broulik wrote: > > I also don't like "Default" either. What does that even mean to a regular user? > > That basically reloads the "no config" case hardcoded in KColorScheme. I think we should

D11308: Use the default Plasma wallpaper on the lock screen

2018-04-22 Thread Nathaniel Graham
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R133:6e5e6adad191: Use the default Plasma wallpaper on the lock screen (authored by ngraham). REPOSITORY R133

D12314: expose the wallpaper config to the lockscreen

2018-04-22 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R133:5e7e94599b78: expose the wallpaper config to the lockscreen (authored by mart). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12314?vs=32484=32807 REVISION

D11308: Use the default Plasma wallpaper on the lock screen

2018-04-22 Thread Nathaniel Graham
ngraham added a comment. Landing per Marco's instructions, since the whole lockscreen thingy is going in. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin, abetts, davidedmundson, mart Cc: fvogt, Fuchs, broulik,

D12278: WIP: [Colors KCM] Port to new design

2018-04-22 Thread Andres Betts
abetts added a comment. In D12278#251722 , @ngraham wrote: > In D12278#251602 , @broulik wrote: > > > > I also don't like "Default" either. What does that even mean to a regular user? > > > >

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

2018-04-22 Thread David Edmundson
davidedmundson updated this revision to Diff 32811. davidedmundson added a comment. Hide in systemsettings whilst keeping in krunner REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7934?vs=19780=32811 BRANCH master REVISION DETAIL

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

2018-04-22 Thread Scott Harvey
sharvey updated this revision to Diff 32814. sharvey added a comment. - Remove scale factor entirely; set minimum size REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12252?vs=32368=32814 BRANCH enlarge-default-size (branched from master)

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

2018-04-22 Thread Andres Betts
abetts added a comment. In D7934#147843 , @davidedmundson wrote: > F3921193: Spectacle.n23639.png Maybe I can help with this? Also, following the idea of simple, can we add explanatory text to these

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

2018-04-22 Thread David Edmundson
davidedmundson added a comment. You can, but given it's intended audience and how hidden it now is, it really isn't worth putting a lot of time into. If you don't know what a render loop is, you most definitely don't want to change it REPOSITORY R119 Plasma Desktop REVISION DETAIL

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

2018-04-22 Thread Andres Betts
abetts added a comment. In D7934#251775 , @davidedmundson wrote: > You can, but given it's intended audience and how hidden it now is, it really isn't worth putting a lot of time into. > > If you don't know what a render loop is, you most