D13178: Compress calls to configuration slots upon new connections

2018-06-11 Thread Jacopo De Simoi
jacopods updated this revision to Diff 36031. jacopods added a comment. I used the direct connection as suggested. Today I learned about QOverload... CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13178?vs=35045=36031 REVISION DETAIL https://phabricator.kde.org/D13178

D13255: Make dependency on KF5NetworkManagerQt optional

2018-06-11 Thread Ivan Čukić
ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R845 Plasma Vault BRANCH arcpatch-D13255 REVISION DETAIL https://phabricator.kde.org/D13255 To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel,

D13487: Fix build against static Qt without QLibrary

2018-06-11 Thread Daniel Vrátil
dvratil created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Sometimes when Qt is built statically it is also built without support for QLibrary and friends,

D13255: Make dependency on KF5NetworkManagerQt optional

2018-06-11 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 35985. asturmlechner added a comment. Use Q_UNUSED REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13255?vs=35896=35985 BRANCH arcpatch-D13255 REVISION DETAIL https://phabricator.kde.org/D13255

D13476: Remove doxygen docs of internal class

2018-06-11 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY And copy the relevant snippet to the

D13372: Mouse KCM Redesign Using Kirigami

2018-06-11 Thread Marco Martin
mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. for me, using qqc1 in a new kcm, is an absolute blocker, no matter what the problem is with qqc2, problems must be fixed, not worked around. ever. REPOSITORY R119 Plasma Desktop

D13372: Mouse KCM Redesign Using Kirigami

2018-06-11 Thread Furkan Tokac
furkantokac added a comment. In D13372#277040 , @mart wrote: > for me, using qqc1 in a new kcm, is an absolute blocker, no matter what the problem is with qqc2, problems must be fixed, not worked around. ever. So please keep following

D13372: Mouse KCM Redesign Using Kirigami

2018-06-11 Thread Marco Martin
mart added a comment. In D13372#277047 , @furkantokac wrote: > In D13372#277040 , @mart wrote: > > > for me, using qqc1 in a new kcm, is an absolute blocker, no matter what the problem is with

D13372: Mouse KCM Redesign Using Kirigami

2018-06-11 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > main.qml:27 > +import org.kde.kirigami 2.4 as Kirigami > import org.kde.plasma.core 2.0 as PlasmaCore > never import anything from plasma in a kcm (an exception which we have to solve is SortFilterProxyModel) Kirigami has its own units >

D13372: Mouse KCM Redesign Using Kirigami

2018-06-11 Thread Marco Martin
mart added a comment. here a patch against this which ports it to qqc2, using the completely different radiobutton mechanics qqc2 uses, fixing separators, removing plasmacore import F5907175: qqc2.diff REPOSITORY R119 Plasma Desktop REVISION

D13372: Mouse KCM Redesign Using Kirigami

2018-06-11 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > main.qml:105 > > -Layouts.ColumnLayout { > -id: maincol > -enabled: deviceCount > -spacing: units.largeSpacing > +Kirigami.Separator { > +} this is broken, it needs

D13372: Mouse KCM Redesign Using Kirigami

2018-06-11 Thread Furkan Tokac
furkantokac added a comment. In D13372#277078 , @mart wrote: > here a patch against this which ports it to qqc2, using the completely different radiobutton mechanics qqc2 uses, fixing separators, removing plasmacore import > F5907175:

D13481: Recommend window border size "None"

2018-06-11 Thread Roman Gilg
romangg created this revision. romangg added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Adds a recommendation of border size "None" for the new KWin