D14489: [ProcessModel] Support high dpi for window pixmaps

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. QPixmap KWindowSystem::icon(WId win, int width, int height, bool scale, int flags, NETWinInfo *info) { Q_D(KWindowSystem); width *=

D10040: Add serial number and EISA ID to OutputDevice interface

romangg added a comment. In D10040#300588 , @davidedmundson wrote: > I just removed handling of dynamically updating eisa/serialNumber it doesn't seem to be something that makes sense for it to change at runtime. > > Also I don't want to

D14480: Don't unintentionally change font rendering when rendering preview images

progwolff created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY Font rendering settings are changed temporarily to render preview images. The changed settings

D14489: [ProcessModel] Support high dpi for window pixmaps

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Request larger pixmaps and set `devicePixelRatio`

D14489: [ProcessModel] Support high dpi for window pixmaps

ngraham added a comment. Should this be `devicePixelRatioF()` to support fractional scale factors? REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D14489 To: broulik, #plasma, davidedmundson Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14493: fontinst quits after KJob is done

mathiastillman created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mathiastillman requested review of this revision. REVISION SUMMARY As the summary says, when installing/removing multiple fonts to system the expected

D14490: [System Monitor] Enable high dpi pixmaps

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - Needs D14489 for

D14489: [ProcessModel] Support high dpi for window pixmaps

davidedmundson added a comment. Not here, no. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D14489 To: broulik, #plasma, davidedmundson Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14487: [Klipper] Only create KHelpMenu when used

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. KHelpMenu looks to lazy load internally inside KHelpMenu::menu. What issue did this cause? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D14488: [Positioner] Be a flat list model

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Return rowCount of `0` for sub items TEST PLAN Noticed

D14436: SwitchDesktop mousewheel options with config dialog added

davidedmundson added inline comments. INLINE COMMENTS > desktop.cpp:172 > +namespace { > +void switchDesktop(bool next, bool rollover, bool invert) { > const int numDesktops = KWindowSystem::numberOfDesktops(); if you turn this into a method you don't need the rollover/invert args > totto

D10040: Add serial number and EISA ID to OutputDevice interface

romangg added inline comments. INLINE COMMENTS > outputdevice.cpp:161 > + int32_t subPixel, const char *make, const char > *model, > + int32_t transform) > { Unrelated change. > outputdevice_interface.cpp:153 > +connect(this,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham requested changes to this revision. ngraham added a reviewer: Plasma. ngraham added a comment. This revision now requires changes to proceed. Nice! Two nitpicks: - `Anti-aliasing: [x] Use antialiasing` Either change the checkbox's label to "Enable", or remove the left label and

D14480: Don't unintentionally change font rendering when rendering preview images

This revision was automatically updated to reflect the committed changes. Closed by commit R119:79a4bbc36cee: Dont unintentionally change font rendering when rendering preview images (authored by progwolff). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D14474: Stop enforcing spacings

This revision was automatically updated to reflect the committed changes. Closed by commit R134:b648825801a3: Stop enforcing spacings (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14474?vs=38736=38770 REVISION DETAIL

D10040: Add serial number and EISA ID to OutputDevice interface

davidedmundson updated this revision to Diff 38772. davidedmundson added a comment. Remove unrelated changes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10040?vs=38734=38772 BRANCH output_changes REVISION DETAIL https://phabricator.kde.org/D10040

D14444: Use nullptr/override

al1xz updated this revision to Diff 38762. al1xz marked an inline comment as done. al1xz added a comment. Update REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=38674=38762 BRANCH arcpatch-D1 REVISION DETAIL

D14480: Don't unintentionally change font rendering when rendering preview images

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good catch. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.13 REVISION DETAIL https://phabricator.kde.org/D14480 To: progwolff, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38764. progwolff added a comment. - split changes to previewimageprovider.cpp to a separate commit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=38757=38764 BRANCH arcpatch-D12925 REVISION DETAIL

D10040: Add serial number and EISA ID to OutputDevice interface

davidedmundson added a comment. I just removed handling of dynamically updating eisa/serialNumber it doesn't seem to be something that makes sense for it to change at runtime. Also I don't want to copy the current setEdid pattern, which is broken ATM. Whenever any new client connects it

D14487: [Klipper] Only create KHelpMenu when used

broulik created this revision. broulik added reviewers: Plasma, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The entry is only shown when run standalone anyway.

D14489: [ProcessModel] Support high dpi for window pixmaps

broulik added a comment. Interesting. Without this patch, I had some icons come out too small, will investigate. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D14489 To: broulik, #plasma, davidedmundson Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D14489: [ProcessModel] Support high dpi for window pixmaps

davidedmundson added a comment. KWindowSystem::icon doesn't set a DPR on the returned pixmap which sounds wrong. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D14489 To: broulik, #plasma, davidedmundson Cc: ngraham, plasma-devel, ragreen, Pitel,

D14437: Fix QFileDialog not remembering the last visited directory.

apol added a comment. +1 from me on the patch. I'd prefer without the comment and just have it investigated, I'm not sure the comment will help. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D14437 To: dfaure, anthonyfieroni,

D13988: Use subseq matching for service runner

cfeck added a comment. According to https://community.kde.org/Schedules/Plasma_5 the Plasma 5.14 release is planned to depend on Frameworks 5.50. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas, #plasma_workspaces, #plasma,

D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available

ngraham added a comment. I'm raid this patch no longer applies cleanly on `master`: Created and checked out branch arcpatch-D12708. Checking patch kstyle/config-breeze.h.cmake... Checking patch kstyle/breezewindowmanager.h... Checking patch kstyle/breezewindowmanager.cpp...

D14493: fontinst quits after KJob is done

ngraham added a comment. Does this fix 379524 and 379324? See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14493 To: mathiastillman, #plasma Cc: ngraham, plasma-devel, ragreen,

D13988: Use subseq matching for service runner

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fantastic. This works great for me, but let's get some more opinions too. REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38757. progwolff added a comment. Rebase on master. Partial rewrite. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=34315=38757 BRANCH arcpatch-D12925 REVISION DETAIL

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. Big sorry for being away for so long. I had some things to do that took much more time than initally planned. Many thanks to those who fixed the bugs I introduced or created workarounds... I tried to get this patch working now. First of all, I want to say a

D14436: SwitchDesktop mousewheel options with config dialog added

totto marked an inline comment as done. totto added a comment. > disabled checkbox for rollover That was partially meant to overcome the shortcoming that changing the kwin value does not change this value until some settings dialog is opened, but with your patch this is no longer

D14477: Do not leak Widget::ui

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14477

D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes

hein added a comment. Can we make the KFilePlaces model static on top of this? It could be shared by all FVs that need it. Look at how tasksmodel.cpp keeps a refcount of when ActivityInfo is in use and deletes it when it drops to 0 for example ... REPOSITORY R119 Plasma Desktop REVISION

D14476: QMLScreen: do not declare the engine a member

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Note, that m_engine is set in widget.cpp. But it's just a Cpp call to setEngine, which is defined extra. So removing the property macro should be fine. REPOSITORY R104 KScreen

D14476: QMLScreen: do not declare the engine a member

broulik added inline comments. INLINE COMMENTS > qmlscreen.h:109 > > QQmlEngine* m_engine = nullptr; > QMLOutput *m_leftmost = nullptr; This entire custom engine handling could be removed, with `QMLScreen` using `qmlEngine(this)` when creating an `QMLOutput` REPOSITORY R104

D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes

broulik planned changes to this revision. broulik added a comment. Good idea, will do REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14426 To: broulik, #plasma, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D14477: Do not leak Widget::ui

This revision was automatically updated to reflect the committed changes. Closed by commit R104:749ab17d5e48: Do not leak Widget::ui (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14477?vs=38746=38749 REVISION DETAIL

D14476: QMLScreen: do not declare the engine a member

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY There is no need for this, the only use of the engine is when

D14478: Do not leak all instances of QMLOutput when QMLScreen is destroyed

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY In practice this is most likely only a leak on exit which does

D14426: [Folder View] Create KFilePlacesModel only when needed and listen for changes

hein added a comment. Danke :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14426 To: broulik, #plasma, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14476: QMLScreen: do not declare the engine a member

gladhorn added inline comments. INLINE COMMENTS > broulik wrote in qmlscreen.h:109 > This entire custom engine handling could be removed, with `QMLScreen` using > `qmlEngine(this)` when creating an `QMLOutput` I had briefly tried and got a nullptr from qmlEngine, but I didn't really spend

D14437: Fix QFileDialog not remembering the last visited directory.

dfaure added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kdeplatformfiledialoghelper.cpp:118 > It works without comment, i think these connections are not needed. Yes for this problem my patch is enough, but I was surprised to find that those signals were not connected. Yes it's

D14353: Improve alignment of types

romangg added a comment. As already said on IRC and also how Vlad sees it: this optimization like for most of our classes is not worth it. Since we are an open source project, which strives to motivate people to contribute, good readability is much more important. So when ordering the

D14478: Do not leak all instances of QMLOutput when QMLScreen is destroyed

davidedmundson added inline comments. INLINE COMMENTS > qmlscreen.cpp:96 > > qmloutput->setParentItem(this); > qmloutput->setZ(m_outputMap.count()); this should clear them already? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14478 To: gladhorn,

D14478: Do not leak all instances of QMLOutput when QMLScreen is destroyed

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in qmlscreen.cpp:96 > this should clear them already? `parentItem` is only visual parent, it doesn't communicate ownership REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14478 To: gladhorn,

D14478: Do not leak all instances of QMLOutput when QMLScreen is destroyed

romangg added a comment. I also thought the call to setParentItem would clear the output. But as @broulik says it does not delete automatically. So is this good to go? Or should we make QMLScreen really a Qt Object parent of the outputs? REPOSITORY R104 KScreen REVISION DETAIL

D14478: Do not leak all instances of QMLOutput when QMLScreen is destroyed

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. It's good to go. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14478 To: gladhorn, #plasma, davidedmundson Cc: romangg, broulik, davidedmundson,