Re: KDE CI: Dependency Build Extragear kf5-qt5 SUSEQt5.9 - Build # 121 - Still Failing!

On Thu, Aug 2, 2018 at 6:10 AM, Ben Cooksley wrote: > Hi folks, > Hi all, > > Looks like there has been a regression in libkscreen, as can be seen below. > This now seems to have been fixed, but the failure point has now moved into KWin. Please see

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.10 - Build # 126 - Failure!

BUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kcoreaddons.desktopparser: Unknown property type for key "X-Plasma-MainScript" -> falling back to stringQDEBUG : VirtualDesktopTest::testNetCurrentDesktop() kf5.kpackage: kpluginindex: Not cached "/usr/share/kwin/effects"

D14542: WIP: Basic KCM using new virtual desktops DBus interface

davidedmundson added a comment. Edit. That unit test comment was intended for Marcos patch not this. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine,

D14542: WIP: Basic KCM using new virtual desktops DBus interface

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > desktopsmodel.cpp:53 > + > +bool connected = QDBusConnection::sessionBus().connect( > +s_serviceName, We can just generate the

D14542: WIP: Basic KCM using new virtual desktops DBus interface

davidedmundson added a comment. Also, I know this is a WIP, but so it's noted it's not going to get merged without some unit test of the new API and checking all current stuff passes. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson

D14562: Introduce Theme.smallestFont

volkov added inline comments. INLINE COMMENTS > volkov wrote in kirigamiplugin.cpp:173 > So, should it be registered for both versions 2.2 and 2.6? > I tried to use revisions, but it looks like they don't work for properties of > attached property objects: >

D14667: Fix a text label in the password dialog

jgrulich closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14667 To: underwit, #plasma, jgrulich Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14562: Introduce Theme.smallestFont

volkov added a comment. Why add it to qml-base theme implementations? Aren't they obsolete? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14562 To: volkov, #kirigami, mart Cc: mart, plasma-devel, apol, davidedmundson, hein

D14670: Fix an undefined reference error with static mode + LTO

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e1620cba164b: Fix the build in LTO static mode (authored by lepagevalleeemmanuel). Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. CHANGED

D14651: [Notifications Engine] Guard "this"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7a98c7d5e58a: [Notifications Engine] Guard this (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14651?vs=39195=39245 REVISION

D14647: [Kicker] Look up relative entryPaths

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2ce76bc5ade2: [Kicker] Look up relative entryPaths (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14647?vs=39184=39246 REVISION

D14667: Fix a text label in the password dialog

underwit created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. underwit requested review of this revision. REVISION SUMMARY With some system settings, this effect appears. Part of the text label on the password dialog

D14667: Fix a text label in the password dialog

underwit added a comment. no commit access REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14667 To: underwit, #plasma, jgrulich Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14673: Fix the Kirigami QRC static plugin generation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:867283d0c159: Fix the Kirigami QRC static plugin generation (authored by mart). REPOSITORY R169 Kirigami CHANGES

D14673: Fix the Kirigami QRC static plugin generation

mart updated this revision to Diff 39259. mart added a comment. - kirigami.qrc.in for cmake, kirigami.qrc for qmake REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14673?vs=39256=39259 BRANCH arcpatch-D14673 REVISION DETAIL

D14672: [plasma-changeicons] Call sync() after writing

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Plasma-integration's KHintsSettings keeps

D14673: Fix the Kirigami QRC static plugin generation

lepagevalleeemmanuel created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. lepagevalleeemmanuel requested review of this revision. REVISION SUMMARY This patch moves the qrc from "raw" to generated using CMake configure

D14671: [Kicker] Use document-properties icon for "Properties" context menu entry

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it consistent with other places where such an entry

D14673: Fix the Kirigami QRC static plugin generation

bearsh added a comment. how is this supposed to work in a qmake based project? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14673 To: lepagevalleeemmanuel Cc: bearsh, plasma-devel, apol, davidedmundson, mart, hein

D14673: Fix the Kirigami QRC static plugin generation

lepagevalleeemmanuel added a comment. In D14673#304936 , @bearsh wrote: > how is this supposed to work in a qmake based project? As of right now I had forgotten it had too. It will probably need another qrc and solution... Currently both