D15683: Add lock icon to desktop context menu

ngraham added a comment. In D15683#329959 , @safaalfulaij wrote: > Why not also add icons to other items instead of other X number of commits coming later by Y number of people? > Yes, some don't have “group” icon (like sort, where only

D15683: Add lock icon to desktop context menu

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15683 To: anemeth, ngraham, #vdg Cc: abetts, safaalfulaij, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

bruns updated this revision to Diff 42127. bruns added a comment. add one more invalid access fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15687?vs=42123=42127 REVISION DETAIL https://phabricator.kde.org/D15687 AFFECTED FILES

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns added a comment. Ping! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15357 To: bruns, #plasma Cc: davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY When a Solid device is removed (e.g. a CD is ejected) the notifier tries to read the attributes

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

ngraham added a comment. Code change looks pretty sane to me. INLINE COMMENTS > FullRepresentation.qml:180 > actionToolTip: { > + var types = model["Device Types"]; > if (!mounted) { Indentation REPOSITORY R120 Plasma Workspace REVISION DETAIL

D15696: Fix qmake build

IlyaBizyaev updated this revision to Diff 42145. IlyaBizyaev edited the summary of this revision. IlyaBizyaev added a comment. Indeed, thanks @alexeymin! REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15696?vs=42142=42145 REVISION DETAIL

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 42148. anthonyfieroni added a comment. Stop indicator in a minute, restart engine in 10 sec. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=42035=42148 REVISION DETAIL https://phabricator.kde.org/D15616 AFFECTED FILES

D15644: Provide option to hide menu bar for Ksysguard

ngraham added a comment. In D15644#330281 , @lsartorelli wrote: > Hi Nathaniel, thanks for all the support. > I can understand and agree with your concerns. > Not sure but maybe an option could be to add the hide menu bar entry in the

D15699: Relabel "Mouse Click Emulation" to "Tap to Click"

sharvey updated this revision to Diff 42154. sharvey added a comment. Update "Mouse Click Emulation" to "Tap to Click" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15699?vs=42153=42154 BRANCH tap-to-click REVISION DETAIL

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

ngraham added a comment. We're past 5.14 and into 5.15 territory now. Does this deserve another look? My personal opinion is that it's not wise to under-invest in the X11 code while Wayland is still very much a work in progress. I get that it's frustrating to work on code that you know

D15696: Fix qmake build

IlyaBizyaev created this revision. IlyaBizyaev added a reviewer: mart. IlyaBizyaev added a project: Kirigami. Herald added a subscriber: plasma-devel. IlyaBizyaev requested review of this revision. REVISION SUMMARY Add scenepositionattached.* to the qmake project file REPOSITORY R169

D15696: Fix qmake build

alexeymin added a comment. Maybe add it to .pro file too then? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15696 To: IlyaBizyaev, mart Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

bruns updated this revision to Diff 42149. bruns added a comment. fix indentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15687?vs=42127=42149 REVISION DETAIL https://phabricator.kde.org/D15687 AFFECTED FILES

D15699: Relabel "Mouse Click Emulation" to "Tap to Click"

sharvey created this revision. sharvey added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Text change/usability improvement. Replace technical terms with user-friendly language. TEST

D15699: Relabel "Mouse Click Emulation" to "Tap to Click"

ngraham accepted this revision. ngraham added subscribers: furkantokac, romangg. ngraham added a comment. This revision is now accepted and ready to land. +1; "Tap to Click" is by far the more commonly used and understood string. Landing this in 5.15 because it's a string change.

D15699: Relabel "Mouse Click Emulation" to "Tap to Click"

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15699 To: sharvey, ngraham, #plasma Cc: romangg, furkantokac, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15687: [Device Notifier] Avoid accessing attributes of stale UDIs

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > ngraham wrote in FullRepresentation.qml:180 > Indentation irks, tabs ... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15687 To: bruns, #frameworks Cc: ngraham,

D15696: Fix qmake build

alexeymin added a comment. How can I reproduce broken build? Any test plan? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15696 To: IlyaBizyaev, mart Cc: alexeymin, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D15699: Relabel "Mouse Click Emulation" to "Tap to Click"

sharvey added inline comments. INLINE COMMENTS > tap.ui:31 > + > +Qt::AlignCenter > I only changed lines 28-31... I don't know what the other changes are. I pulled plasma-desktop fresh from git. The change took mere minutes. REPOSITORY R119 Plasma Desktop REVISION

D15696: Fix qmake build

IlyaBizyaev added a comment. I'm not sure... You can try building a Kirigami application that uses Kirigami as a qmake submodule, like Kaidan . REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15696 To: IlyaBizyaev, mart Cc:

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli added a comment. Hi Nathaniel, thanks for all the support. I can understand and agree with your concerns. Not sure but maybe an option could be to add the hide menu bar entry in the setting menu via kxmlguiwindow and another entry to unhide it maybe can be putted in the