Several warnings on Qt 5.12

Hi, I've seen a bunch of warnings when running plasmashell under Qt 5.12. I haven't had time to look into it but it looks legit. Possibly a matter of using the right namespacing. Cheers! Aleix Previously registered enum will be overwritten due to name clash: PlasmaQuick::Dialog.FullScreen

D15969: Add support for systemd's suspend-then-hibernate

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D15969 AFFECTED FILES

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.11 - Build # 23 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.11/23/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 05 Oct 2018 17:29:33 + Build duration: 6 min 4 sec and counting CONSOLE OUTPUT [...truncated

D15942: Don't drag windows in empty areas from touch/pen events

abalaji added a comment. @davidedmundson awesome! I've been running around in circles trying to find this, glad that you fixed it! Although I'm the future we should support this properly. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15942 To: davidedmundson,

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren updated this revision to Diff 42950. Zren added a comment. - Got rid of the signal+slot that emits KNewStuff changes since wallpaperComboBox is automagically updated. - Reordered the command arguments so the variable is last in `wallpaperplugin.knsrc`. - Put the `plasmoids.knsrc`

D15942: Don't drag windows in empty areas from touch/pen events

abetts added a comment. Would this ensure that, at least, you can drag a window from the top area, like the toolbar, menu and the title bar empty areas? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15942 To: davidedmundson, #plasma, broulik, ngraham Cc: abetts,

D15942: Don't drag windows in empty areas from touch/pen events

broulik added a comment. No, not with a finger or pen. We should support this, yes, but not in the way it's currently done by synthesized mouse events. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15942 To: davidedmundson, #plasma, broulik, ngraham Cc: abetts,

D15942: Don't drag windows in empty areas from touch/pen events

abetts added a comment. In D15942#337137 , @broulik wrote: > No, not with a finger or pen. We should support this, yes, but not in the way it's currently done by synthesized mouse events. Sounds good! Thanks for the update! REPOSITORY

D14542: WIP: Basic KCM using new virtual desktops DBus interface

mart added a comment. I think the last fixme is actually not a fixme. dbus structs moved in vitualdesktopsdbustypes.h INLINE COMMENTS > main.qml:176 > + > +Item { // FIXME TODO: Quick gross spacing hack. > +Layout.fillWidth: true Actually, that's the way rowlayouts are

D14542: WIP: Basic KCM using new virtual desktops DBus interface

mart added a comment. once it uses the common dbus type, good to go for me, just rename it, eliminating the old kcm REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski,

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added a comment. Finally got around to updating this patch and formally testing with `kdesrc-build` (sort of) in Neon Unstable which has Frameworks 5.51. F6306500: screen-2018-10-05_16.35.50.mp4 Updated diff incoming as soon as I figure

D15877: [KonsoleProfiles applet] Fix navigating with the keyboard

This revision was automatically updated to reflect the committed changes. Closed by commit R114:943122b4429d: [KonsoleProfiles applet] Fix navigating with the keyboard (authored by thsurrel). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

This revision was automatically updated to reflect the committed changes. Closed by commit R119:df458e9ea505: [Folder View] In list view mode, fix home button disappearing every other… (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D15946: Avoid creation of needless temporary containers

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > output.cpp:101 > { > -if (before.keys() != after.keys()) { > +if (before.count() != after.count()) { > return false; The previous code also

D15942: Don't drag windows in empty areas from touch/pen events

rikmills added a comment. Fails to build on Neon and Kubuntu CI https://build.neon.kde.org/job/bionic_unstable_kde_breeze/71/ 01:20:12 [ 94%] Building CXX object kstyle/CMakeFiles/breeze.dir/breezewindowmanager.cpp.o 01:20:12 kstyle/CMakeFiles/breeze.dir/build.make:982: recipe for

D15942: Don't drag windows in empty areas from touch/pen events

broulik added a comment. Probably needs an ifdef for `KDE4` REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15942 To: davidedmundson, #plasma, broulik, ngraham Cc: rikmills, ngraham, abalaji, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15887: Fix Klipper popup opening on default screen instead of at cursor position

romangeints added a comment. So, should I rewrite this in terms of `qBound` & `availableGeometry`? REVISION DETAIL https://phabricator.kde.org/D15887 To: romangeints, #plasma, davidedmundson Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15963: [KonsoleProfiles applet] Fix initial focus

thsurrel created this revision. thsurrel added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY Now arrow key nav works when opening a panel applet via keyboard shortcut.

D15946: Avoid creation of needless temporary containers

volkov added inline comments. INLINE COMMENTS > broulik wrote in output.cpp:101 > The previous code also compared the contents of both, or does your new loop > below do that? Yes, the check is in the loop below: `after` and `before` are of the same sizes, and if `after` contains each key from

D15946: Avoid creation of needless temporary containers

volkov closed this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D15946 To: volkov, #plasma, broulik Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » oxygen » kf5-qt5 FreeBSDQt5.11 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/oxygen/job/kf5-qt5%20FreeBSDQt5.11/9/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 05 Oct 2018 12:55:02 + Build duration: 2 min 1 sec and counting

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.11 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.11/17/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 05 Oct 2018 12:43:32 + Build duration: 3 min 28 sec and counting CONSOLE OUTPUT [...truncated

D15887: Fix Klipper popup opening on default screen instead of at cursor position

davidedmundson added a comment. I would, then we'll at least be consistent across plasma code. REVISION DETAIL https://phabricator.kde.org/D15887 To: romangeints, #plasma, davidedmundson Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.11 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.11/18/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 05 Oct 2018 12:58:53 + Build duration: 2 min 58 sec and counting

KDE CI: Plasma » oxygen » kf5-qt5 SUSEQt5.11 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/oxygen/job/kf5-qt5%20SUSEQt5.11/9/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 05 Oct 2018 12:52:42 + Build duration: 8 min 1 sec and counting CONSOLE OUTPUT [...truncated 298.39

KDE CI: Plasma » oxygen » kf5-qt5 FreeBSDQt5.11 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/oxygen/job/kf5-qt5%20FreeBSDQt5.11/8/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 05 Oct 2018 12:52:42 + Build duration: 1 min 43 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » oxygen » kf5-qt5 SUSEQt5.11 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/oxygen/job/kf5-qt5%20SUSEQt5.11/10/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 05 Oct 2018 13:00:44 + Build duration: 9 min 33 sec and counting JUnit Tests Name: (root) Failed: 0

Re: Plasma 5.14.0 tars available for packaging

Hi, some tarballs (at least user-manager, libksysguard, milou -- probably others, test build isn't finished yet) seem to be missing translation files that were included before -- is this intentional (do we need separate l10n/i18n tarballs again?), or by mistake? ttyl bero On Thursday, October

Plasma 5.14.0 release tars updated

Hello Packagers, This is follow up to the 5.14.0 tars availability announced by the Jonathan, Unfortunately previously uploaded tarballs missed the translations completely, and we needed to re-do tars, since Jonathan is traveling today, I have made tars and signed with my key (fingerprint in

D14542: WIP: Basic KCM using new virtual desktops DBus interface

hein updated this revision to Diff 42958. hein edited the summary of this revision. hein added a comment. - Remove copied code. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=42898=42958 BRANCH arcpatch-D13887_2 REVISION DETAIL

D15840: [Folder View] Remember selected item when navigating in subfolders

hein added a comment. I like the goal here, but it's not a given the stored index is still valid when navigating back - the folder contents could have changed. It'd be hygienic to bound the access when popping from the history. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

ngraham added a comment. That looks really sweet. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12040 To: Zren, #plasma Cc: ngraham, cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D14542: WIP: Basic KCM using new virtual desktops DBus interface

hein added a reviewer: ltoscano. hein added a comment. Adding Luigi due to the .pot rename caused by this. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson, ltoscano Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski,

D14542: WIP: Basic KCM using new virtual desktops DBus interface

hein added a comment. Forgot to mention it, but I also did the folder move/rename so this KCM now replaces the old one. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski,

D15855: Port Kickoff to shared view component using single-MouseArea pattern

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in KickoffListView.qml:57 > This already is a focusScope > > could this not be the root item? I don't think so because I need the MouseArea to cover the ScrollArea, but the ScrollArea has to manage its single child (the