D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#340321 , @ngraham wrote: > Here are some screenshots from the latest version: > > F6316263: Spaceships.png > > F6316264: Snow.png

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham updated this revision to Diff 43260. ngraham added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16031?vs=43257=43260 BRANCH tweaked-login-screen (branched from master) REVISION DETAIL

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added a comment. Sorry, just merged both to master. Thanks davidedmundson for the patches that updated the ComboBox. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12040 To: Zren, #plasma, davidedmundson Cc: ngraham, cfeck, mart, davidedmundson,

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel updated this revision to Diff 43190. thsurrel added a comment. Use gridView.visibleArea REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15840?vs=43158=43190 BRANCH arc_folderview3 (branched from master) REVISION DETAIL

Plasma 5.14.0

Plasma 5.14.0 is now released https://www.kde.org/announcements/plasma-5.14.0.php

D16066: [ksmserver] Launch logout greeter with DBus methods

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Removing this is part of preparations for ksmserver to become just an X

D15209: Port scripting to Qt WebEngine

fvogt added a comment. I removed the RFC - I'm using this patch since I uploaded and haven't had any issues so far. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D15209 To: fvogt, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16065: [logoutprompt] Split greeter class into separate .h .cpp files

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY No code changes TEST PLAN Compiles REPOSITORY R120 Plasma Workspace

D15209: Port scripting to Qt WebEngine

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I don't like the use of any web browser in something so minor...but this is definitely better than the current state. I say we go for it. REPOSITORY R111 KSysguard

Google CodeIn

Hello folks, we (KDE Student Programs) are still trying to recruit mentors for the upcoming Google CodeIn contest for 14 to 18 year-olds. We've written to KDE-Community ML and KDE-devel, but don't want to nag. Still, we have too few mentors and not enough tasks to begin the contest. What works

D15209: Port scripting to Qt WebEngine

This revision was automatically updated to reflect the committed changes. Closed by commit R111:c9747e37c531: Port scripting to Qt WebEngine (authored by fvogt). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15209?vs=40829=43206 REVISION DETAIL

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

broulik added a comment. Again: Can we just use shadows behind the logout buttons and avatar like we have for the clock? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma Cc: abetts, pstefan, broulik, rikmills, filipf, rooty,

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. I really like the darker background for the icons, and have suggested that for D15999: Add icons with added background to system.svgz . If we do that, we won't need either blur or shadows behind them, and the shadows can just be

D16076: load icons from proper icon themes

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY this renders Kirigami.Icon and internal QQC2 icon loading mechanism compatible, as creating a valid

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#339180 , @pstefan wrote: > As other have pointed out the shadows for the buttons and username look out of place. Do they use the same radius/spread as those of the clock? > > I think blur is still needed. If

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. In D16031#339882 , @broulik wrote: > Again: Can we just use shadows behind the logout buttons and avatar like we have for the clock? We can't do only a shadow for the avatar since it gives a shadow to the

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

filipf added a comment. The new shadows around the action button text look better and the border around the avatar seems perfectly fine actually. I do, however, think that the shadows are too strong all together. The clock is actually a bigger concern. Have a look at the inside of the

D16073: openconnect: add missing dependency Qt5Xml

asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY QDomDocument is imported from vpn/openconnect/openconnectauth.cpp TEST PLAN

D16073: openconnect: add missing dependency Qt5Xml

asturmlechner updated this revision to Diff 43221. asturmlechner added a comment. Only pull in Qt5Xml if OpenConnect is requested. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16073?vs=43220=43221 BRANCH Plasma/5.14 REVISION

D16076: load icons from proper icon themes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:6a45d5592acf: load icons from proper icon themes (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST

D16082: Notify headphone being plugged in on some hardware

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY On my computer, plugging the headphones in and out does not create a sink change but

D16081: Fix build with gpsd 3.18

arojas created this revision. arojas added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY The signature of gps_read has changed in 3.18 to add an optional buffer parameter. Passing NULL,

D16073: openconnect: add missing dependency Qt5Xml

alexeymin accepted this revision. alexeymin added a comment. This revision is now accepted and ready to land. https://cgit.kde.org/plasma-nm.git/diff/vpn/openconnect/CMakeLists.txt?id=a44b7f38c548d756b6cb822c047ef71cf67645f5 Probably this commit could remove dependency on QtXml (I'm not

D14697: X11: set GDK_SCALE (try 2)

ngraham added a comment. @davidedmundson 5.14 was just released; should we give this a shot for 5.15? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma, broulik Cc: broulik, plasma-devel, ragreen, Pitel,

D14697: X11: set GDK_SCALE (try 2)

broulik added inline comments. INLINE COMMENTS > startkde.cmake:98 > export QT_SCREEN_SCALE_FACTORS="$kdeglobals_kscreen_screenscalefactors" > +if [ "$kdeglobals_kscreen_scalefactor" -eq "2" ] || [ > "$kdeglobals_kscreen_scalefactor" -eq "3" ]; then > +export

D16035: [SDDM theme] Use grammatically correct string "Log In"

abetts accepted this revision as: VDG, abetts. abetts added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16035 To: ngraham, #vdg, #plasma, abetts Cc: abetts, plasma-devel,

D14697: X11: set GDK_SCALE (try 2)

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in startkde.cmake:98 > Where does `kdeglobals_kscreen_scalefactor` come from? kstartupconfig5, which reads startupconfigkeys to see what to extract. They then get set as env vars. REPOSITORY R120 Plasma Workspace

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5e1b650859fe: Add wallpaperplugin.knsrc + QML function to open GHNS dialog (authored by Zren). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16035: [SDDM theme] Use grammatically correct string "Log In"

ngraham updated this revision to Diff 43258. ngraham added a comment. Update one more occurrence REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16035?vs=43101=43258 BRANCH arcpatch-D16035 REVISION DETAIL https://phabricator.kde.org/D16035

D16035: [SDDM theme] Use grammatically correct string "Log In"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:817f51d88237: [SDDM theme] Use grammatically correct string Log In (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

filipf added a comment. One more thing I noticed about functionality and that is related to the opacity of the circles. Since we now have circles, we can add a different opacity for when an action button is hovered over and when it's not. Here's a too strong of an example of different

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R119:347f43c42b70: Add Get Wallpaper Plugins... button to Config Desktop dialog (authored by Zren). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham updated this revision to Diff 43257. ngraham added a comment. - Tighten up outline around user avatar - Tweak shadows REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16031?vs=43092=43257 BRANCH tweaked-login-screen (branched from

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham marked an inline comment as done. ngraham added a comment. In D16031#340299 , @filipf wrote: > One more thing I noticed about functionality and that is related to the opacity of the circles. > > Since we now have circles, we can add

D15885: Clean UI file for `details` portion of UI

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Can you ammend this with the removals of appname/m_appname? If you need any assistance, please ask! REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

ngraham added a comment. No problem at all, I just wanted it to get in so I could blog about it, since I think it will prove popular. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12040 To: Zren, #plasma, davidedmundson Cc: ngraham, cfeck, mart,

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. Here are some screenshots from the latest version: F6316263: Spaceships.png F6316264: Snow.png F6316265: New Mexico.png F6316266:

D14697: X11: set GDK_SCALE (try 2)

eszlari added inline comments. INLINE COMMENTS > broulik wrote in startkde.cmake:98 > Where does `kdeglobals_kscreen_scalefactor` come from? Line 52. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma, broulik

D16087: RFC: Store full URL as URI

broulik created this revision. broulik added reviewers: Plasma, hein, ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A recently used file can also be a remote location TEST PLAN It took me forever to

D16082: Notify headphone being plugged in on some hardware

broulik added inline comments. INLINE COMMENTS > main.qml:173 > +// For some hardware, headphones are a port of the build-in > audio sink > +var text = > defaultSink.ports[defaultSink.activePortIndex].description; > +var icon; Please cache

D16073: openconnect: add missing dependency Qt5Xml

This revision was automatically updated to reflect the committed changes. Closed by commit R116:6919a84c70d8: openconnect: add missing dependency Qt5Xml (authored by asturmlechner). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D16073: openconnect: add missing dependency Qt5Xml

asturmlechner added a comment. In D16073#340107 , @alexeymin wrote: > If it fixes build error `.../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory` then fine... Yes, it was exactly that:

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

filipf added a comment. @ngraham well actually if we are turning off blur maybe it will somehow be possible to put a plain white background in SDDM again. Right now SDDM will darken it for you. If it won't do that anymore, this means that a drop shadow would probably not be enough; whoever