D16231: [ksmserver] Rewrite Startup

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The code is effectively 3 startup phases each of which has some parallel

D16231: [ksmserver] Rewrite Startup

anthonyfieroni added inline comments. INLINE COMMENTS > startup.cpp:194 > +connect(phase1, ::finished, this, [=]() { > +ksmserver->setupShortcuts(); // done only here, because it needs > kglobalaccel :-/ > +}); Can we delay it to finishStartup? > startup.cpp:210 > > -void

D16081: Fix build with gpsd 3.18

This revision was automatically updated to reflect the committed changes. Closed by commit R120:81a0fe6db9ac: Fix build with gpsd 3.18 (authored by arojas). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16081?vs=43233=43676 REVISION DETAIL

D15247: Show tooltips in krunner

McPain added a comment. Any ideas how to fix the bugs I mentioned above? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D15247 To: McPain, #plasma, broulik, ngraham Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D16152: [Discover Notifier] Open Updates page in notification

This revision was automatically updated to reflect the committed changes. Closed by commit R134:f237e7c0ccc8: [Discover Notifier] Open Updates page in notification (authored by broulik). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D16149: [Global Menu Applet] Fix menu layout option being always disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R120:824279fce904: [Global Menu Applet] Fix menu layout option being always disabled (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16241: [Folder View] Improve layout and formatting of Icons page

ngraham added a comment. Note: I know the `width: 500` is a horrible hack that is certainly the wrong way to do this, but I couldn't figure out how else to get the Labels' width to be long enough so that `Layout.alignment: Qt.AlignRight` worked. `Layout.fillWidth: true` had no effect. I

D16241: [Folder View] Improve layout and formatting of Icons page

ngraham updated this revision to Diff 43712. ngraham added a comment. Improve another string REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16241?vs=43710=43712 BRANCH icons-page-tweaks (branched from master) REVISION DETAIL

D16241: [Folder View] Improve layout and formatting of Icons page

ngraham added a comment. Note: I know the `width: 500` is a horrible hack that is certainly the wrong way to do this, but I couldn't figure out how else to get the Labels' width to be long enough so that `Layout.alignment: Qt.AlignRight` worked. `Layout.fillWidth: true` had no effect. I

Re: MOday meeting notes for 15/10/2018

Sorry, missed Johnathan, with the very important announce of the kickoff meeting: 5.14 is out! * 5.14.1 tomorrow * I've been pinging people with ToDo items to get them up to date but could do with catching up with notmart and maybe others ** 5.15 kickoff Wed 17 12:00UTC, 13:00BST, 14:00CEST

D16219: [Lock Screen] Do not try to unlock when unvisible

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY In the lock screen, pressing the enter key while the UI is not yet visible ends up

D15093: Add WireGuard capability.

andersonbruce added a comment. Well for the first time since July there has been activity on network-manager-wireguard including the addition of an additional parameter supported so I am going to get going on adding it to this. Also, it looks like the pre- and post- options now do something

D15702: User can define margins for the desktop

davidedmundson added a comment. I fully understand we want something. I'm not convinced by this as-is. Code wise we already have something to make sure Containments don't overlap with hidden panels (Corona::availableScreenRect) which we override in shellcorona, I don't think we need a

MOday meeting notes for 15/10/2018

David: * I spent another day on stupid FF + wayland. I now have the buffer issue reproducible in a super simple non-kwin test. Which is progress, but not good progress. * There's some news on the bug that plasmashell apparently locks up and freezes on notifications. It seems it happens with oxygen

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.11 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.11/19/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 15 Oct 2018 09:21:54 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed:

D16219: [Lock Screen] Do not try to unlock when unvisible

thsurrel added a comment. In D16219#343399 , @filipf wrote: > The new lock screen runs the risk of adding extra steps for the user. This is one change that can help the issue because IIRC in Windows you also have a double lock screen and

D16220: Add feature to save sensor displays as images

pflynn created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pflynn requested review of this revision. REVISION SUMMARY This adds an item to the context menu in the sensor displays with an option to save them as a PNG image. Below are a few example

D16219: [Lock Screen] Do not try to unlock when unvisible

filipf added a comment. The new lock screen runs the risk of adding extra steps for the user. This is one change that can help the issue because IIRC in Windows you also have a double lock screen and pressing Enter will get you to the password prompt; I assume the users who have had

D15702: User can define margins for the desktop

mvourlakos added a comment. In D15702#343328 , @davidedmundson wrote: > Code wise we already have something to make sure Containments don't overlap with hidden panels (Corona::availableScreenRect) which we override in shellcorona, I don't

D15702: User can define margins for the desktop

mvourlakos added inline comments. INLINE COMMENTS > davidedmundson wrote in FolderView.qml:1127 > I don't understand this change? when I tested the patch there was an issue when the user was dragging an applet at the edges of the desktop and in areas that now the margins are used. This

D16224: move globaltooolbars inside the page

mart created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY hack the Page layouting in order to have 2 levels of headers this makes pagerow and layers work ways better header resizing

D16225: [ksmserver] Split startup into separate class

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Everything related to Plasma startup goes in Startup everything relating

D16219: [Lock Screen] Do not try to unlock when unvisible

abetts added a comment. In D16219#343507 , @davidedmundson wrote: > There's one in the bug report. If this is the bug referenced https://bugs.kde.org/show_bug.cgi?id=399835 There is no video there REPOSITORY R120 Plasma

D16219: [Lock Screen] Do not try to unlock when unvisible

abetts added a comment. In D16219#343511 , @thsurrel wrote: > The bug is https://bugs.kde.org/show_bug.cgi?id=395671 Thank you guys REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16219 To: thsurrel,

D16219: [Lock Screen] Do not try to unlock when unvisible

abetts added a comment. Could you please add a short video or gif showing this problem? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16219 To: thsurrel, #plasma, #vdg Cc: abetts, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16219: [Lock Screen] Do not try to unlock when unvisible

davidedmundson added a comment. There's one in the bug report. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16219 To: thsurrel, #plasma, #vdg Cc: davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16219: [Lock Screen] Do not try to unlock when unvisible

thsurrel added a comment. The bug is https://bugs.kde.org/show_bug.cgi?id=395671 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16219 To: thsurrel, #plasma, #vdg Cc: davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16225: [ksmserver] Split startup into separate class

davidedmundson updated this revision to Diff 43663. davidedmundson added a comment. Remove unused enum value in startup REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16225?vs=43658=43663 BRANCH master REVISION DETAIL

D16231: [ksmserver] Rewrite Startup

davidedmundson updated this revision to Diff 43695. davidedmundson added a comment. Update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16231?vs=43681=43695 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16231 AFFECTED FILES

D16231: [ksmserver] Rewrite Startup

davidedmundson marked an inline comment as done. davidedmundson added inline comments. INLINE COMMENTS > anthonyfieroni wrote in startup.cpp:194 > Can we delay it to finishStartup? Probably, but for now I'm trying to be as close to 1:1 with the old code. Long term plan ideally I want these

D16241: [Folder View] Improve layout and formatting of Icons page

ngraham created this revision. ngraham added reviewers: Plasma, VDG, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Improve the layout and formatting of the Icons page to follow