D17773: Copy to Clipboard in English

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Add a new button to copy to clipboard in English for usage in bug report. This doesn't affect existing copy button which copy

D17704: Copy to clipboard always copy English texts

guoyunhe added a comment. Here is another solution. https://phabricator.kde.org/D17773 Don't affect current button but add a new one. Since here are only two buttons and enough space, I didn't use dropdown or split button. REPOSITORY R102 KInfoCenter REVISION DETAIL

D17682: Show unconnected displays at the right side of the main screen

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Sorry for the delay, I did not notice the review. Looks good. INLINE COMMENTS > qmlscreen.cpp:178 > { > -return 1.0 / 8.0; > +return 1.0 / 12.0; > } Maybe the scale could

D17704: Copy to clipboard always copy English texts

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better. This seems sensible to me. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D17704 To: guoyunhe, #plasma, ngraham Cc: ngraham,

D17773: Copy to Clipboard in English

guoyunhe updated this revision to Diff 48124. guoyunhe edited the summary of this revision. guoyunhe added a comment. Hide the "Copy to Clipboard in English" button when the system is already in English. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D6056: [Run Command] Auto-close on focus loss only if query field is empty

ngraham accepted this revision. ngraham added a comment. This works great for me and fixes an annoying bug. Can we get it landed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson, ngraham Cc: ngraham, cfeck,

D17154: Go back to SCSS

ngraham added inline comments. INLINE COMMENTS > CMakeLists.txt:12 > find_package(GTKEngine) > +find_package(Sass) > +find_package(Python3 REQUIRED) Shouldn't this be required since you can't build the theme without it? > CMakeLists.txt:13 > +find_package(Sass) > +find_package(Python3

D17154: Go back to SCSS

bcooksley added a comment. Thanks @ngraham. I've now scheduled the addition of `scss` into the images with 63d16727883e9c9f9d09bdd2bc7163fb386c0a57 REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D6056: [Run Command] Auto-close on focus loss only if query field is empty

shubham added a comment. Year and half old patch, lucky it got noticed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson, ngraham Cc: shubham, ngraham, cfeck, anthonyfieroni, plasma-devel, GB_2, ragreen,

D17780: Add Plasma wallpapers

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Add some of the best-looking Plasma wallpapers to this package so that users and distros

D17773: Copy to Clipboard in English

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better. This seems sensible to me. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D17773 To: guoyunhe, #plasma, ngraham Cc: ngraham,

D17704: Copy to clipboard always copy English texts

ngraham resigned from this revision. ngraham added a comment. This revision now requires review to proceed. Oops, approved the wrong patch. Meant to approve D17773 . REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D17704 To:

D17154: Go back to SCSS

gepardo updated this revision to Diff 48145. gepardo added a comment. Make Sass a required dependency REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17154?vs=48031=48145 BRANCH breeze-gtk-sass (branched from master) REVISION DETAIL

D17154: Go back to SCSS

gepardo marked 2 inline comments as done. gepardo added inline comments. INLINE COMMENTS > ngraham wrote in CMakeLists.txt:13 > This doesn't seem like the correct way to require Python 3: > > dev@dev-pc:~/repos/breeze-gtk$ (arcpatch-D17154) cmake > -DCMAKE_INSTALL_PREFIX=/usr > -- Could

D17154: Go back to SCSS

gepardo updated this revision to Diff 48148. gepardo marked an inline comment as done. gepardo added a comment. Fix finding Python package for CMake <3.12 REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17154?vs=48145=48148 BRANCH breeze-gtk-sass

D17154: Go back to SCSS

ngraham added a subscriber: Sysadmin. ngraham added a comment. Thanks much better. Now it can find Python 3 with CMake version < 3.12, and Sass is a required dependency. I believe #sysadmin has asked to be notified of all new required

D17784: Don't ignore default virtual devices

sharhalakis created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sharhalakis requested review of this revision. REVISION SUMMARY Ignoring virtual PA devices for volume control results in ignoring the "Simultaneous output" devices. This makes it

D17154: Go back to SCSS

gepardo added a comment. Oops, sorry, I forgot to check the installation. GTK+ 3.18 did built, but it was built into `gtk-3.0` directory (the build scripts in the old repo seem to do so). But `CMakeLists.txt` remained unchanged. I noticed that recent versions install `gtk-3.18` and

D17154: Go back to SCSS

gepardo updated this revision to Diff 48153. gepardo added a comment. Fix GTK+ 3.18 theme installation REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17154?vs=48148=48153 BRANCH breeze-gtk-sass (branched from master) REVISION DETAIL

D17773: Copy to Clipboard in English

This revision was automatically updated to reflect the committed changes. Closed by commit R102:937e9c72fe94: Copy to Clipboard in English (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17773?vs=48124=48154

D17785: Update logic for disabling the PCI module.

adridg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. adridg requested review of this revision. REVISION SUMMARY FreeBSD on ThunderX2 does support PCI, and apparently the KCM even works. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234256

D17154: Go back to SCSS

gepardo updated this revision to Diff 48156. gepardo added a comment. Add gtk-dark.css support for Breeze REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17154?vs=48153=48156 BRANCH breeze-gtk-sass (branched from master) REVISION DETAIL