D19203: ColumnView and partial C++ refactor of PageRow

mart updated this revision to Diff 52799. mart added a comment. - a bit more drag distance to be sure not to conflict with horizontal - preventStealing attached property - hide items when removed - fix item position mapping - signal the visible items when forgetting one - update

D19417: Panel icon & layout change of webbrowser applet

iostapenko created this revision. iostapenko added a reviewer: ematirov. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. iostapenko requested review of this revision. REVISION SUMMARY If you add an applet not to the desktop, but to the panel, then the old icon is out

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Huge improvement. Don't forget to change the preview images in `lookandfeel/contents/previews/` though! Also this fixes https://bugs.kde.org/show_bug.cgi?id=398963.

D19392: shannon entropy to guess monochrome icon

ngraham added subscribers: VDG, ndavis, GB_2, ngraham. ngraham added a comment. In D19392#421900 , @mart wrote: > In D19392#421881 , @davidedmundson wrote: > > > > so, we colorize monochrome icons

D19044: [InlineMessage] Do not draw shadows around the message

mart added a comment. In D19044#419934 , @filipf wrote: > In D19044#416559 , @mart wrote: > > > - whole InlineMessage should be moved into templates > > > Im not home right now but I ran into

D19203: ColumnView and partial C++ refactor of PageRow

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Works fine with KDE Connect REPOSITORY R169 Kirigami BRANCH mart/columnsView REVISION DETAIL https://phabricator.kde.org/D19203 To: mart, #kirigami, nicolasfella Cc:

D19415: warning--

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY use nullptr and override as appropriate TEST PLAN no more warnings REPOSITORY R871 DrKonqi

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

davidedmundson added a comment. Looks readable. No objections from me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19409 To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

Re: Plasma Sprint 2019 in València

Possibly relevant, Paul from Promo has just suggested going to OpenExpo which is 1 day in Madrid on Thu 20 June https://openexpoeurope.com/ There may be an opportunity for someone to take a day out the sprint to go there.https://marc.info/?l=kde-promo=155134572312174=2 Jonathan

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

rooty added a comment. In D19409#421790 , @davidedmundson wrote: > The relevant preview we need to do is see how the blur looks over a near completely black and a near completely white image. Nearly entirely but not entirely

D19392: shannon entropy to guess monochrome icon

mart added a comment. In D19392#421881 , @davidedmundson wrote: > > so, we colorize monochrome icons treating them as just masks, and that works ok, tough there isn't any spec to know with 100% certainty if an icon is monochrome or colored

D19312: Add tooltip for quick search

ngraham added a comment. In D19312#421632 , @simgunz wrote: > I never landed a diff before because I just got my KDE developer account. > Few general questions: > > - Is it enough that one reviewer accept the revision, or all the listed

D19392: shannon entropy to guess monochrome icon

mart added a comment. In D19392#421903 , @ngraham wrote: > Actually we're discussing in VDG-land whether or not this is something we should do anyway, because right now we have no way of forcing the use of a monochrome icon for a >22px size

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

davidedmundson added a comment. The relevant preview we need to do is see how the blur looks over a near completely black and a near completely white image. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19409 To: rooty, #vdg, ngraham, #plasma,

D19415: warning--

This revision was automatically updated to reflect the committed changes. Closed by commit R871:280dd67b3f7f: warning-- (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19415?vs=52815=52816 REVISION DETAIL

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

rooty added a comment. How's this - dark: F6644939: image.png and F6644942: image.png - bright: F6644947: image.png and F6644949: image.png

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

filipf added a comment. In D19409#421832 , @rooty wrote: > In D19409#421790 , @davidedmundson wrote: > > > The relevant preview we need to do is see how the blur looks over a near completely black

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

tagorechandanreddy created this revision. tagorechandanreddy added reviewers: ngraham, davidedmundson. tagorechandanreddy added a project: Plasma. tagorechandanreddy requested review of this revision. REVISION SUMMARY 'Image of the day' has a new landing page everyday. This patch fixes the

D19203: ColumnView and partial C++ refactor of PageRow

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c0f2a341a4c9: ColumnView and partial C++ refactor of PageRow (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19203?vs=52799=52803 REVISION

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ndavis added a comment. In D19230#421924 , @ngraham wrote: > I mean, what do you think about the specific string "Use region's default setting". Too wordy? Just right? You could use use "Default" and maybe have a button to open the

D19423: Fix QLatin1String usage

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D19392: shannon entropy to guess monochrome icon

mart added a comment. In D19392#421950 , @davidedmundson wrote: > > The problem with using -symbolic for all monochrome icons is that we'd have to create color icons without -symbolic to replace the old monochrome icons without -symbolic. >

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ngraham added a comment. I mean, what do you think about the specific string "Use region's default setting". Too wordy? Just right? REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master) REVISION DETAIL

D19392: shannon entropy to guess monochrome icon

davidedmundson added a comment. > The problem with using -symbolic for all monochrome icons is that we'd have to create color icons without -symbolic to replace the old monochrome icons without -symbolic. Why would breeze need two versions? If an app requests -symbolic you get a

Re: Plasma Sprint 2019 in València

On Thu, Feb 28, 2019 at 8:47 AM Kai Uwe Broulik wrote: > > Hi, > > > Sounds like we have some critical mass, Alejandro tells me that > > there's space so let's settle for the 23rd June week. > > Is Wednesday, 19 Arrival day and Sunday, 23 Departure day, or actual > sprint days? I'd say they can

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

rooty added a comment. In D19409#421894 , @ngraham wrote: > Huge improvement. Don't forget to change the preview images in `lookandfeel/contents/previews/` though! > > Also this fixes https://bugs.kde.org/show_bug.cgi?id=398963. Sure

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

ngraham added a comment. `5.16.0` since this will be landing in master. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19409 To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19417: Panel icon & layout change of webbrowser applet

broulik added a comment. What icon theme do you use? Here the icon is fine. The size change is fine, though. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D19417 To: iostapenko, ematirov, #plasma, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19417: Panel icon & layout change of webbrowser applet

iostapenko added a comment. Breeze Before F6645362: Screenshot_20190228_185635.png After F6645364: Screenshot_20190228_184954.png REPOSITORY R114 Plasma Addons REVISION DETAIL

D19392: shannon entropy to guess monochrome icon

ndavis added a comment. In D19392#421903 , @ngraham wrote: > Actually we're discussing in VDG-land whether or not this is something we should do anyway, because right now we have no way of forcing the use of a monochrome icon for a >22px size

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

totte added a comment. What about "Use region default", if it is to replace "Use locale default"? REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master) REVISION DETAIL https://phabricator.kde.org/D19230 To: ngraham, #plasma, Zren,

D19077: Redesign the theme preview window

filipf added a subscriber: mart. filipf added a comment. @mart could you help us out a bit please? I used code with "Kirigami.Theme.viewBackgroundColor.r", which throws out a warning that the value is deprecated. The one suggested for replacement (Theme.View) isn't the same as the

D19392: shannon entropy to guess monochrome icon

mart updated this revision to Diff 52845. mart added a comment. - Merge branch 'master' into mart/iconentropyheuristic - adress some style comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19392?vs=52750=52845 BRANCH mart/iconentropyheuristic

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ngraham updated this revision to Diff 52847. ngraham added a comment. - Change string to "Use Region Defaults" - Add a button that opens the Formats KCM REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19230?vs=52329=52847 BRANCH

D19392: shannon entropy to guess monochrome icon

mart added a comment. In D19392#421923 , @ndavis wrote: > In D19392#421903 , @ngraham wrote: > > > Actually we're discussing in VDG-land whether or not this is something we should do anyway,

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. Didn't like my latest string suggestions? Trust this Device / Revoke Trust REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts,

D19340: Search new knsrc locations

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Submit when kns is ready. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19340 To: leinir, #discover_software_store, apol, ngraham Cc: plasma-devel,

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ngraham added a comment. All good now? REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master) REVISION DETAIL https://phabricator.kde.org/D19230 To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis Cc: totte, ndavis, abetts,

D19392: shannon entropy to guess monochrome icon

davidedmundson added a comment. > so, we colorize monochrome icons treating them as just masks, and that works ok, tough there isn't any spec to know with 100% certainty if an icon is monochrome or colored (all icon names that end up with -symbolys usually are monochrome, but in breeze and

GSOC 2019

GSOC is coming. There are currently 2 plasma proposal on https://community.kde.org/GSoC/2019/Ideas both in kwin. Plasma traditionally has had some great GSOC projects. We should get a few more ideas up. Also if there are any active uni students on this list who are interested in GSOC and you're

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ndavis added a comment. Can you hide the button to open the Formats KCM when "Use Region Defaults" is not selected? REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master) REVISION DETAIL https://phabricator.kde.org/D19230 To: ngraham,

D19399: SwipeListItem: make space for the actions when !supportsMouseEvents

This revision was automatically updated to reflect the committed changes. Closed by commit R169:cd5bae6d3df0: SwipeListItem: make space for the actions when !supportsMouseEvents (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

cfeck added a comment. Disabling is preferred to hiding. If there is a widget, but not enabled, you are eager to learn how to enable it. If you hide it, you won't even know it exists. REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master)

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ngraham added a comment. In D19230#422118 , @cfeck wrote: > Disabling is preferred to hiding. If there is a widget, but not enabled, you are eager to learn how to enable it. If you hide it, you won't even know it exists. Right. My point

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ndavis accepted this revision. ndavis added a comment. I think so REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master) REVISION DETAIL https://phabricator.kde.org/D19230 To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis Cc:

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ngraham added a comment. We could, but is that really necessary? In general we try to avoid having UI elements dynamically show and hide themselves outside of the narrowly-defined exception of when a UI element is inapplicable to the currently active hardware. That condition doesn't apply

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ndavis added a comment. In D19230#422088 , @ngraham wrote: > We could, but is that really necessary? In general we try to avoid having UI elements dynamically show and hide themselves outside of the narrowly-defined exception of when a UI

[Powerdevil] [Bug 367648] Dim Screen time in Energy Saving Settings is wrong

https://bugs.kde.org/show_bug.cgi?id=367648 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com --- Comment #2 from

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

This revision was automatically updated to reflect the committed changes. Closed by commit R120:74f0f2594655: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

Zren added inline comments. INLINE COMMENTS > configAppearance.qml:137 > +icon.name: "preferences-desktop-locale" > +onClicked: KCMShell.open("formats.desktop") > +} Was afk today sorry. Do we need `visible:

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

rooty added a comment. Should we keep the UserDelegate.qml shadow then? Because it doesn't seem necessary considering the blur's here to stay. P.S. What happens to the blur if sddm defaults to software rendering? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19325: [sddm-theme/lock screen] Tighten clock and username shadows

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2286c89b9e31: [sddm-theme/lock screen] Tighten clock and username shadows (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19433: [sddm-theme/lock screen] Increase username and action button font size

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I'm hugely in favor of increasing the font size by using Headings here. The current tiny text is difficult to read and there is no advantage to using small text on something

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

ngraham added a comment. In D19409#422203 , @rooty wrote: > Should we keep the UserDelegate.qml shadow then? Because it doesn't seem necessary considering the blur's here to stay. > > P.S. What happens to the blur if sddm defaults to

D19435: Remove redundant parameter fields

andersonbruce created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. andersonbruce requested review of this revision. REVISION SUMMARY BUG: 403547 Remove entry of parameters which are specific to the wg-quick

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

ngraham added a comment. 1996?  Also the lock screen has a preview image too: `plasma-workspace/lookandfeel/contents/previews/lockscreen.png` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19409 To: rooty, #vdg, ngraham, #plasma, davidedmundson,

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

rooty updated this revision to Diff 52872. rooty added a comment. Add second user (Katie) to preview REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19409?vs=52871=52872 BRANCH adjust-blur (branched from master) REVISION DETAIL

D19433: [sddm-theme/lock screen] Increase username and action button font size

rooty updated this revision to Diff 52874. rooty added a comment. Bring back comment deleted by accident REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19433?vs=52873=52874 BRANCH bump-up-label-fonts (branched from master) REVISION DETAIL

D19434: Change entry of Endpoint UI

andersonbruce created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. andersonbruce requested review of this revision. REVISION SUMMARY BUG: 403548 Entry of the Endpoint was originally done in only one LineEdit

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

rooty updated this revision to Diff 52871. rooty added a comment. Update preview image REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19409?vs=52792=52871 BRANCH adjust-blur (branched from master) REVISION DETAIL

D19433: [sddm-theme/lock screen] Increase username and action button font size

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch increases the font size of the username and action button labels for better readability. REPOSITORY R120 Plasma

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

rooty added a comment. In D19409#422264 , @ngraham wrote: > 1996?  https://kde.org/announcements/announcement.php It seemed preferable to some random date Didn't know about the lock screen preview image... interesting > TBH I

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg Cc: broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty,

D19392: shannon entropy to guess monochrome icon

mart added inline comments. INLINE COMMENTS > cfeck wrote in desktopicon.cpp:545 > You are caching the result per size, but the initial decision depends on the > actual icon image, right? Is it possible that the first icon examined is > colorful, but the rest is not, or vice versa? If yes,

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre updated this revision to Diff 52797. davidre added a comment. Add addDirs method - reload really reloads now To correctly handle cases when there are parent and child directories added to the slide paths the reload methods really reloads now before it added only images. As a