D19011: Thunderbolt KCM and KDED module

ngraham added a comment. `plasma-thunderbolt` sounds fine to me FWIW. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham,

D21056: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham updated this revision to Diff 57692. ngraham marked 3 inline comments as done. ngraham added a comment. - Fix Units typo - Just put everything in one FormLayout; it's simpler REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D21056: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

filipf added inline comments. INLINE COMMENTS > ColorSettings.qml:45 > + > +Kirigami.FormLayout { > +anchors.left: parent.left To better align the checkbox in this layout with the other layout you can set `twinFormLayouts` so the first one points to the second one and get:

D21026: Fix ToolButton remaining in a pressed state after press

ngraham accepted this revision. ngraham added a comment. Nice little papercut fix! REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH no-highlight-color-after-press (branched from master) REVISION DETAIL https://phabricator.kde.org/D21026 To: filipf, mart, #plasma, ngraham,

D20797: [dict] Modernize configuration window

ngraham accepted this revision. ngraham added subscribers: broulik, mart. ngraham added a comment. This revision is now accepted and ready to land. @broulik or @mart, any idea how we get Keyboard navigation working here? The Tab key just goes straight to the buttons and ignores the dictionary

D21056: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham added a comment. Skeleton of a QQC2 SpinBox implementation: P381 The number in the box wasn't mouse-selectable and I wasn't able to get the suffix working properly. In the end I opted to stay with the QQC1 version for now. REPOSITORY R114

D21056: [System Monitor] [Timer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style, except for the SpinBox which cannot handle decimal

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 57680. filipf added a comment. Kirigami.Theme.viewBackgroundColor is deprecated so set the colorSet to Theme.View instead REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=57255=57680 BRANCH master

D21049: [wizard] Enable 1-finger touch scrolling

ngraham added a comment. In D21049#461799 , @apol wrote: > Would it maybe be possible to find a more generic way to tackle this? Maybe at Breeze or KStyle level, this is an issue on every QListView :(. +1, that would be super awesome if

D21030: [WidgetExplorer] Fix blurry previews

filipf added a comment. In D21030#461696 , @ngraham wrote: > Looks like you cherry-picked the commit onto each branch, is that right? In general it's preferred to land the commit onto the oldest branch and then merge forward. See

D21049: [wizard] Enable 1-finger touch scrolling

apol added a comment. Would it maybe be possible to find a more generic way to tackle this? Maybe at Breeze or KStyle level, this is an issue on every QListView :(. Also this will be needed on different kind of devices, would it make sense to consider porting this to QQC2? REPOSITORY

D20867: Add Property to disable drawing of menu arrow indicators

hallas added a comment. In D20867#461499 , @mart wrote: > In D20867#457580 , @hallas wrote: > > > In D20867#457575 , @davidedmundson wrote: > > > > >

D21049: [wizard] Enable 1-finger touch scrolling

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Set a QScroller on the ListView TEST PLAN Scrolling with touchpad: No

D16997: [kcm] Expose interface to control output property retention

romangg planned changes to this revision. romangg added a comment. Changes still need to go back in other diffs in the series. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D16997 To: romangg, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D16997: [kcm] Expose interface to control output property retention

romangg updated this revision to Diff 57671. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16997?vs=45768=57671 BRANCH 1controlKcm REVISION DETAIL https://phabricator.kde.org/D16997 AFFECTED FILES

D16996: Add method to write retention to configuration control files

romangg updated this revision to Diff 57670. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16996?vs=45767=57670 BRANCH 1controlWrite REVISION DETAIL https://phabricator.kde.org/D16996 AFFECTED

D16995: Consider identical display models in ControlConfig

romangg updated this revision to Diff 57667. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16995?vs=45766=57667 BRANCH 1controlNameSpecific REVISION DETAIL https://phabricator.kde.org/D16995

D20871: Don't delete profiles and ports on update

This revision was automatically updated to reflect the committed changes. Closed by commit R994:1c30a34ba622: Dont delete profiles and ports on update (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20871?vs=57110=57666#toc REPOSITORY R994 Pulseaudio Qt

D16994: Split Control class into configurations and outputs control classes

romangg updated this revision to Diff 57665. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16994?vs=45764=57665 BRANCH 1controlClass REVISION DETAIL https://phabricator.kde.org/D16994 AFFECTED

D16992: Introduce secondary control channel of the KScreen daemon

romangg updated this revision to Diff 57662. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16992?vs=45762=57662 BRANCH 1controlRetention REVISION DETAIL https://phabricator.kde.org/D16992 AFFECTED

D16993: Add a common directory for functionality being used by kcm and daemon

romangg updated this revision to Diff 57663. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16993?vs=45763=57663 BRANCH 1commonInterfacesWithClass REVISION DETAIL https://phabricator.kde.org/D16993

D16991: Introduce concept of global and individual output data retention

romangg updated this revision to Diff 57661. romangg added a comment. Rebase on master. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16991?vs=45760=57661 BRANCH 1dirIndividualOutputs REVISION DETAIL https://phabricator.kde.org/D16991 AFFECTED

D16990: [kded] Change configuration storage path

romangg updated this revision to Diff 57660. romangg added a comment. - Fix rebase error REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16990?vs=57659=57660 BRANCH 1configsLocation REVISION DETAIL https://phabricator.kde.org/D16990 AFFECTED FILES

D16990: [kded] Change configuration storage path

romangg updated this revision to Diff 57659. romangg added a comment. - Rebase on master. - Prepare changing the configuration path for KDE6. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16990?vs=45758=57659 BRANCH 1configsLocation REVISION DETAIL

D21030: [WidgetExplorer] Fix blurry previews

ngraham added a comment. Looks like you cherry-picked the commit onto each branch, is that right? In general it's preferred to land the commit onto the oldest branch and then merge forward. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 I

D16989: [kded] Introduce Config wrapper class

romangg updated this revision to Diff 57655. romangg added a comment. Rebase on master. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16989?vs=45756=57655 BRANCH 1configClass REVISION DETAIL https://phabricator.kde.org/D16989 AFFECTED FILES

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/30/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 06 May 2019 15:37:47 + Build duration: 34 sec and counting CONSOLE OUTPUT [...truncated 372

D21048: There's no virtual sources, just source outputs

This revision was automatically updated to reflect the committed changes. Closed by commit R115:cde3ecde25c7: [Microphone Indicator] Theres no virtual sources, just source outputs (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D21047: [Microphone Indicator] Schedule update initially

This revision was automatically updated to reflect the committed changes. Closed by commit R115:2225ea1570f2: [Microphone Indicator] Schedule update initially (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D20576: Add new notifications KCM

broulik updated this revision to Diff 57652. broulik added a comment. - Load source model only on sources page but do so immediately there when needed - Don't set width inside layout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20871: Don't delete profiles and ports on update

drosca accepted this revision. drosca added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > card.cpp:78 > +const QList profileKeys = m_profiles.keys(); > +for (const QString& profileKey : profileKeys) { > +if (!newProfiles.contains(profileKey))

D21029: UpdatesPage: Don't try to translate version numbers

ngraham added a comment. In D21029#461379 , @apol wrote: > Yep, change isn't correct. A solution would be to ad an installedVersion && availableVersion ? i18n(...) : "". +1 REPOSITORY R134 Discover Software Store REVISION DETAIL

D20871: Don't delete profiles and ports on update

nicolasfella added a comment. @drosca Does this look good to you? REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D20871 To: nicolasfella, drosca Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D21048: There's no virtual sources, just source outputs

broulik created this revision. broulik added reviewers: Plasma, drosca, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Still get microphone indicator. Not tested this "virtual" thing for a lack of

D21030: [WidgetExplorer] Fix blurry previews

This revision was automatically updated to reflect the committed changes. Closed by commit R119:29f0bea89889: [WidgetExplorer] Fix blurry previews (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21030?vs=57617=57650 REVISION

D21047: [Microphone Indicator] Schedule update initially

broulik created this revision. broulik added reviewers: Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Catches recording streams running before plasma started. TEST PLAN Ran `arecord`,

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. In D20908#461487 , @mart wrote: > from the screenshots, i like it a lot,the code seems clean enough. > > However, to continue with that i think some attempt should be done to make qwidget based apps follow this as

D21013: [PanelView] remove outdated hack to support mask without compositing

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1f37ba3b81f2: [PanelView] remove outdated hack to support mask without compositing (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D20908: RFC: Redesign QML applet configuration windows

abetts added a comment. Love it! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plasma, ngraham, abetts Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D20265: Introduce libnotificationmanager

broulik updated this revision to Diff 57643. broulik added a comment. - Update patch to include changes in repo, 4269a3b407f339a60b0ccee017278650d2681352 and 86260aba9a49adeb1f02c0ce108752ba42d8f811

D21030: [WidgetExplorer] Fix blurry previews

ngraham added a comment. I was thinking 5.15 only, but 5.12 too is probably fine for a focused change like this. https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 REPOSITORY R119 Plasma Desktop BRANCH no-blurry-previews-widget-explorer

D21030: [WidgetExplorer] Fix blurry previews

filipf added a comment. In D21030#461363 , @ngraham wrote: > Nice! Stable branch please. So both 5.12 and 5.15? REPOSITORY R119 Plasma Desktop BRANCH no-blurry-previews-widget-explorer (branched from master) REVISION DETAIL

D20265: Introduce libnotificationmanager

broulik marked 8 inline comments as done. broulik added inline comments. INLINE COMMENTS > hein wrote in notifications.cpp:76 > Have you considered using `KModelIndexProxyMapper` from KF5::ItemModels? I have, it doesn't work for this usecase. It can only map a tree via a single model, we have

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > job.cpp:30 > + > +#include > + Unused? > notificationgroupcollapsingproxymodel.cpp:194 > +{ > +if (source_parent.isValid() && m_limit > 0) { > +if (!m_expandedGroups.isEmpty() && > m_expandedGroups.contains(source_parent)) { Check

D20908: RFC: Redesign QML applet configuration windows

mart added a comment. that's a veeery quick and dirty attempt: (so hacky that there is not really usable code i'm afraid) F6811626: Screenshot_20190506_123026.png apart the lack of right margin, that should be easily fixable, the worst parts

monday meeting notes for 6/5/2019

Kai Uwe: Work done: - Added DesktopEntry to various application notifyrc files so they can be identified as apps by the new KCM -- kget, discover, kdevelop - Merged KWin patches for critical notifications (show on top of fullscreen windows) - plasma-browser-integration: -- Handles "muted"

D18394: Add OTP support for openconnect VPN

This revision was automatically updated to reflect the committed changes. Closed by commit R116:8fb5c6192c15: Add OTP support for openconnect VPN (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18394?vs=57394=57634#toc REPOSITORY R116 Plasma Network Management

D20576: Add new notifications KCM

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in SourcesPage.qml:60 > Can you talk me through all this: > > We have a listview with a filtered model with a selected item > We change the filter > > As long as the proxies are working correctly and track a movement as a >

D20576: Add new notifications KCM

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in ApplicationConfiguration.qml:103 > you shouldn't specify a width inside a layout. implicitWidth or Layout.preferredWidth REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik,

D21038: Also store the player's frame ID

broulik updated this revision to Diff 57633. broulik added a comment. - Don't mutate while iterating REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21038?vs=57613=57633 REVISION DETAIL https://phabricator.kde.org/D21038 AFFECTED

D20867: Add Property to disable drawing of menu arrow indicators

mart added a comment. In D20867#457580 , @hallas wrote: > In D20867#457575 , @davidedmundson wrote: > > > QToolButton::setArrowType? > > > I just tried that, but it doesn't seem like Breeze

D20908: RFC: Redesign QML applet configuration windows

mart added a comment. In D20908#458426 , @broulik wrote: > I was wondering, wouldn't it also make sense to change the layout to be Icon left of text to make it even more consistent with System Settings? Or will that eat too much horizontal

D20908: RFC: Redesign QML applet configuration windows

mart added a comment. from the screenshots, i like it a lot,the code seems clean enough. However, to continue with that i think some attempt should be done to make qwidget based apps follow this as well. (I think we should go on a campaign to remove unnecessary frames here too)

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/29/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 06 May 2019 08:48:31 + Build duration: 38 sec and counting CONSOLE OUTPUT [...truncated 372

D21045: Don't play sound when muting

This revision was automatically updated to reflect the committed changes. Closed by commit R115:ada2f9c75019: Dont play sound when muting (authored by nicolasfella). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21045?vs=57631=57632

D21045: Don't play sound when muting

nicolasfella created this revision. nicolasfella added a reviewer: drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY When the user presses the mute key to mute the sound they explicitely don't want

D21044: Remove kde connect context menu entries when host dies

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY They don't work without a host and up on (re)starting we get a `deviceAdded` signal for

D20925: Also handle muted property on player

This revision was automatically updated to reflect the committed changes. Closed by commit R856:1ce07b1cec31: Also handle muted property on player (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20925?vs=57286=57627

[Powerdevil] [Bug 348529] Turn off screen after lock screen

https://bugs.kde.org/show_bug.cgi?id=348529 Kai Uwe Broulik changed: What|Removed |Added CC||brai1...@gmail.com --- Comment #29 from Kai