D22087: Build without foreach

apol added a comment. +1 overall INLINE COMMENTS > powermanagementengine.cpp:442 > uint unnamedBatteries = 0; > -foreach (QString source, m_batterySources) { > +for (QString source : qAsConst(m_batterySources)) { > DataContainer *batteryDataContainer =

D22774: Add a button to the notes applet to clear formatting

luc4 added a comment. I'll try to implement that behavior then. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22774 To: luc4, davidedmundson, #plasma Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D22774: Add a button to the notes applet to clear formatting

ngraham added a comment. I'd be in favor of making the paste action always paste unformatted text, and then add a second menu item to paste with preserved formatting. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22774 To: luc4, davidedmundson, #plasma Cc:

D22783: Fix ambiguous "Current" label in energy information

aspotashev added a comment. FYI, in Russian we translate this as "Current charge" ("Текущий заряд"), where "заряд/charge" might also be confused with electic charge measured in coulomb or statC, but - the user-visible unit Wh disambiguates, - I believe, most people forget about

D22494: Attempt to support different collections of Unsplash

guoyunhe added inline comments. INLINE COMMENTS > ngraham wrote in potdprovider.cpp:54 > The lack of error handling and else blocks for all the ifs in this new code > makes me feel a bit nervous. `date` is optional, so if it not found, just leave it as undefined. I can add some detection to

D22774: Add a button to the notes applet to clear formatting

luc4 created this revision. luc4 added reviewers: davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. luc4 requested review of this revision. REVISION SUMMARY It frequently happens to me that formatting is preserved when pasting into the note,

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 62636. guoyunhe added a comment. - Unsplash category combobox REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=62551=62636 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494 AFFECTED

D22494: Attempt to support different collections of Unsplash

guoyunhe added inline comments. INLINE COMMENTS > ngraham wrote in potdprovider.cpp:54 > The lack of error handling and else blocks for all the ifs in this new code > makes me feel a bit nervous. Read Qt documentation that `QVariant::toString()` will always return a string even if the type is

D22778: [WIP] Restore option to create a Qt Designer plugin

kossebau created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Had been missing out the port to Qt5/KF5 so far Using ECMAddQtDesignerPlugin reduces added dependencies to QtUIPlugin Option

D22762: Take in consideration flat() for the All Applications menu

hein added a comment. You got a point, but there's a higher-level thing with the Kicker backend in terms of where it came from and where it's going: - Originally it was created specifically for the Kicker menu with the backend custom-designed to that UI. AppsModel is fairly generic

D22087: Build without foreach

nicolasfella added a comment. Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22087 To: nicolasfella, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,

D22748: whitelist the "turn off screen" shortcut on the lock screen

This revision was automatically updated to reflect the committed changes. Closed by commit R133:5ed0dc17f3f9: Allow the turn off screen to be used from the lockscreen (authored by mblumenstingl). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 62638. guoyunhe marked an inline comment as done. guoyunhe added a comment. - Unsplash category combobox REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=62636=62638 BRANCH master REVISION DETAIL

D22762: Take in consideration flat() for the All Applications menu

hein added a comment. FYI, as maintainer of Kicker, I've reverted this commit in master until this review request is updated with additional info on what it's useful for. Please don't move patches through in <15 minutes without people having a chance to weigh in. REPOSITORY R119 Plasma

D22762: Take in consideration flat() for the All Applications menu

davidedmundson added a comment. Rootmodel inherits appmodel. Appmodel has a property flat. Therefore this does It wasnt supported returning a non flat tree. I do normally wait for maintainers on any new features or big changes, but this seems like a straightforward bug fix?

D22778: [WIP] Restore option to create a Qt Designer plugin

kossebau updated this revision to Diff 62646. kossebau added a comment. also port the other two plugins REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22778?vs=62645=62646 BRANCH readdoptiontogeneratedesignerplugin REVISION DETAIL

D22774: Add a button to the notes applet to clear formatting

ngraham added a comment. The use of a broom-style clear button suggests to me that it will clear everything, not just formatting. I think we either need a new/better icon, or else to give the button some explanatory text. Also, it might be helpful to take a step back and look at the

D22783: Fix ambiguous "Current" label in energy information

aloisw created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aloisw requested review of this revision. REVISION SUMMARY Replace the label text with "Current energy", to prevent confusion with electric current. BUG: 410033 REPOSITORY R102

D22494: Attempt to support different collections of Unsplash

This revision was automatically updated to reflect the committed changes. Closed by commit R114:fe8c40dc3b9a: Attempt to support different collections of Unsplash (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure added a comment. See KFileItem::isSlow() REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19784 To: hoffmannrobert, #frameworks, dfaure, #dolphin Cc: meven, apol, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22783: Fix ambiguous "Current" label in energy information

aloisw added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:66 > How about "Remaining power" ? With "power" I would associate the consumption. What about "Remaining energy"? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D22783 To: aloisw, #plasma,

D22774: Add a button to the notes applet to clear formatting

luc4 added a comment. Yes, I couldn't find a better icon so I temporarily used this. All the options you proposed are perfectly fine for me. I personally find the button sufficient but if you decide for something else I can try to update my patch. Thanks! REPOSITORY R114 Plasma

D22783: Fix ambiguous "Current" label in energy information

ngraham added reviewers: Plasma, VDG, broulik. ngraham added a comment. Thanks for the patch! And nice job using `arc` to submit it. INLINE COMMENTS > main.qml:66 > {label: i18n("Capacity"), value: "capacity", unit: > i18n("%"), precision: 0}, > -{label:

D22783: Fix ambiguous "Current" label in energy information

ngraham added inline comments. INLINE COMMENTS > aloisw wrote in main.qml:66 > With "power" I would associate the consumption. What about "Remaining energy"? That's fine too, but in this context, the words "power" and "energy" mean pretty much the same things in English, and you can always add

D19784: Avoid calling QT_LSTAT and accessing recent documents

meven added a comment. In D19784#503066 , @dfaure wrote: > See KFileItem::isSlow() Interesting but the initial issue happened when a drive is not mounted and isSlow implementation uses statfs that gives information about ... mounted

D17464: [Timer applet] Minor fixes for the applet

gepardo updated this revision to Diff 62660. gepardo added a comment. Updating D17464 : [Timer applet] Minor fixes for the applet Change clock size ratio to 0.84 for better compatibility with Clock's font size REPOSITORY R114 Plasma Addons CHANGES

D17464: [Timer applet] Minor fixes for the applet

gepardo marked an inline comment as done. gepardo added a comment. After some experiments, I finally set clock size to 0.84: F7107969: clock.png The main problem is that the clock widget uses a real font, but the timer uses SVGs to render