D23112: Add a event Spy for GtkFileChooser recent files

broulik added inline comments. INLINE COMMENTS > GtkEventSpy.cpp:135 > +// See > https://techbase.kde.org/Development/Tutorials/Services/Traders#The_KTrader_Query_Language > +QString query = QString("exist Exec and ((Exec ~~ '%1') or (exist > GenericName and '%1' ~~

D21113: Allow hiding option items depending on available extension and version in the host

broulik updated this revision to Diff 63702. broulik added a comment. - use new promise-based reply message API REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21113?vs=57840=63702 REVISION DETAIL https://phabricator.kde.org/D21113

D23130: [energy kcm] Remove bogus Has power supply property from UI

broulik added a comment. That property is whether the selected battery powers the computer or is just a peripheral. Perhaps just the label must be changed? REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D23130 To: meven, broulik, ngraham Cc:

D23151: Implement Web Share API through Purpose

broulik created this revision. broulik added reviewers: Plasma, fvogt, davidedmundson, nicolasfella, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This implements Web Share API Level 1 [1] through

D23152: [energy kcm] Display Vendor and product

meven created this revision. meven added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The code is not great, I would be open to have a suggestion to improve it. I tried to pass

D21113: Allow hiding option items depending on available extension and version in the host

broulik updated this revision to Diff 63705. broulik added a comment. - Check the right thing... REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21113?vs=63704=63705 REVISION DETAIL https://phabricator.kde.org/D21113 AFFECTED FILES

D21113: Allow hiding option items depending on available extension and version in the host

This revision was automatically updated to reflect the committed changes. Closed by commit R856:55d78db657be: Allow hiding option items depending on available extension and version in the… (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D23148: Add missing headers

asturmlechner created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. asturmlechner requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL

D23130: [energy kcm] Remove bogus Has power supply property from UI

meven added a comment. In D23130#511562 , @broulik wrote: > That property is whether the selected battery powers the computer or is just a peripheral. Perhaps just the label must be changed? That might be a better solution, indeed.

D23148: Add missing headers with DISABLE_MODEMMANAGER_SUPPORT=ON

asturmlechner closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D23148 To: asturmlechner, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D23151: Implement Web Share API through Purpose

broulik updated this revision to Diff 63716. broulik added a comment. - Remove leftover testing code REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23151?vs=63715=63716 REVISION DETAIL https://phabricator.kde.org/D23151 AFFECTED

D23130: [energy kcm] Remove bogus Has power supply property from UI

meven updated this revision to Diff 63717. meven added a comment. [kcm energy] Display vendor and battery model REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23130?vs=63670=63717 BRANCH dev1 REVISION DETAIL https://phabricator.kde.org/D23130

D23130: [energy kcm] Remove bogus Has power supply property from UI

meven updated this revision to Diff 63718. meven added a comment. Fix mismatched commit REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23130?vs=63717=63718 BRANCH dev1 REVISION DETAIL https://phabricator.kde.org/D23130 AFFECTED FILES

D23152: [energy kcm] Display Vendor and model

meven updated this revision to Diff 63720. meven added a comment. Add a space REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23152?vs=63719=63720 BRANCH dev2 REVISION DETAIL https://phabricator.kde.org/D23152 AFFECTED FILES

D23155: Show busy indicator while loading apps list

This revision was automatically updated to reflect the committed changes. Closed by commit R134:f2e3e0985ca3: Show busy indicator while loading apps list (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D23151: Implement Web Share API through Purpose

apol added inline comments. INLINE COMMENTS > purposeplugin.cpp:127 > +if (!text.isEmpty()) { > +urls.append(text); > +} shouldn't this be a data: url or something like that? urls should only have urls > purposeplugin.cpp:161 > +if (!mimeType.isEmpty() &&

D23058: Reduce visual strength of version numbers on Updates page

This revision was automatically updated to reflect the committed changes. Closed by commit R134:e576f8a69349: Reduce visual strength of version numbers on Updates page (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D22514: Show if KRunner is still searching for more things

aspotashev added a comment. In D22514#502062 , @apol wrote: > Please review D22540 so I can offer a better solution for @broulik's concerns. You already fixed all of those, right? IMHO the busy

D22908: avoid qml warnings when controlRoot is not set

dakon abandoned this revision. dakon added a comment. Dupe of D21514 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D22908 To: dakon, ngraham, mart, #plasma, apol Cc: ngraham, mart, plasma-devel,

D21113: Allow hiding option items depending on available extension and version in the host

broulik updated this revision to Diff 63704. broulik added a comment. - required→requires - redundant check - ret var REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21113?vs=63702=63704 REVISION DETAIL

D23126: Add browser action for status reporting

broulik updated this revision to Diff 63707. broulik added a comment. - Rebase REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23126?vs=63659=63707 REVISION DETAIL https://phabricator.kde.org/D23126 AFFECTED FILES

D23112: Add a event Spy for GtkFileChooser recent files

meven added a comment. In D23112#511354 , @ivan wrote: > Thanks for geting involved this much! :D REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D23112 To: meven, #frameworks, ivan Cc:

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63713. meven added a comment. Add const where need be, simplify KTrader query REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63669=63713 BRANCH master REVISION DETAIL

D23112: Add a event Spy for GtkFileChooser recent files

meven marked 5 inline comments as done. meven added inline comments. INLINE COMMENTS > ivan wrote in GtkEventSpy.cpp:143 > Let's hope commands will never have spaces in them :) It is to just extract the executable name, we don't want to have an exploding number of initiatingAgent for every

D21113: Allow hiding option items depending on available extension and version in the host

fvogt added inline comments. INLINE COMMENTS > options.js:207 > + > document.querySelectorAll("[data-requires-extension]").forEach((item) => { > +let requiredExtension = item.dataset.requiresExtension; > +let requiredMinimumVersion = >

KDE CI: Plasma » plymouth-kcm » stable-kf5-qt5 SUSEQt5.12 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plymouth-kcm/job/stable-kf5-qt5%20SUSEQt5.12/22/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 14 Aug 2019 09:57:13 + Build duration: 1 min 54 sec and counting JUnit Tests

KDE CI: Plasma » plymouth-kcm » kf5-qt5 SUSEQt5.12 - Build # 27 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plymouth-kcm/job/kf5-qt5%20SUSEQt5.12/27/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 14 Aug 2019 09:57:14 + Build duration: 1 min 44 sec and counting JUnit Tests Name: (root)

D21113: Allow hiding option items depending on available extension and version in the host

broulik marked 3 inline comments as done. broulik added a comment. Depends on the REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D21113 To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23150: [energy kcm] Fix width$ of lines in the graph background

meven created this revision. meven added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Before: After: REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 63723. ngraham added a comment. Rebase and update message REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=48441=63723 BRANCH arcpatch-D17598 REVISION DETAIL

D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63724. meven added a comment. grammar REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63713=63724 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23112 AFFECTED FILES

D23112: Add a event Spy for GtkFileChooser recent files

meven marked an inline comment as done. meven added a comment. In D23112#511779 , @ngraham wrote: > Cool stuff. Does it handle duplicates when a file is present in both GTKFileChooserRecent and KActivitiesStats? Yes, the file url is a

D23152: [energy kcm] Display Vendor and model

ngraham added a comment. Is this the vendor and model for the battery itself? If so, maybe it should be under the "Battery" section towards the top. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23152 To: meven, broulik, ngraham Cc: plasma-devel, LeGast00n,

D17598: Improve "No internet connection!" error message

GB_2 added inline comments. INLINE COMMENTS > BrowsingPage.qml:73 > +horizontalAlignment: Text.AlignHCenter > +text: xi18nc("@info", "Unable to load > applicationsplease verify Internet connectivity") > +} I'd put a dot after "applications" and

D23112: Add a event Spy for GtkFileChooser recent files

ngraham added a comment. Cool stuff. Does it handle duplicates when a file is present in both GTKFileChooserRecent and KActivitiesStats? INLINE COMMENTS > kactivitymanagerd-plugin-gtk-eventspy.json:41 > +"Name[zh_CN]": "Méven Car", > +"Name[zh_TW]": "Méven

D22885: Add global animation speed slider to workspace options KCM

GB_2 added a comment. In D22885#505635 , @broulik wrote: > Why is it confusing? I find it more confusing if `AnimationSpeed=0.5` means *faster* instead of "half the speed" as reading that line would suggest. > However, KWin seems to do it the

D22885: Add global animation speed slider to workspace options KCM

broulik added a comment. We agreed that code-wise a multiplier is easier but then the name of the group should be adjusted to reflect that. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22885 To: davidedmundson, #plasma Cc: GB_2, broulik, anthonyfieroni,

D23112: Add a event Spy for GtkFileChooser recent files

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > ngraham wrote in kactivitymanagerd-plugin-gtk-eventspy.json:41 > Not sure you need to add translations of your own name here This was done for Ivan so I guess the translation team fills this. REPOSITORY

D23154: allow to set custom icon for the left drawer handle

camiloh updated this revision to Diff 63738. camiloh added a comment. add default handle icon props to null REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23154?vs=63737=63738 BRANCH left-drawer-handle-custom-icon (branched from master) REVISION

D23154: allow to set custom icon for the left drawer handle

camiloh created this revision. camiloh added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY it allows to set a icon to the globaldrawer handle, for that both close and open handle

D23154: allow to set custom icon for the left drawer handle

mart added inline comments. INLINE COMMENTS > OverlayDrawer.qml:111 > } > switch(edge) { > case Qt.LeftEdge: you can write it more compact and avoid code duplication, you can do: if (root.handleClosedIcon.source &&

D23155: Show busy indicator while loading apps list

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN F7247302: Busy indicator while loading - with internet.webm

D23154: allow to set custom icon for the left drawer handle

camiloh updated this revision to Diff 63742. camiloh added a comment. code style spaces REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23154?vs=63740=63742 BRANCH left-drawer-handle-custom-icon (branched from master) REVISION DETAIL

D23154: allow to set custom icon for the left drawer handle

camiloh updated this revision to Diff 63740. camiloh added a comment. more compact code and fix coding style spaces REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23154?vs=63738=63740 BRANCH left-drawer-handle-custom-icon (branched from master)

D23154: allow to set custom icon for the left drawer handle

ngraham added a comment. Needs moar `@since 5.62` REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23154 To: camiloh, #kirigami, mart Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D23154: allow to set custom icon for the left drawer handle

This revision was automatically updated to reflect the committed changes. Closed by commit R169:191ff22b1cb9: allow to set custom icon for the left drawer handle (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23154?vs=63742=63758

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh added a comment. In D22974#508067 , @mart wrote: > good direction, unfortunately we can't remove the custom toolbutton contentitem yet, so for now let's keep the custom icon group The solution here was to add back the

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63726. camiloh added a comment. remove debugging line REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22974?vs=63725=63726 BRANCH k-action-to-qqc2-action (branched from master) REVISION DETAIL

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

mart added inline comments. INLINE COMMENTS > Action.qml:27 > * > * @inherit QtObject > */ @inherit QtQuick.Controls.Action > Action.qml:76 > */ > -property ActionIconGroup icon: ActionIconGroup { > -id: iconGroup > -} > +// property ActionIconGroup icon:

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63727. camiloh added a comment. clean up code, remove comments and documentation fixes REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22974?vs=63726=63727 BRANCH k-action-to-qqc2-action (branched from master)

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

This revision was automatically updated to reflect the committed changes. Closed by commit R169:fd8fec5b8923: Allow usage of QQC2 actions on Kirigami components and now make K.Action based… (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D23152: [energy kcm] Display Vendor and model

meven added a comment. In D23152#511775 , @ngraham wrote: > Is this the vendor and model for the battery itself? If so, maybe it should be under the "Battery" section towards the top. Yes it is. Since all the information in this

D22376: new env var DRKONQI_HTTP_DELAY_MS to force a connection delay

This revision was automatically updated to reflect the committed changes. Closed by commit R871:e08d7f5b9b70: new env var DRKONQI_HTTP_DELAY_MS to force a connection delay (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22376?vs=61507=63731#toc REPOSITORY R871

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 3 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/3/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Wed, 14 Aug 2019 14:48:53 + Build duration: 8 min 8 sec and counting CONSOLE OUTPUT

D23150: [energy kcm] Fix width of lines in the graph background

This revision was automatically updated to reflect the committed changes. Closed by commit R102:56ac21c9e177: [energy kcm] Fix width of lines in the graph background (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23150?vs=63714=63733

D17598: Improve "No internet connection!" error message

This revision was automatically updated to reflect the committed changes. Closed by commit R134:131071136f56: Improve No internet connection! error message (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63725. camiloh added a comment. fallback to custom kirigamiAction property for PrivateActionToolButton - useage of the fallback property due to: if we use QQC2.ToolButton default action property then the style will draw the content, and since this

D23109: Rework the visibleActions logic in SwipeListItem

This revision was automatically updated to reflect the committed changes. Closed by commit R169:56d3ccd95753: Rework the visibleActions logic in SwipeListItem (authored by leinir). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23109?vs=63658=63730 REVISION

D23150: [energy kcm] Fix width of lines in the graph background

meven added a comment. It was needed after bd33412355824837c888974890fb3b46c45be3b8 changed the plotWidth from "width - xPadding *2" to "width - xPadding" REPOSITORY R102 KInfoCenter BRANCH master REVISION

D17598: Improve "No internet connection!" error message

ngraham updated this revision to Diff 63734. ngraham added a comment. Fix diff REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17598?vs=63723=63734 BRANCH arcpatch-D17598 REVISION DETAIL https://phabricator.kde.org/D17598 AFFECTED

D23154: allow to set custom icon for the left drawer handle

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. it's ok, doesn't add public properties REPOSITORY R169 Kirigami BRANCH left-drawer-handle-custom-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D23154 To:

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The button grid was not centered, the content inside the buttons was not centered, the

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Intention makes sense, as do most the changes. Just some minor comments. INLINE COMMENTS > ConfigGeneral.qml:124 > +Layout.topMargin: units.gridUnit > +

D21872: Translate keyboard layouts in sddm

davidedmundson added a comment. > So is this unnecessary, and the string should be translated somewhere over in FreeDesktop-land? The translations are done somewhere over in freedesktop-land, but someone still needs to load them. This does it in our theme. My question is why is

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

davidedmundson added a comment. One minor comment, and anthonyfieroni's comment, and this is good to go. INLINE COMMENTS > xwindowtasksmodel.cpp:203 > +cachedStackingOrder = KWindowSystem::stackingOrder(); > +q->dataChanged(q->index(0, 0), q->index(q->rowCount() - 1,

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in ConfigGeneral.qml:124 > What's this about? It's typically a sign that something else is wrong. > > Probably the lack of spacer in this dialog means the label below occupies >

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham updated this revision to Diff 63756. ngraham added a comment. Use Layout.preferred[Width|Height] REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23158?vs=63748=63756 BRANCH improve-kickoff-settings-button-grid (branched from master)

D22012: Clean up old bug workaround in KCMFileIndexer

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. It was first added in 2d5f289767ee7b7c54f8b55e8032d20ef7f092f4 with some pretty sparse docs,

D23154: allow to set custom icon for the left drawer handle

camiloh added a comment. In D23154#511924 , @ngraham wrote: > Needs moar `@since 5.62` where ? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23154 To: camiloh, #kirigami, mart Cc: ngraham, plasma-devel,

D23154: allow to set custom icon for the left drawer handle

ngraham added a comment. On the new public properties REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23154 To: camiloh, #kirigami, mart Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein