D23308: Add a warning message about needing globally installed theme files

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:4b2171bb3db3: Add a warning message about needing 
globally installed theme files (authored by filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23308?vs=65084=65278

REVISION DETAIL
  https://phabricator.kde.org/D23308

AFFECTED FILES
  src/advancedconfig.cpp
  src/ui/advancedconfig.ui

To: filipf, #plasma, davidedmundson, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23686: Allow a setting to declaratively depend on another one

[Kai Uwe Broulik]

broulik updated this revision to Diff 65273.
broulik added a comment.


  - Simplify...

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23686?vs=65272=65273

REVISION DETAIL
  https://phabricator.kde.org/D23686

AFFECTED FILES
  extension/options.css
  extension/options.html
  extension/options.js

To: broulik, #plasma, davidedmundson, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23686: Allow a setting to declaratively depend on another one

[Kai Uwe Broulik]

broulik updated this revision to Diff 65272.
broulik added a comment.


  - Be explicit about the value, so you can also have something on when 
something else is *un*checked
  - Initially check dependencies, too, not just when changing setting

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23686?vs=65271=65272

REVISION DETAIL
  https://phabricator.kde.org/D23686

AFFECTED FILES
  extension/options.css
  extension/options.html
  extension/options.js

To: broulik, #plasma, davidedmundson, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23686: Allow a setting to declaratively depend on another one

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Also indent dependant settings.

TEST PLAN
  - Enhanced media controls is indented now
  - Checking and unchecking media controls enables/disables enhanced media 
controls (like before, but now without "special code")

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23686

AFFECTED FILES
  extension/options.css
  extension/options.html
  extension/options.js

To: broulik, #plasma, davidedmundson, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23683: [libnotificatonmanager] Initialise member variable

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  1408== Conditional jump or move depends on uninitialised value(s)
  -
  
  1408==at 0x1F0D8A6D:
  
  
  NotificationManager::NotificationGroupCollapsingProxyModel::setLimit(int)
  
(src/kde/workspace/plasma-workspace/libnotificationmanager/notificationgroupcollapsingproxymodel.cpp:112)
  
  1408==by 0x1F0BA091:
  
  
  NotificationManager::Notifications::Private::initProxyModels()
  
(src/kde/workspace/plasma-workspace/libnotificationmanager/notifications.cpp:227)
  
  1408==by 0x1F0BBC75:
  
  
  
NotificationManager::Notifications::setGroupMode(NotificationManager::Notifications::GroupMode)
  
(src/kde/workspace/plasma-workspace/libnotificationmanager/notifications.cpp:584)
  
  1408==by 0x1F09F7B2:
  
  
  NotificationManager::Notifications::qt_static_metacall(QObject*,
  QMetaObject::Call, int, void**) (moc_notifications.cpp:668)
  
  Practical impact is limited as every user has to call setLimit anyway

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23683

AFFECTED FILES
  libnotificationmanager/notificationgroupcollapsingproxymodel_p.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23392: [energy KCM] Add battery Technology

[Méven Car]

meven planned changes to this revision.
meven added a comment.


  Waiting for KF 5.62 release

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23392

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23651: WIP: Add support for a theming in Kicker Dashboard

[David Redondo]

davidre added a comment.


  The reason it's transparent is because the clear color of the buffer is set 
to the background color when it's changed [1][2]. 
  This worked before probably because the Color was (0, 0, 0). For transparent 
windows we need to set it to `Qt::transparent`[3] and enable an  alpha 
buffer[4].
  
  F7309362: Screenshot_20190902_171545.png 

  
diff --git a/applets/kicker/plugin/dashboardwindow.cpp 
b/applets/kicker/plugin/dashboardwindow.cpp
index 6665e8df7..cc6b70c32 100644
--- a/applets/kicker/plugin/dashboardwindow.cpp
+++ b/applets/kicker/plugin/dashboardwindow.cpp
@@ -32,6 +32,8 @@ DashboardWindow::DashboardWindow(QQuickItem *parent) : 
QQuickWindow(parent ? par
 , m_visualParentWindow(nullptr)
 {
 setClearBeforeRendering(true);
+setDefaultAlphaBuffer(true);
+setColor(Qt::transparent);
 setFlags(Qt::FramelessWindowHint);
 
 setIcon(QIcon::fromTheme(QStringLiteral("plasma")));
@@ -100,8 +102,6 @@ QColor DashboardWindow::backgroundColor() const
 void DashboardWindow::setBackgroundColor(const QColor )
 {
 if (color() != c) {
-setColor(c);
-
 emit backgroundColorChanged();
 }
 }
  
  [1] 
https://cgit.kde.org/plasma-desktop.git/tree/applets/kicker/plugin/dashboardwindow.cpp#n103
  [2]https://doc.qt.io/qt-5/qquickwindow.html#color-prop
  [3]https://doc.qt.io/qt-5/qquickwidget.html#details (see Limitations)
  [4]https://doc.qt.io/qt-5/qquickwindow.html#setDefaultAlphaBuffer

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23651

To: ognarb, #plasma, #vdg
Cc: davidre, felixernst, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23392: [energy KCM] Add battery Technology

[Nathaniel Graham]

ngraham added a comment.


  In D23392#524021 , @meven wrote:
  
  > Please note that the feature needs solid 5.62 installed on system as qml 
looks in `/usr/include/solid/battery.h` for the battery model header.
  >  By chance iIf you know how to set the include path used by qml
  
  
  Probably easiest to just wait until 5.62 is tagged in a few days and then 
commit. This is safe because KInfoCenter is distributed with Plasma, and the 
next Plasma release (5.17) will have Frameworks 5.62 as the dependency version. 
I've got a few patches myself that are waiting on 5.62 tagging.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23392

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23678: Change Installed list icon to view-list-details

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:bd12770b2b1c: Change Installed list icon to 
view-list-details (authored by ndavis).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23678?vs=65238=65239

REVISION DETAIL
  https://phabricator.kde.org/D23678

AFFECTED FILES
  discover/qml/DiscoverWindow.qml

To: ndavis, #vdg, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23678: Change Installed list icon to view-list-details

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yup.

REPOSITORY
  R134 Discover Software Store

BRANCH
  installed-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23678

To: ndavis, #vdg, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23678: Change Installed list icon to view-list-details

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The previous icon was the same, but it was blurry because it was only 16px

REPOSITORY
  R134 Discover Software Store

BRANCH
  installed-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23678

AFFECTED FILES
  discover/qml/DiscoverWindow.qml

To: ndavis, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23330: Make manual control compatible with redshift >= 1.12

[Melvin Vermeeren]

vermeeren added a comment.


  Is there any news regarding this? The updated diff has been tested (both 
version paths) and works properly. It should be ready for merge as is, and will 
close a bug over a year old. Urgency is rather high in my opinion, as both 
Debian >= buster and Ubuntu >= cosmic are shipping redshift 1.12 meaning this 
bug is now reaching end users in stable production systems.

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D23330

To: vermeeren, martinkostolny, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23651: WIP: Add support for a theming in Kicker Dashboard

[Felix Ernst]

felixernst added a comment.


  Current (?) one for comparison (from Kubuntu 18.04 since the one from Neon 
Unstable crashes for me)
  F7308896: Screenshot_20190902_143551.png 

  I feel like there was a lot of thought put into the current design of the 
dashboard and the search field in particular:
  
  - It does fit the style of having different logical parts of the dashboard 
purely divided by white space (and not by borders, lines).
  - It makes very clear that typing will trigger the search while in your 
screenshot it looks like the search field doesn't have focus and typing might 
not trigger the search.
  - In addition the size of the elements of the dashboard should loosely 
correspond to their importance.  The search is arguably the most important 
feature of the dashboard. The way you changed it it seems a bit too minor to me.
  
  I agree that the search as it currently is is inconsistent with how we 
display search fields anywhere else but it does fit with the rest of the 
dashboard. The overall style of the dashboard is pretty unique imo (for better 
or worse).
  
  Other than that +1 for the color change. I'm using Breeze and the dashboard 
with its white text on dark background always looked out of place to me.
  I agree that a blurred background would most likely look very nice.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23651

To: ognarb, #plasma, #vdg
Cc: felixernst, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23677: [Folder View] Load icon only for isPopup case

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  There's no point in loading the icon when it cannot be seen.

TEST PLAN
  No longer have desktop containment query the icon name of the root item

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23677

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23676: [Folder View] Only install watch on .directory file if actually used

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Installing a `KDirWatch` checks file system type to determine which backend 
to use (e.g. cannot use inotify on NFS), potentially blocking.

TEST PLAN
  - Folder icon was still correctly shown in the panel
  - Changing the folder icon in Dolphin had the panel icon change live
  
  - Cascading folder popups no longer install a dir watch when opening

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23676

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23675: [Folder View] Don't query file information if tooltips are disabled

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Especially the `TypeRole` can be quite heavy.

TEST PLAN
  5.16?
  Disabled tooltips (the default), hovered a slow mount, Plasma didn't freeze 
anymore.
  Enabled tooltips, contents was still correct, and then obviously froze when 
encountering a slow mount

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23675

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[David Faure]

dfaure added a comment.


  My suggestion is (still) "improve KFileItem to enable SkipMimeTypeFromContent 
automatically if isSlow is true"
  [possibly with another flag if you think there are actually use cases for 
mime-magic over network mounts]
  
  Then all this code isn't needed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Monday meeting notes for 2/9/2019

[Marco Martin]

Nicofee:
* Killed the phonon KCM
* Patched Pulseaudio to not load module-device-manager for us
* This means we should be able to use switch-on-connect by default
* Debugged an issue in PA. Profiles that weren't actually useful were
still marked as available. Apparently this is already fixed in master
* Added a bunch of icons to the kicker/kickoff context menu
* Added a bunch of icons to the kicker/kickoff context menu
* Added icons to jumplistactions of Konsole, Falkon and Libreoffice
* Fixed issue with the speaker test in plasma-pa KCM

Kai Uwe:
plasma-browser-integration:
 * Did a new release \o/
 * https://blog.broulik.de/2019/08/plasma-browser-integration-1-6/
 * and a 1.6.1 hotfix two days later :D
 * Uses KCrash now. You get DrKonqi when the native host crashes
 Notifications:
 * Did some testing and research on KDE Connect's notification sync,
now that I have a phone that supports it :)
 * Only apps with the same "origin" are grouped together now
 Plasma:
 * KSplash is delayed until wallpaper has loaded now
 * Changing color scheme no longer reloads KWin configuration
 * Makes the transition a lot less jarring. Didn't see why that
would still be neccessary with KDecoration2
 * Implemented JobViewV3, a new job view API using variant maps
instead of dozens of methods
 * Implementation in KIO/KJobWidgets pending
 Other:
 * KFilePlacesView uses asynchronous KIO::FileSystemFreeSpaceJob for
"free space" overlay in file dialog
 * Windows thumbnails (EXE, ICO, CUR) are now cached
 * I don't see where they should be trated differently than any
other image. It's not like they're changing on their own
 * Dolphin's status bar doesn't erroneously show "Sorting..." while
it's actually still loading the directory
 * Made BlueDevil's discovery page use KBusyIndicatorWidget instead of
KPixmapSequence
 Please review: D23145 D22569
Diff 23145 "[Exe Thumbnailer] Match 16 bit executables and don't
request icon types wrestool cannot handle" [Needs Review]
https://phabricator.kde.org/D23145
Diff 22569 "[Dialog] Apply window type after changing flags"
[Needs Review] https://phabricator.kde.org/D22569

Roman:
* I put up my patch series for output duplication. See for example
here: https://phabricator.kde.org/D23666
Diff 23666 "[kcm] Provide graphical interface to replicate
outputs" [Needs Review] https://phabricator.kde.org/D23666
* That's a big change and I think it can generate quite some buzz if
we announce it correctly.
* For that I would like us to make an effort to still get it in 5.17.
* Take a look at the video to see how it works:
https://www.youtube.com/watch?v=j__FJZK-A-0
* There is one patch which has priority because of frameworks release:
https://phabricator.kde.org/D23619
Diff 23619 "Introduce cloning and replication of output devices"
[Needs Review] https://phabricator.kde.org/D23619

Arjen:
**KSysGuard**
* Process plugins and network plugin still pending, but stuff is
happening there.
* Landed https://phabricator.kde.org/D23566 which is a first step to a
QML plugin for KSysGuard.
**Kirigami**
* Some work on making sure that PrivateActionToolButton behaves
correctly with menus (https://phabricator.kde.org/D23463)
* Uncovered a bug that caused the entire page context menu not to show
up, already fixed (https://phabricator.kde.org/D23499)
* Use PrivateActionToolButton for overflow menu button, could use a
re-review on this one. (https://phabricator.kde.org/D23502)
* Display icons for submenus in overflow menu and other action menus.
(https://phabricator.kde.org/D23501)
**Other**
* Did some reviewing of Leinir's KNewStuffQuick work.
* Sent a mail about Quick Charts to framworks-devel and core-devel just now.

Leinir:
* I did that thing where i posted the thing for review :)
https://phabricator.kde.org/D21721
Diff 21721 "Bring KNewStuffQuick to feature parity with
KNewStuff(Widgets)" [Needs Review] https://phabricator.kde.org/D21721

Jonathan:
* Plasma 5.16.5 is tomorrow, get your final bug fixes in!
* Repo freeze for 5,17 is on thursday, no new dependencies or git
repos added after that
* I'm aware of one new repo, plasma-thunderbolt
* Reminder to add new features and noteable bugfixes to the 5.17
announce notes page https://notes.kde.org/p/plasma_5_17

Marco:
# Plasma
* fixing bugs on the new applet layout manager, unhearted by its usage
in the plasma mobile homescreen
# Plasma mobile
* made saving and loading launcher positions work correctly
* Auto scrolling while dragging icons around
* in general, polishing, polishing polishing to make it ready to
drop-in replace the current phone homescreen
* Testing on the phone and debugging problems that happen there too
(still a misterious phone-specific crash remaining)

D23342: Add a per-process network information plugin

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Seems good to me !
  I am using this now, and it is great.
  
  But my review does not weight much as I am not a ksysguard 
maintainer/developer.
  
  It makes me want to add a network graph by process in ksysguard.

INLINE COMMENTS

> main.cpp:97
> +
> +std::this_thread::sleep_for(std::chrono::seconds(1));
> +}

Could the refresh rate be a parameter or at least a constant instead of an 
hardcoded value.

REPOSITORY
  R106 KSysguard

BRANCH
  network_plugin

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma, meven
Cc: meven, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23566: Move code to send signals and set priority of processes to a dedicated object

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:cb3ccfc6b3db: Move code to send signals and set priority 
of processes to a dedicated object (authored by ahiemstra).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23566?vs=64942=65215

REVISION DETAIL
  https://phabricator.kde.org/D23566

AFFECTED FILES
  CMakeLists.txt
  processcore/CMakeLists.txt
  processcore/process_controller.cpp
  processcore/process_controller.h
  processui/ksysguardprocesslist.cpp

To: ahiemstra, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Arjen Hiemstra]

ahiemstra added a comment.


  The readme already mentions it needs cap_net_raw. But I've now added a line 
on how to ensure that it has that.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma, meven
Cc: meven, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 65214.
ahiemstra added a comment.


  - Add a line that explains using setcap for cap_net_raw

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23342?vs=64310=65214

BRANCH
  network_plugin

REVISION DETAIL
  https://phabricator.kde.org/D23342

AFFECTED FILES
  CMakeLists.txt
  cmake/FindLibcap.cmake
  cmake/Findlibpcap.cmake
  plugins/CMakeLists.txt
  plugins/process/network/CMakeLists.txt
  plugins/process/network/README.md
  plugins/process/network/helper/Accumulator.cpp
  plugins/process/network/helper/Accumulator.h
  plugins/process/network/helper/CMakeLists.txt
  plugins/process/network/helper/Capture.cpp
  plugins/process/network/helper/Capture.h
  plugins/process/network/helper/ConnectionMapping.cpp
  plugins/process/network/helper/ConnectionMapping.h
  plugins/process/network/helper/Packet.cpp
  plugins/process/network/helper/Packet.h
  plugins/process/network/helper/TimeStamps.h
  plugins/process/network/helper/main.cpp
  plugins/process/network/network.cpp
  plugins/process/network/network.h
  plugins/process/network/networkconstants.h.in
  plugins/process/network/networkplugin.json

To: ahiemstra, #plasma, meven
Cc: meven, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23662: Wayland: Support output replication

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> waylandoutput.cpp:102
> +const auto uuid = m_device->replicationSource();
> +if (!uuid.isEmpty()) {
> +for (auto waylandOutput : m_config->outputMap()) {

if (uuid.isEmpty())
  return

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D23662

To: romangg, #kwin, #plasma
Cc: nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23663: RandR: Replicate outputs with XRender extension

[Roman Gilg]

romangg created this revision.
romangg added reviewers: KWin, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  This provides means to set replicas and queries them on X11 by transforming
  crtcs with the XRender extension.
  
  There is a heuristic at play to detect possible replications and currently
  the aspect ratio is not perserved but the image stretched. Using different
  values for the transformation matrix also the former should be possible.

TEST PLAN
  Manually together with patch to KScreen.

REPOSITORY
  R110 KScreen Library

BRANCH
  cloneX11

REVISION DETAIL
  https://phabricator.kde.org/D23663

AFFECTED FILES
  backends/xrandr/xrandrconfig.cpp
  backends/xrandr/xrandrcrtc.h
  backends/xrandr/xrandroutput.cpp
  backends/xrandr/xrandroutput.h
  src/configserializer.cpp

To: romangg, #kwin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23662: Wayland: Support output replication

[Roman Gilg]

romangg created this revision.
romangg added reviewers: KWin, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Uses new functionality in KWayland to allow queriying and setting the
  current replication source of an output.

TEST PLAN
  Manually together with patches to KWin and KScreen.

REPOSITORY
  R110 KScreen Library

BRANCH
  clone

REVISION DETAIL
  https://phabricator.kde.org/D23662

AFFECTED FILES
  backends/kwayland/waylandoutput.cpp
  backends/kwayland/waylandoutput.h
  backends/kwayland/waylandscreen.cpp
  src/output.cpp
  src/output.h
  src/setconfigoperation.cpp

To: romangg, #kwin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23647: XRandR: Generic code cleanup

[Roman Gilg]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:5ed9a35e3e27: XRandR: Generic code cleanup (authored by 
romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23647?vs=65126=65209

REVISION DETAIL
  https://phabricator.kde.org/D23647

AFFECTED FILES
  backends/xrandr/xrandr.cpp
  backends/xrandr/xrandr.h
  backends/xrandr/xrandrconfig.cpp
  backends/xrandr/xrandrconfig.h
  backends/xrandr/xrandrcrtc.cpp
  backends/xrandr/xrandrcrtc.h
  backends/xrandr/xrandrmode.cpp
  backends/xrandr/xrandrmode.h
  backends/xrandr/xrandroutput.cpp
  backends/xrandr/xrandroutput.h
  backends/xrandr/xrandrscreen.cpp
  backends/xrandr/xrandrscreen.h

To: romangg, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven added a comment.


  In D23198#523708 , @broulik wrote:
  
  > So I guess we can use the `KFileItem::isSlow()` here now, too?
  
  
  No because isSlow is a member function but the purpose here is to choose a 
constructor for KFileItem in the first place.
  Hence my idea to have a function encompassing this in a library, because this 
ought to be reused.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=304696

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||certainlya...@gmail.com

--- Comment #16 from Kai Uwe Broulik  ---
*** Bug 411497 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.