D23821: Clean up a few deprecated headers, and make dependencies more explicit

vkrause created this revision. vkrause added a reviewer: plasma-devel. Herald added a project: Plasma. vkrause requested review of this revision. REVISION SUMMARY Side effect from trying to figure out what needs to be done for T11568 . REPOSITORY R119

D23823: [KMenuEdit] port away from KStandardDirs

dfaure created this revision. dfaure added a reviewer: mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. TEST PLAN only did smoke testing (kmenuedit starts and displays the tree, clicking on one item shows details).

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 119 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/119/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 11 Sep 2019 05:10:12 + Build duration: 8 min 45 sec and counting JUnit Tests Name:

D23846: Fix build error of wrong function reference

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cf154a59148b: Fix compile (authored by lbeltrame). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23846?vs=65791=65815 REVISION DETAIL

D23823: [KMenuEdit] port away from KStandardDirs

dfaure closed this revision. REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D23823 To: dfaure, mlaurent Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,

D23799: Get rid of khtml usage (kill classic mode)

gladhorn accepted this revision. gladhorn added a comment. This revision is now accepted and ready to land. Based on all the +1s, this should clearly go in. Go for it :) REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela,

D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY I changed all QPainter functions to qreal functions. But this didn't make the line chart sharp in HiDPI. REPOSITORY R111

D23836: Use new TabKCM API

ngraham added a comment. +1, lovely code simplification. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23836 To: nicolasfella, mart, drosca Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D23845: Add a mode to center actions and omit the title when using a ToolBar style

ngraham created this revision. ngraham added reviewers: Kirigami, VDG, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch implements an optional and off-by-default feature to center the actions

D23852: Show connectivity status in tooltip

broulik added inline comments. INLINE COMMENTS > networkstatus.cpp:226 > +case NetworkManager::Portal: > +status = i18n("Connected to %1 (behind captive > portal)", connection->name()); > +break; I think this is

D23852: Show connectivity status in tooltip

broulik added a comment. Don't you need to connect to connectivity change signal, too? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D23852 To: jgrulich, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23854: Fix wrong title of the Drawers page

dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY The Drawers page title was erroneously set to Overlay Sheets. This commit

D23852: Show connectivity status in tooltip

jgrulich added a comment. In D23852#529025 , @broulik wrote: > Don't you need to connect to connectivity change signal, too? Ups, I probably want to. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D23853: Add api urls into the information sheet

dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY Users will be able to directly navigate to the api.kde.org page of the

D23840: Enable HiDPI rendering for systemmonitor

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Make toolbar and menu icons sharp REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

Plasma 5.12.9 LTS

Plasma 5.12.9 LTS is now released https://www.kde.org/announcements/plasma-5.12.9.php

D23840: Enable HiDPI rendering for systemmonitor

broulik added a comment. Can you check whether window icons are still correct? See D14490 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23840 To: guoyunhe, #plasma, ngraham Cc: broulik, plasma-devel, LeGast00n,

D23840: Enable HiDPI rendering for systemmonitor

guoyunhe added a comment. Fixed in https://phabricator.kde.org/D23846 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23840 To: guoyunhe, #plasma, ngraham Cc: kossebau, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin created this revision. jfranklin added reviewers: KWin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jfranklin requested review of this revision. REVISION SUMMARY Greetings, I am working on improving some of the functionality in the screen

D23852: Show connectivity status in tooltip

jgrulich created this revision. jgrulich added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY BUG: 411788 REPOSITORY R116 Plasma Network Management Applet BRANCH

D23846: Fix build error of wrong function reference

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Fix build error caused by D23840 REPOSITORY R120 Plasma Workspace BRANCH master

Plasma 5.18 as LTS

Following up on the previous threads: * We said we should ask distros when a next LTS suits them * 2 big distros have requested 5.18 (Feb 2020) * We had a chat at Akademy Decisions: * Plasma 5.18 will be LTS * It will have to depend on Qt 5.12 * Plasma 5.12 will then fall back to important

Re: Plasma 5.18 as LTS

Thanks, noted on https://community.kde.org/Schedules/Plasma_5#Release_Series On Tue, 10 Sep 2019 at 21:09, David Edmundson wrote: > Following up on the previous threads: > * We said we should ask distros when a next LTS suits them > * 2 big distros have requested 5.18 (Feb 2020) > * We had

D23799: Get rid of khtml usage (kill classic mode)

broulik added a comment. +1 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela, vkrause, plasma-devel, #plasma, bcooksley Cc: broulik, davidedmundson, ognarb, ngraham, #plasma, GB_2, sitter, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23799: Get rid of khtml usage (kill classic mode)

nicolasfella added a comment. +1 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela, vkrause, plasma-devel, #plasma, bcooksley Cc: nicolasfella, broulik, davidedmundson, ognarb, ngraham, #plasma, GB_2, sitter, LeGast00n, The-Feren-OS-Dev,

D23799: Get rid of khtml usage (kill classic mode)

This revision was automatically updated to reflect the committed changes. Closed by commit R124:03892b3b0dc7: Get rid of khtml usage (kill classic mode) (authored by svuorela). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23799?vs=65675=65737

D23836: Use new TabKCM API

nicolasfella created this revision. nicolasfella added reviewers: mart, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Use the new TabKCM API to improve the code and looks REPOSITORY R115

D23799: Get rid of khtml usage (kill classic mode)

davidedmundson added a comment. +1 as the new sidebar is very similar IMHO. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela, vkrause, plasma-devel, #plasma, bcooksley Cc: davidedmundson, ognarb, ngraham, #plasma, GB_2, sitter, LeGast00n,

D23823: [KMenuEdit] port away from KStandardDirs

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me. REPOSITORY R103 KMenu Editor BRANCH master REVISION DETAIL https://phabricator.kde.org/D23823 To: dfaure, mlaurent Cc: plasma-devel, LeGast00n,

D23798: Polish Displays KCM UI

GB_2 added inline comments. INLINE COMMENTS > OutputPanel.qml:33 > +text: i18n("Settings for %1", element.display) > +visible: kcm.numberOfOutputs > 1 > +} `element.count > 1` > OutputPanel.qml:42 > onClicked: element.enabled = checked > + visible:

D23852: Show connectivity status in tooltip

jgrulich updated this revision to Diff 65807. jgrulich added a comment. - Address review comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23852?vs=65796=65807 BRANCH tooltip-connectivity-status REVISION DETAIL

D23846: Fix build error of wrong function reference

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. LGTM this fixes plasma-workspace build REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23846 To: guoyunhe, #plasma, meven Cc: meven,

Re: Plasma 5.12.9 LTS

plasma-desktop got an updated tar to 5.12.9.1 to add an extra include to fix compile http://embra.edinburghlinux.co.uk/~jr/tmp/pkgdiff_reports/plasma-desktop/5.12.9_to_5.12.9.1/diffs/kcms/dateandtime/dtime.h-diff.html sha256 sum b79a04b1d39e7d12832520e9676265fd9beac626a5d41dd51481da51110f65d2

D23798: Polish Displays KCM UI

ngraham updated this revision to Diff 65779. ngraham added a comment. Reduce minimum height of screen grid a tiny bit so there's no vertical scrollbar in System Settings when showing multiple displays REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D23798: Polish Displays KCM UI

GB_2 added a comment. In D23798#528804 , @ngraham wrote: > Did you test the patch with those suggestions? They don't work. Oh, sorry then. I didn't actually have two screens to test this. It just looked like it worked for one.

D23843: Add template for Kirigami application development

dkardarakos created this revision. dkardarakos added reviewers: kossebau, apol. dkardarakos added a project: Plasma: Mobile. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY With this commit developers

D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display

guoyunhe updated this revision to Diff 65765. guoyunhe added a comment. continue trying REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23831?vs=65748=65765 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23831 AFFECTED FILES

D23818: Port away from kdemacros.h

This revision was automatically updated to reflect the committed changes. Closed by commit R101:7f6ab9fe5b96: Port away from kdemacros.h (authored by vkrause). REPOSITORY R101 KHotKeys CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23818?vs=65723=65774 REVISION DETAIL

D23798: Polish Displays KCM UI

ngraham added a comment. Yeah, all the things that I would have expected to work didn't, which is why I went with the nuclear option of creating a new function exposed to the QML side. Definitely needs input from #kwin people or @romangg. Everyone's

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 118 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/118/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 10 Sep 2019 16:12:59 + Build duration: 31 min and counting CONSOLE OUTPUT

D23840: Enable HiDPI rendering for systemmonitor

kossebau added a comment. Does this compile? What compiler are you using? At least it does not on CI: https://build.kde.org/view/Failing/job/Plasma/job/plasma-workspace/ When calling a static method of a class using the "::", one rather needs to use the classname, not the name of an

D23798: Polish Displays KCM UI

ngraham added a comment. Did you test the patch with those suggestions? They don't work. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23798 To: ngraham, romangg, #vdg, #kwin Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23840: Enable HiDPI rendering for systemmonitor

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f62e2f2a0901: Enable HiDPI rendering for systemmonitor (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

GB_2 added a comment. In D23283#526239 , @ngraham wrote: > Thanks for the review, @gb_2. Have you tested it out? I did a lot of testing, but even more testing would be appreciated since I know this has the potential to introduce some

D12827: Added process details in the process list context menu

chrisx updated this revision to Diff 65769. chrisx set the repository for this revision to R111 KSysguard Library. chrisx added a comment. @meven Sorry I've totally forgotten about your suggestions when I was updating the patch... I have renamed `DetailsDlg` to `ProcessDetailsDialog`. But

D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display

zzag added a comment. FYI D20445 REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D23831 To: guoyunhe, #plasma Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 380 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/380/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 10 Sep 2019 16:12:59 + Build duration: 18 min and counting CONSOLE OUTPUT [...truncated

D23840: Enable HiDPI rendering for systemmonitor

kossebau added a comment. And attributes in general are better set before the application instance is created. Some attributes even need that, so defaulting to it is better, REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23840 To: guoyunhe, #plasma,

D23818: Port away from kdemacros.h

vkrause created this revision. vkrause added a reviewer: plasma-devel. Herald added a project: Plasma. vkrause requested review of this revision. REPOSITORY R101 KHotKeys BRANCH master REVISION DETAIL https://phabricator.kde.org/D23818 AFFECTED FILES

D23799: Get rid of khtml usage (kill classic mode)

vkrause added a comment. In D23799#527953 , @ognarb wrote: > +1 > is there a task somewhere where we can track all the KDE projects still using khtml? T11542 tracks KHTML specifically, and it's