D24451: metadata: Add form factors to make kcm appear on mobile again

bshah added a comment. > Commited to 5.17, should I cherry pick the commit to master or merge the 5.17 branch back into master? Generally you merge the branch back in master, but I've done it (metadata.desktop file of package also needed updating). REPOSITORY R115 Plasma Audio Volume

D24223: [RFC] Add global themes that mimic other platforms' workflows

enriqueme added a comment. It looks like we want look and feel kcm split in two parts: - Desktop layout (panels and widgets) - Themes (wallpaper, color scheme, kwin theme, widget theme) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24223 To: ngraham,

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 434 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/434/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 07 Oct 2019 08:30:55 + Build duration: 57 sec and counting CONSOLE OUTPUT [...truncated

D24333: sddm-theme: Set needsFullUserModel=false

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0565c8e615e0: sddm-theme: Set needsFullUserModel=false (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24333?vs=67112=67406 REVISION

D24451: metadata: Add form factors to make kcm appear on mobile again

jbbgameich added a comment. Commited to 5.17, should I cherry pick the commit to master or merge the 5.17 branch back into master? REPOSITORY R115 Plasma Audio Volume Applet BRANCH mobile (branched from master) REVISION DETAIL https://phabricator.kde.org/D24451 To: jbbgameich,

D24451: metadata: Add form factors to make kcm appear on mobile again

This revision was automatically updated to reflect the committed changes. Closed by commit R115:91e6cf9694cd: metadata: Add form factors to make kcm appear on mobile again (authored by jbbgameich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24451?vs=67400=67403#toc REPOSITORY R115

D24452: Un-break remote input portal

apol created this revision. apol added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Have it document that it will be using the fake keys protocol TEST PLAN Tested manually

D24454: Include an emoji picker

broulik added a comment. Screenshot, please REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24454 To: apol, #plasma Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D24452: Un-break remote input portal

This revision was automatically updated to reflect the committed changes. Closed by commit R838:91793221302e: Un-break remote input portal (authored by apol). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 99 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/99/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 07 Oct 2019 09:40:25 + Build duration: 42 sec and counting CONSOLE OUTPUT [...truncated 127

D24454: Include an emoji picker

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Shows all emoji in categories, it will save the new emoji into the clipboard. TEST PLAN Manual

D24454: Include an emoji picker

apol updated this revision to Diff 67413. apol added a comment. Remove unused empty file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67412=67413 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED FILES

D24361: [Style KCM] Port to new design

broulik updated this revision to Diff 67427. broulik added a comment. - Don't let current style mess with preview palette REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24361?vs=67342=67427 REVISION DETAIL https://phabricator.kde.org/D24361

Monday meeting notes for 7/10/2019

Kai Uwe * Been on vacation last week, before that: * Rewrote widget style KCM as GridViewKCM, please review D24361 Diff 24361 "[Style KCM] Port to new design" [Needs Review] https://phabricator.kde.org/D24361 * Make qqc2-desktop-style listen to application style changing D24425 Diff 24425

D5961: Adoption of KUserFeedback for Discover

apol updated this revision to Diff 67423. apol added a comment. Move options to Sources, rename Sources back to Settings REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=67200=67423 BRANCH arcpatch-D5961_2 REVISION DETAIL

D24414: No need to keep ibus 1.4.* compatibility anymore

This revision was automatically updated to reflect the committed changes. Closed by commit R119:95c8ae371483: No need to keep ibus 1.4.* compatibility anymore (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24414?vs=67325=67411

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 98 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/98/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 07 Oct 2019 09:39:40 + Build duration: 43 sec and counting CONSOLE OUTPUT [...truncated 125

D24427: Explicitly qmlRegisterType QAbstractItemModel

This revision was automatically updated to reflect the committed changes. Closed by commit R124:e3d189a838dc: Explicitly qmlRegisterType QAbstractItemModel (authored by broulik). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24427?vs=67353=67409

D24454: Include an emoji picker

davidedmundson added a comment. There's coding style issues, as it's new code you can hopefully just run clang-format over it. INLINE COMMENTS > emojier.cpp:65 > +"Need to create the dictionaries again."; > +return; > +} leak of list?

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 420 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/420/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 07 Oct 2019 09:57:35 + Build duration: 3 min 16 sec and counting CONSOLE OUTPUT

D24471: [KRDB] Remove Oxygen-era colour exporting code

ngraham added a comment. Is this the other half for fixing https://bugs.kde.org/show_bug.cgi?id=412331? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24471 To: cblack, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24469: Allow the global drawer to become a menu if desired

nicolasfella updated this revision to Diff 67434. nicolasfella added a comment. - Rename property REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24469?vs=67433=67434 BRANCH toolbarmenu REVISION DETAIL https://phabricator.kde.org/D24469 AFFECTED

D24471: [KRDB] Remove Oxygen-era colour exporting code

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Can confirm that it fixes the bug and the fix conceptually makes sense. I'd like a review from a #plasma person to confirm before landing this

D24469: Allow the global drawer to become a menu if desired

ngraham added a comment. Nice, anything that improves convergence by makes Kirigami apps feel more at home on the desktop is a good thing in my mind. :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24469 To: nicolasfella, #vdg, mart Cc: ngraham, plasma-devel,

D24470: feedback kcm: Use a horizontal slider like GammaRay does

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Instead of a combo box, which is a bit harder on the wording. Also get more texts from kuserfeedback

D24470: feedback kcm: Use a horizontal slider like GammaRay does

broulik added inline comments. INLINE COMMENTS > main.qml:80 > +var found = false; > +for(var v in modeOptions) { > +if (modeOptions[v] === kcm.plasmaFeedbackLevel) { Use `Array.findIndex` > main.qml:91 > > -

KDE CI: Plasma » kmenuedit » kf5-qt5 SUSEQt5.12 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kmenuedit/job/kf5-qt5%20SUSEQt5.12/22/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 07 Oct 2019 15:25:56 + Build duration: 3 min 14 sec and counting CONSOLE OUTPUT [...truncated 127

D24471: [KRDB] Remove Oxygen-era colour exporting code

cblack added a comment. In D24471#543113 , @ngraham wrote: > Is this the other half for fixing https://bugs.kde.org/show_bug.cgi?id=412331? It'll get rid of the bug on its own by not exporting colours at all. (so instead of a mixture of

D24469: Allow the global drawer to become a menu if desired

nicolasfella created this revision. nicolasfella added reviewers: VDG, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The global drawer is usually used to implement one of two patterns: As

D5961: Adoption of KUserFeedback for Discover

ngraham added a comment. So close! The Settings page still says "Sources" in its header rather than "Settings." Also it might be nice to have the actions visible on the toolbar when there's room rather than always having them all in an overflow menu. Other than that, looks good.

D24454: Include an emoji picker

ngraham added a comment. Cool beans. Can you make the drawer/sidebar more narrow like we do in Discover? The width is hardcoded in Kirigami to something that's just way too high for this application IMO. Also an "all" category on top would be nice too. Many smartphone

D24471: [KRDB] Remove Oxygen-era colour exporting code

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY GTK2 colours are no longer exported. This is necessary in 2019 because most popular GTK2 themes

D24479: [KCM] Make multi-screen draggability more obvious

ngraham created this revision. ngraham added reviewers: romangg, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Add a label and use a grabby hand cursor when hovering over a screen when there are

D24470: feedback kcm: Use a horizontal slider like GammaRay does

apol updated this revision to Diff 67472. apol added a comment. ehm, typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24470?vs=67471=67472 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24470 AFFECTED FILES

D24479: [KCM] Make multi-screen draggability more obvious

broulik added inline comments. INLINE COMMENTS > Output.qml:272 > +cursorShape: Qt.OpenHandCursor > +acceptedButtons: Qt.NoButton // Otherwise it interferes with the > drag handler > +visible: kcm.outputModel && kcm.outputModel.rowCount() > 1 Hm, can you still make the

D24470: feedback kcm: Use a horizontal slider like GammaRay does

apol updated this revision to Diff 67471. apol added a comment. Address kai's comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24470?vs=67435=67471 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24470 AFFECTED FILES

D24479: [KCM] Make multi-screen draggability more obvious

ngraham updated this revision to Diff 67464. ngraham added a comment. Translate REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24479?vs=67462=67464 BRANCH make-draggability-more-obvious (branched from master) REVISION DETAIL

D24479: [KCM] Make multi-screen draggability more obvious

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > broulik wrote in Output.qml:272 > Hm, can you still make the hand "close" when you press the button, which is > what is typically done for dragging things I can do that if I accept the left button, but

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 435 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/435/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 07 Oct 2019 17:07:11 + Build duration: 2 min 32 sec and counting CONSOLE OUTPUT

D5961: Adoption of KUserFeedback for Discover

apol updated this revision to Diff 67448. apol added a comment. ++verbosity WRT the server error, I'd like to have the patch in before configuring the server to acknowledge Discover. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D5961: Adoption of KUserFeedback for Discover

ngraham added a comment. Clicking "Submit Feedback" produces the following: org.kde.UserFeedback: failed to submit user feedback: "Error transferring https://telemetry.kde.org/receiver/submit/org.kde.discover - server replied: Not Found" "\nUnknown product." . Calling

D24265: support global edit mode

mart added a comment. In D24265#541411 , @GB_2 wrote: > A few bugs I found: > > - when you open the desktop context menu it enters the edit mode automatically (probably because it thinks you still click) gah, yet another bug of the

D5961: Adoption of KUserFeedback for Discover

apol updated this revision to Diff 67441. apol added a comment. oops sources page title REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=67423=67441 BRANCH arcpatch-D5961_3 REVISION DETAIL https://phabricator.kde.org/D5961

D5961: Adoption of KUserFeedback for Discover

apol added a comment. In D5961#543062 , @ngraham wrote: > So close! The Settings page still says "Sources" in its header rather than "Settings." > > Also it might be nice to have the actions visible on the toolbar when there's room rather

D5961: Adoption of KUserFeedback for Discover

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Shipit! INLINE COMMENTS > DiscoverWindow.qml:54 > +text: i18n("Submit usage information") > +tooltip: i18n("Sends anonymized usage information to KDE to better >

D24474: Show menu items tooltip text

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Displays a tooltip with the action's tooltip text TEST PLAN Manually REPOSITORY R169 Kirigami

D24223: [RFC] Add global themes that mimic other platforms' workflows

LeGast00n added a comment. Great work. This plus additional usability issues tackled in other streams will make my full switch to KDE possible (coming from Mac). Two relatively minor things: - desktop icons (e.g. Recycle bin) are also part of it - Cupertino should have window

D24483: [Weather data engine] Handle windy conditions in NOAA backend

ngraham created this revision. ngraham added reviewers: kossebau, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now windy conditions are not handled at all. I live in an area with very frequent

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 436 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/436/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 08 Oct 2019 03:29:33 + Build duration: 1 min 8 sec and counting CONSOLE OUTPUT