D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 68019. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout - A much much better layout than tabs - Beginning of KC

D24224: Start of the accessibility KCM

tcanabrava added a comment. F7605185: kcm_access.png Now it uses a Vertical List, providing a better navigation mode, The Settings where also rewritten using KConfigXT so I don't need to deal with all the possible properties. This actually hit a hard l

D24683: [KWindowSystem] in icon() return realistic icon size

zzag added inline comments. INLINE COMMENTS > windowsystem.cpp:188 > +if (scale) { > +pixmap.scaled(width, height, Qt::IgnoreAspectRatio, > Qt::SmoothTransformation); > +} You forgot to assign the copied pixmap to something. However, I think you could just return it

D24683: [KWindowSystem] in icon() return realistic icon size

zzag added inline comments. INLINE COMMENTS > zzag wrote in windowsystem.cpp:188 > You forgot to assign the copied pixmap to something. However, I think you > could just return it from this point. edit: scaled pixmap REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETA

D24683: [KWindowSystem] in icon() return realistic icon size

meven updated this revision to Diff 68022. meven marked an inline comment as done. meven added a comment. Actually use the scaled pixmap REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24683?vs=68012&id=68022 BRANCH ar

D24687: [KCM] Add output selector ComboBox

broulik created this revision. broulik added reviewers: Plasma, VDG, romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since hidden outputs aren't shown at all for some reason, provide a `ComboBox` to sw

D24224: Start of the accessibility KCM

bport requested changes to this revision. bport added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmaccess.cpp:171 > + > +m_mouseSettings = new MouseSettings(); > +m_keyboardSettings = new KeyboardSettings(); new MouseSettings(this) in order to avo

D24192: WIP: Active page follow the focus

mart added inline comments. INLINE COMMENTS > broulik wrote in PageRow.qml:162 > Does this work in Qt 5.11? I recall `typeof` for QML types only being > implemented in Qt 5.12 i kinda remind instanceof was added in 5.10 tough was buggy or something like that it needs someone actually testing i

D24688: [KCM] Disallow dropping screen outside of reachable area

broulik created this revision. broulik added reviewers: Plasma, VDG, romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In the old KCM it was annoying that you couldn't drag screens outside when arranging

D24674: Fix Kirigami template image

This revision was automatically updated to reflect the committed changes. Closed by commit R169:03adbbcd2f74: Fix Kirigami template image (authored by dkardarakos). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24674?vs=67995&id=68026 REVISION DETAIL http

D24683: [KWindowSystem] in icon() return realistic icon size

mart added inline comments. INLINE COMMENTS > windowsystem.cpp:173 > +iconWidth = 16; > +} else if (width < 40) { > +iconWidth = 32; what's the logic behind the numbers 40, 56, 96 ans 192? should at least be in a comment REPOSITORY R130 Frameworks integration plugin using

D24687: [KCM] Add output selector ComboBox

mart added a comment. depends if they aren't shown there for a good reason or not. ie how would be this vs showing all output inthe view with maybe the hidden ones as rtanslucent? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24687 To: broulik, #plasma, #vdg, ro

D24687: [KCM] Add output selector ComboBox

broulik added a comment. > depends if they aren't shown there for a good reason or not. I don't know. @romangg Showing them is easy, they're just `visible: model.enabled` basically but I don't know what other implications changing that has. REPOSITORY R104 KScreen REVISION DETAIL

D24688: [KCM] Disallow dropping screen outside of reachable area

mart added inline comments. INLINE COMMENTS > Screen.qml:83 > +// Ensure a corner of a screen always stays visible > +visibleBounds: Qt.rect(20, 20, screenView.width - 40, > screenView.height - 40) > +} magic numbers? REPOSITORY R104 KScreen REVISION DETAIL

D24688: [KCM] Disallow dropping screen outside of reachable area

broulik added inline comments. INLINE COMMENTS > mart wrote in Screen.qml:83 > magic numbers? Suggestions? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24688 To: broulik, #plasma, #vdg, romangg Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalo

D24683: [KWindowSystem] in icon() return realistic icon size

meven added inline comments. INLINE COMMENTS > mart wrote in windowsystem.cpp:173 > what's the logic behind the numbers 40, 56, 96 ans 192? > should at least be in a comment It was copied from kwindowsystem/src/platforms/xcb/kwindowsytem.cpp So I don't know precisely but at least it is coherent

D24601: [mobile/wifi] Use network name as title for settings page

mart added inline comments. INLINE COMMENTS > nicolasfella wrote in ConnectionItemDelegate.qml:114 > That doesn't seem to work hmm, needs to be debugged, title is just a property of page so it must work... REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator

D24567: WIP: Implement sidebar mode for system tray plasmoid popups

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. This is more a comment on the technical side. It seems quite a brittle implementation to me, and quite prone to breakage (anything that relies on PlasmaCore.Dialog trying to make wit

D24503: Integrate the normal keyboard layout switcher

mart added a comment. In D24503#545961 , @hein wrote: > For context though, in the GSoC the following work was done: > > - The keyboard layout KCM was rewritten in Qt Quick Can that work be resumed/used? REPOSITORY R119 Plasma Deskt

D24488: [kcm] Don't transform button to show rotated icon

mart added a comment. In D24488#543719 , @ngraham wrote: > Hmm, the "no rotation" and "upside down" icons aren't accurate anymore (especially "no rotation"). I think it's the right approach... icons should be fixed? REPOSITORY R104 KSc

D24374: WIP: Initial port of the Date and Time KCM

mart added a comment. screenshots? INLINE COMMENTS > clock.png:1 wouldn't be better the breeze-styled one? also, a svg or would look bad on high dpi REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24374 To: tcanabrava Cc: mart, ngraham, plasma-devel, LeGa

D24424: Create kf5-network.directory

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2932b4e4b03e: Create kf5-network.directory (authored by Guo Yunhe ). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24424?vs=67366&id=680

D24648: Don't show context drawer if all actions are invisible

This revision was automatically updated to reflect the committed changes. Closed by commit R169:5f13c7b9c200: Don't show context drawer if all actions are invisible (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24648?vs=67933&id=6

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

apol added a comment. I'll insist, this KCM is distributed by Plasma. An Okular user on Windows won't have it available, this makes for tendentious data. Even with Plasma users, the process of explaining people "you have to go to enable it in system settings, then you go to enable it i

D24648: Don't show context drawer if all actions are invisible

broulik added a comment. Assuming this is a proper JS Array var somethingVisible = root.actions.some(function(item) { return item.visible; }); REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24648 To: nicolasfella, mart Cc: broulik, ngraham, plasm

[neon] [Bug 394459] "Invalid escape sequences in line" error in system log

https://bugs.kde.org/show_bug.cgi?id=394459 Harald Sitter changed: What|Removed |Added Assignee|plasma-devel@kde.org|neon-b...@kde.org Version|5.12.5

D24683: [KWindowSystem] in icon() return realistic icon size

meven added inline comments. INLINE COMMENTS > meven wrote in windowsystem.cpp:173 > It was copied from kwindowsystem/src/platforms/xcb/kwindowsytem.cpp > So I don't know precisely but at least it is coherent with X. > Unfortunately the commit history does not tell much. I can't explain the curr

D24503: Integrate the normal keyboard layout switcher

apol added a comment. > Can that work be resumed/used? See D14796 . It seems like the original author is MIA. I rebased the patch, seems to work but adopting it will set us back as the ibus backend was never implemented. REPOSITORY R119 Plasma Deskt

D24564: Fix warning when we're not hovering a Control

This revision was automatically updated to reflect the committed changes. Closed by commit R858:bcc30eb31a27: Fix warning when we're not hovering a Control (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24564?vs=6

D24691: Add support for WPA3

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24691 AFFECTED FILES CMakeLists.

D24691: Add support for WPA3

jgrulich updated this revision to Diff 68036. jgrulich added a comment. Drop cmake change REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24691?vs=68035&id=68036 BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24691 A

D24692: Show version information in about screen

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It can be useful to know what version of host you're using. For older hosts, this

D24692: Show version information in about screen

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tried with old host, no observable change REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D24692 To: broulik, #plasma, fvogt, ognarb Cc: plasma-dev

D24693: Bail out early when setPluginLoaded would result in no change

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise complains that the plugin refused to load because we didn't even try in the if st

D24694: fix part count

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the format line above has 8 parts, on my system I also get 8 parts. since we only access up to element 5 we only need to check >=5 t

D24692: Show version information in about screen

This revision was automatically updated to reflect the committed changes. Closed by commit R856:4b75dd4e2be0: Show version information in about screen (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24692?vs=68037&id=68040#toc REPOSITORY R856 Plasma Browser Integr

D24693: Bail out early when setPluginLoaded would result in no change

This revision was automatically updated to reflect the committed changes. Closed by commit R856:70fe227edb7e: Bail out early when setPluginLoaded would result in no change (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D23330: Make manual control compatible with redshift >= 1.12

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D23330 To: vermeeren, martinkostolny, #plasma, mart Cc: mart, ltoscano, ngraham, plasma-devel,

D24488: [kcm] Don't transform button to show rotated icon

romangg added a comment. From usability perspective I don't like the arrow. It is not as easy to grasp what will be the outcome since you have a current state and a transformation of that applied to symbolize a different state (the rotated one). Directly showing the rotated state, i.e. the o

D24361: [Style KCM] Port to new design

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4fcc01d536e5: [Style KCM] Port to new design (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24361?vs=67699&id=68042#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE L

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 434 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/434/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 16 Oct 2019 12:08:19 + Build duration: 13 min and counting CONSOLE OUTPUT [...truncated 7535

D24687: [KCM] Add output selector ComboBox

romangg added a comment. In D24687#547976 , @mart wrote: > depends if they aren't shown there for a good reason or not. > ie how would be this vs showing all output inthe view with maybe the hidden ones as rtanslucent? Disabled outputs

D24687: [KCM] Add output selector ComboBox

broulik added a comment. > I thought about showing some mini-symbols for disabled outputs on one of the sides of the overview at a fixed position. What do you need a proxy model for that? The outputs are part of the model, just `visible: model.enabled`. You could just have the delegate l

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson, fvogt, ngraham Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23578: Before requesting a scan, check the time threshold

meven added inline comments. INLINE COMMENTS > meven wrote in main.qml:77 > I removed this because > > 1: > Request scan failure should never happen anymore because the handler makes > sure never to call requestScan too often. > The timer can just constantly ask for request scans it does not im

D24208: [Notifications] Dodge Plasma dialogs

meven added a comment. I have some personal feedback regarding this : 1. I open my bluetooth popup 2. Click on a device to connect to 3. Nothing happens 4. I close the bluetooth popup 5. I discover a notification telling me the bluetooth connection failed Because of this chang

D24208: [Notifications] Dodge Plasma dialogs

broulik added a comment. Bluetooth could provide some better feedback inside the plasmoid. Pointless confirmation notifications in plasma-nm were the main reason for this patchset. Sliding could be done but is a lot more complicated than this patchset since the dialogs are individual, pat

D18299: ComboBox: fix default delegate

broulik added a comment. I checked Qt source code and Qt indeed should handle this on its own, it also works fine hwere without the code. Worse, the explicit assignment from QML breaks any binding set on `currentIndex`. In the handler that's called when the delegate model creates a delega

D24677: Add `sudo` to the lines in install-sessions.sh that need it so you don't need to sudo the whole thing

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c12befa1c65b: Add `sudo` to the lines in install-sessions.sh that need it so you don't need… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.k

D24324: [GTK2] Add program to libexec for GTK2 recoloration

ngraham added a comment. How about calling this new one "Breeze" and renaming the old one "Breeze (fixed colors)" or something like that? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24324 To: cblack, #breeze Cc: ngraham, ndavis, plasma-devel, LeGast00n, Th

D24699: Disable the module if the setting is locked down

ervin created this revision. ervin added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY In this case we simply disable the whole module since it manages only a single key really. We cou

D24698: Leverage latest KConfig changes

ervin created this revision. ervin added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY - Use the ctor with parent (no need to call setParent anymore) - Use isSaveNeeded on the settings

D24699: Disable the module if the setting is locked down

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Cool! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24699 To: ervin, #plasma, mart, broulik Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jral

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

romangg added a comment. Actually I would like to expose the fact that we are doing that only on X11. People not knowing what this is can ignore it. Also it is a single factor, not multiple as with multi output DPI scaling on Wayland. How about: The global scale factor is limited

D24370: [KCM] Display scale factor as a percentage, not a decimal

This revision was automatically updated to reflect the committed changes. Closed by commit R104:0f52663c7829: [KCM] Display scale factor as a percentage, not a decimal (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24370?vs=67215&id=68049#toc REPOSITORY R104 KScr

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

ngraham updated this revision to Diff 68050. ngraham added a comment. Rebase REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24373?vs=67226&id=68050 BRANCH 0625-increment-on-x11 REVISION DETAIL https://phabricator.kde.org/D24373 AFFECTED FILES kcm/p

D24373: [KCM] Limit scale factor increment to 6.25% on X11

ngraham updated this revision to Diff 68051. ngraham added a comment. Update message REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24373?vs=68050&id=68051 BRANCH 0625-increment-on-x11 REVISION DETAIL https://phabricator.kde.org/D24373 AFFECTED FILES

D24373: [KCM] Limit scale factor increment to 6.25% on X11

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Thank you Nate. master branch only. REPOSITORY R104 KScreen BRANCH 0625-increment-on-x11 REVISION DETAIL https://phabricator.kde.org/D24373 To: ngraham, #plasma, romangg, mart Cc:

D24373: [KCM] Limit scale factor increment to 6.25% on X11

This revision was automatically updated to reflect the committed changes. Closed by commit R104:2b23256b0a47: [KCM] Limit scale factor increment to 6.25% on X11 (authored by ngraham). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24373?vs=68051&id=68053 REVI

D24634: [WIP] Allow contextualActions to flow into the header toolbar

mart added a comment. now has the order main action, left, right. before was left, main right. it does change a bit the behavior, tough i see the point of making sure that the main action is always the last being hidden (i wonder how it would be making it hide last even if not the last) RE

D24634: [WIP] Allow contextualActions to flow into the header toolbar

mart added a comment. testing it i did find a major problem: if i resize the window quickly (kirigami gallery 2 columns mode) when it goes from icon+text to just icon, the window freezes for an instant, seems quite expensive, while before didn't do that REPOSITORY R169 Kirigami REVISION

D24634: [WIP] Allow contextualActions to flow into the header toolbar

mart added a comment. In D24634#547077 , @ngraham wrote: > Oh, this is so nice! can you test/qa some existing apps? (at least discover and kamoso ?) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24634 To: ahi

D24634: [WIP] Allow contextualActions to flow into the header toolbar

ngraham added a comment. In D24634#548229 , @mart wrote: > In D24634#547077 , @ngraham wrote: > > > Oh, this is so nice! > > > can you test/qa some existing apps? (at least discover and kamoso

D24699: Disable the module if the setting is locked down

This revision was automatically updated to reflect the committed changes. Closed by commit R119:77cfc0dc78fd: Disable the module if the setting is locked down (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24699?vs=68048&id=68055 R

D24698: Leverage latest KConfig changes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:05ec670029db: Leverage latest KConfig changes (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24698?vs=68047&id=68054 REVISION DETAIL

D24669: Port fonts KCM to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a4d23764ea46: Port fonts KCM to KConfigXT (authored by bport). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24669?vs=67988&id=68057#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST U

D24670: KCM fonts : Rearrange code

This revision was automatically updated to reflect the committed changes. Closed by commit R119:36d8d9e32351: KCM fonts : Rearrange code (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24670?vs=67989&id=68058 REVISION DETAIL https

D24668: Simplify kcms cmake file

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c72a1d5ce982: Simplify kcms cmake file (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24668?vs=67987&id=68056 REVISION DETAIL https:/

D24127: Fix toggle button colours

ngraham added a comment. I think this patch needs some changes (outlined above). REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24127 To: cblack, #breeze, ndavis, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ra

D24567: WIP: Implement sidebar mode for system tray plasmoid popups

ngraham added a comment. I agree that it would probably make more sense to allow the system tray popup to be arbitrarily resized, and use a panel instead when you wand a vertical sidebar type of UI. The issues with using a panel to accomplish that are discussed in https://bugs.kde.org/show_b

D24688: [KCM] Disallow dropping screen outside of reachable area

ngraham added inline comments. INLINE COMMENTS > broulik wrote in Screen.qml:83 > Suggestions? IMO magic numbers are probably okay here, but 20 is pretty similar to GridUnit so maybe just use multiples of that instead? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D2

D24701: Notify about change after cursor config is saved

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Before that patch the cursor change signal was only transmitted after a configuration was applied on a fly. Because the cursor chang

D24208: [Notifications] Dodge Plasma dialogs

ngraham added a comment. In D24208#548153 , @broulik wrote: > Bluetooth could provide some better feedback inside the plasmoid. Agreed, notifications shouldn't be used when the app/window/UI/whatever is still open; feedback should be prov

D24666: Be explicit about X11 or Wayland for the dev session names

This revision was automatically updated to reflect the committed changes. Closed by commit R120:63dca8847085: Be explicit about X11 or Wayland for the dev session names (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24666?vs=679

D24687: [KCM] Add output selector ComboBox

ngraham added a comment. This is a big improvement IMO. You can also remove the little dots at the bottom too. +1 for getting it into 17.1. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24687 To: broulik, #plasma, #vdg, romangg Cc: ngraham, mart, plasma-devel, LeG

D24224: Start of the accessibility KCM

ngraham added a comment. In D24224#547897 , @tcanabrava wrote: > F7605185: kcm_access.png Lists such as these always need frames and backgrounds, like how it looks in the Notifications KCM. Just cop

D24704: [KCM] Show the same name in the replication model that's shown in the title

ngraham created this revision. ngraham added reviewers: romangg, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch makes the name shown in the combobox match the name shown for each individual o

D24704: [KCM] Show the same name in the replication model that's shown in the title

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. 5.17 confirmed REPOSITORY R104 KScreen BRANCH replica-output-names (branched from Plasma/5.17) REVISION DETAIL https://phabricator.kde.org/D24704 To: ngraham, romangg, #vdg Cc: pl

D24208: [Notifications] Dodge Plasma dialogs

meven added a comment. In D24208#548272 , @ngraham wrote: > In D24208#548153 , @broulik wrote: > > > Bluetooth could provide some better feedback inside the plasmoid. > > > Agreed, notification

D24704: [KCM] Show the same name in the replication model that's shown in the title

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ba20c56a724f: [KCM] Show the same name in the replication model that's shown in the title (authored by ngraham). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2470

D24208: [Notifications] Dodge Plasma dialogs

broulik added a comment. > Hidding the notification behind a popup is at best a workaround. It is. > What if you receive an email while changing your audio setup ? Then you close the popup and get the notification, I don't see an issue with that. It's not like you fiddle with Sy

D24276: Add text to speech functionality to klipper.

mart added a comment. this only affects the old standalone executable, right? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24276 To: whiting, davidedmundson, gladhorn, #plasma_accessibility, #plasma Cc: mart, ndavis, plasma-devel, LeGast00n, The-Feren-OS-

KDE CI: Plasma » kscreen » stable-kf5-qt5 SUSEQt5.12 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20SUSEQt5.12/25/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 16 Oct 2019 16:47:00 + Build duration: 2 min 48 sec and counting CONSOLE OUTPUT [...tr

D24276: Add text to speech functionality to klipper.

whiting added a comment. In D24276#548330 , @mart wrote: > this only affects the old standalone executable, right? Um, I guess so. I didn't realize there was something else... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://

D24208: [Notifications] Dodge Plasma dialogs

ngraham added a comment. In D24208#548315 , @meven wrote: > In D24208#548272 , @ngraham wrote: > > > In D24208#548153 , @broulik wrote: > > > > > Bluet

D24706: Don't use focus color on checkable button backgrounds

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY This fixes a usability problem where it was hard to tell whether or not a focused and checkable

D24706: Don't use focus color on checkable button backgrounds

ngraham added a comment. Before/after images or video? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezh

D24706: Don't use focus color on checkable button backgrounds

ndavis updated this revision to Diff 68069. ndavis removed a subscriber: ngraham. ndavis added a comment. Change the style of the if else in the AnimationHover section REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=68068&id=68069 BRANCH focus-togg

D24706: Don't use focus color on checkable button backgrounds

ndavis added a comment. Darn, I just realized the text still uses the highlight text color. Not sure how to fix that besides changing the color in the colorscheme. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: plasma-devel, LeGast

D24634: [WIP] Allow contextualActions to flow into the header toolbar

ngraham accepted this revision as: ngraham. ngraham added a comment. This revision is now accepted and ready to land. This works really well in Discover, Kamoso, and kirigami-gallery. Still a big thumbs-up from me. REPOSITORY R169 Kirigami BRANCH contextactions_in_toolbar REVISION DETAI

D14068: add -P switch to one-shot redshift call

ngraham abandoned this revision. ngraham added a comment. Superseded by D23330 . REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D14068 To: ngraham, #plasma, romangg, martinkostolny, grmat Cc: davidedmundson, ngr

D23401: Fix scroll control (add -P option)

ngraham abandoned this revision. ngraham added a comment. Superseded by D23330 . REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D23401 To: ngraham, martinkostolny, srenaud Cc: ngraham, plasma-devel, LeGast00n, T

D14245: Use '-P' option to properly adjust color temperature in manual mode

ngraham abandoned this revision. ngraham added a comment. Superseded by D23330 . REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D14245 To: ngraham, martinkostolny, andrewc Cc: plasma-devel, LeGast00n, The-Feren-

D24706: Don't use focus color on checkable button backgrounds

ndavis updated this revision to Diff 68070. ndavis added a comment. Wait no, I got it - Don't use HighlightedText if sunken REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=68069&id=68070 BRANCH focus-toggle-button (branched from master) REVIS

D24706: Don't use focus color on checkable button backgrounds

ndavis added a comment. The hover color is still kind of an issue, but less of an issue. It looked really stiff and unnatural without something to indicate that it can be hovered. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: plas

D24488: [kcm] Don't transform button to show rotated icon

ngraham added a comment. I agree with roman that the rotated icons are preferable from a usability perspective. Maybe we need new icons then? #VDG REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24488 To: davidedmundson, #plas

D24483: [Weather data engine] Handle windy conditions in NOAA backend

ngraham added a comment. Nice. The icons should go in today, after which I'll land this. REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg, LeG

D24488: [kcm] Don't transform button to show rotated icon

broulik added a comment. I would still suggest overriding the `contentItem` of the `Button` and put a rotated `Kirigami.Icon` in there without actually transforming the entire button. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24488 To: davidedmundson, #plasma

D24706: Don't use focus color on checkable button backgrounds

ngraham added a comment. I see what you're trying to do here, and I approve. But I think it might make more sense to more generally rethink how we indicate focus for buttons. IMO we should draw a highlight around the edges rather than changing the background color, for the following reasons:

D24488: [kcm] Don't transform button to show rotated icon

davidedmundson updated this revision to Diff 68076. davidedmundson edited the summary of this revision. davidedmundson added a comment. update REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24488?vs=67488&id=68076 BRANCH master REVISION DETAIL https:/

  1   2   >