D24924: Don't reset model when adding an active connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:6929300787ac: Don't reset model when adding an active connection (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D24919: Don't reset model when device state changes

This revision was automatically updated to reflect the committed changes. Closed by commit R116:2bb496b0708f: Don't reset model when device state changes (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24919?vs=68694&id=68698#toc REPOSITORY R116 Plasma Networ

D24925: KCM KSplash port to ManagedConfigModule

crossi added inline comments. INLINE COMMENTS > crossi wrote in kcm.cpp:148 > it needs an explicit call, like load() and save() My bad. setNeedsSave() is no longer needed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24925 To: crossi, #plasma, ervin, mart, b

D24927: Use updateItem

jgrulich added a comment. I just pushed the very same change so you don't need to do the review. Can be closed then. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24927 To: nicolasfella, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-D

D24925: KCM KSplash port to ManagedConfigModule

crossi updated this revision to Diff 68699. crossi added a comment. setNeedsSave() not needed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24925?vs=68682&id=68699 REVISION DETAIL https://phabricator.kde.org/D24925 AFFECTED FILES kcms/ksplash/

D24906: [KCMs/Night Color] Explain Night Color feature inline

ngraham updated this revision to Diff 68704. ngraham added a comment. Tweak wording and set a maximum width for the label REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24906?vs=68646&id=68704 BRANCH explain-night-color (branched from master) REV

D24906: [KCMs/Night Color] Explain Night Color feature inline

ngraham added a comment. In D24906#553215 , @ahiemstra wrote: > Hmm, I feel the text here is a bit vague... "can make" should probably be "makes". Also, do people understand what "making colours warmer" means? I would hope so; warm vs co

D24906: [KCMs/Night Color] Explain Night Color feature inline

This revision was automatically updated to reflect the committed changes. Closed by commit R119:af39f0aeaf93: [KCMs/Night Color] Explain Night Color feature inline (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24906?vs=68704&id=6

D24906: [KCMs/Night Color] Explain Night Color feature inline

GB_2 added a comment. In the Desktop Effects KCM the label is top-left aligned. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24906 To: ngraham, #vdg, #plasma, ndavis, zzag Cc: GB_2, ahiemstra, davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-D

D24906: [KCMs/Night Color] Explain Night Color feature inline

ngraham added a comment. The desktop effects KCM doesn't have a centered form layout like this one does. I tried a left-aligned label but it looked quite odd. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24906 To: ngraham, #vdg, #plasma, ndavis, zzag Cc: G

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

wbauer added a comment. In D24748#552313 , @anthonyfieroni wrote: > You can try it like that: > > if (!m_editMode) { > event->setAccepted(false); > } > > > or > > event->setAccepted(m_editMode); > That does

D24901: [sidebar] Add a hover effect to intro page icons

This revision was automatically updated to reflect the committed changes. Closed by commit R124:a306b76cb853: [sidebar] Add a hover effect to intro page icons (authored by filipf). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24901?vs=68641&id=68713

D21815: [sddm-theme] Start moving from QQC1 to QQC2

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5c8ce892e394: [sddm-theme] Start moving from QQC1 to QQC2 (authored by cblack). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=64261&id=68716 REV

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7a7363289304: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen (authored by cblack). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kd

D24934: [notifications] Center no notification text on mobile

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED FILES applets/notificatio

D24786: [GTK3] Add styles for libhandy widgets

cblack added a comment. In D24786#550396 , @ndavis wrote: > I think it might be a bit premature to copy the look of Plasma Mobile at this point. I don't know what is likely to change and what is likely to stay. I expect that it will mirror the l

D24934: [notifications] Center no notification text on mobile

KonqiDragon added a comment. Could you add a rounded corners? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24934 To: nicolasfella, #plasma, #vdg Cc: KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, n

D24935: Fix search field focus, both initial and on-demand

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now the search field doesn't get focus initially, or w

D24934: [notifications] Center no notification text on mobile

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Keep the width and enable wrapping and horizontal centering. We both know how wide some locale can get :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricat

D24934: [notifications] Center no notification text on mobile

nicolasfella updated this revision to Diff 68720. nicolasfella added a comment. - Do as Kai says REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24934?vs=68718&id=68720 BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED F

D24934: [notifications] Center no notification text on mobile

nicolasfella added a comment. Looks just more complicated to me, but :shrug: REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24934 To: nicolasfella, #plasma, #vdg, broulik Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampa

D24934: [notifications] Center no notification text on mobile

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Fix it, then ship it INLINE COMMENTS > FullRepresentation.qml:582 > +horizontalAlignment: Kirigami.Settings.isMobile ? > Text.AlignHCenter : Text.AlignLeft > +

D24934: [notifications] Center no notification text on mobile

nicolasfella updated this revision to Diff 68721. nicolasfella added a comment. - Fix it REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24934?vs=68720&id=68721 BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED FILES a

D24934: [notifications] Center no notification text on mobile

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c3ab37034791: [notifications] Center no notification text on mobile (authored by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24934?vs=687

D24934: [notifications] Center no notification text on mobile

broulik added inline comments. INLINE COMMENTS > FullRepresentation.qml:580 > PlasmaExtras.Heading { > width: list.width > +height: list.height Now you could have used an `anchors.fill` xD REPOSITORY R120 Plasma Workspace REVISION DETAIL https:

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.13 - Build # 41 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/41/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 20:17:45 + Build duration: 2 hr 4 min and counting CONSOLE OUTPUT

D24935: Fix search field focus, both initial and on-demand

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Let's give it a try, merge to master, this could have side-effects. INLINE COMMENTS > DiscoverDrawer.qml:85 > +id: searchField > +focus: true > This shouldn't

D24937: Set focus on the search bar by default

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Opened discover REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D2

D24937: Set focus on the search bar by default

ngraham added a comment. FWIW this doesn't actually fix the bug for me. The search bar is now focusable by hitting the tab key enough times, but it doesn't get focus by default for me. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24937 To: davide

D24935: Fix search field focus, both initial and on-demand

ngraham updated this revision to Diff 68726. ngraham added a comment. Remove unnecessary `focus: true` REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24935?vs=68719&id=68726 BRANCH fix-searchfield-focus (branched from master) REVISION DE

D24935: Fix search field focus, both initial and on-demand

ngraham added a comment. @apol does this make sense conceptually though? I don't want to commit a big ugly hack. REPOSITORY R134 Discover Software Store BRANCH fix-searchfield-focus (branched from master) REVISION DETAIL https://phabricator.kde.org/D24935 To: ngraham, #discover_softw

D24935: Fix search field focus, both initial and on-demand

apol added a comment. Sure, it makes sense. It's not really changing much, only removing the loader. The loader did make things slightly more complex so I can imagine this working better. The whole `Component.onCompleted: {` bit is what gives it the focus. Having the focus there

D24935: Fix search field focus, both initial and on-demand

ngraham added a comment. In D24935#553754 , @apol wrote: > Having the focus there (which is where it used to be in some older version) makes it a bit harder to navigate the central view with the arrows Hopefully that will eventually be fi

D24935: Fix search field focus, both initial and on-demand

This revision was automatically updated to reflect the committed changes. Closed by commit R134:5d1b3718efb8: Fix search field focus, both initial and on-demand (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24935?vs=6872

D24940: Enchanting/Showing more informations on the info section of plasma-nm plasmoid

mibofra created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. mibofra requested review of this revision. REVISION SUMMARY I apologize if I annoy someone with this request, as here https://bugs.kde.org/show_bug.cgi?id=3

D24732: Rewrite AppChooser dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R838:c85055441a22: Rewrite AppChooser dialog (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68673&id

D24940: Enchanting/Showing more informations on the info section of plasma-nm plasmoid

jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > networkmodelitem.cpp:548 > > +if (device && device->ipV4Config().isValid() && m_connectionState == > NetworkManager::ActiveConnection::Activated) {

D24810: Ensure defintion of XDG_DATA_DIRS

tcberner updated this revision to Diff 68731. tcberner added a comment. Fix comment and commit message. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24810?vs=68379&id=68731 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24810 A

D24810: Ensure defintion of XDG_DATA_DIRS

tcberner updated this revision to Diff 68732. tcberner edited the summary of this revision. tcberner added a comment. Update commit message in diff. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24810?vs=68731&id=68732 BRANCH master REVISION D

<    1   2