D26021: Display sub categories when searching

mart marked 2 inline comments as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in SidebarMode.cpp:400 > please check validity, otherwise model is null and we'll crash. > > also ..why make it const, only to cast it? got rif of the cast REPOSITORY R124 System

D26021: Display sub categories when searching

mart updated this revision to Diff 71776. mart added a comment. - get rid of the const cast REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71775=71776 BRANCH arcpatch-D26021 REVISION DETAIL https://phabricator.kde.org/D26021

D26078: Ship plasma-logo in repo

ngraham added a comment. +1 for the concept, but will this implementation work for users? Should we maybe use the QRC mechanism instead? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D26078 To: davidre, #plasma, GB_2 Cc: ngraham, plasma-devel, LeGast00n,

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

davidedmundson added a comment. That's quite a good idea. INLINE COMMENTS > sniproxy.cpp:154 > //tell client we're embedding it > -xembed_message_send(wid, XEMBED_EMBEDDED_NOTIFY, m_containerWid, 0, 0); > +xembed_message_send(wid, XEMBED_EMBEDDED_NOTIFY, 0, m_containerWid, >

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in sniproxy.cpp:154 > can you explain the swapping 0 and m_containerWid here? I knew someone will ask, I wanted to add comment here but you were too quick :) I was not following the standard - worked because most clients

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 594 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/594/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Dec 2019 12:56:11 + Build duration: 1 min 39 sec and counting CONSOLE OUTPUT

D25539: feat(kcm): add revert timer

ngraham added a comment. In D25539#579182 , @broulik wrote: > > With direct-apply having a revert window/overlay/inline message only shown when certain critical options were changed could be a good compromise. > > It needs to be made

D26041: Move applet configuration to KCM

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right, LGTM them! INLINE COMMENTS > jgrulich wrote in ConfigurationDialog.qml:55 > The Configuration class contains only static methods, which means you cannot > emit signal from

D26041: Move applet configuration to KCM

jgrulich marked 4 inline comments as done. jgrulich added inline comments. INLINE COMMENTS > ngraham wrote in ConfigurationDialog.qml:55 > Then it should be given the NOTIFY property so it can be bound to The Configuration class contains only static methods, which means you cannot emit signal

D25634: Add kconf update script for ksmserver

broulik added a comment. -1 I'd prefer if the config value was kept REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25634 To: davidedmundson, #plasma Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26039: [Plasma Style KCM] Add search filter

crossi added a comment. In D26039#579546 , @davidre wrote: > - Only move to the next theme if the current selected one is marked for deletion > > FYI I could spot this same bug in the colors kcm. Will fix after this Looks good to

D26021: Display sub categories when searching

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in SidebarMode.cpp:400 > please check validity, otherwise model is null and we'll crash. > > also ..why make it const, only to cast it? QModelIndex::index() is always const? REPOSITORY R124 System Settings REVISION DETAIL

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY When the window is embedded, it should not request position change. Sometimes applications are

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

davidedmundson added a comment. > In future I will want to cleanup the code a bit (formatting, maybe some refactoring). I don't know if this welcomed because this will break git history. Refactoring, sure go for it. I don't really agree with people worrying about git history, if you

D26041: Move applet configuration to KCM

jgrulich updated this revision to Diff 71785. jgrulich marked 2 inline comments as done. jgrulich added a comment. Simplify tooltips REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26041?vs=71707=71785 BRANCH kcm-config REVISION

D26021: Display sub categories when searching

ngraham added a comment. Nice! Somehow this has regressed the text color for the selected item: F7824037: Screenshot_20191218_064325.png It used to be white before this patch. REPOSITORY R124 System Settings REVISION DETAIL

D25782: [Notifications] Add draggable file icon when single file job finishes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:a22c44dafc6b: [Notifications] Add draggable file icon when single file job finishes (authored by broulik). CHANGED

D26021: Display sub categories when searching

mart updated this revision to Diff 71775. mart marked 3 inline comments as done. mart added a comment. - adress comments - fix clicking againthe same category REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71614=71775 BRANCH

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Awesome stuff INLINE COMMENTS > sniproxy.cpp:4 > * Copyright (C) 2015 David Edmundson > * > * This library is free software; you can redistribute it and/or make

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

davidedmundson added a comment. That's accepting purely code-wise. Please make sure the text is approved by VDG people before pushing. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26018 To: broulik, #plasma, #vdg, davidedmundson Cc: ngraham,

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

ngraham accepted this revision. ngraham added a comment. As discussed in chat: i18nc("Turn do not disturb mode on/off with keyboard shortcut", "Toggle with:") REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26018 To: broulik, #plasma, #vdg,

D26041: Move applet configuration to KCM

ngraham added inline comments. INLINE COMMENTS > jgrulich wrote in ConfigurationDialog.qml:55 > I did it this way, because if I use checked: foo, then it reports warning > about non-NOTIFYable property. Then it should be given the NOTIFY property so it can be bound to > jgrulich wrote in

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 580 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/580/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Dec 2019 13:40:46 + Build duration: 55 sec and counting CONSOLE OUTPUT [...truncated 127

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 292 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/292/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Dec 2019 13:40:46 + Build duration: 54 sec and counting CONSOLE OUTPUT

D26065: [KCM/Access] Port to use KConfigXT

ngraham added a comment. Sorry to invalidate your work. :/ Please feel free to review that patch! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26065 To: meven, ervin, #plasma, crossi Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

Re: KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 593 - Failure!

Dep can't be fetched, problem exists on the CI side. I have filed a sysadmin request to look into this. David

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:24f75b2fda71: [XembedSNIProxy] Redirect and handle structure requests on the embedded window. (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 595 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/595/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Dec 2019 13:04:36 + Build duration: 1 min 17 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 330 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/330/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Dec 2019 13:04:38 + Build duration: 48 sec and counting CONSOLE OUTPUT

D25992: [Wizard] Allow choosing device by double click

This revision was automatically updated to reflect the committed changes. Closed by commit R97:0fd34f0497cc: [Wizard] Allow choosing device by double click (authored by broulik). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25992?vs=71525=71770 REVISION

D25777: Avoid deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1a9e84b79e6c: Avoid deprecated method (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25777?vs=70996=71780 REVISION DETAIL

D26079: [XembedSNIProxy] Redirect and handle structure requests on the embedded window.

kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in sniproxy.cpp:4 > make sure you update this sometime I have another fix ready :) In future I will want to cleanup the code a bit (formatting, maybe some refactoring). I don't know if this welcomed because this will break

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 329 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/329/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Dec 2019 12:56:11 + Build duration: 6 min 5 sec and counting CONSOLE OUTPUT

D26065: [KCM/Access] Port to use KConfigXT

meven abandoned this revision. meven added a comment. In D26065#579715 , @ngraham wrote: > FYI this KCM is also being rewritten in QML+KConfigXT somewhere else: D25375 Since the other diff seems quite

D26039: [Plasma Style KCM] Add search filter

davidre updated this revision to Diff 71760. davidre added a comment. - Only move to the next theme if the current selected one is marked for deletion FYI I could spot this same bug in the colors kcm. Will fix after this REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26021: Display sub categories when searching

davidedmundson added inline comments. INLINE COMMENTS > MenuModel.cpp:102 > +MenuItem *candidate = mi->parent(); > +while ( candidate && candidate->parent() && > candidate->parent()->parent() ) { > +candidate = candidate->parent(); More comments are

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 328 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/328/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Dec 2019 10:36:10 + Build duration: 48 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 593 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/593/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Dec 2019 10:36:10 + Build duration: 1 min 13 sec and counting CONSOLE OUTPUT

D26081: [dataengine/geolocation] Use logging category in location_ip.cpp

meven created this revision. meven added reviewers: Plasma, apol, crossi, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D26065: [KCM/Access] Port to use KConfigXT

ngraham added a comment. FYI this KCM is also being rewritten in QML+KConfigXT somewhere else: D25375 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26065 To: meven, ervin, #plasma, crossi Cc: ngraham, broulik,

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

crossi created this revision. crossi added reviewers: Plasma, Frameworks, ervin, mart, davidedmundson, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Allow the KCM Notifications to query the immutable

D26083: KCM Notifications : disable settings that are immutable

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, davidedmundson, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Need D26082 to work. TEST

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R119:35e8cb70c0c0: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26018?vs=71599=71787#toc REPOSITORY

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 294 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/294/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Dec 2019 15:49:42 + Build duration: 1 min 9 sec and counting CONSOLE OUTPUT

D26021: Display sub categories when searching

mart updated this revision to Diff 71799. mart added a comment. - white text when selected - lways load the module when in search mode REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71776=71799 BRANCH arcpatch-D26021 REVISION DETAIL

D26088: [XembedSNIProxy] Regression - really resize instead of notifying only.

kmaterka added a comment. I don't know why I missed that, I tested D25777 but obviously not enough. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26088 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson Cc:

D26021: Display sub categories when searching

mart updated this revision to Diff 71803. mart added a comment. - Pleased code enter the commit message for your changes. Lines starting REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71799=71803 BRANCH arcpatch-D26021 REVISION DETAIL

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi added inline comments. INLINE COMMENTS > broulik wrote in settings.h:343 > Not a fan of this becoming public API Maybe not the best approach. Any suggestion to access the KCoreConfigSkeleton encapsulated to register them in the KCM's ConfigModule ? REPOSITORY R120 Plasma Workspace

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

meven updated this revision to Diff 71790. meven added a comment. Remove unnecessary call REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71730=71790 BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049

D26086: Don't fetch pixmap if we have it already

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `AppData` contains a `QIcon` with pixmap data gathered from `KWindowSystem::icon` which we

D26021: Display sub categories when searching

mart added a comment. In D26021#579771 , @ngraham wrote: > Nice! > > Somehow this has regressed the text color for the selected item: F7824037: Screenshot_20191218_064325.png > > It used to be white

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 331 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/331/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Dec 2019 16:02:47 + Build duration: 1 min 14 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 582 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/582/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Dec 2019 15:49:42 + Build duration: 12 min and counting JUnit Tests Name: (root)

D26081: [dataengine/geolocation] Use logging category in location_ip.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit R120:88c8e4b0d77e: [dataengine/geolocation] Use logging category in location_ip.cpp (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25945: Sync dark theme preference for GTK3 applications

ngraham added a comment. @apol is the maintainer and @broulik hasn't raised any objections, so I'd say you're good to go. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH sync-dark-gtk3-theme-preference REVISION DETAIL https://phabricator.kde.org/D25945 To: gikari, apol, cblack,

D25945: Sync dark theme preference for GTK3 applications

This revision was automatically updated to reflect the committed changes. Closed by commit R99:99c72b4b9581: Sync dark theme preference for GTK3 applications (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

meven updated this revision to Diff 71792. meven marked an inline comment as done. meven added a comment. Split REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71790=71792 BRANCH nightcolor-default REVISION DETAIL

D26021: Display sub categories when searching

mart added a comment. In D26021#579771 , @ngraham wrote: > Nice! > > Somehow this has regressed the text color for the selected item: F7824037: Screenshot_20191218_064325.png > > It used to be white

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

meven updated this revision to Diff 71795. meven added a comment. Add a space for form REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71792=71795 BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049 AFFECTED

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f1943a1e59ff: [KCM/NightColor] Allow the user to know the default settings are selected (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

meven added a comment. FYI the restore button is currently always enabled on load even if parameters represent the default ones. I have a fix proposal at : https://phabricator.kde.org/D26085 REPOSITORY R119 Plasma Desktop BRANCH nightcolor-default REVISION DETAIL

D26087: [KCM/Autostart] Fix a foreach

meven created this revision. meven added reviewers: Plasma, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26087 AFFECTED

D26087: [KCM/Autostart] Fix a foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R119:137c62efaf34: [KCM/Autostart] Fix a foreach (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26087?vs=71797=71798 REVISION DETAIL

D26088: [XembedSNIProxy] Regression - really resize instead of notifying only.

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Regression introduced in previous commit, review D25777 .

D25670: Synchronize decorations buttons order in GTK headerbars

apol added a comment. This looks like it's trying to change configurations from other sources. This feels wrong. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25670 To: gikari, #vdg, cblack, #plasma Cc: apol, GB_2, broulik, plasma-devel,

D25945: Sync dark theme preference for GTK3 applications

gikari added a comment. @broulik do I need your revision to land this? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH sync-dark-gtk3-theme-preference REVISION DETAIL https://phabricator.kde.org/D25945 To: gikari, apol, cblack, broulik, #vdg Cc: GB_2, plasma-devel, LeGast00n,

D25762: Only serialize window pixmap if we're using it

broulik updated this revision to Diff 71789. broulik retitled this revision from "Don't bother serializing window icon pixmap for known services" to "Only serialize window pixmap if we're using it". broulik edited the summary of this revision. broulik added a comment. - Use

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > main.qml:89 > +evenBeginManField.backend = cA.eveningBeginFixedDefault; > +transTimeField.value = cA.transitionTimeStaged = > cA.transitionTimeDefault; > Please split.

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 581 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/581/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Dec 2019 15:26:56 + Build duration: 1 min 21 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 293 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/293/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Dec 2019 15:26:56 + Build duration: 47 sec and counting CONSOLE OUTPUT

D25872: Refactor GTK KCM code

This revision was automatically updated to reflect the committed changes. Closed by commit R99:13c4eee2553a: Refactor GTK KCM code (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25872?vs=71246=71804 REVISION DETAIL

D26041: Move applet configuration to KCM

This revision was automatically updated to reflect the committed changes. jgrulich marked an inline comment as done. Closed by commit R116:7601936e3642: Move applet configuration to KCM (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26041?vs=71785=71788#toc

D25670: Synchronize decorations buttons order in GTK headerbars

gikari added a comment. In D25670#579888 , @apol wrote: > This looks like it's trying to change configurations from other sources. This feels wrong. Could you elaborate on that? What do you mean exactly? What other sources? Do you mean

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 596 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/596/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Dec 2019 16:02:47 + Build duration: 12 min and counting BUILD ARTIFACTS

D26088: [XembedSNIProxy] Regression - really resize instead of notifying only.

kmaterka added inline comments. INLINE COMMENTS > sniproxy.cpp:228 > { > -xcb_configure_notify_event_t event; > -memset(, 0x00, sizeof(xcb_configure_notify_event_t)); xcb_configure_notify_event_t @davidedmundson In this commit

D26021: Display sub categories when searching

ngraham added inline comments. INLINE COMMENTS > MenuModel.cpp:25 > #include > - > +#include > #include "MenuItem.h" Remove > CategoriesPage.qml:149 > +//icon: model.decoration > +//label: model.display > separatorVisible: false Remove REPOSITORY

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71802. trmdi added a comment. - Remove unneeded code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71650=71802 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL

D25945: Sync dark theme preference for GTK3 applications

gikari updated this revision to Diff 71806. gikari added a comment. Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25945?vs=71424=71806 BRANCH sync-dark-gtk3-theme-preference REVISION DETAIL

D26065: [KCM/Access] Port to use KConfigXT

meven updated this revision to Diff 71756. meven added a comment. Remove unconvenient white space, add a else to a if block REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26065?vs=71734=71756 BRANCH kaccess-kconfigxt REVISION DETAIL

D26077: [kcms/ksmserver] Swap shutdown options

broulik created this revision. broulik added reviewers: Plasma, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY With kcfg magic the order of the radio buttons determines the enum value. Just swap them

D26078: Ship plasma-logo in repo

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY We don't want the plasma-logo on the homepage to be changed to something else by the icon theme. It's not used like an icon but

D26039: [Plasma Style KCM] Add search filter

crossi added a comment. In D26039#579253 , @davidre wrote: > - Reinstate isSaveNeeded > - Fix initial index and pendingDeletion I can confirm these issue are fixed. Still one concern, when setting an item for pending deletion, it

D26077: [kcms/ksmserver] Swap shutdown options

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Fastest bug-to-fix process this year? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26077 To: broulik, #plasma, ervin, romangg Cc: romangg,

D26065: [KCM/Access] Port to use KConfigXT

meven updated this revision to Diff 71757. meven added a comment. Remove unconvenient white space, add a else to a if block REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26065?vs=71756=71757 BRANCH kaccess-kconfigxt REVISION DETAIL

D26077: [kcms/ksmserver] Swap shutdown options

romangg resigned from this revision. romangg added a comment. This revision now requires review to proceed. Kai said that he wants to wait on @ervin's opinion since this patch would change the button order and maybe there is a way to solve the issue without doing that. REPOSITORY R119

D25670: Synchronize decorations buttons order in GTK headerbars

This revision was automatically updated to reflect the committed changes. Closed by commit R99:2b12ceb1b891: Synchronize decorations buttons order in GTK headerbars (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D25670: Synchronize decorations buttons order in GTK headerbars

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Never mind my last message, that's okay. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH gtk-decoration-order-sync (branched from master) REVISION DETAIL

D25670: Synchronize decorations buttons order in GTK headerbars

gikari updated this revision to Diff 71810. gikari added a comment. Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25670?vs=70782=71810 BRANCH gtk-decoration-order-sync (branched from master) REVISION DETAIL

D26093: Use a fixed icon size for the notification popup close button

ndavis added a comment. It may just be an optical illusion. Sometimes red next to blue or another highly saturated color will appear to be 1px higher than it actually is. Here's a white icon: F7824663: Screenshot_20191218_191906.png REPOSITORY R120

D26091: [Notifications] Improve self-closing behavior

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When a plasmoid collapses in Active state, the popup is hidden. In Passive state, however, one

D26093: Use a fixed icon size for the notification popup close button

ndavis added a comment. I do think the larger close icon looks nicer and more in line with window decorations: F7824629: Screenshot_20191218_182922.png The offset is still there, unfortunately. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26094: Add shadow rendering helper functions

ndavis updated this revision to Diff 71825. ndavis added a comment. Edit ellipse shadow comment REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26094?vs=71824=71825 BRANCH replace-hardcoded (branched from master) REVISION DETAIL

D26094: Add shadow rendering helper functions

ndavis created this revision. ndavis added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY This patch makes other helper functions reuse more code by calling these shadow rendering functions

D26093: Use a fixed icon size for the notification popup close button

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Both the popup header size as well as units.smallMargin depend on font size. This causes

D14949: Add option for whether to show the volume change OSD

achauvel added a comment. This hasn’t been merged. The option seem to already exist for all types of OSD in: Workspace → Workspace Behavior → General Behavior → «Display visual feedback for status change», though that’s a very vague and unclear option name. I tried to use the

D26093: Use a fixed icon size for the notification popup close button

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Actually, it not even an optical illusion. It turns out it's because my laptop screen just low quality :( Sorry for all the fuss REPOSITORY R120 Plasma Workspace BRANCH

D20569: RFC: Use more compact OSD

achauvel added a comment. The current design seems amazing, how hard would it be to put it as an option? Even it may be better to use the notification system in the long run, accepting this patch or a modified version of it would be better than to wait for a long time still. Also, most

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 295 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/295/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Dec 2019 04:56:28 + Build duration: 46 min and counting JUnit Tests Name: