D26344: Fix building plasma-desktop without X11 cursor development headers

ouwerkerk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ouwerkerk requested review of this revision. REVISION SUMMARY The lookandfeel KCM has a hard dependency on xcursor code of the cursor KCM. This change updates the CMake code to reflect

D26344: Fix building plasma-desktop without X11 cursor development headers

ouwerkerk updated this revision to Diff 72544. ouwerkerk added a comment. Fixed commit message typo REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26344?vs=72542=72544 BRANCH fix-build-without-cursors REVISION DETAIL

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ngraham Sorry to bother you again, but tomorrow is repo freeze and it would be unfortunate if this doesn't make it in. I mean it's finished and it works correctly, right? If needed we can still do small polishing during the Beta period, correct? REPOSITORY R120

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven marked 3 inline comments as done. meven added a comment. In D26111#580344 , @meven wrote: > Two points raised by @broulik but not resolved : > > - should display a specific icon based on file mimetype ? > - should we allow to open a

D26354: Introduce ActionRow widget

cblack updated this revision to Diff 72579. cblack marked an inline comment as done. cblack added a comment. Update based off of feedback REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26354?vs=72578=72579 BRANCH actionrow (branched from master)

D26344: Fix building plasma-desktop without X11 cursor development headers

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. That may fix the build, but it's a somewhat hamfisted approach, lookandfeel is a key KCM, we can't make that depend on an optional feature. We need to either:

D26354: Introduce ActionRow widget

cblack created this revision. cblack added reviewers: VDG, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY ActionRows are row widgets with associated actions. Left and right actions are triggered by

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. Yeah sorry, I need to block out some time to build a mental model of all the possible combinations currently, and what this changes them to, to make sure nothing regresses. Don't worry, this can go in after the soft feature freeze since it was already in progress,

D26354: Introduce ActionRow widget

cblack updated this revision to Diff 72580. cblack added a comment. Get the other two items unhardcoded REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26354?vs=72579=72580 BRANCH actionrow (branched from master) REVISION DETAIL

D26354: Introduce ActionRow widget

ngraham added inline comments. INLINE COMMENTS > ActionRow.qml:51 > + > +height: 64 > + Make this a multiple of GridUnit > ActionRow.qml:144 > +anchors.left: parent.left > +anchors.leftMargin: 20 > +anchors.verticalCenter:

D26344: Fix building plasma-desktop without X11 cursor development headers

ouwerkerk added a comment. Right now the KCM CmakeListst does stuff like: set(kcm_lookandfeel_SRCS kcmmain.cpp kcm.cpp ../krdb/krdb.cpp ../cursortheme/xcursor/cursortheme.cpp ../cursortheme/xcursor/xcursortheme.cpp ) And the main `kcm.cpp` simply

D26354: Introduce ActionRow widget

ouwerkerk added a comment. Are we certain about naming here: `SwipeAction.isDelete`? Maybe `SwipeAction.remove` or `SwipeAction.removeFromList` ? It doesn't necessarily have to be a real "delete" action that is backing this, maybe all you want to convey with the name of this setting is that