D26688: WIP: [Night Color] Display time when the next transition will start

anthonyfieroni added inline comments. INLINE COMMENTS > zzag wrote in main.qml:57 > 6500K is the neutral screen color temperature. Although I don't think that I > follow you. Do you recommend not to hardcode this constant? > Do you recommend not to hardcode this constant? Yes. REPOSITORY

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. In D26544#595246 , @bcooksley wrote: > Cancel that, it fails to build on Linux as well - i'm guessing that the KNetstuff changes have not been landed? The KNS changes have indeed not been landed yet REPOSITORY

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 666 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/666/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 09:28:11 + Build duration: 13 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 667 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/667/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 09:41:14 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated

D26688: WIP: [Night Color] Display time when the next transition will start

zzag updated this revision to Diff 73685. zzag added a comment. - Add Monitor.NeutralTemperature constant - Display locale time - Nate's suggestion REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26688?vs=73616=73685 BRANCH

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 376 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/376/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 09:14:31 + Build duration: 50 min and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 668 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/668/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 10:06:41 + Build duration: 11 min and counting JUnit Tests Name: (root)

D26702: [MPRIS Data Engine] Support player proxying for another one

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Plasma Browser Integration provides controls for Chrome, so when a player with `kde:pid`

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 665 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/665/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 09:14:31 + Build duration: 6 min 45 sec and counting CONSOLE OUTPUT

D26684: [Notifications KCM] Add docbook for new KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:75481705c68e: [Notifications KCM] Add docbook for new KCM (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26684?vs=73618=73681#toc REPOSITORY R119 Plasma Desktop

D26655: show a thin separator between view and scrollbar

mart added a comment. In D26655#595102 , @ndavis wrote: > I noticed that when hovering on the scrollbar border, while the view area is not focused, the scrollbar handle is light gray (Breeze Dark, dark gray for Breeze) instead of blue. Moving

D26688: WIP: [Night Color] Display time when the next transition will start

zzag updated this revision to Diff 73686. zzag added a comment. - Use i18nc(). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26688?vs=73685=73686 BRANCH show-next-transition-timings REVISION DETAIL https://phabricator.kde.org/D26688 AFFECTED

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

meven added a comment. In D26544#595269 , @leinir wrote: > In D26544#595246 , @bcooksley wrote: > > > Cancel that, it fails to build on Linux as well - i'm guessing that the KNetstuff changes have

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. In D26544#595312 , @meven wrote: > In D26544#595269 , @leinir wrote: > > > In D26544#595246 , @bcooksley wrote: > > > > >

D26667: refactor about-distro to more generically support textual dumps

sitter updated this revision to Diff 73708. sitter added a comment. remove extra file REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26667?vs=73707=73708 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26667 AFFECTED FILES

D26709: add gpu entry to about system

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY simply queries gl_renderer from gl also refactor string processing for (R) and (TM) replacement so it can be shared for cpu

D26705: KCM/Component Revamp Terminal Emulator UI

ngraham accepted this revision. ngraham added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > componentchooserterminal.cpp:76 > + > +const auto constraint = QStringLiteral("'TerminalEmulator' in Categories > AND (not exist NoDisplay OR NoDisplay !=

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 58 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/58/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 13:13:24 + Build duration: 9 min 10 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 141 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/141/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 13:17:55 + Build duration: 25 min and counting JUnit Tests Name: (root) Failed:

D26706: Remove notification inhibitor lock

This revision was automatically updated to reflect the committed changes. Closed by commit R116:8df6c01ca46f: Remove notification inhibitor lock (authored by broulik). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 383 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/383/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 14:07:46 + Build duration: 10 min and counting JUnit Tests Name:

D26709: add gpu entry to about system

broulik added inline comments. INLINE COMMENTS > GPUEntry.cpp:49 > +// It seems the renderer value may have excess information in > parentheses -> > +// strip that. Elide would probably be nicer, a bit meh with > QWidgets though. > +value = value.mid(0,

D26565: KCM/Component Revamp email config

meven added a comment. In D26565#595522 , @ngraham wrote: > Hmm, I don't have KMail installed yet it shows up in the combobox anyway. I don't think that makes sense. Everything in the combobox comes from /usr/share/applications/*desktop

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. As a side note: I have been using this code for a couple of days now, and while I think the separator looks well for vertical scrollbars, when you have both vertical and horizontal, ... this will need some getting used to. See: F7886206:

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 382 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/382/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 13:15:49 + Build duration: 48 min and counting CONSOLE OUTPUT

D26565: KCM/Component Revamp email config

ngraham added a comment. Hmm, I don't have KMail installed yet it shows up in the combobox anyway. I don't think that makes sense. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26565 To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil Cc:

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.13 - Build # 42 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/42/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 17:06:01 + Build duration: 3 min 54 sec and counting JUnit Tests Name:

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. In D26655#595314 , @mart wrote: > In D26655#595102 , @ndavis wrote: > > > I noticed that when hovering on the scrollbar border, while the view area is not focused,

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 672 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/672/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 13:15:49 + Build duration: 18 min and counting CONSOLE OUTPUT [...truncated 276

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:aa2119a835e9: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26506?vs=73369=73705#toc REPOSITORY R119 Plasma Desktop

Plasma 5.18 Branched

Plasma has branched for the 5.18 releases. Beta is due today and final release in three weeks time. Could i18n team move over the stable translations from master? Plasma team please don't commit new features to Plasma/5.18 branches but please do make lots of bug fixes. Jonathan

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 673 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/673/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 14:07:46 + Build duration: 6 min 26 sec and counting JUnit Tests Name: (root)

D26655: show a thin separator between view and scrollbar

ndavis added a comment. Vertical scrollbar taking the corner without the column header change: F7886334: Screenshot_20200116_083629.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26655 To: mart, #plasma, #breeze, #vdg,

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/8/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 15:18:54 + Build duration: 26 sec and counting CONSOLE OUTPUT

D9875: Extend parsing ssh prompt

fvogt added a comment. Ping. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9875 To: pali, fvogt Cc: ngraham, fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai,

D26705: KCM/Component Revamp Terminal Emulator UI

meven updated this revision to Diff 73718. meven marked an inline comment as done. meven edited the test plan for this revision. meven added a comment. NoDisplay == false instead of NoDisplay != true REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 59 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/59/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 17:05:59 + Build duration: 6 min 20 sec and counting JUnit Tests Name: (root)

D26658: fix(kwayland): move blocking tablet init before timer start

This revision was automatically updated to reflect the committed changes. Closed by commit R110:13b631eabb98: fix(kwayland): move blocking tablet init before timer start (authored by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D24706: [RFC] Change button style

ngraham added a comment. Would you mind rebasing this? It seems like we're moving forward with the idea of iterating on Breeze rather than making a whole new theme, and since Plasma 5.18 just branched, we have some space to hack on master now. I'd like to see if we can move forward with

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73695. meven added a comment. Add a couple of const REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73548=73695 BRANCH email-config REVISION DETAIL https://phabricator.kde.org/D26565 AFFECTED FILES

D26706: Remove notification inhibitor lock

broulik created this revision. broulik added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. broulik requested review of this revision. REVISION SUMMARY Now that the notifications dodge the

D26655: show a thin separator between view and scrollbar

ndavis added a comment. In D26655#595381 , @hpereiradacosta wrote: > As a side note: I have been using this code for a couple of days now, and while I think the separator looks well for vertical scrollbars, when you have both vertical and

D26655: show a thin separator between view and scrollbar

hpereiradacosta added a comment. > Can the top of the scrollbar go below the column headers instead of next to them? > > Like this: > F7886305: Screenshot_20200116_083629.png I don't think it is doable inside Qt no, due to how widgets are

D26705: KCM/Component Revamp Terminal Emulator UI

meven created this revision. meven added reviewers: Plasma, ervin, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Revamp UI, to use a simple combobox - Other... choice allows to select any programe

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 74 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/74/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 13:17:40 + Build duration: 23 min and counting CONSOLE OUTPUT [...truncated 259

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/41/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 13:13:24 + Build duration: 30 min and counting CONSOLE OUTPUT [...truncated

D26667: refactor about-distro to more generically support textual dumps

sitter updated this revision to Diff 73707. sitter added a comment. split into one class per file REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26667?vs=73602=73707 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26667 AFFECTED FILES

Plasma 5.18 LTS Beta

Plasma 5.18 LTS Beta is out for testing for the next three weeks! Emoji Selector, global edit mode, improved touch-friendliness, better GTK app support and weather widget gets breezy with windy conditions. https://kde.org/announcements/plasma-5.17.90 New in this release is plasma-nano and

Re: Plasma 5.18 LTS Beta

plasma-nm has an update 5.17.90.2 http://download.kde.org/unstable/plasma/5.17.90/plasma-nm-5.17.90.2.tar.xz sha256 2c68cab7de88e8479aa9be91255fcec4ca8129ae42c0a8aeee14b884ef5cd60e On Thu, 16 Jan 2020 at 14:42, Jonathan Riddell wrote: > Plasma 5.18 LTS Beta is out for testing for the next

D26710: [Notifications] Support DESKTOP_FILE_HINT without BAMF prefix

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY No idea why this has changed for my Spotify but that's what I have now... TEST PLAN 5.18 My

D26709: add gpu entry to about system

sitter added inline comments. INLINE COMMENTS > broulik wrote in GPUEntry.cpp:49 > `KSqueezedTextLabel` doesn't help? Never knew this was a thing! Looks like this would require lots of fiddling though. It seems to bug out with AlignLeft in the grid layout, and also one would have to know what

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 75 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/75/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 17:07:03 + Build duration: 3 min 57 sec and counting JUnit Tests Name: (root)

D26565: KCM/Component Revamp email config

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I'm so sorry, this was my mistake. Somehow KMail got re-installed without my knowledge. Probably https://bugzilla.suse.com/show_bug.cgi?id=1035802 biting me again. Once I've removed

D26688: WIP: [Night Color] Display time when the next transition will start

ngraham added a comment. Here's my suggestions for what to display in the applet for various conditions: Feature disabled: no tray icon shown anywhere Feature enabled but not active: tray icon in passive state (only in pop-up) with the following text: > Night color is inactive

D26580: Kicker/RecentDocuments display place's icon when resource matches one

meven added a comment. ping @hein REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26580 To: meven, #plasma, ngraham, hein Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. So what do we do here? The Qt bug has been fixed but still I'm not sure what should be done about the environment variables. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc:

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

ngraham added a comment. IIRC we used to do this, but changed it to run-on-demand to save some memory on startup. Might be worth revisiting that though, since I can confirm the latency that leads to the first few characters getting typed into the open app instead of KRunner, which is

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski added a comment. In D26718#595688 , @broulik wrote: > Maybe if we autostarted KRunner based on whether it was used previously "Used previously" as in opened at least once? I guess this is always true for every user, because

Re: Plasma 5.18 LTS Beta

Two more updates http://download.kde.org/unstable/plasma/5.17.90/plasma-nm-5.17.90.4.tar.xz b9a507d05806ec1cc83b2c6c5c6076901d5e3aaf4849f4a0691858cdfb282d74 http://download.kde.org/unstable/plasma/5.17.90/libkscreen-5.17.90.1.tar.xz

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski created this revision. pdabrowski added reviewers: Plasma, Plasma: Workspaces, davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pdabrowski requested review of this revision. REVISION SUMMARY autostart KRunner with Plasma as daemon to

D26717: [App Style KCM] Port GTK GHNS dialogs from exec()

gikari added a comment. In D26717#595664 , @ngraham wrote: > Even better would be if we can use the new QML dialogs too. See D26544 Does this count as a new feature, i.e is this QML change will be in

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

broulik added a comment. Hmm, I'd appreciate some startup time optimizations for KRunner first. Maybe if we autostarted KRunner based on whether it was used previously would be a nice trade-off between resources for systems that don't use it and power users that always use it and get

D26458: [windowsystem] Provide a KWindowShadow implementation

zzag updated this revision to Diff 73729. zzag added a comment. Adjust to recent changes in KWindowShadow REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26458?vs=73381=73729 BRANCH port-to-shadows-api REVISION

D26717: [App Style KCM] Port GTK GHNS dialogs from exec()

gikari created this revision. gikari added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Move away from using QDialog::exec() due to using nested event loop. Also make knsrc files use

D26717: [App Style KCM] Port GTK GHNS dialogs from exec()

ngraham added a comment. Even better would be if we can use the new QML dialogs too. See D26544 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26717 To: gikari, broulik Cc: ngraham, plasma-devel, LeGast00n,

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski added inline comments. INLINE COMMENTS > broulik wrote in main.cpp:231 > This is not how we want to autostart something :) Instead, you want to place > the desktop file in autostart folder again Right :) I thought of this so that everytime Plasma starts it ensures KRunner is running

D26714: KCM/Component Revamp FileManager UI

meven created this revision. meven added reviewers: Plasma, ervin, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH filemanager-settings REVISION DETAIL

D26715: [Widget Explorer] Show placeholder message when there are no widgets or searc results

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 416313 FIXED-IN: 5.19.0 TEST PLAN F7886823: Peek 2020-01-16 13-03.webm

D26717: [App Style KCM] Port GTK GHNS dialogs from exec()

gikari planned changes to this revision. gikari added a comment. Ok, then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26717 To: gikari, broulik Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26717: [App Style KCM] Port GTK GHNS dialogs from exec()

ngraham added a comment. No I see it as a consistency/polish/bugfix thing. The rest of the KCMs got ported to use the new dialog for Plasma 5.18; it would be a bit weird if this one didn't get the same treatment. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D26111: Runner: make recentdocument use KActivityStats data

meven added a comment. Adding @apol as reviewers as he was the original author of this runner. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik, apol Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D26714: KCM/Component Revamp FileManager UI

ngraham added a comment. Selecting the "Other..." option for this one takes me to the filetype editor for `inode/directory` instead of the app chooser as in the other patches. Is that intentional? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26714 To:

D26720: Cache single image wallpapers locally

broulik added a comment. This doesn't appear to be containment-aware (e.g. multi-screen, activities, etc). How does the settings page handle this scenario? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26720 To: ngraham, #plasma Cc: broulik, filipf,

D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results

davidedmundson added a comment. What does enabled on a label do? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26715 To: ngraham, #vdg, #plasma, apol Cc: davidedmundson, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ce5094c02a87: [Widget Explorer] Show placeholder message when there are no widgets or search… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18006: Include only the largest size for the "Next" wallpaper

ngraham added a comment. The whole point was to save some space on the user's machine. However trading space savings for load time maybe isn't the best trade-off? 18 MB isn't really all that much of a savings. Should we shelve this idea? REPOSITORY R31 Breeze REVISION DETAIL

D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results

ngraham added a comment. Yep. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26715 To: ngraham, #vdg, #plasma, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D26719: [Battery Monitor] Glow icon on hover

kmaterka added inline comments. INLINE COMMENTS > CompactRepresentation.qml:67 > -pluggedIn: batteryContainer.pluggedIn > -height: isConstrained ? batteryContainer.iconSize : > batteryContainer.iconSize - batteryLabel.height > -width:

D24706: [RFC] Change button style

ndavis added a comment. In D24706#595764 , @ngraham wrote: > Thanks Noah. > > So you're the boss after all (as the de- facto Breeze maintainer now), and I think we should follow your lead design-wise. But it might also be interesting to

D26720: Cache single image wallpapers locally

ngraham added a comment. Note that I found the code here very complicated so it's possible I may have done this in a sub-optimal way. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26720 To: ngraham, #plasma Cc: filipf, plasma-devel, LeGast00n,

D18006: Include only the largest size for the "Next" wallpaper

apol added a comment. -1 This will also reduce load time considerably (I did the profiling before, using the same resolution is a big win). Also you'll get to save quite some IO. If this is a problem, I'd suggest looking into doing these wallpapers in svg or even QML. REPOSITORY

D26719: [Battery Monitor] Glow icon on hover

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, broulik, ngraham, davidedmundson. Herald added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY All icons in System Tray "glow" a little bit when mouse is over the icon. This

D24706: [RFC] Change button style

ndavis added a comment. There were some conflicts, so this isn't exactly how it was before. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, manueljlin, Orage, LeGast00n,

D24706: [RFC] Change button style

ndavis updated this revision to Diff 73742. ndavis added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=69901=73742 BRANCH ndavis/pushbutton-style (branched from master) REVISION DETAIL https://phabricator.kde.org/D24706

D18006: Include only the largest size for the "Next" wallpaper

apol added a comment. In D18006#595773 , @apol wrote: > -1 I just saw what this revision depends on. So it could make sense. I'll leave it at -0 because caches are bad. REPOSITORY R31 Breeze REVISION DETAIL

D24706: [RFC] Change button style

ndavis added a comment. I think I'm going to need bigger, fancier shadows to get a good pressed movement (besides changing background color) with the diagonal movement removed. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc:

D24706: [RFC] Change button style

ndavis added a comment. TBH, the current way control shadows are rendered seems kind of wrong anyway. The shadow is rendered within the button, so when you rotate a button, the shadow gets rotated as well. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To:

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. The continual forwarding of keys makes sense. I'm happy to accept that. I don't want us to make krunner autostart. It's a hack, not a fix. REPOSITORY R120

D24706: [RFC] Change button style

ngraham added a comment. Thanks Noah. So you're the boss after all (as the de- facto Breeze maintainer now), and I REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel,

Re: Plasma 5.18 Branched

El dijous, 16 de gener de 2020, a les 14:30:29 CET, Jonathan Riddell va escriure: > Plasma has branched for the 5.18 releases. Beta is due today and final > release in three weeks time. > > Could i18n team move over the stable translations from master? Luigi did this. Cheers, Albert > >

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

pdabrowski updated this revision to Diff 73740. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26718?vs=73737=73740 REVISION DETAIL https://phabricator.kde.org/D26718 AFFECTED FILES krunner/CMakeLists.txt

D26720: Cache single image wallpapers locally

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now, if the user sets a wallpaper and it disappears on disk, the next time Plasma is

D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I believe we are in string freeze, this will sadly have to go to master. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26715 To: ngraham,

D26111: Runner: make recentdocument use KActivityStats data

apol added a comment. I'm not the original author. I guess I appear because of the git repository split or something. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik, apol Cc: broulik, plasma-devel,

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 57 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/57/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 11:59:26 + Build duration: 6 min 10 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 73 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/73/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 12:03:42 + Build duration: 16 min and counting CONSOLE OUTPUT [...truncated 259

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 671 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/671/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 12:19:29 + Build duration: 1 min 49 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 140 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/140/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Jan 2020 12:03:57 + Build duration: 16 min and counting CONSOLE OUTPUT [...truncated 266

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 377 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/377/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 16 Jan 2020 10:05:23 + Build duration: 45 min and counting JUnit Tests Name:

D26702: [MPRIS Data Engine] Support player proxying for another one

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:e4f91a3ee8b0: [MPRIS Data Engine] Support player proxying for another one (authored by broulik). REPOSITORY R120

  1   2   >