D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 73993. meven marked 11 inline comments as done. meven added a comment. Code formatting, only one loop in ComponentChooser::emitChanged, indentation tabs vs spaces REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26783: Center only during drawing, not the hit rects

This revision was automatically updated to reflect the committed changes. Closed by commit R31:5a447b59fc96: Center only during drawing, not the hit rects (authored by mart). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26783?vs=73923=73997 REVISION DETAIL

D26783: Center only during drawing, not the hit rects

mart added a comment. In master and 5.18 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26783 To: mart, #vdg, hpereiradacosta, ndavis Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,

D26796: [Notifications] When there is only a reply action, show reply field right away

broulik updated this revision to Diff 73998. broulik added a comment. - Move `MouseArea` inside as to not break the `RowLayout` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26796?vs=73972=73998 REVISION DETAIL

D26580: Kicker/RecentDocuments display place's icon when resource matches one

meven added a comment. I am thinking about merging this and push to 5.18 branch, this ought to be in 5.18. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26580 To: meven, #plasma, ngraham, hein Cc: plasma-devel, Orage, LeGast00n,

D26803: [Notifications] Send reply text as targeted signal

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoids waking up non-interested parties. TEST PLAN 5.18 while it is an API change, it was

D26805: Startkde: Foreach conversion, prevents warnings, improve some variables naming

meven created this revision. meven added reviewers: apol, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Builds REPOSITORY R120 Plasma Workspace BRANCH foreach-startkde REVISION DETAIL

D26797: KCM/Component Refactor UI to a single list of combobox

ervin added inline comments. INLINE COMMENTS > componentchooser.cpp:98 > > +void ComponentChooser::emitChanged(bool val) > +{ I still think val is useless. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26797 To: meven, #plasma, #vdg, ngraham, ervin Cc:

D26797: KCM/Component Refactor UI to a single list of combobox

meven added inline comments. INLINE COMMENTS > ervin wrote in componentchooser.cpp:98 > I still think val is useless. I kept it as the compiler might be able to do some optimization in the loop when val is true line 105. It may skip the `plugin->hasChanged();` calls in that case, but I am not

D26185: Also disable automatic scaling on Qt >= 5.14

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea66bff2af84: Also disable automatic scaling on Qt = 5.14 (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26185?vs=72070=74004

D26797: KCM/Component Refactor UI to a single list of combobox

ervin added inline comments. INLINE COMMENTS > meven wrote in componentchooser.cpp:98 > I kept it as the compiler might be able to do some optimization in the loop > when val is true line 105. > It may skip the `plugin->hasChanged();` calls in that case, but I am not sure > it gcc is clever

D26185: Also disable automatic scaling on Qt >= 5.14

ahartmetz added a comment. @fvogt Yeah thanks, that made more sense than you spoon-feeding me the information for the commit message ;) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson, fvogt Cc:

D26803: [Notifications] Send reply text as targeted signal

broulik updated this revision to Diff 74006. broulik added a comment. - No fallback, `createTargetedSignal` without a service seems to behave like the non-targeted version REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26803?vs=73999=74006

D26805: Startkde: Foreach conversion, prevents warnings, improve some variables naming

This revision was automatically updated to reflect the committed changes. Closed by commit R120:209b21e240c7: Startkde: Foreach conversion, prevents warnings, improve some variables naming (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 74008. meven added a comment. change emitChanged(bool) to emitChanged() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26797?vs=73993=74008 BRANCH new-component-chooser REVISION DETAIL

D26796: [Notifications] When there is only a reply action, show reply field right away

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3328f6a2f5ad: [Notifications] When there is only a reply action, show reply field right away (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26796?vs=73998=74010#toc

D26803: [Notifications] Send reply text as targeted signal

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5369cf775c4b: [Notifications] Send reply text as targeted signal (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 74011. meven added a comment. Add copyright mentions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26797?vs=74008=74011 BRANCH new-component-chooser REVISION DETAIL https://phabricator.kde.org/D26797

D26797: KCM/Component Refactor UI to a single list of combobox

meven added a comment. @ngraham I think I should wait for some feedback/review from #VDG or #Plasma to iron out issues if any. REPOSITORY R119 Plasma Desktop BRANCH new-component-chooser REVISION DETAIL

D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 74012. meven added a comment. Add missing line change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26797?vs=74011=74012 BRANCH new-component-chooser REVISION DETAIL https://phabricator.kde.org/D26797

D24856: Add a .desktop file to ksplashqml

meven added inline comments. INLINE COMMENTS > apol wrote in ksplashqml.desktop.cmake:7 > Are you sure the wayland interface is required? > > It seems like the warning is broken, so we could just as well remove it. I agree, it seems `org_kde_plasma_window_management` is so simple we should

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Icons were decreased in sized and placed in row with their labels. 'Enable power management' was

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74014. gvgeo added a comment. Clean up REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74013=74014 BRANCH b3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26806 AFFECTED

D26806: [Applets/Power Manager] Update layout based on T10470

davidedmundson added a comment. With any layout changes be sure you've tested it: - in the system tray - in the panel - in a vertical panel - on the desktop INLINE COMMENTS > BatteryItem.qml:96 > +RowLayout { > +width: batteryItem.width > + We want to almost

D26806: [Applets/Power Manager] Update layout based on T10470

davidedmundson added inline comments. INLINE COMMENTS > BatteryItem.qml:150 > + > +property int _s: units.largeSpacing / 2 > + can we use units.smallSpacing If we invent our own margin policy everywhere by multiplying by random factors we're not going to have any consistency. >

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo added a comment. I will not touch any more BatteryItem.qml, has a bug with Grid and uses Flow instead. That made very difficult to fix the tooltip and details. R120:d12521b149fa7766fbbeb9957bde14b4a6278928

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74017. gvgeo added a comment. Remove translating of new lines REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74014=74017 BRANCH b3 (branched from master) REVISION DETAIL

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo marked an inline comment as done. gvgeo added a comment. I believe scroolbars should look good, but didn't test the new scrollbars. I use stable builds, where it touches the scrollbar. F7895378: Screenshot_20200121_152405.png Can someone that

D26531: [Wallpaper] Show author as subtitle in configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3729873fdd1d: [Wallpaper] Show author as subtitle in configuration (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26802: [Applet] Focus search field after showing it

This revision was automatically updated to reflect the committed changes. Closed by commit R116:585427ce0180: [Applet] Focus search field after showing it (authored by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D26799: Apply KDE coding style, minor optimizations

alex marked an inline comment as done. alex added inline comments. INLINE COMMENTS > meven wrote in filteredfoldermodel.cpp:38 > space ? I am not sure. I am not sure too, because in the plasma-workspace project and even some qt files it is sometimes formatted like above but sometimes it is

D26580: Kicker/RecentDocuments display place's icon when resource matches one

hein added a comment. This patch is fine and in line with the existing implementation, but it occurs to me we probably should make the RecentUsageModel use FileEntry and put it centrally there at some point. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D26783: Center only during drawing, not the hit rects

hpereiradacosta added a comment. Thanks for the fix. On a different topics, I have found a couple more places where the separators look weird. See: F7895454: Screenshot_20200121_102848.png or F7895458: Screenshot_20200121_102934.png

D26807: override picutils' error logger; it has an exit() call

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY instead simply run the output through qwarning as a cheap solution. FIXED-IN: 5.18.0 BUG: 382979 TEST PLAN builds, dont

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi updated this revision to Diff 74021. crossi added a comment. Following discussion with @ervin and @broulik, export generated KConfig settings, remove singleton option. The KCM will have its own KConfig settings' instance like other KCMs. REPOSITORY R120 Plasma Workspace CHANGES

D26580: Kicker/RecentDocuments display place's icon when resource matches one

meven added a comment. In D26580#598081 , @hein wrote: > This patch is fine and in line with the existing implementation, but it occurs to me we probably should make the RecentUsageModel use FileEntry and put it centrally there at some point.

D26808: Credit Ken for his wallpapers

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Since D26531 landed, it's now very obvious who made

D26047: Expose KConfig settings to allow registration in KCM Notification

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. I like it, just an unwanted change to clean up still. @broulik what say you? INLINE COMMENTS > settings.h:33 > > +class KCoreConfigSkeleton; > + This change isn't needed

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi updated this revision to Diff 74023. crossi added a comment. Remove unneeded forward declaration REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26047?vs=74021=74023 REVISION DETAIL https://phabricator.kde.org/D26047 AFFECTED FILES

D26783: Center only during drawing, not the hit rects

ndavis added a comment. In D26783#598083 , @hpereiradacosta wrote: > Thanks for the fix. > On a different topics, I have found a couple more places where the separators look weird. See: > F7895454: Screenshot_20200121_102848.png

D26808: Credit Ken for his wallpapers

This revision was automatically updated to reflect the committed changes. Closed by commit R131:dceedef5184d: Credit Ken for his wallpapers (authored by ngraham). REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26808?vs=74022=74026 REVISION DETAIL

D26580: Kicker/RecentDocuments display place's icon when resource matches one

ngraham added a comment. Yes please. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26580 To: meven, #plasma, ngraham, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26048: KCM Notification port to ManagedConfigModule

crossi updated this revision to Diff 74028. crossi added a comment. Following new approach in D26047 , also taking into immutability is much more straightforward. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26048: KCM Notification port to ManagedConfigModule

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Wondering, do we still need "settings"? I guess it's for the per-app settings? INLINE COMMENTS > kcm.cpp:115 > + > +registerSettings(m_dndSettings); > +

D26783: Center only during drawing, not the hit rects

ngraham added a comment. There's some weirdness in System Settings too. However all of this just exposes when we have a scrollable view that should be reformatted to show everything without needing to be scrollable (e.g. Okular's settings window; see

D26797: KCM/Component Refactor UI to a single list of combobox

ngraham added a comment. In D26797#598030 , @meven wrote: > @ngraham I think I should wait for some feedback/review from #VDG or #Plasma to iron out issues if any.

D26048: KCM Notification port to ManagedConfigModule

crossi added a comment. In D26048#598157 , @ervin wrote: > Wondering, do we still need "settings"? I guess it's for the per-app settings? Yes, for app specific settings. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D26813: Have user-manager write to SDDM's new config file

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY user-manager still wants to write to sddm.conf and it's using sddm_kcm's function to do so, but this function no longer supports

D26048: KCM Notification port to ManagedConfigModule

crossi updated this revision to Diff 74037. crossi added a comment. Not necessary anymore REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26048?vs=74028=74037 REVISION DETAIL https://phabricator.kde.org/D26048 AFFECTED FILES

D26813: Have user-manager write to SDDM's new config file

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. We could move the full file path to the helper rather than having the calling user send it. I'll be more secure that way. REPOSITORY R128 User Manager BRANCH

D26813: Have user-manager write to SDDM's new config file

ngraham accepted this revision. ngraham added a comment. Sounds good, should we do that refactor in master and land this on the stable branch? REPOSITORY R128 User Manager BRANCH write-autologin-right (branched from master) REVISION DETAIL https://phabricator.kde.org/D26813 To:

KDE CI: Plasma » kwindowsystem » stable-kf5-qt5 FreeBSDQt5.13 - Build # 53 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwindowsystem/job/stable-kf5-qt5%20FreeBSDQt5.13/53/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 22 Jan 2020 00:32:26 + Build duration: 6 min 26 sec and counting JUnit Tests

KDE CI: Plasma » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/53/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 22 Jan 2020 00:32:27 + Build duration: 6 min 26 sec and counting JUnit Tests Name:

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

Hi, I'm writing to let you know that we've dropped Breeze and Oxygen Qt 4 builds. [1][2] Cheers, vlad [1] https://cgit.kde.org/breeze.git/commit/?id=2df91ac9a3287c0082f742c2cd10567ed0c5b001 [2] https://cgit.kde.org/oxygen.git/commit/?id=94c856314c163ac869a271a16729ed26c07276b3

D26823: Port connections to new syntax

zzag added a comment. ++ INLINE COMMENTS > breezeconfigwidget.cpp:49 > // track ui changes > connect( m_ui.titleAlignment, SIGNAL(currentIndexChanged(int)), > SLOT(updateChanged()) ); > connect( m_ui.buttonSize, SIGNAL(currentIndexChanged(int)), >

D26458: [windowsystem] Provide a KWindowShadow implementation

zzag updated this revision to Diff 74059. zzag added a comment. Update REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26458?vs=74057=74059 BRANCH port-to-shadows-api REVISION DETAIL

KDE CI: Plasma » oxygen » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/oxygen/job/kf5-qt5%20FreeBSDQt5.13/40/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 22 Jan 2020 00:27:55 + Build duration: 6 min 16 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 373 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/373/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 22 Jan 2020 00:22:13 + Build duration: 13 min and counting CONSOLE OUTPUT [...truncated 3381

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.13/66/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 22 Jan 2020 00:24:51 + Build duration: 9 min 29 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 374 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/374/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 22 Jan 2020 00:35:47 + Build duration: 26 min and counting JUnit Tests Name: projectroot

D26823: Port connections to new syntax

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Porting done by clazy. TEST PLAN Compiles REPOSITORY R31 Breeze

D26621: [kstyle] Drop Qt 4 style plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R113:94c856314c16: [kstyle] Drop Qt 4 style plugin (authored by zzag). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26621?vs=73391=74065 REVISION DETAIL

D26609: [kstyle] Port to KWindowSystem shadows API

This revision was automatically updated to reflect the committed changes. zzag marked an inline comment as done. Closed by commit R113:164dbdb334b8: [kstyle] Port to KWindowSystem shadows API (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26609?vs=73644=74066#toc

D26458: [windowsystem] Provide a KWindowShadow implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R130:8b0244949229: [windowsystem] Provide a KWindowShadow implementation (authored by zzag). REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE

KDE CI: Plasma » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/52/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 22 Jan 2020 00:17:38 + Build duration: 12 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kwindowsystem » stable-kf5-qt5 FreeBSDQt5.13 - Build # 52 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwindowsystem/job/stable-kf5-qt5%20FreeBSDQt5.13/52/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 22 Jan 2020 00:17:31 + Build duration: 11 min and counting CONSOLE OUTPUT

KDE CI: Plasma » breeze » kf5-qt5 SUSEQt5.12 - Build # 119 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20SUSEQt5.12/119/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 22 Jan 2020 00:25:24 + Build duration: 6 min 3 sec and counting CONSOLE OUTPUT [...truncated 376

D26823: Port connections to new syntax

davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in breezeconfigwidget.cpp:49 > Does clazy handle overloaded signals and slots? Sort of. It handles not doing anything bad. It detects it and prints a warning. There's about 24 left in this repo. REPOSITORY R31 Breeze

KDE CI: Plasma » kwayland-integration » kf5-qt5 SUSEQt5.12 - Build # 37 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20SUSEQt5.12/37/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 22 Jan 2020 00:19:51 + Build duration: 10 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 533 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/533/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 22 Jan 2020 00:22:27 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated 3199

KDE CI: Plasma » kwayland-integration » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 22 Jan 2020 00:19:32 + Build duration: 12 min and counting CONSOLE OUTPUT

D26458: [windowsystem] Provide a KWindowShadow implementation

zzag updated this revision to Diff 74057. zzag added a comment. Use QWindow::requestUpdate() REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26458?vs=73729=74057 BRANCH port-to-shadows-api REVISION DETAIL

D26476: [kstyle] Drop Qt 4 style plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R31:2df91ac9a328: [kstyle] Drop Qt 4 style plugin (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26476?vs=73387=74063#toc REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D26475: [kstyle] Port to KWindowSystem shadows API

This revision was automatically updated to reflect the committed changes. Closed by commit R31:7f3ae29b1964: [kstyle] Port to KWindowSystem shadows API (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26475?vs=73643=74064 REVISION DETAIL

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 534 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/534/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 22 Jan 2020 00:33:02 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 0

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74069. gvgeo added a comment. Revert 2 lines (unintentional changes) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74045=74069 BRANCH b3 (branched from master) REVISION DETAIL

D26580: Kicker/RecentDocuments display place's icon when resource matches one

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b51fb9dc522b: Kicker/RecentDocuments display places icon when resource matches one (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

T12567: Reduce code/effort duplication around color scheme support

ndavis added a comment. QML can use C++ functions right? Would we still need to make property bindings for all the colors if we had color() functions? TASK DETAIL https://phabricator.kde.org/T12567 To: ndavis Cc: ognarb, plasma-devel, kde-frameworks-devel, ndavis, Orage, LeGast00n,

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74044. gvgeo added a comment. Fix Layout issues. No changes of the apperance. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74017=74044 BRANCH battery (branched from master) REVISION DETAIL

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74045. gvgeo added a comment. Correct previous wrong update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74044=74045 BRANCH b3 (branched from master) REVISION DETAIL

D26047: Expose KConfig settings to allow registration in KCM Notification

broulik added a comment. Other than the seemingly missing `config`, looks good INLINE COMMENTS > settings.cpp:173 > -if (!s_settingsInited) { > -DoNotDisturbSettings::instance(config); > -NotificationSettings::instance(config); I still want to be able to specify what

T12567: Reduce code/effort duplication around color scheme support

davidedmundson added a comment. > QML can use C++ functions right? Would we still need to make property bindings for all the colors if we had color() functions? C++ functions can be exposed to QML. However: color: myObject.color(fooBar); has one behaviour big behavioural

T12567: Reduce code/effort duplication around color scheme support

ndavis added a comment. In T12567#218405 , @davidedmundson wrote: > The former won't know when to update, the latter can. So we'll need to make property bindings anyway? Or maybe we can use arrays instead of writing 108 individual

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

cfeck added inline comments. INLINE COMMENTS > standard_actions_module.cpp:73 > +m_editor->setMinimumWidth(700); > +m_editor->setMinimumHeight(600); > + `setMinimumSize()` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26695 To: ngraham, #plasma Cc:

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

cfeck added a comment. Note that a window's minimum size does not include decorations or the panel. I suggest to subtract 60 pixels from the minimum height, otherwise on a 800x600 screen the buttons are likely hidden behind the panel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

ngraham updated this revision to Diff 74052. ngraham marked an inline comment as done. ngraham added a comment. Use `setMinimumSize()` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26695?vs=73657=74052 BRANCH standardshortcuts-minimum-size

D26458: [windowsystem] Provide a KWindowShadow implementation

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. One minor change, otherwise it's all good. INLINE COMMENTS > windowshadow.cpp:99 > +shadowManager->removeShadow(surface); > +