D26892: Switch to the old-style button text for the KNSQuick buttons

[Victor Ryzhykh]

victorr added a comment.


  F8013548: Screenshot_20200130_103821.jpeg 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26892

To: leinir, #plasma, davidedmundson
Cc: victorr, aacid, yurchor, davidedmundson, kde-i18n-doc, gikari, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[Victor Ryzhykh]

victorr added a comment.


  The window title is left with double text.
  Image taken without a network connection,
  therefore there are no thumbnails.
  F8013492: Screenshot_20200130_103307.jpeg 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26892

To: leinir, #plasma, davidedmundson
Cc: victorr, aacid, yurchor, davidedmundson, kde-i18n-doc, gikari, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[Victor Ryzhykh]

victorr added a comment.


  Please add this patch as well.
  
  .downloadNewWhat: i18n("Wallpapers")
  +text: i18nd("plasma_wallpaper_org.kde.image","Get New 
Wallpapers...")
  
  F8013202: plasma-workspace-5.17.98-tr.patch 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26892

To: leinir, #plasma, davidedmundson
Cc: victorr, aacid, yurchor, davidedmundson, kde-i18n-doc, gikari, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26912: Use Qt5 signal syntax, format files, optimizations

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  seems ok for me now.
  Thanks

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26912

To: alex, mlaurent, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 93 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/93/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 30 Jan 2020 05:02:07 +
 Build duration:
1 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 499 lines...][2020-01-30T05:03:21.915Z] [ 56%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/ksmbstatus.cpp.o[2020-01-30T05:03:22.184Z] 1 warning generated.[2020-01-30T05:03:22.184Z] [ 58%] Building CXX object Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/Module.cpp.o[2020-01-30T05:03:22.184Z] [ 59%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/soldevice.cpp.o[2020-01-30T05:03:22.764Z] [ 61%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/__/base/os_current.cpp.o[2020-01-30T05:03:23.036Z] [ 62%] Linking CXX shared module ../../bin/kcm_usb.so[2020-01-30T05:03:23.036Z] [ 64%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/totalMemoryChart.cpp.o[2020-01-30T05:03:23.036Z] [ 64%] Built target kcm_usb[2020-01-30T05:03:23.036Z] [ 66%] Building CXX object Modules/pci/CMakeFiles/kcm_pci.dir/__/base/info_wayland.cpp.o[2020-01-30T05:03:23.036Z] In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/os_current.cpp:24:[2020-01-30T05:03:23.036Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/pci/../base/os_base.h:35:10: fatal error: 'config-X11.h' file not found[2020-01-30T05:03:23.036Z] #include [2020-01-30T05:03:23.036Z]  ^~[2020-01-30T05:03:23.036Z] 1 error generated.[2020-01-30T05:03:23.036Z] gmake[2]: *** [Modules/pci/CMakeFiles/kcm_pci.dir/build.make:89: Modules/pci/CMakeFiles/kcm_pci.dir/__/base/os_current.cpp.o] Error 1[2020-01-30T05:03:23.036Z] gmake[2]: *** Waiting for unfinished jobs[2020-01-30T05:03:23.036Z] [ 67%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/physicalMemoryChart.cpp.o[2020-01-30T05:03:23.036Z] [ 69%] Building CXX object Modules/opengl/CMakeFiles/kcm_opengl.dir/opengl.cpp.o[2020-01-30T05:03:23.036Z] [ 70%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/devinfo.cpp.o[2020-01-30T05:03:23.036Z] [ 72%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/swapMemoryChart.cpp.o[2020-01-30T05:03:23.304Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/samba/ksmbstatus.cpp:122:13: warning: variable length array used [-Wvla][2020-01-30T05:03:23.304Z] char buffer[buflen];[2020-01-30T05:03:23.304Z]^[2020-01-30T05:03:23.304Z] [ 74%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/__/base/info_wayland.cpp.o[2020-01-30T05:03:23.574Z] [ 75%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/devicelisting.cpp.o[2020-01-30T05:03:23.574Z] [ 77%] Linking CXX shared module ../../../bin/kcm_about_distro.so[2020-01-30T05:03:23.574Z] [ 79%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/infopanel.cpp.o[2020-01-30T05:03:23.574Z] 1 warning generated.[2020-01-30T05:03:23.574Z] [ 79%] Built target kcm_about_distro[2020-01-30T05:03:23.574Z] [ 80%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/kcmsambaimports.cpp.o[2020-01-30T05:03:23.574Z] [ 82%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/soldevicetypes.cpp.o[2020-01-30T05:03:23.844Z] In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/os_current.cpp:24:[2020-01-30T05:03:23.844Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/info/../base/os_base.h:35:10: fatal error: 'config-X11.h' file not found[2020-01-30T05:03:23.844Z] #include [2020-01-30T05:03:23.844Z]  ^~[2020-01-30T05:03:23.844Z] 1 error generated.[2020-01-30T05:03:23.844Z] gmake[2]: *** [Modules/info/CMakeFiles/kcm_info.dir/build.make:102: Modules/info/CMakeFiles/kcm_info.dir/__/base/os_current.cpp.o] Error 1[2020-01-30T05:03:23.844Z] gmake[2]: *** Waiting for unfinished jobs[2020-01-30T05:03:23.844Z] [ 83%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/kcmsambalog.cpp.o[2020-01-30T05:03:24.115Z] [ 85%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/qvlistlayout.cpp.o[2020-01-30T05:03:24.373Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/info_wayland.cpp:76:18: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2020-01-30T05:03:24.373Z] [this, interfacesItem] (const QByteArray , quint32 name, quint32 version) {[2020-01-30T05:03:24.373Z]  ^[2020-01-30T05:03:24.373Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/info_wayland.cpp:87:26: warning: lambda capture 'this' is not used [-Wunused-lambda-capture][2020-01-30T05:03:24.373Z] [this, seat, seatItem] {[2020-01-30T05:03:24.373Z]  

KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.12 - Build # 155 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.12/155/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 30 Jan 2020 05:02:07 +
 Build duration:
1 min 18 sec and counting
   CONSOLE OUTPUT
  [...truncated 686 lines...][2020-01-30T05:03:18.148Z] Scanning dependencies of target kcm_samba[2020-01-30T05:03:18.148Z] [ 31%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/kcm_samba_autogen/mocs_compilation.cpp.o[2020-01-30T05:03:18.148Z] [ 31%] Built target kcm_energyinfo_autogen[2020-01-30T05:03:18.148Z] [ 32%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/kcm_memory_autogen/mocs_compilation.cpp.o[2020-01-30T05:03:18.148Z] [ 34%] Generating ui_opengl.h[2020-01-30T05:03:18.148Z] Scanning dependencies of target kcm_devinfo[2020-01-30T05:03:18.148Z] [ 34%] Built target kcm_fileindexermonitor_autogen[2020-01-30T05:03:18.148Z] [ 35%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/kcm_devinfo_autogen/mocs_compilation.cpp.o[2020-01-30T05:03:18.148Z] Scanning dependencies of target kcm_opengl[2020-01-30T05:03:18.148Z] [ 36%] Building CXX object Modules/opengl/CMakeFiles/kcm_opengl.dir/kcm_opengl_autogen/mocs_compilation.cpp.o[2020-01-30T05:03:18.405Z] Scanning dependencies of target kcm_energyinfo[2020-01-30T05:03:18.405Z] [ 38%] Building CXX object Modules/energy/CMakeFiles/kcm_energyinfo.dir/kcm_energyinfo_autogen/mocs_compilation.cpp.o[2020-01-30T05:03:18.974Z] [ 39%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/main.cpp.o[2020-01-30T05:03:18.974Z] [ 40%] Building CXX object Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/main.cpp.o[2020-01-30T05:03:18.974Z] [ 42%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/info.cpp.o[2020-01-30T05:03:18.974Z] [ 42%] Built target doc-index-cache-bz2[2020-01-30T05:03:18.974Z] [ 43%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/soldevice.cpp.o[2020-01-30T05:03:19.233Z] [ 44%] Building CXX object Modules/usbview/CMakeFiles/kcm_usb.dir/kcmusb.cpp.o[2020-01-30T05:03:19.233Z] [ 46%] Building CXX object Modules/pci/CMakeFiles/kcm_pci.dir/kcm_pci.cpp.o[2020-01-30T05:03:19.233Z] [ 47%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/memory.cpp.o[2020-01-30T05:03:19.490Z] [ 48%] Building CXX object Modules/opengl/CMakeFiles/kcm_opengl.dir/opengl.cpp.o[2020-01-30T05:03:19.490Z] [ 50%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/main.cpp.o[2020-01-30T05:03:19.749Z] [ 51%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/chartWidget.cpp.o[2020-01-30T05:03:19.749Z] [ 52%] Linking CXX shared module ../../bin/kcm_nic.so[2020-01-30T05:03:20.007Z] [ 53%] Building CXX object Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/Module.cpp.o[2020-01-30T05:03:20.007Z] [ 55%] Building CXX object Modules/energy/CMakeFiles/kcm_energyinfo.dir/kcm.cpp.o[2020-01-30T05:03:20.007Z] [ 56%] Building CXX object Modules/energy/CMakeFiles/kcm_energyinfo.dir/batterymodel.cpp.o[2020-01-30T05:03:20.007Z] [ 56%] Built target kcm_nic[2020-01-30T05:03:20.266Z] Scanning dependencies of target kcm_fileindexermonitor[2020-01-30T05:03:20.266Z] [ 57%] Building CXX object Modules/fileindexermonitor/CMakeFiles/kcm_fileindexermonitor.dir/kcm_fileindexermonitor_autogen/mocs_compilation.cpp.o[2020-01-30T05:03:20.266Z] [ 59%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/__/base/os_current.cpp.o[2020-01-30T05:03:20.525Z] [ 60%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/totalMemoryChart.cpp.o[2020-01-30T05:03:20.525Z] [ 61%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/devinfo.cpp.o[2020-01-30T05:03:20.525Z] /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/opengl/opengl.cpp: In function ���bool GetInfo_OpenGL(QTreeWidget*)���:[2020-01-30T05:03:20.525Z] /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/opengl/opengl.cpp:961:13: warning: variable ���numScreens��� set but not used [-Wunused-but-set-variable][2020-01-30T05:03:20.525Z]   961 | int numScreens, scrnum;[2020-01-30T05:03:20.525Z]   | ^~[2020-01-30T05:03:20.525Z] [ 63%] Building CXX object Modules/pci/CMakeFiles/kcm_pci.dir/__/base/os_current.cpp.o[2020-01-30T05:03:20.525Z] In file included from /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/base/os_current.cpp:24:[2020-01-30T05:03:20.525Z] /home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 SUSEQt5.12/Modules/base/os_base.h:35:10: fatal error: config-X11.h: No such file or directory[2020-01-30T05:03:20.525Z]35 | #include [2020-01-30T05:03:20.525Z]   |  ^~[2020-01-30T05:03:20.525Z] compilation terminated.[2020-01-30T05:03:20.525Z] make[2]: *** [Modules/info/CMakeFiles/kcm_info.dir/build.make:102: Modules/info/CMakeFiles/kcm_info.dir/__/base/os_current.cpp.o] Error 1[2020-01-30T05:03:20.525Z] make[1]: *** [CMakeFiles/Makefile2:747: 

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham added a comment.


  Nice find. Fixed in 093e2d917ff386e627a062f3337c9ff23294e95c 
.
  
  Hopefully that's done it!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  In D26739#602951 , @ngraham wrote:
  
  > Argh, now I can see it too: F8008546: weird margin.webm 

  >
  > No idea what's causing this. The code seems conceptually right to me. Maybe 
something's getting rounded up instead of down or something.
  
  
  Yep, that is. A possible solution I found is to round up `winTitle.height` 
like this: 
https://phabricator.kde.org/source/latte-dock/browse/master/plasmoid/package/contents/ui/previews/ToolTipInstance.qml$175

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham added a comment.


  Argh, now I can see it too: F8008546: weird margin.webm 

  
  No idea what's causing this. The code seems conceptually right to me. Maybe 
something's getting rounded up instead of down or something.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27016: Update from Plasma's ToolTip

[Tranter Madi]

trmdi created this revision.
trmdi added a reviewer: Latte Dock.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Add highlight effect when hovering over the tooltip's thumbnail

REPOSITORY
  R878 Latte Dock

BRANCH
  add-highlight

REVISION DETAIL
  https://phabricator.kde.org/D27016

AFFECTED FILES
  plasmoid/package/contents/ui/previews/ToolTipInstance.qml

To: trmdi, #latte_dock
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[Victor Ryzhykh]

victorr added a comment.


  This is probably a typo?
  Now there are "Icons".
  
  - downloadNewWhat: i18n("Splash Screens")
  
  +text: i18n("Get New Icons...")

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26892

To: leinir, #plasma, davidedmundson
Cc: victorr, aacid, yurchor, davidedmundson, kde-i18n-doc, gikari, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27006: Add .arcconfig

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1014:d96bd2d45e7e: Add .arcconfig (authored by ndavis).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27006?vs=74623=74635

REVISION DETAIL
  https://phabricator.kde.org/D27006

AFFECTED FILES
  .arcconfig

To: ndavis, mart, #kirigami, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, mart, hein

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Filip Fila]

filipf added a comment.


  In D26739#602243 , @trmdi wrote:
  
  > In D26739#602082 , @filipf wrote:
  >
  > > ^ I can't reproduce that, the patch works as intended for me.  (we should 
investigate this though)
  > >
  > > One thing to just comment is that this is tailor-made for Breeze (the 1px 
thing), but it looks fine with other themes and I don't really know of any 
other solution.
  >
  >
  > Try changing the General Font size to see if you can reproduce it. On my 
system, I can reproduce it with `Noto 10`, but not with `Noto 11`.
  
  
  Still can't see it, except for this one case:
  
  F7999376: Screenshot_20200129_233038.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27011: Update plasma startup sequence README

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> README:37
>  
>  The server is usually started from the 'startkde' script. It supports the 
> following options:
>  

Isn't this startplasma now?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27011

To: davidedmundson
Cc: nicolasfella, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27011: Update plasma startup sequence README

[David Edmundson]

davidedmundson updated this revision to Diff 74632.
davidedmundson added a comment.


  review comments

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27011?vs=74631=74632

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27011

AFFECTED FILES
  ksmserver/README
  startkde/README

To: davidedmundson
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27011: Update plasma startup sequence README

[David Edmundson]

davidedmundson updated this revision to Diff 74631.
davidedmundson added a comment.


  Fix another outdated lie

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27011?vs=74629=74631

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27011

AFFECTED FILES
  ksmserver/README
  startkde/README

To: davidedmundson
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27011: Update plasma startup sequence README

[Carl Schwan]

ognarb added a comment.


  I think I found some small typos

INLINE COMMENTS

> README:25
> +which may be 0, 1 or 2 (the default). Kded phase 0 means the module is
> +always loaded by kded, even outside of KDE session. It should used only
> +by kded modules which must be always running. Kded phase 1 modules are

It should used -> It should be used

> README:37
> +
> +StartPlasma finaly then spawns plasma-session that takes care of the rest of 
> the process.
> +

finaly -> finally

> README:63
> +After this session restore is triggered. i.e. launching all applications that
> +were running during last session saving (usually logout).
> +

during last session -> during the last session

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27011

To: davidedmundson
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27011: Update plasma startup sequence README

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  At least half of the stuff ksmserver docuemented was wrong.
  
  I like to think plasma-session/startup.cpp is now self-documenting due
  to the jobs, but I've tried to keep the doc up to date anyway instead of
  just deleting it.

TEST PLAN
  N/A

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27011

AFFECTED FILES
  ksmserver/README
  startkde/README

To: davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27007: [kcm/standardactions] Don't register kcminit hook when we don't have one

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  There is no exported function called standard_actions. kcminit will link
  against this library, fail to find a method to run and do nothing.

TEST PLAN
  Grepped for method

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27007

AFFECTED FILES
  kcms/standard_actions/standard_actions.desktop

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27006: Add .arcconfig

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: mart, Kirigami.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This repo was missing this file, so one had to manually specify the url in 
order to make phabricator diffs.

REPOSITORY
  R1014 Kirigami Gallery

BRANCH
  arcconfig (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27006

AFFECTED FILES
  .arcconfig

To: ndavis, mart, #kirigami
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, mart, hein

D26823: Port connections to new syntax

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D26823#599100 , @davidedmundson 
wrote:
  
  > > yeah ok. Just noted this. indeed.
  >
  > Sorry, I assumed you had seen the thread.
  >  Hope you're ok with it?
  
  
  Sure thing ! The whole thing is more modern and easier to maintain for 
everybody. Glad to see Qt4 going !

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26823

To: davidedmundson, #plasma, zzag
Cc: hpereiradacosta, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27003: [kstyle] Port to QWindow::startSystemMove()

[Vlad Zahorodnii]

zzag updated this revision to Diff 74622.
zzag added a comment.


  Drop UseWMMoveResize option.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27003?vs=74619=74622

REVISION DETAIL
  https://phabricator.kde.org/D27003

AFFECTED FILES
  kstyle/breeze.kcfg
  kstyle/breezewindowmanager.cpp
  kstyle/breezewindowmanager.h

To: zzag, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27003: [kstyle] Port to QWindow::startSystemMove()

[Vlad Zahorodnii]

zzag updated this revision to Diff 74619.
zzag added a comment.


  Get rid of _cursorOverride

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27003?vs=74617=74619

REVISION DETAIL
  https://phabricator.kde.org/D27003

AFFECTED FILES
  kstyle/breezewindowmanager.cpp
  kstyle/breezewindowmanager.h

To: zzag, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27003: [kstyle] Port to QWindow::startSystemMove()

[Vlad Zahorodnii]

zzag added a comment.


  https://www.youtube.com/watch?v=tPh7U9otpy4

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27003

To: zzag, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27004: [kstyle] Drop XCB and KWayland dependency

[Vlad Zahorodnii]

zzag created this revision.
zzag added reviewers: Plasma, hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  They are not used anywhere.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27004

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breezehelper.cpp
  kstyle/config-breeze.h.cmake

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27003: [kstyle] Port to QWindow::startSystemMove()

[Vlad Zahorodnii]

zzag created this revision.
zzag added reviewers: KWin, Plasma, hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  QWindow::startSystemMove() is a new feature in Qt 5.15 that provides a
  platform-independent way to start an interactive move operation.
  
  WARNING: I have no idea whether KDE Plasma 5.19 is going to depend on Qt 5.15.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27003

AFFECTED FILES
  kstyle/breezewindowmanager.cpp
  kstyle/breezewindowmanager.h

To: zzag, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26889: Change notification button text to "View Updates"

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:7126e11498ac: Change notification button text to 
View Updates (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26889?vs=74292=74616

REVISION DETAIL
  https://phabricator.kde.org/D26889

AFFECTED FILES
  libdiscover/resources/ResourcesUpdatesModel.cpp
  notifier/DiscoverNotifier.cpp

To: ngraham, #vdg, #discover_software_store, apol, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: ngraham, #vdg, #plasma, ndavis, mthw
Cc: GB_2, ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26979: KWallet-PAM SELinux context transition support

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> CMakeLists.txt:17
> +find_library(SELINUX selinux)
>  
>  find_program(SOCAT_EXECUTABLE socat)

instead of message()

  set_package_properties(SELINUX PROPERTIES DESCRIPTION "some security thing"
 TYPE OPTIONAL
 PURPOSE "Do a security thing."
)

and then line

  feature_summary(WHAT ALL INCLUDE_QUIET_PACKAGES 
FATAL_ON_MISSING_REQUIRED_PACKAGES)

is better, it does the same thing you're doing but in a more parseable way

> pam_selinux.c:44
> +
> + ret = security_compute_create(execcon, fcon, string_to_security_class 
> ("process"), );
> + if (ret < 0) goto err;

on the gnome patch this is the macro

SECCLASS_PROCESS

any reason for the difference?

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D26979

To: secureworkstation, #plasma, #frameworks
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26640: [applets/weather] Port weather station picker to QQC2+ListView

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26640

To: ngraham, #vdg, #plasma, broulik
Cc: fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26845: [context menu] Remove last traces of "Lock Widgets" action from UI

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26845

To: ngraham, mart, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26882: [Applets/Folder] Re-arrange positioning of "Arrange in" and "Align" submenus

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26882

To: ngraham, hein, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26884: [Folder View] Fix text label color in pop-up

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26884

To: ngraham, #vdg, #plasma, hein, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  I applied the patches in this series and tested and went through the code 
again and everything looks good to me. Shall we start landing them for 5.19? We 
can always tweak things later; there's loads of time before the next release.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  layout2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: cfeck, ndavis, filipf, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27000: [kstyle] Drop Helper::connection()

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:9b20726184e4: [kstyle] Drop Helper::connection() (authored 
by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27000?vs=74605=74607

REVISION DETAIL
  https://phabricator.kde.org/D27000

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezewindowmanager.cpp

To: zzag, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:932e5dc45410: [kstyle] Use 
QX11Info::isCompositingManagerRunning() (authored by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26978?vs=74606=74608

REVISION DETAIL
  https://phabricator.kde.org/D26978

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27000: [kstyle] Drop Helper::connection()

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  thanks !

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27000

To: zzag, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Vlad Zahorodnii]

zzag updated this revision to Diff 74606.
zzag added a comment.


  update

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26978?vs=74598=74606

BRANCH
  use-qx11info-is-compositing-manager-active

REVISION DETAIL
  https://phabricator.kde.org/D26978

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27000: [kstyle] Drop Helper::connection()

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Since Qt 4 style plugin had been dropped, we can use QX11Info::connection()
  directly.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27000

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezewindowmanager.cpp

To: zzag, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26998: Fix new user creation

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R128:184a544cdef0: Fix new user creation (authored by meven).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26998?vs=74602=74604

REVISION DETAIL
  https://phabricator.kde.org/D26998

AFFECTED FILES
  src/lib/accountmodel.cpp

To: meven, ngraham, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26998: Fix new user creation

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Ignore my ramblings. Seems to work, and the logic makes sense

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26998

To: meven, ngraham, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26998: Fix new user creation

[David Edmundson]

davidedmundson added a comment.


  I had deleted
  
if (m_newUserData.isEmpty()) {
return true;
}
  
  which is effectively the same thing.
  
  and I was catting /etc/shadow to see if it was blank or not as my test
  
  Let me completely everything and retry with this. Maybe I had mixed up 
changes or something

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26998

To: meven, ngraham, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26999: [Notifications] Fix action button size

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This never was a `Layout`, so this never worked, but they were supposed to be 
sized to fit.

TEST PLAN
  5.18 please
  Before
  F7994741: Screenshot_20200129_190651.PNG 

  After
  F7994740: Screenshot_20200129_190521.PNG 

  (I also verified with an even longer button as the one in the screenshot 
happened to still be smaller than the default width and that also still works)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26999

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26998: Fix new user creation

[Méven Car]

meven added a comment.


  In D26998#602676 , @davidedmundson 
wrote:
  
  > I reached that same conclusion late last night (so in a sense ), and 
abandoned the other patch thinking I had everything understood.
  >
  > But then I tried it and it didn't work.
  
  
  Do you mean you tried the same as this patch and it does not fix the issue ?
  Could you have mistyped your test user password, not entered a password in 
the UI ( currently in the password window you need to wait 400 ms before the ok 
is enabled and if you hit enter then, you hit cancel without a warning) ?
  
  According to my testing and debugging, it fixes the issue.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26998

To: meven, ngraham, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26998: Fix new user creation

[David Edmundson]

davidedmundson added a comment.


  I reached that same conclusion late last night (so in a sense ), and 
abandoned the other patch thinking I had everything understood.
  
  But then I tried it and it didn't work.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26998

To: meven, ngraham, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26998: Fix new user creation

[Méven Car]

meven created this revision.
meven added reviewers: ngraham, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  UserAdded was called only when other parameters were provided for a new user 
beside name and realname.
  Which could not happen since 2471fa7d252de904b305dac77171fa300d66c05d 
 and 
given the order the setData are called in accountinfo.cpp
  
  Alternative to D26977 
  
  BUG: 416801
  FIXED-IN: 5.18

TEST PLAN
  Create a new user with a password
  in a terminal su new_user

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26998

AFFECTED FILES
  src/lib/accountmodel.cpp

To: meven, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Vlad Zahorodnii]

zzag added a comment.


  In D26978#602655 , 
@hpereiradacosta wrote:
  
  > In principle, the removal of Helper::connection, although is a change 
unrelated to the commit purpose. Maybe put it in a different commit ?
  
  
  Will do. (I removed it as a preparation step for `QWindow::startSystemMove()`)

REPOSITORY
  R31 Breeze

BRANCH
  use-qx11info-is-compositing-manager-active

REVISION DETAIL
  https://phabricator.kde.org/D26978

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Makes sense, thanks !
  
  In principle, the removal of Helper::connection, although is a change 
unrelated to the commit purpose. Maybe put it in a different commit ? 
  (the story behind if I remember right is that QX11Info::connection have not 
always been available in the past. hence the method)

REPOSITORY
  R31 Breeze

BRANCH
  use-qx11info-is-compositing-manager-active

REVISION DETAIL
  https://phabricator.kde.org/D26978

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Vlad Zahorodnii]

zzag updated this revision to Diff 74598.
zzag added a comment.


  Fix coding style.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26978?vs=74539=74598

BRANCH
  use-qx11info-is-compositing-manager-active

REVISION DETAIL
  https://phabricator.kde.org/D26978

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezewindowmanager.cpp

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21226: search for a default wallpaper in lookandfeel

[Rik Mills]

rikmills added a comment.


  Would this handle the case where an existing look-and-feel package that did 
NOT specify a wallpaper, then in a new version adds one? And that occurs on a 
users system the l-n-f package was already active and plasma is long past 1st 
plasma start.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21226

To: mart, #plasma, davidedmundson
Cc: rikmills, kossebau, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26993: [libkworkspace] Introduce UpdateLaunchEnvJob

[David Edmundson]

davidedmundson added a comment.


  +++
  
  Lets port some usages, so we can confirm it works in practice, but this looks 
good

INLINE COMMENTS

> updatelaunchenvjob.cpp:79
> +
> +// Startup (effectively KSMServer)
> +org::kde::Startup startup(QStringLiteral("org.kde.Startup"),

Not quite. It's plasma-session

It spawns processes, which in turn might update the launch env, that we should 
have that env when we spawn the next round of processes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26993

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26993: [libkworkspace] Introduce UpdateLaunchEnvJob

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This is supposed to replace manual DBus calls to `KLauncher` `setLaunchEnv` 
done in e.g. the KCMs, so this can easily be extended in the future.

TEST PLAN
  - Successfully changed an env variable

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26993

AFFECTED FILES
  libkworkspace/CMakeLists.txt
  libkworkspace/updatelaunchenvjob.cpp
  libkworkspace/updatelaunchenvjob.h

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26992: [SystemTray] Use unified data model everywhere

[Konrad Materka]

kmaterka added a comment.


  This change is very big. I can try to split in into two (maybe more) id 
that's required. If yes, should I connect revisions somehow? Create task, add 
parent/child revision?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26992

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26992: [SystemTray] Use unified data model everywhere

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, ngraham, 
broulik.
kmaterka added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  Use the unified data model everywhere, not just in configuration. This 
simplifies UI code, separetes presentation from data.
  This requires the use of ListView and GridView.
  This change enables the implementation of more advanced sorting algorithms 
for systemtray items.

TEST PLAN
  Affects almost all areas of system tray.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26992

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/ExpanderArrow.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/ItemLoader.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/sortedsystemtraymodel.cpp
  applets/systemtray/sortedsystemtraymodel.h
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26985: [Panel Shadows] Un-constify QWindow parameters

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bb60002b1340: [Panel Shadows] Un-constify QWindow 
parameters (authored by zzag).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26985?vs=74555=74585

REVISION DETAIL
  https://phabricator.kde.org/D26985

AFFECTED FILES
  shell/panelshadows.cpp
  shell/panelshadows_p.h

To: zzag, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21226: search for a default wallpaper in lookandfeel

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:670f3ec50456: search for a default wallpaper in 
lookandfeel (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21226?vs=58130=74583#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21226?vs=58130=74583

REVISION DETAIL
  https://phabricator.kde.org/D21226

AFFECTED FILES
  lookandfeel/contents/defaults
  wallpapers/image/image.cpp

To: mart, #plasma, davidedmundson
Cc: kossebau, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26972: Work around an issue with changing the wallpaper's filetype

[Nathaniel Graham]

ngraham added a comment.


  I didn't have the cache patch installed, but I probably forgot to delete the 
wallpapers from one of the several on-disk locations where they live. :/ 
reverted in bfe2152c5ef73e9f5b7ad03313f3a4ccef440a22 
.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26972

To: ngraham, davidedmundson, #plasma, ognarb
Cc: broulik, bshah, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21225: set the wallpaper when applying look and feel

[Nathaniel Graham]

ngraham added a comment.


  I have a feeling we'll get user complaints and bug reports if we 
unconditionally reset the wallpaper when applying a global theme. Before we do 
this, I think we need to add a mechanism to allow the user to choose which 
parts get applied, per the discussion in T11746: Make it possible to only apply 
certain parts of a Global Theme .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21225

To: mart, #plasma
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26842: Fix fonts KCM button state

[Nathaniel Graham]

ngraham added a comment.


  We are getting duplicates of https://bugs.kde.org/show_bug.cgi?id=416358, so 
I guess it would be nice if this made it into 5.18.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26842

To: bport, #plasma, ervin, crossi, meven
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

[Vlad Zahorodnii]

zzag added a comment.


  Sorry, I know little to nothing about internals of KScreenLocker.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D26986

To: tcanabrava
Cc: zzag, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26842: Fix fonts KCM button state

[Benjamin Port]

bport updated this revision to Diff 74576.
bport added a comment.


  fix coding style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26842?vs=74127=74576

REVISION DETAIL
  https://phabricator.kde.org/D26842

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontssettings.kcfg

To: bport, #plasma, ervin, crossi, meven
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26842: Fix fonts KCM button state

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> meven wrote in fonts.cpp:473
> Just a nitpick, I guess you plan to change it soon.

It will be changed when we migrate this part to kconfigxt

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26842

To: bport, #plasma, ervin, crossi, meven
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25634: Add kconf update script for ksmserver

[David Edmundson]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6dc8da6c9539: Add kconf update script for ksmserver 
(authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25634?vs=74440=74569

REVISION DETAIL
  https://phabricator.kde.org/D25634

AFFECTED FILES
  kcms/ksmserver/CMakeLists.txt
  kcms/ksmserver/kconf_update/ksmserver_update_loginMode_value.py
  kcms/ksmserver/kconf_update/ksmserver_update_loginMode_value.upd

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26842: Fix fonts KCM button state

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> meven wrote in fonts.cpp:473
> You can make this static.

Just a nitpick, I guess you plan to change it soon.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26842

To: bport, #plasma, ervin, crossi, meven
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25634: Add kconf update script for ksmserver

[David Edmundson]

davidedmundson added a comment.


  [Monday, 27 January 2020] [16:02:16 GMT]  Alright then it 
looks reasonable to me
  
  Treating that as an approval

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25634

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26842: Fix fonts KCM button state

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> ervin wrote in fontssettings.kcfg:77
> I guess this depends on how the font get serialized... and looking into 
> KConfig we use toString() so stylename will appear AFAICT.

This is only the default value, and default value will be not bold or italic so 
we will not have this kind of problem AFAIK.
I also tested to set bold to my general font and it work as expected

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26842

To: bport, #plasma, ervin, crossi, meven
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 74565.
tcanabrava added a comment.


  - Simplify Architecture

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26986?vs=74556=74565

BRANCH
  wip_fix_screenlocker_detach_reattach

REVISION DETAIL
  https://phabricator.kde.org/D26986

AFFECTED FILES
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/main.cpp

To: tcanabrava
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26784: KCM KDED: Add immutability and fix default, reset, apply buttons

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:69ac53df265e: KCM KDED: Add immutability and fix default, 
reset, apply buttons (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26784?vs=74137=74564

REVISION DETAIL
  https://phabricator.kde.org/D26784

AFFECTED FILES
  kcms/kded/kcmkded.cpp
  kcms/kded/modulesmodel.cpp
  kcms/kded/modulesmodel.h
  kcms/kded/package/contents/ui/main.qml

To: bport, ervin, crossi, meven, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21225: set the wallpaper when applying look and feel

[David Edmundson]

davidedmundson added a comment.


  I'm not completely blocking this, but I have two concerns with this patch:
  
  --
  
  1. wallpaper is somewhat different to the other configs, I'm not super 
convinced we want to reset it without prompts
  
  
  
  --
  
  2. the resetting has potential to mess with 3rd parties setting the wallpaper.
  
  From a customer project we have:
  
usr/share/plasma/look-and-feel/net.bluesystems.[redacted]/contents/plasmoidsetupscripts/org.kde.plasma.folder.js:applet.writeConfig("Image",
 "file:///usr/share/wallpapers/[redated]os.jpg")
  
  Currently:
  if you click on the lnf with reset layout you go to the lnf set one. That 
will result in it switching to the distro set one if available otherwise fall 
back to lnf
  if  you click on the lnf without reset layout you don't change the wallpaper 
at all
  
  After this patch:
  if you click on the lnf with reset layout everything is as before. That's all 
good.
  
  if you click on the lnf without reset layout we will:
  
  - if defaults exist and wallpaper is set, change it
  - if defaults exist and wallpaper is not set, do nothing
  - if defaults does not exist, load the wallpaper from the superclass lnf
  
  Which might seem a bit random.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21225

To: mart, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 3 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/3/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Wed, 29 Jan 2020 13:04:30 +
 Build duration:
2 min 37 sec and counting
   CONSOLE OUTPUT
  [...truncated 498 lines...][2020-01-29T13:06:59.468Z] [114/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\debuggermanager.cpp.obj[2020-01-29T13:06:59.468Z] [115/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\debugger.cpp.obj[2020-01-29T13:06:59.468Z] [116/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\applicationdetailsexamples.cpp.obj[2020-01-29T13:07:00.061Z] [117/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\crashedapplication.cpp.obj[2020-01-29T13:07:00.649Z] [118/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\statusnotifier.cpp.obj[2020-01-29T13:07:00.650Z] [119/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\bugzillalib.cpp.obj[2020-01-29T13:07:00.910Z] [120/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\gdbhighlighter.cpp.obj[2020-01-29T13:07:00.910Z] [121/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpage.cpp.obj[2020-01-29T13:07:01.171Z] [122/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportinterface.cpp.obj[2020-01-29T13:07:01.171Z] [123/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\assistantpage_bugzilla_version.cpp.obj[2020-01-29T13:07:01.171Z] [124/145] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\attachmenttest.dir\attachmenttest_autogen\mocs_compilation.cpp.obj[2020-01-29T13:07:01.778Z] [125/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantdialog.cpp.obj[2020-01-29T13:07:01.778Z] [126/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\productmapping.cpp.obj[2020-01-29T13:07:02.042Z] [127/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpages_bugzilla.cpp.obj[2020-01-29T13:07:02.305Z] [128/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpages_base.cpp.obj[2020-01-29T13:07:02.305Z] [129/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\parsebugbacktraces.cpp.obj[2020-01-29T13:07:02.305Z] [130/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpages_bugzilla_duplicates.cpp.obj[2020-01-29T13:07:02.305Z] [131/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\drkonqi_debug.cpp.obj[2020-01-29T13:07:02.305Z] [132/145] Linking CXX executable bin\bugzillalibtest.exe[2020-01-29T13:07:02.562Z] [133/145] Linking CXX executable bin\connectiontest.exe[2020-01-29T13:07:02.562Z] [134/145] Linking CXX executable bin\attachmenttest.exe[2020-01-29T13:07:02.562Z] [135/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\duplicatefinderjob.cpp.obj[2020-01-29T13:07:02.562Z] [136/145] Linking CXX executable bin\bugzillatest.exe[2020-01-29T13:07:02.820Z] [137/145] Linking CXX executable bin\bugtest.exe[2020-01-29T13:07:02.820Z] [138/145] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\DrKonqiInternal_autogen\mocs_compilation.cpp.obj[2020-01-29T13:07:02.820Z] [139/145] Linking CXX static library lib\DrKonqiInternal.lib[2020-01-29T13:07:02.820Z] [140/145] Linking CXX executable bin\producttest.exe[2020-01-29T13:07:02.820Z] [141/145] Linking CXX executable bin\bugfieldtest.exe[2020-01-29T13:07:02.820Z] [142/145] Automatic MOC for target drkonqi[2020-01-29T13:07:03.079Z] [143/145] Building CXX object src\CMakeFiles\drkonqi.dir\drkonqi_autogen\mocs_compilation.cpp.obj[2020-01-29T13:07:04.458Z] [144/145] Building CXX object src\CMakeFiles\drkonqi.dir\main.cpp.obj[2020-01-29T13:07:04.458Z] [145/145] Linking CXX executable bin\drkonqi.exe[2020-01-29T13:07:04.458Z] FAILED: bin/drkonqi.exe [2020-01-29T13:07:04.459Z] cmd.exe /C "cd . && C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\cmake-base\bin\cmake.exe -E vs_link_exe --intdir=src\CMakeFiles\drkonqi.dir --manifests  -- C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe /nologo src\CMakeFiles\drkonqi.dir\main.cpp.obj src\CMakeFiles\drkonqi.dir\drkonqi_autogen\mocs_compilation.cpp.obj  /out:bin\drkonqi.exe /implib:lib\drkonqi.lib /pdb:bin\drkonqi.pdb /version:0.0  /machine:x64 /NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd /debug /INCREMENTAL  /subsystem:console  lib\DrKonqiInternal.lib "C:\CI\Software Installs\drkonqi\lib\KF5ConfigWidgets.lib" "C:\CI\Software Installs\drkonqi\lib\KF5Codecs.lib" "C:\CI\Software Installs\drkonqi\lib\KF5Auth.lib" "C:\CI\Software Installs\drkonqi\lib\KF5AuthCore.lib" "C:\CI\Software Installs\drkonqi\lib\KF5JobWidgets.lib" "C:\CI\Software Installs\drkonqi\lib\KF5Completion.lib" 

D26894: Enable publication of API dox on api.kde.org

[Friedrich W. H. Kossebau]

kossebau added a comment.


  For KDEPIM, the definition is in the akonadi repo: 
https://phabricator.kde.org/source/akonadi/browse/master/metainfo.yaml

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D26894

To: kossebau, #kwin, graesslin, zzag
Cc: davidedmundson, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26894: Enable publication of API dox on api.kde.org

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D26894#602388 , @davidedmundson 
wrote:
  
  > Go for it.
  >
  > > If so, this change should trigger addition of KDecoration on api.kde.org, 
similar like KAsync is currently at the toplevel.
  >
  > If we could make a plasma subcategory, that would be great. We have some 
other potential libs to add. There's a lot of QML plugins and scripting hooks 
that we should be exposing properly.
  
  
  For such a Plasma subcategory, by the current design of kapidox as I know it, 
this needs to have one KDE repo to have a metainfo.yaml file which describes 
such a group of projects.
  KApidox itself hacks this in for KDE Frameworks by having the group 
information for that in its own metainfo.yaml, which works as it is official 
part of Frameworks as well, cmp. 
https://phabricator.kde.org/source/kapidox/browse/master/metainfo.yaml
  
  No instant proposal where Plasma could define its group, it should be some 
repo central to plasma.
  
  No time myself to care for this, sorry. But might be an interesting thing to 
play with for a beginner, things are mostly documented.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D26894

To: kossebau, #kwin, graesslin, zzag
Cc: davidedmundson, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26894: Enable publication of API dox on api.kde.org

[David Edmundson]

davidedmundson added a comment.


  Go for it.
  
  > If so, this change should trigger addition of KDecoration on api.kde.org, 
similar like KAsync is currently at the toplevel.
  
  If we could make a plasma subcategory, that would be great. We have some 
other potential libs to add. There's a lot of QML plugins and scripting hooks 
that we should be exposing properly.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D26894

To: kossebau, #kwin, graesslin, zzag
Cc: davidedmundson, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26894: Enable publication of API dox on api.kde.org

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R129:e08b848015f5: Enable publication of API dox on 
api.kde.org (authored by kossebau).

REPOSITORY
  R129 Window Decoration Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26894?vs=74558=74560

REVISION DETAIL
  https://phabricator.kde.org/D26894

AFFECTED FILES
  README.md
  metainfo.yaml

To: kossebau, #kwin, graesslin, zzag
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

[Tomaz Canabrava]

tcanabrava added a comment.


  In D26986#602373 , @davidedmundson 
wrote:
  
  > This is definitely an area for improvement.
  >
  > This code was initially written before QGuiApplication::screenRemoved 
existed, which is why it's like this.
  >  I think this solution is overly complex, you have the pointer to what 
changed in screenRemoved, we then discard that information and then go through 
loops to effectively retrieve that information we originally had.
  >  With a refactor that could be cleaner.
  
  
  I'll try to refactor.
  
  > As for your initial bug you're trying to fix:
  >  You're still in a race to see if kscreenlocker can update before kwin 
renders something, this might make kscreenlocker faster, but it won't resolve 
it being a race.
  
  I'll poke vlad to see how to proceed here.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D26986

To: tcanabrava
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26894: Enable publication of API dox on api.kde.org

[Friedrich W. H. Kossebau]

kossebau added a comment.


  So, with only positive feedback so far I would be going to merge this on 31st 
Jan. Or earlier, if you tell me :)

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D26894

To: kossebau, #kwin, graesslin
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26894: Enable publication of API dox on api.kde.org

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 74558.
kossebau added a comment.


  keep Martin noted as maintainer, given no official step-down
  rebase to latest master

REPOSITORY
  R129 Window Decoration Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26894?vs=74305=74558

BRANCH
  addtoapikdeorg

REVISION DETAIL
  https://phabricator.kde.org/D26894

AFFECTED FILES
  README.md
  metainfo.yaml

To: kossebau, #kwin, graesslin
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

[David Edmundson]

davidedmundson added a comment.


  This is definitely an area for improvement.
  
  This code was initially written before QGuiApplication::screenRemoved 
existed, which is why it's like this.
  I think this solution is overly complex, you have the pointer to what changed 
in screenRemoved, we then discard that information and then go through loops to 
effectively retrieve that information we originally had.
  With a refactor that could be cleaner.
  
  As for your initial bug you're trying to fix:
  You're still in a race to see if kscreenlocker can update before kwin renders 
something, this might make kscreenlocker faster, but it won't resolve it being 
a race.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D26986

To: tcanabrava
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21226: search for a default wallpaper in lookandfeel

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  So default wallpaper is effectively via any of:
  
  - The active LNF
  - the plasma theme
  - LNF/layout.js
  - desktoppackage/layout.js
  - containment specific override hooks
  
  I will accept this on the condition that we mark the Plasma::theme one as 
deprecated. 
  I don't even think we need to load it here if we update the breeze one.
  
  I don't want to say this, but maybe stable branch is a good idea as then we 
can resolve this .png vs .jpeg issue

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/wallpaperFromLnf

REVISION DETAIL
  https://phabricator.kde.org/D21226

To: mart, #plasma, davidedmundson
Cc: kossebau, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  This patch tries - and fails - to fix the flicker of screens while
  the kscreenlocker_greeter is active. The reasoning of the patch is
  simple:
  
  instead of deleting the overlays in the vector untill we have as
  many overlays as screens, we check if a overlay belongs to a screen
  that's currently plugged in, deleting only those that don't have
  a screen anymore.
  
  and then, instead of going thru all of the views and updating the
  geometry and position, we only set that once for each overlay created.
  
  This is not by all means something that I want to merge, as currently
  is broken, but given the current implementation is also broken I think
  it's safe to assume a 'v1' so we can discuss what's wrong on both
  implementations.
  
  To test the bug: plug two monitors, run the locker, detach and reattach
  the monitors. on detaching (but not reattaching) the monitor will flicker
  and display the contents of what's behind the locked screen.

REPOSITORY
  R133 KScreenLocker

BRANCH
  wip_fix_screenlocker_detach_reattach

REVISION DETAIL
  https://phabricator.kde.org/D26986

AFFECTED FILES
  greeter/greeterapp.cpp

To: tcanabrava
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26985: [Panel Shadows] Un-constify QWindow parameters

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  It doesn't make sense to pass const `QWindow`s to `PanelShadows` because
  a `KWindowShadow` needs a mutable `QWindow` object.

TEST PLAN
  const_cast in PanelShadows::Private::updateShadow is gone \o/

REPOSITORY
  R120 Plasma Workspace

BRANCH
  pass-mutable-window-to-panel-shadows

REVISION DETAIL
  https://phabricator.kde.org/D26985

AFFECTED FILES
  shell/panelshadows.cpp
  shell/panelshadows_p.h

To: zzag, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26972: Work around an issue with changing the wallpaper's filetype

[Kai Uwe Broulik]

broulik added a comment.


  This doesn't work. The image doesn't load. `QImage` shortcuts when it sees a 
".png".
  Are you sure you didn't leave the old wallpaper in the folder when you tested 
this? Or even had your "wallpaper cache" attempt patch still applied?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26972

To: ngraham, davidedmundson, #plasma, ognarb
Cc: broulik, bshah, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26972: Work around an issue with changing the wallpaper's filetype

[Bhushan Shah]

bshah added a comment.


  This doesn't work on neon dev unstable and actually breaks the wallpaper.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26972

To: ngraham, davidedmundson, #plasma, ognarb
Cc: bshah, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26965: [Emojier] Copy Emoji also into selection clipboard

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6175428b2e80: [Emojier] Copy Emoji also into selection 
clipboard (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26965?vs=74496=74548

REVISION DETAIL
  https://phabricator.kde.org/D26965

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/emojier.cpp

To: broulik, #plasma, apol
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26981: [startkde] Export LC_TIME again

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bc34f232b7cd: [startkde] Export LC_TIME again (authored 
by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26981?vs=74545=74546

REVISION DETAIL
  https://phabricator.kde.org/D26981

AFFECTED FILES
  startkde/startplasma.cpp

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26981: [startkde] Export LC_TIME again

[David Edmundson]

davidedmundson added a comment.


  I win!
  
  https://phabricator.kde.org/D26980

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26981

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26981: [startkde] Export LC_TIME again

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BUG: 416670
  FIXED-IN: 5.18.0

TEST PLAN
  None.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26981

AFFECTED FILES
  startkde/startplasma.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> settings.cpp:40
> +{
> +static const char s_configFile[] = "plasmanotifyrc";
> +}

I don't think that's what Kai had in mind regarding his comment. @broulik could 
you confirm?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26834

To: crossi, ervin, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26980: Sync LC_TIME

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It's written out by the formats KCM, but wasn't loaded here
  BUG: 416670

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26980

AFFECTED FILES
  startkde/startplasma.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart