D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

ngraham added a comment. It is (already) font-dependent, yes. A higher font size will result in larger spacing. IMO this is not super sensible, but, there is it. :p BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg,

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev added a comment. Went to check on different DPIs again to be sure it's fine and it definitely looks fine to me, scaling up the hitbox padding additions (and therefore the icon spacing) in sync with the DPI scaling very nicely, so that shouldn't be an issue. BRANCH D27466

D27669: WIP: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > breezetoolsareamanager.cpp:146 > +if (window == widget->window()->windowHandle()) { > +hasWidget = true; > +} you can break here once one widget is found. no need to loop over the

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev added a comment. In D27466#620052 , @IlyaBizyaev wrote: > In D27466#620050 , @The-Feren-OS-Dev wrote: > > > This patch only affects the System Tray widget itself, not anything else

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76706. cblack added a comment. Clean up animation map REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76694=76706 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D27669: WIP: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > breeze.h:191 > +AnimationPressed = 0x8, > +AnimationWindowFocused = 0x10, > }; Sorry for the many postings. As far as I can tell this guy is used nowhere. Please remove. REPOSITORY R31 Breeze REVISION DETAIL

D27669: WIP: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > breezetoolsareamanager.h:1 > +#pragma once > + Please use garding defines rather than "pragma once" for consistency with the rest of the code. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack,

D27669: WIP: [kstyle] Tools area

hpereiradacosta added a subscriber: davidedmundson. hpereiradacosta added a comment. also adding @davidedmundson in the loop in particular for opinion on the devicepixel ratio business, and in case he can reproduce the crash. REPOSITORY R31 Breeze REVISION DETAIL

D27669: WIP: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > cblack wrote in breezehelper.cpp:1726 > In testing, I found that this would remain 1 physical pixel regardless of > scale factor. Then shouldn't you divide device pixel ratio ? Also, someone else should double check. To me that does not

D27669: WIP: [kstyle] Tools area

cblack added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezehelper.cpp:1726 > No. Should be QPen( outline, 1) or just "outline" > DevicePixelRatio is handled by paint engine. In testing, I found that this would remain 1 physical pixel regardless of scale factor. REPOSITORY

D27669: WIP: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > breezehelper.cpp:1726 > + > +painter->setPen(QPen(outline, > 1*widget->screen()->devicePixelRatio())); > +painter->setBrush(Qt::NoBrush); No. Should be QPen( outline, 1) or just "outline" DevicePixelRatio is handled by

D27669: WIP: [kstyle] Tools area

cblack added a comment. In D27669#620072 , @hpereiradacosta wrote: > I can also try produce a crash report. A stack trace (with all debug symbols available) would be nice, yes. REPOSITORY R31 Breeze REVISION DETAIL

D27669: WIP: [kstyle] Tools area

hpereiradacosta added a comment. In D27669#619991 , @cblack wrote: > In D27669#619230 , @hpereiradacosta wrote: > > > right now it crashes all applications (here at least) when you unlock toolbars,

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

IlyaBizyaev added a comment. In D27466#620050 , @The-Feren-OS-Dev wrote: > This patch only affects the System Tray widget itself, not anything else on the panel. Only the spacing around the icons that are part of the System Tray applet itself

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev added a comment. In D27466#620037 , @IlyaBizyaev wrote: > Repeating my comment on the previous diff for this change: on my machine, the current spacing for systray elements already looks like your "after" screenshot. With

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

IlyaBizyaev added a comment. Repeating my comment on the previous diff for this change: on my machine, the current spacing for systray elements already looks like your "after" screenshot. With normal usage, my systray takes up 1/4 of the panel. Does it mean that after this change, it's

D27737: Fixed margin of digital clock

gvgeo added a comment. I was too late, it does change constantly now. But it depends on the font. The default font has the same width for all numbers, others don't. Wish I could at least help with git, but I struggle with it. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76694. cblack added a comment. Clear pen before drawing toolbar control REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76592=76694 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669

D27669: WIP: [kstyle] Tools area

cblack added a comment. In D27669#619230 , @hpereiradacosta wrote: > right now it crashes all applications (here at least) when you unlock toolbars, move them to a different position, then move them back to top. > Tested with dolphin,

D27737: Fixed margin of digital clock

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fed83f884acd: Fixed margin of digital clock (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27737?vs=76678=76692 REVISION DETAIL

D27737: Fixed margin of digital clock

niccolove added a comment. Is this correct, or is there anything special I have to do to land it to stable? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27737 To: niccolove, #vdg, #plasma, davidedmundson, ngraham Cc: gvgeo, davidedmundson, ngraham,

D27737: Fixed margin of digital clock

gvgeo added a comment. By using paintedWidth size is going to change constantly and will move the rest of the widgets. REPOSITORY R120 Plasma Workspace BRANCH margin_digital_clock (branched from master) REVISION DETAIL https://phabricator.kde.org/D27737 To: niccolove, #vdg, #plasma,

D27737: Fixed margin of digital clock

ngraham accepted this revision. ngraham added a comment. Visually +1 too. Stable branch? REPOSITORY R120 Plasma Workspace BRANCH margin_digital_clock (branched from master) REVISION DETAIL https://phabricator.kde.org/D27737 To: niccolove, #vdg, #plasma, davidedmundson, ngraham

D27737: Fixed margin of digital clock

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. code wise it makes much more sense than the original one REPOSITORY R120 Plasma Workspace BRANCH margin_digital_clock (branched from master) REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev added a comment. In D27466#619931 , @ngraham wrote: > So at this point it's just one pixel, and I don't see the huge harm. :) However the last patch to adjust this (D27438 ) proved quite

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

ngraham accepted this revision. ngraham added a comment. So at this point it's just one pixel, and I don't see the huge harm. :) However the last patch to adjust this (D27438 ) proved quite controversial, so we should wait for more opinions to avoid

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9e0711ac408d: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet… (authored by The-Feren-OS-Dev, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE

D27577: [KCM]Fix content below scrollbars

ngraham added a comment. +1, go ahead REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27577 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27737: Fixed margin of digital clock

ngraham added a comment. Nice, this fixes https://bugs.kde.org/show_bug.cgi?id=417803. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27737 To: niccolove, #vdg, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

niccolove added a comment. +1 BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D27737: Fixed margin of digital clock

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH margin_digital_clock (branched from master) REVISION DETAIL https://phabricator.kde.org/D27737

D27697: WIP: Added top area to notification header

niccolove updated this revision to Diff 76674. niccolove added a comment. Fix close button right margin REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27697?vs=76672=76674 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27697

D27697: WIP: Added top area to notification header

niccolove updated this revision to Diff 76672. niccolove added a comment. Fixed layouts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27697?vs=76571=76672 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27697 AFFECTED FILES

D27645: [KCM]Align volume controls row

gvgeo added a comment. In my opinion this is better even without the workaround. Only when scale is 100% for playback devices, look worse (first photo in before-after). REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma,