D25324: [GTK Config] Add XSettingsd as a runtime dependency

2020-03-07 Thread Mikhail Zolotukhin 
gikari added a comment.


  Ping!

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25324

To: gikari, #plasma, cblack, apol, jgrulich
Cc: eszlari, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 9 - Unstable!

2020-03-07 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/9/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 07 Mar 2020 21:30:18 +
 Build duration:
2 min 46 sec and counting
   JUnit Tests
  Name: projectroot.src Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.bugzillaintegration.libbugzilla Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.src.bugzillaintegration.libbugzilla.autotests.connectiontestName: projectroot.src.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27100: [GTK Config] Parameterise GTK config editing

2020-03-07 Thread Mikhail Zolotukhin 
gikari updated this revision to Diff 77185.
gikari added a comment.


  Use `arg` instead of + + + + + +

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27100?vs=74855=77185

BRANCH
  parameterise-gtk-config-io (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27100

AFFECTED FILES
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 8 - Still Failing!

2020-03-07 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/8/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 07 Mar 2020 21:08:53 +
 Build duration:
2 min 59 sec and counting
   CONSOLE OUTPUT
  [...truncated 397 lines...][2020-03-07T21:11:34.521Z] [14/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparserkdbgwin.cpp.obj[2020-03-07T21:11:35.116Z] [15/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\apijob.cpp.obj[2020-03-07T21:11:35.116Z] [16/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\connection.cpp.obj[2020-03-07T21:11:35.116Z] [17/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\bugzilla.cpp.obj[2020-03-07T21:11:35.696Z] [18/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\bugsearch.cpp.obj[2020-03-07T21:11:35.696Z] [19/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\bugupdate.cpp.obj[2020-03-07T21:11:35.958Z] [20/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\productclient.cpp.obj[2020-03-07T21:11:36.543Z] [21/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\jsoncommand.cpp.obj[2020-03-07T21:11:36.543Z] [22/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\newattachment.cpp.obj[2020-03-07T21:11:36.807Z] [23/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\exceptions.cpp.obj[2020-03-07T21:11:37.093Z] [24/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\bugfieldclient.cpp.obj[2020-03-07T21:11:37.093Z] [25/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\bugclient.cpp.obj[2020-03-07T21:11:37.355Z] [26/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commentclient.cpp.obj[2020-03-07T21:11:37.930Z] [27/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\querycommand.cpp.obj[2020-03-07T21:11:38.193Z] [28/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\clientbase.cpp.obj[2020-03-07T21:11:38.193Z] [29/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\attachmentclient.cpp.obj[2020-03-07T21:11:38.455Z] [30/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\newbug.cpp.obj[2020-03-07T21:11:38.455Z] [31/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bug.cpp.obj[2020-03-07T21:11:38.720Z] [32/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bugfield.cpp.obj[2020-03-07T21:11:38.982Z] [33/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\logindetails.cpp.obj[2020-03-07T21:11:39.682Z] [34/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\comment.cpp.obj[2020-03-07T21:11:39.682Z] [35/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\bugzilla_debug.cpp.obj[2020-03-07T21:11:39.682Z] [36/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\qbugzilla_autogen\mocs_compilation.cpp.obj[2020-03-07T21:11:39.943Z] [37/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsercdb.cpp.obj[2020-03-07T21:11:39.943Z] [38/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\product.cpp.obj[2020-03-07T21:11:40.205Z] [39/149] Linking CXX static library lib\qbugzilla.lib[2020-03-07T21:11:40.816Z] [40/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_parser_debug.cpp.obj[2020-03-07T21:11:40.816Z] [41/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_backtrace_parser_autogen\mocs_compilation.cpp.obj[2020-03-07T21:11:40.816Z] [42/149] Linking CXX static library lib\drkonqi_backtrace_parser.lib[2020-03-07T21:11:40.816Z] [43/149] Linking CXX executable bin\crashtest.exe[2020-03-07T21:11:41.783Z] [44/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\__\drkonqi_debug.cpp.obj[2020-03-07T21:11:41.783Z] [45/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\outputters.cpp.obj[2020-03-07T21:11:41.783Z] [46/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\callbacks.cpp.obj[2020-03-07T21:11:41.783Z] [47/149] Automatic MOC for target gdbbacktracelinetest[2020-03-07T21:11:41.783Z] [48/149] Automatic MOC for target backtraceparsertest_manual[2020-03-07T21:11:42.045Z]

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 9 - Unstable!

2020-03-07 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/9/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 07 Mar 2020 21:09:07 +
 Build duration:
2 min 42 sec and counting
   JUnit Tests
  Name: projectroot.src Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.bugzillaintegration.libbugzilla Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.src.bugzillaintegration.libbugzilla.autotests.connectiontestName: projectroot.src.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27917: [Baloo] Fix firstRun and config change logic

2020-03-07 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  FirstRun should only be set if baloo was *never ever* run before, and
  this case is already handled by baloo internally.
  
  Do no try to do a baloo config refresh if it has just been quit.
  
  Also avoid triggering a config update immediately after starting baloo,
  it will do another walk of the directory tree.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27917

AFFECTED FILES
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h

To: bruns, #baloo, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-07 Thread Yunhe Guo 
guoyunhe added a comment.


  In D27915#623862 , @davidre wrote:
  
  > In D27915#623859 , @guoyunhe 
wrote:
  >
  > > In D27915#623854 , @davidre 
wrote:
  > >
  > > > There is something wrong on your system, this is how before looks for 
me:
  > > >  F8163706: Screenshot_20200307_171017.PNG 

  > >
  > >
  > > Please ignore the content. I only want to compare the left panel.
  >
  >
  > Yes there is still a difference in the left panel in my screenshot compared 
to your before screenshot. Not pixelated and all categories colorful
  
  
  The "pixelated" icon only appears to HiDPI display. The "monochrome" icon 
only appears when the system has dejavu-fonts installed. It looks different in 
different distros.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27915

To: guoyunhe, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-07 Thread David Redondo 
davidre added a comment.


  In D27915#623859 , @guoyunhe wrote:
  
  > In D27915#623854 , @davidre 
wrote:
  >
  > > There is something wrong on your system, this is how before looks for me:
  > >  F8163706: Screenshot_20200307_171017.PNG 

  >
  >
  > Please ignore the content. I only want to compare the left panel.
  
  
  Yes there is still a difference in the left panel in my screenshot compared 
to your before screenshot. Not pixelated and all categories colorful

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27915

To: guoyunhe, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-07 Thread Yunhe Guo 
guoyunhe added a comment.


  In D27915#623854 , @davidre wrote:
  
  > There is something wrong on your system, this is how before looks for me:
  >  F8163706: Screenshot_20200307_171017.PNG 

  
  
  Please ignore the content. I only want to compare the left panel.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27915

To: guoyunhe, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-07 Thread David Redondo 
davidre added a comment.


  There is something wrong on your system, this is how before looks for me:
  F8163706: Screenshot_20200307_171017.PNG 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27915

To: guoyunhe, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-07 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 77174.
guoyunhe added a comment.


  Change object-group to object

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27915?vs=77172=77174

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27915

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/emojier/ui/CategoryAction.qml

To: guoyunhe, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27915: Use breeze icons for categories

2020-03-07 Thread Yunhe Guo 
guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27915

AFFECTED FILES
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/emojier/ui/CategoryAction.qml

To: guoyunhe
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27421: [Cuttleffish] Use proper QSortFilterProxyModel

2020-03-07 Thread David Redondo 
davidre updated this revision to Diff 77171.
davidre added a comment.


  Remove members that are not needed anymore

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27421?vs=75742=77171

BRANCH
  searchproxy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27421

AFFECTED FILES
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/autotests/iconmodeltest.cpp
  cuttlefish/package/contents/ui/IconGrid.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp
  cuttlefish/src/sortfiltermodel.cpp
  cuttlefish/src/sortfiltermodel.h

To: davidre, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27914: [Kilpper] Port QRegExp to QRegularExpression

2020-03-07 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added a reviewer: Plasma.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest
  klipper still seems to work

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-klipper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27914

AFFECTED FILES
  klipper/clipcommandprocess.cpp
  klipper/configdialog.cpp
  klipper/editactiondialog.cpp
  klipper/klipperpopup.cpp
  klipper/popupproxy.cpp
  klipper/popupproxy.h
  klipper/urlgrabber.cpp
  klipper/urlgrabber.h

To: ahmadsamir, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25919: Add open containing folder action

2020-03-07 Thread David Redondo 
davidre abandoned this revision.
davidre added a comment.


  Needs changes in cuttlefish

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25919

To: davidre, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27866: Make it compile against qt5.15. ::unite is deprecated.

2020-03-07 Thread Laurent Montel 
mlaurent added a comment.


  ping ?:)

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27866

To: mlaurent, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26992: [SystemTray] Use unified data model everywhere

2020-03-07 Thread Konrad Materka 
This revision was automatically updated to reflect the committed changes.
kmaterka marked an inline comment as done.
Closed by commit R120:39975673cb6a: [SystemTray] Use unified data model 
everywhere (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26992?vs=76028=77156

REVISION DETAIL
  https://phabricator.kde.org/D26992

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpanderArrow.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/ItemLoader.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/sortedsystemtraymodel.cpp
  applets/systemtray/sortedsystemtraymodel.h
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26992: [SystemTray] Use unified data model everywhere

2020-03-07 Thread Konrad Materka 
kmaterka marked an inline comment as done.
kmaterka added inline comments.

INLINE COMMENTS

> davidedmundson wrote in AbstractItem.qml:34
> Lets look at fixing in a follow up patch
> 
> QML can do enums now

OK, I will change that in a separate patch

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26992

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart