D28075: [kstyle] Properly unregister widgets in ShadowHelper

ahmadsamir added a comment. FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a SIGSEGV even after building breeze with this diff: Thread 1 "kdatetimeeditte" received signal SIGSEGV, Segmentation fault. 0x70c6c770 in qDeleteAll::const_iterator>

D28075: [kstyle] Properly unregister widgets in ShadowHelper

zzag added a comment. In D28075#629808 , @ahmadsamir wrote: > FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a SIGSEGV even after building breeze with this diff: > > Thread 1 "kdatetimeeditte" received signal

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

zzag updated this revision to Diff 77916. zzag added a comment. Rebase on master REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14910?vs=39945=77916 BRANCH arcpatch-D14910 REVISION DETAIL https://phabricator.kde.org/D14910 AFFECTED FILES

D28109: [applets/systemtray] Simplify icon size logic

ngraham accepted this revision. ngraham added subscribers: davidedmundson, mart. ngraham added a comment. This revision is now accepted and ready to land. This looks like a sensible refactor to me, and it solves the issue that I was having with icon size changing based on the expanded popup

D27857: Port some usage of QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 77906. ahmadsamir added reviewers: davidedmundson, apol, broulik. ahmadsamir added a comment. Verbatim REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27857?vs=77905=77906 BRANCH l-qregexp-QRE (branched

D27857: Port some usage of QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 77905. ahmadsamir added a comment. Verbatim REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27857?vs=77898=77905 BRANCH l-qregexp-QRE (branched from master) REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/72/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 13:49:53 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT [...truncated

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

bshah updated this revision to Diff 77896. bshah added a comment. - rename method to lock rotation - disconnect/connect orientation sensor when we want to lock/unlock rotation REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28115?vs=77879=77896 BRANCH

D28103: introduce PassiveNotification type

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:4e596d8bed9c: introduce PassiveNotification type (authored by mart). CHANGED PRIOR TO COMMIT

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex added a comment. F8182687: folderview_work.patch I did the changes above like you said in the patch above. I didn't applied it yet, because on testing that same patch, I discovered a bug. I reverted the changes ( after saving the work

D28115: feat(kded): add a dbus method to lock current rotation

bshah added a comment. This works as expected API wise and functionality wise, but internally control config is not written at all. :/ REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28115 To: bshah, romangg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28120: [Icons KCM] Floor delegate height

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c9f545a3c537: [Icons KCM] Floor delegate height (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28120?vs=77895=77912 REVISION DETAIL

D27199: [Applet]Update layout based on T10470

manueljlin added a comment. In D27199#627422 , @gvgeo wrote: > Differently sized icons are about to be restored in D28034 . Nice! Thanks >> ...text indicator replaced with a 1px divider... Is it

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. Nice job INLINE COMMENTS > abstracttasksmodel.h:99 > LastActivated,/**< The timestamp of the last time a task was the > active task. */ > +ApplicationMenuServiceName, /**< The DBus service name for the > application's menu. > +

D27857: Port some usage of QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 77898. ahmadsamir marked 2 inline comments as done. ahmadsamir removed reviewers: davidedmundson, apol, broulik. ahmadsamir added a comment. Address comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27166: Refactor converter runner

alex updated this revision to Diff 77899. alex added a comment. Add tests for converterrunner REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=76487=77899 BRANCH converter_runner_refactoring (branched from master) REVISION DETAIL

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. In D27199#629881 , @manueljlin wrote: > In D27199#627422 , @gvgeo wrote: > > > Differently sized icons are about to be restored in D28034

D28075: [kstyle] Properly unregister widgets in ShadowHelper

zzag added a comment. In D28075#629829 , @ahmadsamir wrote: > Anyway, the important thing is that the test passes on the CI system. Okay, that's good! We still have that qDeleteAll in ~ShadowHelper(), not sure what we have to do about

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 77924. cblack added a comment. Use new KWindowInfo APIs REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77835=77924 BRANCH cblack/appmenu-libtaskmanager (branched from master) REVISION DETAIL

D27857: Port some usage of QRegExp to QRegularExpression

apol added a comment. +1 overall INLINE COMMENTS > ksolidnotify.cpp:131 > QString out(p->readAll()); > -const QStringList = > out.split(QRegExp(QStringLiteral("\\s+")), QString::SkipEmptyParts); > +const QStringList = >

D28126: Fix crash, the e-mail client service can be null

apol created this revision. apol added a reviewer: meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN I don't get a crash anymore REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 73 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/73/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 14:21:33 + Build duration: 4 min 39 sec and counting CONSOLE OUTPUT [...truncated

D27935: Make kwallet-pam work with pam_fscrypt

sitter added inline comments. INLINE COMMENTS > aacid wrote in pam_kwallet.c:329 > > How about leaving it in for 5.18 and drop it for master? > > Should there be an unexpected problem we'll at least have months of > > theoretical testing and a shorter window from 5.19.0 to .1 to hotfix a > >

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jjorge requested review of this revision. REVISION SUMMARY Depending on hardware, Linux kernel exports battery state in different files. Previously only charge_now, charge_full and

D28075: [kstyle] Properly unregister widgets in ShadowHelper

zzag added a comment. In D28075#629808 , @ahmadsamir wrote: > FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a SIGSEGV even after building breeze with this diff: > > Thread 1 "kdatetimeeditte" received signal

D28075: [kstyle] Properly unregister widgets in ShadowHelper

ahmadsamir added a comment. Could be something on my system no idea what though. Sorry for the noise. Anyway, the important thing is that the test passes on the CI system. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28075 To: zzag, #plasma, cblack Cc:

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 71 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/71/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 13:41:16 + Build duration: 46 sec and counting CONSOLE OUTPUT [...truncated 266

D27857: Port some usage of QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in server.cpp:671 > Why the changes from [0-9] to \d? Less cluttered; but maybe not as readable. I'll revert it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27857 To: ahmadsamir, #plasma Cc:

D27100: [GTK Config] Parameterise GTK config editing

gikari updated this revision to Diff 77909. gikari added a comment. Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27100?vs=77185=77909 BRANCH parameterise-gtk-config-io (branched from master) REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 16 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/16/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 18 Mar 2020 13:49:16 + Build duration: 54 sec and counting CONSOLE OUTPUT

D27985: Include s_kcrashErrorMessage in our traces

broulik added a comment. When this symbol isn't present, gdb just aborts and you don't get any back trace anymore: Error in sourced command file: No symbol "s_kcrashErrorMessage" in current context. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D27985

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 773 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/773/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Mar 2020 16:08:17 + Build duration: 2 min 57 sec and counting CONSOLE OUTPUT

D28034: [Applet] Port to ExpandableListItem

ngraham updated this revision to Diff 77936. ngraham added a comment. ExpandableListItem is now in PlasmaExtras REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28034?vs=77704=77936 BRANCH port-to-ExpandableListItem (branched from

D28037: [Applet] Port to ExpandableListItem

ngraham updated this revision to Diff 77938. ngraham added a comment. ExpandableListItem is now in PlasmaExtras REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28037?vs=77700=77938 BRANCH port-to-ExpandableListItem (branched from master) REVISION

D27063: Fix disabeling of autolock timeout

ervin added a comment. Well, I already accepted it, I thought you pushed long ago (and I suspect it got overlooked by the other potential reviewers). :-) REPOSITORY R133 KScreenLocker BRANCH fix_disabled_state REVISION DETAIL https://phabricator.kde.org/D27063 To: alex, mart, ervin

D27063: Fix disabeling of autolock timeout

ervin added a comment. Ah didn't know! I assumed you could push... But yeah, you authored a few patches now, time to apply for a developer account. You can put my name indeed. REPOSITORY R133 KScreenLocker BRANCH fix_disabled_state REVISION DETAIL https://phabricator.kde.org/D27063

D27063: Fix disabeling of autolock timeout

alex added a comment. Ping. REPOSITORY R133 KScreenLocker BRANCH fix_disabled_state REVISION DETAIL https://phabricator.kde.org/D27063 To: alex, mart, ervin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 77950. cblack marked 4 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77930=77950 BRANCH cblack/appmenu-libtaskmanager (branched

D28129: Read the new message string after rather than before

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. <3 REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D28129 To: apol, #frameworks, broulik, sitter Cc: plasma-devel, Orage, LeGast00n,

D28129: Read the new message string after rather than before

apol created this revision. apol added reviewers: Frameworks, broulik, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This way if we're linking against an old KF5, we still generate a backtrace

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:60 > Qt5::X11Extras > +XCB::XCB > KF5::IconThemes) Unused REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik,

D27857: Port some usage of QRegExp to QRegularExpression

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > calculatorrunner.cpp:199 > > -if (cmd.contains(QRegExp(QStringLiteral("\\d+and\\d+" { > - cmd.replace(QRegExp(QStringLiteral("(\\d+)and(\\d+)")), >

D27857: Port some usage of QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f444ebe595a2: Port some usage of QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. It seems it is possible to do this (removing stuff from the data engine) after all. I will try to work on this in the next time REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28107 To: davidre, kmaterka, #plasma, broulik,

D28129: Read the new message string after rather than before

apol planned changes to this revision. apol added a comment. Just tested it properly, it fails to generate a backtrace altogether :( REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D28129 To: apol, #frameworks, broulik, sitter Cc: plasma-devel, Orage, LeGast00n,

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 77930. cblack added a comment. Drop unused linkage REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77924=77930 BRANCH cblack/appmenu-libtaskmanager (branched from master) REVISION DETAIL

D28035: [Applet] Port to ExpandableListItem

ngraham updated this revision to Diff 77937. ngraham added a comment. ExpandableListItem is now in PlasmaExtras REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28035?vs=77699=77937 BRANCH port-to-ExpandableListItem (branched from master) REVISION

D28072: [GTK Config] Apply color scheme to GTK3 applications

davidre added a comment. It seems it is possible to do this (removing stuff from the data engine) after all. I will try to work on this in the next time REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: davidre,

D28103: introduce PassiveNotification type

mart updated this revision to Diff 77934. mart added a comment. - export the item - support multiple notifications - make it a private component again - fix passive notifications for ApplciationItem REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D28103: Support multiple stacked Passive Notifications

mart added inline comments. INLINE COMMENTS > broulik wrote in PassiveNotification.qml:35 > Just `padding`? actually, it would make the implicitHeight calculation fail (it's dumb like that and that's why for the new property inset they only added leftInset topInset etcand not a simple inset

D28103: Support multiple stacked Passive Notifications

mart updated this revision to Diff 77942. mart marked 2 inline comments as done. mart added a comment. - fix quick spawning of notifications REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28103?vs=77934=77942 BRANCH mart/passivenotification REVISION

D28103: Support multiple stacked Passive Notifications

broulik added inline comments. INLINE COMMENTS > PassiveNotification.qml:26 > + > +x: parent.width/2 - width/2 > +y: parent.height - height - Kirigami.Units.smallSpacing `Math.round` please > PassiveNotification.qml:35 > + > +topPadding: Kirigami.Units.smallSpacing > +

D27063: Fix disabeling of autolock timeout

alex added a comment. I don't have a developer account, but I am going to apply for one. May I enter your name as a supporter? REPOSITORY R133 KScreenLocker BRANCH fix_disabled_state REVISION DETAIL https://phabricator.kde.org/D27063 To: alex, mart, ervin Cc: plasma-devel, Orage,

D28132: [Calculator Runner] Minor code optimisation

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, apol. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY Remove redunant QString::contains() checks. Create one QRegularExpression object and use setPattern(). TEST PLAN

D28035: [Applet] Port to ExpandableListItem

ngraham updated this revision to Diff 77966. ngraham added a comment. Remove now-unnecessary imports REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28035?vs=77937=77966 BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL

D27063: Fix disabeling of autolock timeout

This revision was automatically updated to reflect the committed changes. Closed by commit R133:b060c853b4cd: Fix disabeling of autolock timeout (authored by alex, committed by ngraham). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 774 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/774/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Mar 2020 18:48:08 + Build duration: 5 min 6 sec and counting CONSOLE OUTPUT

D27935: Make kwallet-pam work with pam_fscrypt

aacid updated this revision to Diff 77963. aacid added a comment. restore the code that calls pam_sm_open_session from pam_sm_authenticate if they were called "out of order" REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE

D28104: [applets/digital-clock] Increase size of calendar in pop-up

This revision was automatically updated to reflect the committed changes. Closed by commit R120:86f0e49150e7: [applets/digital-clock] Increase size of calendar in pop-up (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26956: Remove export header from static install

masonm requested review of this revision. masonm added a comment. Hello, Just following up on this change review—it all looks good to me. Can we merge it in? Thanks! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26956 To: masonm, #kirigami, mart, apol

D28132: [Calculator Runner] Minor code optimisation

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cd37cc6926c3: [Calculator Runner] Minor code optimisation (authored by ahmadsamir). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28132?vs=77945=77957

D28134: Add ColorUtils

cblack updated this revision to Diff 77975. cblack added a comment. Better class description REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=77974=77975 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFECTED

D28126: Fix crash, the e-mail client service can be null

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8a0bcc24fdb8: Fix crash, the e-mail client service can be null (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28126?vs=77917=77967

D28134: Add ColorUtils

cblack updated this revision to Diff 77976. cblack added a comment. Improve documentation comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=77975=77976 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134

D28133: [applets/digital-clock] Switch timezones by clicking on them in the popup

ngraham created this revision. ngraham added reviewers: VDG, Plasma, jriddell. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch allows you to switch the timezone by clicking on your desired one in

D28134: Add ColorUtils

cblack updated this revision to Diff 77973. cblack added a comment. Use words instead of single letters REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=77972=77973 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134

[kio-extras] [Bug 376301] sftp.so not closing connections when ProxyCommand is configured

https://bugs.kde.org/show_bug.cgi?id=376301 --- Comment #3 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

[kio-extras] [Bug 345440] SFTP: Internal Error on deleting a folder without having permissions and wich is also mounted

https://bugs.kde.org/show_bug.cgi?id=345440 --- Comment #4 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

[kio-extras] [Bug 366488] Too many sftp.so processes, not closing

https://bugs.kde.org/show_bug.cgi?id=366488 --- Comment #3 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular

D28134: Add ColorUtils

cblack created this revision. cblack added reviewers: Plasma, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY ColorUtils is a class that offers utilities for working with colour, offering the following

D28134: Add ColorUtils

cblack updated this revision to Diff 77972. cblack added a comment. Add EOF newlines REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=77971=77972 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFECTED FILES

D28134: Add ColorUtils

cblack updated this revision to Diff 77974. cblack added a comment. Add comments to code REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=77973=77974 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFECTED

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 775 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/775/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Mar 2020 19:34:41 + Build duration: 1 min 43 sec and counting CONSOLE OUTPUT

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

bshah created this revision. bshah added a reviewer: romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY This allows to toggle the auto-rotation or temporary inhibit it on mobile. TEST PLAN it works

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

bshah added a comment. Maybe it would be sensible idea to instead connect/disconnect orientation sensor, and replace method name with "inhibitAutoRotation"? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28115 To: bshah, romangg Cc: plasma-devel, Orage, LeGast00n,

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

bshah updated this revision to Diff 77879. bshah added a comment. update branch REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28115?vs=77878=77879 BRANCH arcpatch-D28115 REVISION DETAIL https://phabricator.kde.org/D28115 AFFECTED FILES

D28116: Fix sizing of ComboBox and RadioButton

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `KQuickStyleItem` manages its implicit size internally. Overriding it on the QML side makes this

D27857: Port some usage of QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27857 To: ahmadsamir, #plasma, davidedmundson, apol, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D28115: [RFC] feat(kded): add a dbus method to toggle auto-rotation

romangg added a comment. So I think of two things to consider: - How is the overall interaction? Do we want something in line with other systems? Then we should have a lock/unlock rotation workflow where the current rotation orientation is made permanent until the icon is tapped again.

D28116: Fix sizing of ComboBox and RadioButton

broulik updated this revision to Diff 77882. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added reviewers: mart, hpereiradacosta. broulik added a comment. - Use pixel metric for checkbox/radio button size and use the spacing. Only use

D28116: Fix sizing of ComboBox and RadioButton

This revision was automatically updated to reflect the committed changes. Closed by commit R858:b738ebbb6369: Fix sizing of CheckBox and RadioButton (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D28073: [kstyle] Properly unregister widgets in ShadowHelper

This revision was automatically updated to reflect the committed changes. Closed by commit R113:19771d84177d: [kstyle] Properly unregister widgets in ShadowHelper (authored by zzag). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28073?vs=77725=77892

D28075: [kstyle] Properly unregister widgets in ShadowHelper

This revision was automatically updated to reflect the committed changes. Closed by commit R31:49fdd73e1629: [kstyle] Properly unregister widgets in ShadowHelper (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28075?vs=77727=77893 REVISION

D28120: [Icons KCM] Floor delegate height

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's two rows, so if the delegate happens to be at an odd size, both rows would be rounded