D28354: [applets/digital-clock] Fix calendar events not being shown at first

ngraham added a comment. Can you rebase this patch on current master? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28354 To: epopov, ngraham, #plasma, vkrause Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

epopov updated this revision to Diff 78827. epopov added a comment. Use `hideOnWindowDeactivate` property instead of `configuration.pin` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28408?vs=78805=78827 REVISION DETAIL

D28360: cmake: make xsettingsd check an option

kossebau added a comment. Yes, I would just do a patch for the 'PURPOSE' text, mentioning "Required" or "Optional" (whatever you decide on), based on previously discussions with packagers on similar cases. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari updated this revision to Diff 78823. gikari marked an inline comment as done. gikari added a comment. - Rebase on master - Add recoloration module check REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28072?vs=77860=78823 BRANCH

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

epopov added a comment. In D28408#637476 , @davidedmundson wrote: > As a question, rather than a researched proposal, is it better to check for the pin in? > > systemtray / PlasmoidItem.qml > > Connections { > target: applet

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

This revision was automatically updated to reflect the committed changes. Closed by commit R99:6f01f8040007: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them (authored by cblack). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D28360: cmake: make xsettingsd check an option

gikari added a comment. In D28360#636687 , @kossebau wrote: > Edit: and yes, I agree CMake has awful flaws here when it comes to our needs to properly communicate dependencies to fellow developers & packagers. I am trying to give you best

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78813. cblack added a comment. Rerender toolbar when invalidating cached rects REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78754=78813 BRANCH cblack/toolsarea REVISION DETAIL

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

davidedmundson added a comment. As a question, rather than a researched proposal, is it better to check for the pin in? systemtray / PlasmoidItem.qml Connections { target: applet onExpandedChanged: { INLINE COMMENTS > main.qml:158 > + > +

D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior

heikobecker added a comment. In D28398#637401 , @apol wrote: > If plasma pass is part of plasma, which I'm not sure of, you can consider just bumping the required Qt version to Qt 5.14, as it will be the minimum Qt for Plasma 5.19. It

D27669: [kstyle] Tools area

hpereiradacosta added a comment. In D27669#637164 , @ndavis wrote: > I've discovered another bug. When you move a window by dragging on an empty area, all hover effects stop working. This bug has been here since forever and is not

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

epopov created this revision. epopov added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. epopov requested review of this revision. REVISION SUMMARY When I pin a Klipper widget and then click on a history item, the Klipper widget closes. To

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 78804. cblack added a comment. Use KDE_INSTALL_LIBDIR REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77871=78804 BRANCH arcpatch-D28076 REVISION DETAIL https://phabricator.kde.org/D28076

D28086: Improve CMake handling of GNOME libraries

gikari added a comment. Everything is fine on CI. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28086 To: cblack, #plasma, gikari, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28086: Improve CMake handling of GNOME libraries

This revision was automatically updated to reflect the committed changes. Closed by commit R99:7f7a57095cf1: Improve CMake handling of GNOME libraries (authored by cblack). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28086?vs=78590=78803

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.14/18/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 29 Mar 2020 16:33:28 + Build duration: 2 min 6 sec and counting JUnit Tests Name:

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.14 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.14/11/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 29 Mar 2020 16:33:28 + Build duration: 2 min 4 sec and counting JUnit Tests Name: (root) Failed: 0

D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior

apol added a comment. +1 If plasma pass is part of plasma, which I'm not sure of, you can consider just bumping the required Qt version to Qt 5.14, as it will be the minimum Qt for Plasma 5.19. REPOSITORY R1028 Plasma Pass REVISION DETAIL https://phabricator.kde.org/D28398 To:

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.14 - Build # 10 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.14/10/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 29 Mar 2020 16:25:33 + Build duration: 2 min 6 sec and counting CONSOLE OUTPUT [...truncated 611

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.14 - Build # 17 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.14/17/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 29 Mar 2020 16:25:33 + Build duration: 1 min 35 sec and counting CONSOLE OUTPUT

D28389: Add support for logging categories

apol added a comment. Other than that, the patch looks good. +1 INLINE COMMENTS > romangg wrote in CMakeLists.txt:23 > Any idea how to reuse the declaration from the top-directory CMake file? Make sure the include() call is before the add_subdirectory(). That's why we usually put them

D28385: Remove unused file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:184cee85e9f5: Remove unused file (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28385?vs=78753=78802 REVISION DETAIL

D28339: [kapplymousetheme] Avoid loading QPT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:aa2212e25c92: [kapplymousetheme] Avoid loading QPT (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28339?vs=78640=78800

D28369: [runners/recentdocuments] disable executables or .desktop files

This revision was automatically updated to reflect the committed changes. Closed by commit R120:97bf7d777e56: [runners/recentdocuments] disable executables or .desktop files (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28286: [Task Manager] Port backend to ApplicationLauncherJob

dfaure added a comment. In D28286#637346 , @anthonyfieroni wrote: > Even 1200 is not problem to me. We seem to have very different opinions on good API design. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28133: [applets/digital-clock] Switch timezones by clicking on them in the popup

davidedmundson added a comment. Be careful about mixing terms here. This absolutely does not change "the timezone". This changes what the applet shows. It is super super important that if a user travels to another country even for a vacation they update the system timezone. The

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added a comment. In D28286#636881 , @dfaure wrote: > Why not -> because it just doesn't scale. 30 jobs * 4 delegates = 120 wrapper methods... Even 1200 is not problem to me. REPOSITORY R119 Plasma Desktop REVISION

D28382: QQC2-Desktop-Style: Convert license headers to SPDX expressions

This revision was automatically updated to reflect the committed changes. Closed by commit R858:d2f44e46e758: QQC2-Desktop-Style: Convert license headers to SPDX expressions (authored by cordlandwehr). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D28286: [Task Manager] Port backend to ApplicationLauncherJob

broulik planned changes to this revision. broulik added a comment. Will rebase on pending API change in D28268 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28286 To: broulik, #plasma, hein, dfaure Cc: anthonyfieroni,

D28347: Port services and shell runner away from KRun

broulik planned changes to this revision. broulik added a comment. Will rebase on pending API change in D28268 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28347 To: broulik, #plasma, dfaure Cc: plasma-devel, Orage,

D28398: Use Qt::SplitBehavior enum instead of QString::SplitBehavior

heikobecker created this revision. heikobecker added a reviewer: dvratil. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY The former was introduced with Qt 5.14 while the latter was deprecated with 5.15