D28455: add dbus interface to the greeter

bshah updated this revision to Diff 79013. bshah added a comment. - change signal name, notify caused confusion with notify of QObj REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28455?vs=78978=79013 BRANCH bshah/ksld-dbus-notify REVISION DETAIL

D28455: add dbus interface to the greeter

bshah created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY Currently this dbus interface allows the notification server to pass the notifications, which then are forwarded to greeter theme by

D28435: [System Tray] Update effective status on model insertion

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1d3b6e8f0a18: [System Tray] Update effective status on model insertion (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28454: [libnotificationmanager] forward notifications to lockscreen greeter

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Seems pretty simple and sensible. 1 minor fixup needed. INLINE COMMENTS > server_p.cpp:234 > +hints, notification.timeout()); > +

D28462: [KCM] Add color state probe to allow system settings to display current default state

broulik added a comment. You reckon we should do a simple base class that just does `settings->isDefaults()` since that will be quite a common thing? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28462 To: bport, #plasma, ervin, meven, crossi, hchain Cc:

D27669: [kstyle] Tools area

hpereiradacosta added a comment. Hi I don't think it is very satisfactory to say that the perforrmance hit it is "the apps fault" ... It is not there without the change, and with other widgets styles (or is it ? Did any one check, e.g. oxygen which is quite resource heavy because of

D28458: Bugfix ConverterRunner

alex created this revision. alex added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Skip empty parts when splitting the units(D27166: Refactor converter runner

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

davidedmundson added a comment. > @davidedmundson - is QIcon(QImage(...)) save? For the way it's used in the runner, yes. > Before this patch the icon was created in the BookmarkMatch::asQueryMatch method which was called from the secondary thread. Then my comment is happily

D28454: [libnotificationmanager] forward notifications to lockscreen greeter

bshah added inline comments. INLINE COMMENTS > davidedmundson wrote in server_p.cpp:234 > "This" will lack any context when someone is actually debugging this. "This" debug statement should be removed :P > davidedmundson wrote in server_p.cpp:245 > I assume you forgot to have an > >

D28454: [libnotificationmanager] forward notifications to lockscreen greeter

bshah updated this revision to Diff 78961. bshah marked 2 inline comments as done. bshah added a comment. - fix comments by David REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28454?vs=78951=78961 BRANCH bshah/greeter-notify REVISION DETAIL

D28455: add dbus interface to the greeter

bshah updated this revision to Diff 78968. bshah added a comment. - fixup comments mentioned by David REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28455?vs=78952=78968 BRANCH bshah/ksld-dbus-notify REVISION DETAIL

D28455: add dbus interface to the greeter

bshah planned changes to this revision. bshah added a comment. I need to add methods for the communicating the actions back to notification server. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28455 To: bshah Cc: davidedmundson, plasma-devel, Orage,

D28455: add dbus interface to the greeter

bshah added inline comments. INLINE COMMENTS > davidedmundson wrote in greeterapp.cpp:497 > This pattern of fetching and poking the root object of a scene isn't one I > like, it's better to expose an object to the view that then has normal > signals and slots - but this does follow the

D28462: [KCM] Add color state probe to allow system settings to display current default state

bport created this revision. bport added reviewers: Plasma, ervin, meven, crossi, hchain. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28462

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638514 , @ngraham wrote: > Same error about not being able to find the module. Sorry for not being clear. Does the specified path contain (`/home/nate/kde/usr/lib64/gtk-3.0/`) `modules` directory with

D26934: KCM/Autostart Add a model to separate logic from UI

meven added inline comments. INLINE COMMENTS > broulik wrote in autostartmodel.h:52 > Why define `DisplayRole` as dedicated enum entry, rather than just using > `Qt::DisplayRole` in the code everywhere I see, I meant my code to have all Roles used explicitly declared here rather than relying

D28428: [screenlocker] listen to notifications from the notification server

bshah abandoned this revision. bshah added a comment. Closed in favor of the more simpler version. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28428 To: bshah, davidedmundson Cc: davidedmundson, nicolasfella, plasma-devel, Orage, LeGast00n,

D28461: In sidebar mode show if a module is in default state or not

broulik added a comment. Please include screenshots when you do UI changes. INLINE COMMENTS > CategoriesPage.qml:207 > + > +width: 16 > +height: 16 `Kirigami.Units.iconSizes.small` and elsewhere Why do you need this wrapper `Item`, though?

D28455: add dbus interface to the greeter

davidedmundson added a comment. I'd say we go for the simplest solution +++ Given we have MPRIS on here, if we were to do any DBus lockdowns we would almost certainly want to use xdg-dbus-proxy, at which point this would continue to work. INLINE COMMENTS > greeterapp.cpp:139 > +

D28458: Bugfix ConverterRunner

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R114 Plasma Addons BRANCH converter_fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D28458 To: alex, broulik Cc: plasma-devel, Orage,

D28427: [libnotificationmanager] forward notifications to lockscreen

bshah added a subscriber: broulik. bshah added a comment. > +1 to using global and per-notification blacklists rather than a per-notification whitelist Plan is to change this in future, but for now to keep code simple I and @broulik agreed on this solution. (Also I am closing this

D28461: In sidebar mode show if a module is in default state or not

bport created this revision. bport added reviewers: Plasma, ervin, meven, crossi, hchain. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461

D28333: Add a new daemon for stats monitoring

davidedmundson updated this revision to Diff 78977. davidedmundson added a comment. Register bus name after loading plugins REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28333?vs=78658=78977 BRANCH master REVISION DETAIL

D27166: Refactor converter runner

broulik added a comment. I'm seeing another issue: everything with a slash is now interpreted as unit of volume, even just calculations: F8207700: Screenshot_20200331_091752.png REPOSITORY R114 Plasma Addons REVISION DETAIL

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov added a comment. I have no idea how to test code from **master** branch REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28458: Bugfix ConverterRunner

alex added a comment. I don't know why but I cant land this patch(`arc land --preview` looks fine) and the previous commits worked: `fatal: remote error: service not enabled: /kdeplasma-addons` I would be thankful if you could commit this. REPOSITORY R114 Plasma Addons BRANCH

D28455: add dbus interface to the greeter

bshah updated this revision to Diff 78978. bshah added a comment. - proper object instead of QMetaObject invokeMethod REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28455?vs=78968=78978 BRANCH bshah/ksld-dbus-notify REVISION DETAIL

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. In D28208#638846 , @davidre wrote: > Yes it's not pretty but I had no other Idea. One option would be trying to manually search for the icon in the path? Not a good idea, theme path only point to root of more

Re: [kde-announce] Plasma 5.18.4

Sorry all I didn't bump the version numbers in the source code. I'll re-roll the tars as 5.18.4.1 Jonathan On Tue, Mar 31, 2020 at 02:41:27PM +0100, Jonathan Riddell wrote: > Plasma 5.18.4 is now released https://www.kde.org/announcements/ > plasma-5.18.4.php

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.14 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.14/2/ Project: stable-kf5-qt5 SUSEQt5.14 Date of build: Tue, 31 Mar 2020 13:56:51 + Build duration: 11 min and counting CONSOLE OUTPUT

D28458: [runners/converter] Skip empty parts when splitting units

This revision was automatically updated to reflect the committed changes. Closed by commit R114:6e6c5707d406: [runners/converter] Skip empty parts when splitting units (authored by alex, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D27677: refactor: incorporate prior libkscreen EDID changes

romangg added a comment. Oh, I just noticed: Please absolutely add a commit message body to this commit on push! Just a single line explaining what you do is enough. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D27677 To: dvratil, #plasma,

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.14 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.14/2/ Project: stable-kf5-qt5 SUSEQt5.14 Date of build: Tue, 31 Mar 2020 13:51:35 + Build duration: 2 min 34 sec and counting CONSOLE OUTPUT

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham added a comment. You'll need to compile Plasma from git master, and then run your master-branch plasma session. There are instructions here: https://community.kde.org/Get_Involved/development#Plasma Feel free to ping me or anyone else in #plasma

D28465: [Categories Page] Use BasicListItem

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The delegate doesn't have its own appearance anymore, so just use the default one. TEST PLAN

D28458: [runners/converter] Skip empty parts when splitting units

ngraham added a comment. No problem. :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28458 To: alex, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf,

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov updated this revision to Diff 78992. epopov added a comment. Rebase on **master**, second edition. Can you try this patch? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28408?vs=78926=78992 REVISION DETAIL

D27675: feat: avoid duplicated text when assembling user-facing output names

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Sorry for late review. I didn't get notified by this bullshit platform (which might be because I disabled all notifications at one point to not get spammed constantly). INLINE COMMENTS

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.14/7/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 31 Mar 2020 13:54:19 + Build duration: 50 min and counting CONSOLE OUTPUT

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 78982. davidre added a comment. - Revert "Also handle IconThemePath" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78852=78982 BRANCH sni (branched from master) REVISION DETAIL

D28208: Move sni icon handling logic from data engine to applet

davidre added a comment. Yes it's not pretty but I had no other Idea. One option would be trying to manually search for the icon in the path? Or if all else fails for now use the old icon property in case `IconThemePath` is set. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 78985. ahiemstra added a comment. - Update zzag's last name REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=78372=78985 BRANCH sensors_lib REVISION DETAIL https://phabricator.kde.org/D28141

D28461: In sidebar mode show if a module is in default state or not

ndavis added a comment. This is merely an indicator and not a button, right? If so, you should not use `edit-reset` since you cannot actually reset the settings there. I'll try to come up with another indicator. I'm concerned that this indicator will make system settings visually messy.

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.14 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.14/4/ Project: stable-kf5-qt5 SUSEQt5.14 Date of build: Tue, 31 Mar 2020 13:54:20 + Build duration: 8 min 34 sec and counting CONSOLE OUTPUT

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. Goal of this feature is to improve user discoverability and allow them to find more easily which settings diverged from defaults one, so they can more easily revert to the default value when needed Indeed the current indicator is not the good one, and I will be happy

D10042: feat: parse EDID on the backend side

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. In D10042#629261 , @dvratil wrote: > Agreed. deviceId is not actually used (it's stored in KDED config files, but the value doesn't seem to

D27669: [kstyle] Tools area

davidre added a comment. Hi, I made a comparison video performing the same task with oxygen, current breeze, this patch with the option enabled and disabled (in order of appearance). The task is opening kdevelop, opening the same two files, switching between them and then closing the files

D28465: [Categories Page] Use BasicListItem

broulik added a comment. > Tablet mode spacing should just be added into BasicListItem itself Agreed. I was surprised it didn't actually come from it but was done here explicitly REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28465 To: broulik,

D28222: Add ShadowedImage and ShadowedTexture items

This revision was automatically updated to reflect the committed changes. Closed by commit R169:0c7ba88d3970: Add ShadowedImage and ShadowedTexture items (authored by ahiemstra). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28222?vs=78294=78987#toc REPOSITORY R169 Kirigami CHANGES

D28465: [Categories Page] Use BasicListItem

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice! Tablet mode spacing should just be added into BasicListItem itself, if it doesn't already have it. REPOSITORY R124 System Settings REVISION DETAIL

D28461: In sidebar mode show if a module is in default state or not

filipf added a comment. Can you explain why we want this? It's going to be visually prominent so we need a good reason. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg Cc: filipf,

D28461: In sidebar mode show if a module is in default state or not

The-Feren-OS-Dev added a comment. IMHO this is wholly pointless a change, currently. Most people won't care about if they've made changes or not in SySe from the defaults, and quite frankly seeing that indicator on the sidebar would potentially even deter user customisation if not utterly

D28420: [Image Wallpaper] Fix thumbnail generation when model is reloaded in-flight

This revision was automatically updated to reflect the committed changes. Closed by commit R120:492301406a46: [Image Wallpaper] Fix thumbnail generation when model is reloaded in-flight (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Plasma 5.18.4

Plasma 5.18.4 is now released https://www.kde.org/announcements/plasma-5.18.4.php

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.14 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.14/2/ Project: stable-kf5-qt5 SUSEQt5.14 Date of build: Tue, 31 Mar 2020 13:57:01 + Build duration: 12 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.14 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.14/2/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 31 Mar 2020 13:51:35 + Build duration: 20 min and counting CONSOLE OUTPUT

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. F8208462: image.png Test with a blue dot, took less space than an icon Wa can imagine a tooltip when you go hover the dot explaining it REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461

Re: Plasma 5.18.4

The tars have now been re-rolled and named 5.18.4.1 available in the same place. Jonathan On Tue, Mar 31, 2020 at 01:49:26PM +, Jonathan Riddell wrote: > > Sorry all I didn't bump the version numbers in the source code. I'll re-roll > the tars as 5.18.4.1 > > Jonathan > > > On Tue,

D28461: In sidebar mode show if a module is in default state or not

abetts added a comment. If I am understanding correctly, this patch adds icons in the kcm list to indicate changes you can revert by going to the kcm. Basically, default settings have changed and now you have the possibility to see that changes have been made. I am not sure that I like the

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham added a comment. Screenshots in the Test Plan section are always appreciated :) REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D28467 To: niccolove, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added a comment. In D28467#639027 , @ngraham wrote: > Screenshots in the Test Plan section are always appreciated :) True, sorry. Added REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D28467 To:

D28461: In sidebar mode show if a module is in default state or not

ndavis added a comment. maybe it would make more sense to add a different way to view non-default settings? like maybe a summary of custom settings. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg

D28467: Converted to Page with a PlasmodHeading in the heading

niccolove updated this revision to Diff 78999. niccolove added a comment. I said components 3 REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=78998=78999 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED FILES

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

This revision was automatically updated to reflect the committed changes. Closed by commit R120:175424169d18: [applets/clipboard]: Fix applet closing itself when clicking on a history item… (authored by epopov, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28467: Converted to Page with a PlasmodHeading in the heading

niccolove updated this revision to Diff 78996. niccolove added a comment. Remove unrelated changes REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=78995=78996 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED FILES

D28467: Converted to Page with a PlasmodHeading in the heading

niccolove updated this revision to Diff 78997. niccolove added a comment. remove unrelated changes pt2 REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=78996=78997 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED

D28467: Converted to Page with a PlasmodHeading in the heading

niccolove added a comment. I'm a bit confused by import org.kde.plasma.components 2.0 as PlasmaComponents import org.kde.plasma.components 3.0 as PlasmaComponents3 is it correct? REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D28467 To: niccolove,

D28467: Converted to Page with a PlasmodHeading in the heading

niccolove updated this revision to Diff 79000. niccolove added a comment. Import components3 separately REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=78999=79000 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED

D28461: In sidebar mode show if a module is in default state or not

ngraham added a comment. I get a compile error: /home/nate/kde/src/systemsettings/core/MenuItem.cpp: In member function ‘void MenuItem::updateDefault()’: /home/nate/kde/src/systemsettings/core/MenuItem.cpp:154:36: error: ‘isDefaults’ is not a member of ‘KCModuleLoader’ 154 |

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. Works perfectly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc: davidedmundson, plasma-devel, Orage,

D28467: Converted to Page with a PlasmodHeading in the heading

niccolove updated this revision to Diff 78998. niccolove added a comment. unrelated pt3 REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=78997=78998 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED FILES

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham added a comment. In D28467#638980 , @niccolove wrote: > I'm a bit confused by > > import org.kde.plasma.components 2.0 as PlasmaComponents > import org.kde.plasma.components 3.0 as PlasmaComponents3 > > > is it correct?

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. In D28461#639016 , @abetts wrote: > If I am understanding correctly, this patch adds icons in the kcm list to indicate changes you can revert by going to the kcm. Basically, default settings have changed and now you have

KDE CI: Plasma » powerdevil » stable-kf5-qt5 FreeBSDQt5.14 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20FreeBSDQt5.14/3/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 31 Mar 2020 13:56:54 + Build duration: 56 min and counting CONSOLE OUTPUT

D28467: Converted to Page with a PlasmodHeading in the heading

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY Now the main view is a Page, the toolbar is moved to the heading and it's contained in a PlasmoidHeading REPOSITORY R97

D28468: Add property initializer support to PagePool

masonm created this revision. masonm added reviewers: Kirigami, mart. Herald added a project: Kirigami. masonm requested review of this revision. REVISION SUMMARY Currently PagePool allows pages to be pushed onto the stack but there is no way to pass initialization properties to the

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex added a comment. In D28057#639054 , @ngraham wrote: > Sorry for the delay, I will resume reviewing this soon. No worries :) Thank you for your support ! REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27669: [kstyle] Tools area

cblack updated this revision to Diff 79006. cblack added a comment. More optimization REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78928=79006 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D28461: In sidebar mode show if a module is in default state or not

ngraham added a comment. Is D28460 the only other patch that's needed? I applied that and then this patch compiled fine, but I don't see any difference in the sidebar, despite having changed some settings from their default values. REPOSITORY R124

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. In D28461#639056 , @ngraham wrote: > Is D28460 the only other patch that's needed? I applied that and then this patch compiled fine, but I don't see any difference in the sidebar,

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. In D28461#639022 , @ngraham wrote: > I get a compile error: > > /home/nate/kde/src/systemsettings/core/MenuItem.cpp: In member function ‘void MenuItem::updateDefault()’: >

D28057: Fix/Allow folderview popup mode icon and list icon size

ngraham added a comment. Sorry for the delay, I will resume reviewing this soon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28057 To: pereira.alex, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27669: [kstyle] Tools area

cblack updated this revision to Diff 79010. cblack added a comment. More optimization REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=79006=79010 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Make sure you test how this looks in the System Tray too, and not just as a standalone applet. ;) INLINE COMMENTS > FullRepresentation.qml:31 > > -

D27669: [kstyle] Tools area

ngraham added a comment. Thanks, that helps a lot. It still feels a little bit slower than before, but it's at least much improved. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre Cc: maartens,