D28799: Refactor and fix the mobile wifi kcm

2020-04-14 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > NetworkSettings.qml:27 > SimpleKCM { > +id: networkSettings > property var path not needed > wifisettings.cpp:65 > > +if(type == "secrets") > +return >

D28799: Refactor and fix the mobile wifi kcm

2020-04-14 Thread Tobias Fella
tfella updated this revision to Diff 80143. tfella marked an inline comment as done. tfella added a comment. More fixes REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28799?vs=80076=80143 BRANCH mobileWifiFix (branched from

D28744: Rewrite of the global shortcuts kcm

2020-04-14 Thread David Redondo
davidre updated this revision to Diff 80137. davidre marked 3 inline comments as done. davidre added a comment. - Use QCollator and one more coding style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80136=80137 BRANCH kcmkeys2

D28744: Rewrite of the global shortcuts kcm

2020-04-14 Thread David Redondo
davidre updated this revision to Diff 80135. davidre added a comment. - redo exportActive and exportWarning bindings REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80088=80135 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D28678: adjust smb kcm size to be sufficient vis a vis headers

2020-04-14 Thread Nathaniel Graham
ngraham added a comment. In D28678#648072 , @mart wrote: > I think I'll take a look into that (i mean, replacing kcmshell with systemsettings) <3 <3 <3 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D28678

D28830: Don't set a custom palette if we have the same palette as the currently active one

2020-04-14 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This fixes that weird icon coloration issue I was having in Dolphin that I had just started to investigate. :) REPOSITORY R31 Breeze BRANCH ffs (branched from master) REVISION

D28744: Rewrite of the global shortcuts kcm

2020-04-14 Thread David Redondo
davidre updated this revision to Diff 80136. davidre marked an inline comment as done. davidre added a comment. - Set transient window for application dialog REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80135=80136 BRANCH kcmkeys2

<    1   2