D29594: Close low battery notificaton when showing critical

2020-05-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When not acknowledging the low battery notification, close it when showing the critical one, to

D29571: [Kickoff] Add emacs/bash style keybindings

2020-05-10 Thread David Edmundson
davidedmundson added a comment. > Does the mechanism of standard shortcuts really apply here? It's not implementing it yet, but that's the entire point. The bigger problem is someone added some vim shortcuts to krunner a year ago: (plasma-workspace

D29601: Port KRun::runApplication to ApplicationLauncherJob

2020-05-10 Thread David Faure
dfaure created this revision. dfaure added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. TEST PLAN Builds REPOSITORY R856 Plasma Browser Integration BRANCH master REVISION DETAIL

D29601: Port KRun::runApplication to ApplicationLauncherJob

2020-05-10 Thread David Faure
dfaure closed this revision. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D29601 To: dfaure, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D29579: [kcms/keys] Really ignore unknown action

2020-05-10 Thread David Redondo
davidre created this revision. davidre added reviewers: ngraham, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Otherwise the end() iterator is dereferenced resulting in a crash BUG: 421016 TEST

D29570: Fix some alignments

2020-05-10 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > PowerManagementItem.qml:34 > Layout.fillWidth: true > +Layout.leftMargin: units.smallSpacing > How does this affect RTL layouts? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29570 To:

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

2020-05-10 Thread Noah Davis
ndavis added a comment. I agree with the size chosen if we are doing a vertical panel, but I can't think of any way to justify this change in a way that I find satisfactory. There's no clear improvement over using a horizontal panel, just tradeoffs. REPOSITORY R119 Plasma Desktop

D29580: [kcms/keys] Also consider portable text when filtering

2020-05-10 Thread David Redondo
davidre created this revision. davidre added reviewers: broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Enables searching for "ctrl" or "shift" in non english locale REPOSITORY R119 Plasma

D29125: lookandfeel kcm: port from KRun::runApplication to KIO::ApplicationLauncherJob

2020-05-10 Thread David Faure
dfaure closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29125 To: dfaure, broulik, ngraham, crossi, mart, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29125: lookandfeel kcm: port from KRun::runApplication to KIO::ApplicationLauncherJob

2020-05-10 Thread David Faure
dfaure added a comment. ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29125 To: dfaure, broulik, ngraham, crossi, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29595: Add gocryptfs support

2020-05-10 Thread Martino Pilia
mpilia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mpilia requested review of this revision. REVISION SUMMARY Implement basic support for gocryptfs backend. BUG: 398323 REPOSITORY R845 Plasma Vault BRANCH add-gocryptfs-support

D29603: Adds custom spacing between task manager icons

2020-05-10 Thread Jacopo Martellini
martellini created this revision. martellini added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. martellini requested review of this revision. REVISION SUMMARY Adds the option to set a custom spacing between the icons of the icons-only task manager.

Re: kwallet-pam >= 5.18.4 and ecryptfs homes

2020-05-10 Thread Albert Astals Cid
P.S: Remember to CC me El dilluns, 4 de maig de 2020, a les 21:11:22 CEST, Nate Graham va escriure: > On 5/3/20 4:02 PM, Albert Astals Cid wrote:> Problem with SOLUTION 1 is > that it adds lots of code in a relative "sensitive" piece of code like a > pam module for for what it is a one time

D27576: Kill Runner: Move config keys to new file

2020-05-10 Thread Alexander Lohnau
This revision was automatically updated to reflect the committed changes. Closed by commit R120:63deb6a0125b: Kill Runner: Move config keys to new file (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27576?vs=79224=82462 REVISION

D27576: Kill Runner: Move config keys to new file

2020-05-10 Thread Méven Car
meven accepted this revision. meven added a comment. In D27576#659971 , @alex wrote: > @meven and others, may I ship this? Yep ship it, it is low risk. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D27576_1 REVISION DETAIL

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

2020-05-10 Thread Jiří Paleček
jpalecek created this revision. jpalecek added reviewers: davidedmundson, ahiemstra. Herald added a project: Plasma. jpalecek requested review of this revision. REVISION SUMMARY When some SensorClients are destroyed, eg. when KSysguard is closed, they fail to deregister themselves from

D29615: Nice all threads of multithreaded programs

2020-05-10 Thread Jiří Paleček
jpalecek created this revision. jpalecek added reviewers: ahiemstra, davidedmundson. Herald added a project: Plasma. jpalecek requested review of this revision. REVISION SUMMARY Setting process priorities by ksysguard has the flaw that it only sets priority of a single thread of a

D28509: [libnotificationmanager] introduce the WatchedNotificationsModel

2020-05-10 Thread Bhushan Shah
bshah updated this revision to Diff 82489. bshah added a comment. rebase on master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28509?vs=80990=82489 BRANCH bshah/notification-watcher REVISION DETAIL https://phabricator.kde.org/D28509

D29617: Renice all threads of a multithreaded process

2020-05-10 Thread Jiří Paleček
jpalecek created this revision. jpalecek added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. jpalecek requested review of this revision. REVISION SUMMARY This is a mirror of D29615 implemented in libksysguard for local processes. All

D28509: [libnotificationmanager] introduce the WatchedNotificationsModel

2020-05-10 Thread Bhushan Shah
This revision was automatically updated to reflect the committed changes. Closed by commit R120:2357e6f2e134: [libnotificationmanager] introduce the WatchedNotificationsModel (authored by bshah). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23704: Allow tmpfs in ksysguard disk space monitor

2020-05-10 Thread Jiří Paleček
jpalecek added a comment. @davidedmundson Can you please have a look at this? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D23704 To: jpalecek, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D23592: ksysguard: handle multiple mounts to the same mountpoint gracefully

2020-05-10 Thread Jiří Paleček
jpalecek added a comment. Could this be committed please? REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabricator.kde.org/D23592 To: jpalecek, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D29618: Fix case fallback warning

2020-05-10 Thread Jiří Paleček
jpalecek created this revision. jpalecek added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. jpalecek requested review of this revision. REVISION SUMMARY Courtesy of gcc warnings: in decoding of the "ps" reply, the answer would be wrongly used as free memory as well due

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

2020-05-10 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > SensorBrowser.cpp:53 > +} > qDeleteAll( mHostInfoMap ); > mHostInfoMap.clear(); When you delete the map content, all agents should loose their connections, no? REPOSITORY R106 KSysguard REVISION DETAIL