D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

epopov created this revision. epopov added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. epopov requested review of this revision. REVISION SUMMARY In D29652 , I made an annoying mistake: I removed the check if

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

mart added a comment. the length of that button text is quite daunting, i fear imagining how would be in geman :p REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29798 To: ngraham, #vdg, #plasma Cc: mart, niccolove, plasma-devel, Orage, LeGast00n,

D29796: Fix "Implicitly defined onFoo" deprecation warnings

hexchain abandoned this revision. hexchain added a comment. Oh sorry, I shouldn't have submitted this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29796 To: hexchain Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. looks good REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29462 To: Zren, #kirigami, mart Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol,

D29264: New tabs for Breeze

bcooksley added a comment. Please note that should you have a KDE Developer account, then you can use a work branch instead of forking the repository. For more information on these please see my email to kde-devel and kde-cvs-announce. REPOSITORY R31 Breeze REVISION DETAIL

D29796: Fix "Implicitly defined onFoo" deprecation warnings

mart added a comment. this needs dependency upon Qt 5.15, right? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29796 To: hexchain Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,

D29819: Using background rectangle in icon text when in software rendering

brunogoncalves created this revision. brunogoncalves added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. brunogoncalves requested review of this revision. REVISION SUMMARY Up to plasma 5.5 the icons on the desktop used a background

D29820: Correction when displaying "badger counter" icons using software rendering

brunogoncalves created this revision. brunogoncalves added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. brunogoncalves requested review of this revision. REVISION SUMMARY Icons that use content overlay, leave the icon hidden when using software

D29799: [kcms/notifications] Port "no search result" message to PlaceholderMessage

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29799 To: ngraham, #vdg, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D29716: [applet] Show KCM in System Settings

ngraham closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D29716 To: ngraham, jgrulich, mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29714: [applets] Show KCMs in System Settings

ngraham closed this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29714 To: ngraham, mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D29713: [applets] Show KCMs in System Settings

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29713 To: ngraham, mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D29712: [applets] Show KCMs in System Settings or Info Center, as appropriate

ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29712 To: ngraham, mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

ngraham added a comment. In D29798#672886 , @mart wrote: > the length of that button text is quite daunting, i fear imagining how would be in geman :p Indeed, and Brazilian Portuguese, and probably many others too. What are your

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

ngraham added a comment. In D29818#672947 , @epopov wrote: > In D29818#672942 , @ngraham wrote: > > > was landed on master, not 5.19 > > > Can it be moved to Plasma 5.19? Rut the

D29438: Use font: instead of font.pointSize: where possible

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29438 To: ngraham, cblack, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D29437: Use font: instead of font.pointSize: where possible

ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29437 To: ngraham, cblack, #plasma Cc: ahiemstra, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29081: [QStyle] Make menu titles look less like menu items

ngraham updated this revision to Diff 83066. ngraham added a comment. Compute background color in a more colorscheme-friendly way REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29081?vs=83065=83066 BRANCH menu-title-looks-less-like-a-menu-item (branched

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

ngraham added a comment. Oh you mean both of them. Yeah, seems reasonable. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D29081: [QStyle] Make menu titles look less like menu items

ngraham updated this revision to Diff 83064. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29081?vs=80924=83064 BRANCH menu-title-looks-less-like-a-menu-item (branched from master) REVISION DETAIL

D29820: Correction when displaying "badger counter" icons using software rendering

ngraham added a comment. We have moved to GitLab now; could you submit this as a Merge Request at https://invent.kde.org/plasma/plasma-desktop/-/merge_requests? Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29820 To: brunogoncalves, ngraham

Re: Gitlab workboards

On 5/18/20 11:05 PM, Bhushan Shah wrote: For Gitlab best way to filter/track anything is labels and existing states like, open/closed So one way to for instance list all VDG issues and merge requests would be,

Re: Gitlab workboards

If we use Issues in each individual project for tasks, wouldn't this complicate eventually migrating from Bugzilla to GitLab issues, since it would intermingle the user bug reporting function with developer task tracking and communication? Nate On 5/18/20 10:59 PM, Bhushan Shah wrote: On

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

epopov added a comment. Right, but they can be cherry-picked the the **Plasma 5.19**. In truth, I'm tired of editing these files after every Plasma update☹️ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel,

D29819: Using background rectangle in icon text when in software rendering

meven added a comment. This can be closed : https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29819 To: brunogoncalves, #plasma, ngraham Cc: meven, plasma-devel, Orage, LeGast00n,

D29819: Using background rectangle in icon text when in software rendering

ngraham added a comment. We have moved to GitLab now; could you submit this as a Merge Request at https://invent.kde.org/plasma/plasma-desktop/-/merge_requests? Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29819 To: brunogoncalves, #plasma,

D24721: Show backend name and version in app delegates

ngraham added a comment. Ping! This is an important thing to have overall; could you please submit it as a Merge Request at https://invent.kde.org/plasma/discover/-/merge_requests? Thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24721

D29081: [QStyle] Make menu titles look less like menu items

ngraham updated this revision to Diff 83065. ngraham added a comment. Fix non-rounded corners REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29081?vs=83064=83065 BRANCH menu-title-looks-less-like-a-menu-item (branched from master) REVISION DETAIL

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

epopov added a comment. Ohhh, okay, thanks anyway REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

ngraham accepted this revision. ngraham added a comment. Oops, sorry for not catching that. D29652 was landed on master, not 5.19, so it's not urgent. Thanks. Note that we have migrated to GitLab; would you mind submitting future patches as Merge

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

epopov added a comment. In D29818#672942 , @ngraham wrote: > was landed on master, not 5.19 Can it be moved to Plasma 5.19? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

ngraham added a comment. Ah, it doesn't cherry-pick cleanly. You'll have to wait for 5.20, sorry. This is a good incentive to start living on git master. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel,

D20569: RFC: Use more compact OSD

ngraham commandeered this revision. ngraham added a reviewer: broulik. ngraham added a comment. Yoink. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: ngraham, #plasma, #vdg, broulik Cc: kori, Armstrong, alexde, achauvel, abetts, ngraham,

D29333: Don't show an empty error dialog when canceling the sync password prompt

ngraham abandoned this revision. ngraham added a comment. Looked into it and concluded that PolKit/Kauth are... special. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D29333 To: ngraham, filipf, davidedmundson, #plasma Cc: broulik, mthw,

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

ndavis abandoned this revision. ndavis added a comment. Resuming this on invent REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29439 To: ndavis, #vdg Cc: GB_2, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D29465: [applets/appmenu] Improve menu feel

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Clever with the `hoverEnabled`, I had to think twice to understand it, though :p REPOSITORY R120 Plasma Workspace BRANCH cblack/appmenu-better-menu-behaviour (branched from master)

D20569: Use more compact OSD

ndavis accepted this revision. ndavis added a comment. I have no problem with this. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D20569_2 REVISION DETAIL https://phabricator.kde.org/D20569 To: ngraham, #plasma, #vdg, broulik, niccolove, ndavis Cc: ndavis, kori, Armstrong, alexde,

D26881: [Applets/Folder View] Allow using a folder that ends with a space

ngraham abandoned this revision. ngraham added a comment. What a silly little patch this was. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26881 To: ngraham, hein, #plasma Cc: anthonyfieroni, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D20569: Use more compact OSD

ngraham added a comment. I would like to formally re-submit this for consideration. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: ngraham, #plasma, #vdg, broulik Cc: kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein,

D20569: Use more compact OSD

ngraham updated this revision to Diff 83067. ngraham edited the test plan for this revision. ngraham added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20569?vs=56281=83067 BRANCH arcpatch-D20569_2 REVISION DETAIL

D27874: Disable the audio stream indicator for IOTM by default

ndavis abandoned this revision. ndavis added a comment. Abandoning this since nobody wanted it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27874 To: ndavis, #vdg, #plasma Cc: gvgeo, ngraham, broulik, cblack, plasma-devel, Orage, LeGast00n,

D24706: [RFC] Change button style

ndavis abandoned this revision. ndavis added a comment. Resuming this on invent REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: mart, ahiemstra, cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, dmenig,

D20569: Use more compact OSD

ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: ngraham, #plasma, #vdg, broulik, niccolove, ndavis Cc: ndavis, kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, Codezela, filipf, zzag,

D29081: [QStyle] Make menu titles look less like menu items

ngraham closed this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen,

D28154: Add users KCM

cblack updated this revision to Diff 83079. cblack added a comment. Focus the stackSwitcher when opening the sheet REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=83074=83079 BRANCH arcpatch-D28154_1 REVISION DETAIL

D29395: Refactor MediaController

cblack updated this revision to Diff 83073. cblack marked 8 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29395?vs=81831=83073 BRANCH arcpatch-D29395 REVISION DETAIL

D28154: Add users KCM

cblack updated this revision to Diff 83074. cblack marked 17 inline comments as done. cblack added a comment. Address code concerns; add escape keyboard gesture REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82214=83074 BRANCH

D27669: [kstyle] Tools area

cblack updated this revision to Diff 83075. cblack added a comment. Properly determine if tools area should be drawn on QDialogs with auto set REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=81137=83075 BRANCH arcpatch-D27669_2 REVISION DETAIL

D29464: [applets/appmenu] Hide old menu before showing new menu

broulik added a comment. That focus loss flickering was fixed at some point iirc. I'll try the patch tomororw but lgtm REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29464 To: cblack, #plasma, #kwin Cc: broulik, plasma-devel, Orage, LeGast00n,

D29465: [applets/appmenu] Improve menu feel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf337f552a02: [applets/appmenu] Improve menu feel (authored by cblack). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29465?vs=82043=83069 REVISION

D29395: Refactor MediaController

cblack added inline comments. INLINE COMMENTS > broulik wrote in ExpandedRepresentation.qml:99 > Unrelated cleanup a cleanup is unrelated in a cleanup patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29395 To: cblack, #plasma Cc: broulik, trmdi,

D27669: [kstyle] Tools area

ngraham added a comment. I think this should land early in the 5.20 cycle so we have a lot of time for testing. However I think we need to land it alongside the new colorscheme so people don't get a bad first impression, or else re-work it to pull the color from a new "toolsarea" color set

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham abandoned this revision. ngraham added a comment. Moved to Invent: https://invent.kde.org/plasma/breeze/-/merge_requests/3 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: cblack, ndavis, niccolove, The-Feren-OS-Dev,

D28154: Add users KCM

ngraham added a comment. The avatar sheet still does not close with Esc. :/ REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D28154_1 REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: ltoscano, mart, yurchor, iasensio, meven, crossi,

D28154: Add users KCM

ngraham added a comment. Great, that works! BTW I think you can change the KCM name to `kcm_users` as you originally wanted. Sorry for saying otherwise. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D28154_1 REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack,

D27669: [kstyle] Tools area

ndavis added a comment. The line seems to stop just short of the sidebar: F8339738: Screenshot_20200520_001106.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta,

D27669: [kstyle] Tools area

ngraham added a comment. Now disabled toolbar items don't use the disabled text color when disabled. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham Cc: mart, maartens, abstractdevelop,

D27669: [kstyle] Tools area

ndavis added a comment. what are some ways the issue of toolbar colors not being perfectly in sync with titlebar colors could be fixed or worked around? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta,