D27034: Fix message box when passing a remote url that includes a file

sandsmark added a comment. This is wrong, isn't it? The logic was: if setDirectory is passed something that _isn't_ a directory, try to strip the filename. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27034 To: apol,

D29847: Fixes compile problem for freebsd because of missing crypt.h

usta added a comment. Sorry i have written one of them twice , so is this aproach wrong ? #if !defined(Q_OS_UNIX) && !defined(Q_OS_BSD4) && !defined(Q_OS_FREEBSD) && !defined(Q_OS_NETBSD) && !defined(Q_OS_OPENBSD) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D29847: Fixes compile problem for freebsd because of missing crypt.h

usta added a comment. or if this is just for linux think we can make it just directly if defined(Q_OS_LINUX) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29847 To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd Cc: tcberner, adridg, plasma-devel,

D29847: Fixes compile problem for freebsd because of missing crypt.h

usta updated this revision to Diff 83237. usta added a project: FreeBSD. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29847?vs=83235=83237 REVISION DETAIL https://phabricator.kde.org/D29847 AFFECTED FILES kcms/users/src/user.cpp To: usta,

D29847: Fixes compile problem for freebsd because of missing crypt.h

adridg added a comment. https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes There's already a CMake-time check for ``, it's just not used. (`HAVE_CRYPT_H`) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29847 To: usta, #plasma,

D28881: [Applet] Fix connecting with a password

broulik added inline comments. INLINE COMMENTS > ConnectionItem.qml:234 > +} else if (connectionItem.customExpandedViewContent == > passwordDialogComponent) { > +if (passwordDialogComponent.password != "") { > +

D29847: Fixes compile problem for freebsd because of missing crypt.h

usta added a comment. In D29847#674807 , @adridg wrote: > https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes > > There's already a CMake-time check for ``, it's just not used. (`HAVE_CRYPT_H`) @adridg having or

D27129: [Notifications] Allow expiring an entire group

broulik added a comment. Should we go with this now? I haven't seen it crash on me since I fixed the `checkIndex` thing REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27129 To: broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27129: [Notifications] Allow expiring an entire group

meven accepted this revision as: meven. meven added a comment. This revision is now accepted and ready to land. Seems fine to me REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27129 To: broulik, #plasma, meven Cc: meven, plasma-devel, Orage, LeGast00n,

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 130 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/130/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 07 Jun 2020 15:15:15 + Build duration: 3 min 1 sec and counting CONSOLE OUTPUT

D29847: Fixes compile problem for freebsd because of missing crypt.h

tcberner added inline comments. INLINE COMMENTS > user.cpp:23 > #include > +#ifndef Q_OS_FREEBSD > #include wouldn't it be a bit more portable to check for the header file in cmake? (OpenBSD also has the same issue, I would assume from [1]) [1]

D29847: Fixes compile problem for freebsd because of missing crypt.h

usta added inline comments. INLINE COMMENTS > tcberner wrote in user.cpp:23 > wouldn't it be a bit more portable to check for the header file in cmake? > (OpenBSD also has the same issue, I would assume from [1]) > > [1] >