FrameSvg corruption [a bit urgent]

2009-01-15 Thread Ivan Čukić
Hi guys, I have a problem affecting both 4.2 branch and the trunk. I'm getting corrupted painting of FrameSvgs in Lancelot and have absolutely no idea why. I became aware of the problem thanks to the forum post [1] and the screenshot [2]. It all worked well for me until I cleared the

Re: [PATCH] fixing krazy2 issues in dataengines

2009-01-15 Thread Artur Souza (MoRpHeUz)
Hey 2009/1/15 Philipp Klaffert pklaff...@googlemail.com: license and copyright issues and you can find the patch in the attachement of this Mail. I think you forgot to attach the patch hehe =) Cheers -- --- Artur Duque de Souza OpenBossa

[PATCH] fixing krazy2 issues in dataengines

2009-01-15 Thread Philipp Klaffert
Hi, according to the Kourse on kde.org [1] I fixed some of the issues in kdeplasma-addons/dataengines found on EBN. The only issues left are the license and copyright issues and you can find the patch in the attachement of this Mail. Regards Philipp Klaffert [1]

RE: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Philipp Klaffert
Hey 2009/1/15 Philipp Klaffert pklaffert at googlemail.com https://mail.kde.org/mailman/listinfo/plasma-devel: * license and copyright issues and you can find the patch in the attachement ** of this Mail. * I think you forgot to attach the patch hehe =) Cheers and I think you are right...

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Dominik Haumann
Hi Philipp, On Thursday 15 January 2009, Philipp Klaffert wrote: @@ -54,7 +53,7 @@ return true; } -if (!name.startsWith(Timeline:) !name.startsWith(TimelineWithFriends:) !name.startsWith(Profile:)) { +if (!name.startsWith(QString(Timeline:))

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Philipp Klaffert
Hi Dominik, thanks for your reply and for the link. For fixing the krazy2 issues correctly I changed QString to QLatin1String. I understand your point of view with readability but I won't decide which way is better. I think the explicit conversion of these Strings makes the understanding of the

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Ivan Čukić
More strange things. I've added a couple of debug lines to framesvg.cpp, and I'm receiving this in setElementPrefix: First call of setElementPrefix on the same FrameSvg object: ### setElementPrefix: /opt/kde4trunk/kde/share/apps/desktoptheme/slim- glow/lancelot/section-buttons.svgz prefix:

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Aaron J. Seigo
On Thursday 15 January 2009, Philipp Klaffert wrote: thanks for your reply and for the link. For fixing the krazy2 issues correctly I changed QString to QLatin1String. I understand your point of view with readability but I won't decide which way is better. I think the explicit conversion of

Tokamak Meeting II

2009-01-15 Thread Nuno Pinheiro
hey everybody IM planing the tokamak meeting details. So I need some infos from everyone coming to the meeting... So We can produce a schedule for the days we will be there, sort out all details for credentials and stuf. fristly confirmation for the people coming. Secondly I asked several

Re: Tokamak Meeting II

2009-01-15 Thread Aaron J. Seigo
On Thursday 15 January 2009, Nuno Pinheiro wrote: fristly confirmation for the people coming. shockingly, i'll be there ;) Secondly I asked several people already to prepare a litle presentation to give on the 6. (can be about anything as long as its plasma related, i think a small

Re: Plasma Applet Direction

2009-01-15 Thread Jud Craft
we (plasma team) don't actually control that =) There really does need to be a pervasive integration of all aspects of the user-experience with plasma. Get Hot New Stuff is an interesting compromise, but at the moment it seems a strange klutch, which stands in the way of implementing a much more

Re: Tokamak Meeting II

2009-01-15 Thread Nuno Pinheiro
A Thursday 15 January 2009 17:07:26, Aaron J. Seigo escreveu: On Thursday 15 January 2009, Nuno Pinheiro wrote: fristly confirmation for the people coming. shockingly, i'll be there ;) Secondly I asked several people already to prepare a litle presentation to give on the 6. (can be

Re: Plasma Applet Direction

2009-01-15 Thread Aaron J. Seigo
On Thursday 15 January 2009, Jud Craft wrote: we (plasma team) don't actually control that =) There really does need to be a pervasive integration of all aspects of the user-experience with plasma. Get Hot New Stuff is an interesting compromise, but at the moment it seems a strange klutch,

Re: My progress

2009-01-15 Thread Marco Martin
On Wednesday 14 January 2009, Aaron J. Seigo wrote: On Wednesday 14 January 2009, Marco Martin wrote: On Wednesday 14 January 2009, Aaron J. Seigo wrote: On Wednesday 14 January 2009, Marco Martin wrote: On Tuesday 13 January 2009, Aaron J. Seigo wrote: this would probably mean

Re: Tokamak Meeting II

2009-01-15 Thread Marco Martin
On Thursday 15 January 2009, Nuno Pinheiro wrote: hey everybody IM planing the tokamak meeting details. So I need some infos from everyone coming to the meeting... So We can produce a schedule for the days we will be there, sort out all details for credentials and stuf. fristly

Re: Plasma Applet Direction

2009-01-15 Thread Jud Craft
I do really like the platform-independence and compilation-free packages! I had neglected those; that's awesome, so the picture is much less depressing than my post says. Plasma themes themselves are also independent, correct? (Assumption based on hearing efforts to port Plasma to Windows).

Re: Tokamak Meeting II

2009-01-15 Thread Anne-Marie Mahfouf
Le jeudi 15 janvier 2009 17:47:30, Nuno Pinheiro a écrit : hey everybody IM planing the tokamak meeting details. So I need some infos from everyone coming to the meeting... So We can produce a schedule for the days we will be there, sort out all details for credentials and stuf. fristly

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Marco Martin
On Thursday 15 January 2009, Ivan Čukić wrote: More strange things. I've added a couple of debug lines to framesvg.cpp, and I'm receiving this in setElementPrefix: First call of setElementPrefix on the same FrameSvg object: ### setElementPrefix:

Re: Tokamak Meeting II

2009-01-15 Thread Artur Souza(MoRpHeUz)
On Thursday 15 January 2009 17:03:26 Anne-Marie Mahfouf wrote: fristly confirmation for the people coming. I'm all in =P Kévin (ervin) and me will be arriving at 9:05 am at OPO the 6th. What time are these presentations scheduled ? How long do we need to get from the airport to the

Re: Tokamak Meeting II

2009-01-15 Thread Nuno Pinheiro
A Thursday 15 January 2009 20:03:26, Anne-Marie Mahfouf escreveu: Le jeudi 15 janvier 2009 17:47:30, Nuno Pinheiro a écrit : hey everybody IM planing the tokamak meeting details. So I need some infos from everyone coming to the meeting... So We can produce a schedule for the days we

Re: Tokamak Meeting II

2009-01-15 Thread Nuno Pinheiro
A Thursday 15 January 2009 19:25:29, Artur Souza(MoRpHeUz) escreveu: On Thursday 15 January 2009 17:03:26 Anne-Marie Mahfouf wrote: fristly confirmation for the people coming. I'm all in =P Kévin (ervin) and me will be arriving at 9:05 am at OPO the 6th. What time are these

Review Request: a messagebox for applets

2009-01-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/327/ --- Review request for Plasma. Summary --- this adds

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Philipp Klaffert
Am 15. Januar 2009 17:39 schrieb Aaron J. Seigo ase...@kde.org: On Thursday 15 January 2009, Philipp Klaffert wrote: thanks for your reply and for the link. For fixing the krazy2 issues correctly I changed QString to QLatin1String. I understand your point of view with readability but I

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Ivan Čukić
The line bool found = Theme::defaultTheme()-findInRectsCache(d-path, id, elementRect); returns true, but the elementRect is invalid 0x0, so the hasElement returns false. When I change found to be false always, everything works as it used before - no problems... Cheerio -- A positive

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Ivan Čukić
p.s. Why don't we call the /not found/ branch when the rectangle is not valid? Something like: if (found elementRect.isValid()) { return true; } else { d-findAndCacheElementRect(elementId); return d-renderer-elementExists(elementId); } -- Those people who

Re: Plasma Applet Direction

2009-01-15 Thread Aaron J. Seigo
On Thursday 15 January 2009, Jud Craft wrote: I do really like the platform-independence and compilation-free packages! I had neglected those; that's awesome, so the picture is much less depressing than my post says. Plasma themes themselves are also independent, correct? (Assumption based

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Aaron J. Seigo
On Thursday 15 January 2009, Ivan Čukić wrote: The line bool found = Theme::defaultTheme()-findInRectsCache(d-path, id, elementRect); returns true, but the elementRect is invalid 0x0, so the hasElement returns false. ah, so either we need to special case non-existing elements a bit better

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Alexis Ménard
I noticed some artifacts too in my case on the task manager. I will try lancelot. The problem appears quite recently since the big move with the caching big work. I guess it was my Nvidia driver that were crap(as usually) but not sure now. On my laptop everything works fine so... 2009/1/15 Aaron

[PATCH] fix for 8 krazy2 issues

2009-01-15 Thread Bruno Bigras
Have a special look at 6_qclasses.diff, I tested everything I could with plasmoidviewer but some changes may be in code not used (yet). Fix issues with the same name as the patch (without the number). http://englishbreakfastnetwork.org/krazy/reports/kde-4.x/kdeplasma-addons/applets/index.html

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Aaron J. Seigo
On Thursday 15 January 2009, Philipp Klaffert wrote: I've now swapped all the Strings with constants and so, just 3 objects an no more krazy complaining for at least these issues. great; ready to commit! =)) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA

Re: Plasma Applet Direction

2009-01-15 Thread Jud Craft
Well, true. I suppose the only reservation is that such solutions like the Google Gadget/iPhone software stores require the development of a supported software delivery system, that I think should not be outsourced to a third party website. And that takes a lot of planning and resources - KDE

Re: FrameSvg corruption [a bit urgent]

2009-01-15 Thread Aaron J. Seigo
On Thursday 15 January 2009, Ivan Čukić wrote: The patch hasn't made any changes for me (not for better, nor worse) ok.. on the one hand, too bad. on the other hand, it's more correct so it not breaking it more is a good thing. which would result in checking the svg on every invalid entry,

Re: [PATCH] fix for 8 krazy2 issues

2009-01-15 Thread Aaron J. Seigo
On Thursday 15 January 2009, Bruno Bigras wrote: Alex Merry a écrit : These all look fine. Have you visually checked the results of the changes in 6_qclasses.diff? Do you have an SVN account in order to commit these? I only tested with the viewer and compiled. I don't have an SVN